Skip to contentSkip to conversation

net/smc: Add warning about remote memory exposure

PATCH Applied Leon Romanovsky 4 participants 4 messages May 16, 2017 1 message not in the archive

Subsystems (4)
Networking Network drivers InfiniBand Shared memory communications (SMC) sockets
lore
Share & tools
lore

Leon Romanovsky

author
#0 lore raw

PATCH 1/1 net/smc: Add warning about remote memory exposure

From: Christoph Hellwig <[email protected]>

The driver explicitly bypasses APIs to register all memory once a connection is made, and thus allows remote access to memory.

Signed-off-by Christoph Hellwig <[email protected]>
Signed-off-by Leon Romanovsky <[email protected]>

---
Dave,
Can you please forward this patch to stable?
Thanks
---
Changes from v0:
* Remove BROKEN Kconfig option as a followup of this discussion

    https://patchwork.ozlabs.org/patch/760454/
  * Refine commit message
---
 net/smc/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
net/smc/Kconfig +4 -0
index c717ef0896aa..33954852f3f8 100644
@@ -8,6 +8,10 @@ config SMC
 	  The Linux implementation of the SMC-R solution is designed as
 	  a separate socket family SMC.
 
+	  Warning: SMC will expose all memory for remote reads and writes
+	  once a connection is established.  Don't enable this option except
+	  for tightly controlled lab environment.
+
 	  Select this option if you want to run SMC socket applications
 
 config SMC_DIAG

A message that is not in the archive (sent off-list or not yet received): 20170516065138.24789-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

#2 lore raw

+ linux-rdma ML.

Quoted 38 lines · Leon Romanovsky

From: Christoph Hellwig <[email protected]>

The driver explicitly bypasses APIs to register all memory once a connection is made, and thus allows remote access to memory.

Signed-off-by Christoph Hellwig <[email protected]>
Signed-off-by Leon Romanovsky <[email protected]>

---
Dave,
Can you please forward this patch to stable?
Thanks
---
Changes from v0:
* Remove BROKEN Kconfig option as a followup of this discussion

    https://patchwork.ozlabs.org/patch/760454/
  * Refine commit message
---
 net/smc/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
net/smc/Kconfig +4 -1
index c717ef0896aa..33954852f3f8 100644
@@ -8,6 +8,10 @@ config SMC
 	  The Linux implementation of the SMC-R solution is designed as
 	  a separate socket family SMC.
 
+	  Warning: SMC will expose all memory for remote reads and writes
+	  once a connection is established.  Don't enable this option except
+	  for tightly controlled lab environment.
+
 	  Select this option if you want to run SMC socket applications
 
 config SMC_DIAG
--

2.12.2

Acked-by on v1 1/1
#3 lore raw
In reply to Leon Romanovsky
Quoted 36 lines · Leon Romanovsky

From: Christoph Hellwig <[email protected]>

The driver explicitly bypasses APIs to register all memory once a connection is made, and thus allows remote access to memory.

Signed-off-by Christoph Hellwig <[email protected]>
Signed-off-by Leon Romanovsky <[email protected]>

---
Dave,
Can you please forward this patch to stable?
Thanks
---
Changes from v0:
* Remove BROKEN Kconfig option as a followup of this discussion

    https://patchwork.ozlabs.org/patch/760454/
  * Refine commit message
---
 net/smc/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
net/smc/Kconfig +4 -1
index c717ef0896aa..33954852f3f8 100644
@@ -8,6 +8,10 @@ config SMC
 	  The Linux implementation of the SMC-R solution is designed as
 	  a separate socket family SMC.
 
+	  Warning: SMC will expose all memory for remote reads and writes
+	  once a connection is established.  Don't enable this option except
+	  for tightly controlled lab environment.
+
 	  Select this option if you want to run SMC socket applications
 
 config SMC_DIAG
--
Quoted 2 lines

2.12.2

Acked-by Ursula Braun <[email protected]>