Skip to contentSkip to conversation

bnx2x: Remove open coded carrier check

PATCH Applied Leon Romanovsky 3 participants 3 messages May 16, 2017

Subsystems (3)
Networking Network drivers Broadcom BNX2X 10 gigabit Ethernet driver
lore
Share & tools
lore

Leon Romanovsky

author
#0 lore raw

PATCH 1/1 bnx2x: Remove open coded carrier check

From: Leon Romanovsky <[email protected]>

There is inline function to test if carrier present, so it makes open-coded solution redundant.

Signed-off-by Leon Romanovsky <[email protected]>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +1 -1
index a851f95c307a..7414ffd70c90 100644
@@ -10303,7 +10303,7 @@ static void bnx2x_sp_rtnl_task(struct work_struct *work)
 	}
 	if (test_and_clear_bit(BNX2X_SP_RTNL_VFPF_CHANNEL_DOWN,
 			       &bp->sp_rtnl_state)){
-		if (!test_bit(__LINK_STATE_NOCARRIER, &bp->dev->state)) {
+		if (netif_carrier_ok(bp->dev)) {
 			bnx2x_tx_disable(bp);
 			BNX2X_ERR("PF indicated channel is not servicable anymore. This means this VF device is no longer operational\n");
 		}