Skip to contentSkip to conversation

Wireguard is not building on Fedora with 4.12 rc1 kernels

DISCUSSION Bruno Wolff III 2 participants 5 messages May 17, 2017

lore
Share & tools
lore
#0 lore raw

It looks like the test for memneq is broken and both the kernel and compat versions get used at the same time.

[bruno@cerberus src]$ make
make -C /lib/modules/4.12.0-0.rc1.git0.1.fc27.x86_64/build M=/home/bruno/WireGuard/src modules make[1]: Entering directory '/usr/src/kernels/4.12.0-0.rc1.git0.1.fc27.x86_64'
CC [M] /home/bruno/WireGuard/src/main.o
CC [M] /home/bruno/WireGuard/src/noise.o
In file included from /home/bruno/WireGuard/src/noise.c:15:0:
./include/crypto/algapi.h:389:19: error: redefinition of ‘crypto_memneq’
static inline int crypto_memneq(const void *a, const void *b, size_t size)

                  ^~~~~~~~~~~~~
In file included from <command-line>:0:0:
/home/bruno/WireGuard/src/compat/memneq/include.h:2:19: note: previous definition of ‘crypto_memneq’ was here
static inline int crypto_memneq(const void *a, const void *b, size_t size)
                  ^~~~~~~~~~~~~

make[2]: *** [scripts/Makefile.build:303: /home/bruno/WireGuard/src/noise.o] Error 1 make[1]: *** [Makefile:1516: _module_/home/bruno/WireGuard/src] Error 2 make[1]: Leaving directory '/usr/src/kernels/4.12.0-0.rc1.git0.1.fc27.x86_64'
make: *** [Makefile:28: module] Error 2

#1 lore raw

Hey Bruno,

Youch. I'm guessing this is because checking for the existence of a .c file isn't sufficient, since it might not be supplied. I'll change things around and you can retest.

Jason

#2 lore raw

Hi again,

I think I might have fixed this.

git fetch && git reset --hard origin/master

And then see if it builds now?

Alternatively, find me on IRC (I'm zx2c4) and we can talk in real time.

Jason

#3 lore raw
Quoted 7 lines · Jason A. Donenfeld

Hi again,

I think I might have fixed this.

git fetch && git reset --hard origin/master

And then see if it builds now?

It builds now. In about 15 minutes I'll have it tested.

#4 lore raw
Quoted 11 lines · Bruno Wolff III
Quoted 7 lines · Jason A. Donenfeld

Hi again,

I think I might have fixed this.

git fetch && git reset --hard origin/master

And then see if it builds now?

It builds now. In about 15 minutes I'll have it tested.

It took a lot longer than I thought because the remote machine is pretty slow and I needed to reinstall the kernel-PAE-devel package.

The two machines do not seem to be connecting. The remote machine is using 4.12.0-0.rc0.git2.1.fc27.i686+PAE. So this could potentially be a kernel problem. I can reboot the remote machine tonight when I get home and see if things work when the kernels match.