Skip to contentSkip to conversation

fbgrab: explicitly build fbgrab target to workaround gzip issue

PATCH New Peter Korsgaard 2 participants 3 messages May 17, 2017

lore
Share & tools
lore

Peter Korsgaard

author
#0 lore raw

PATCH 1/1 fbgrab: explicitly build fbgrab target to workaround gzip issue

Fixes #9871

gzip reads default command line options from the environment variable GZIP. The fbgrab Makefile internally also uses a GZIP make variable to know what command to use to compress the manpage. Unfortunaly make will export the value of this make variable to the environment if GZIP is already present in the enviroment, confusing gzip (as 'gzip' isn't a valid command line argument).

This can either be triggered by users having GZIP set in their environment (E.G. for custom options), or by enabling BR2_REPRODUCIBLE, where we use this feature to force the -n option (to not store name/timestamp) to gzip.

We don't really need to compress the manpage as it isn't installed anyway, so work around the issue by only building the fbgrab application.

Signed-off-by Peter Korsgaard <[email protected]>
---
 package/fbgrab/fbgrab.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/fbgrab/fbgrab.mk +1 -1
index 15e0a95c9..d81a5ee2a 100644
@@ -11,7 +11,7 @@ FBGRAB_LICENSE = GPL-2.0
 FBGRAB_LICENSE_FILES = COPYING
 
 define FBGRAB_BUILD_CMDS
-	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) fbgrab
 endef
 
 define FBGRAB_INSTALL_TARGET_CMDS
Signature · 1 line
2.11.0
Applied
#1 lore raw

PATCH 1/1 fbgrab: explicitly build fbgrab target to workaround gzip issue

Hello,

Quoted 12 lines · Peter Korsgaard

Fixes #9871

gzip reads default command line options from the environment variable GZIP. The fbgrab Makefile internally also uses a GZIP make variable to know what command to use to compress the manpage. Unfortunaly make will export the value of this make variable to the environment if GZIP is already present in the enviroment, confusing gzip (as 'gzip' isn't a valid command line argument).

This can either be triggered by users having GZIP set in their environment (E.G. for custom options), or by enabling BR2_REPRODUCIBLE, where we use this feature to force the -n option (to not store name/timestamp) to gzip.

Quoted 7 lines

We don't really need to compress the manpage as it isn't installed anyway, so work around the issue by only building the fbgrab application.

Signed-off-by Peter Korsgaard <[email protected]>
---
 package/fbgrab/fbgrab.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 fbgrab: explicitly build fbgrab target to workaround gzip issue

In reply to Peter Korsgaard
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Fixes #9871
gzip reads default command line options from the environment variable GZIP. The fbgrab Makefile internally also uses a GZIP make variable to know what command to use to compress the manpage. Unfortunaly make will export the value of this make variable to the environment if GZIP is already present in the enviroment, confusing gzip (as 'gzip' isn't a valid command line argument).

Quoted 8 lines

This can either be triggered by users having GZIP set in their environment (E.G. for custom options), or by enabling BR2_REPRODUCIBLE, where we use this feature to force the -n option (to not store name/timestamp) to gzip.

We don't really need to compress the manpage as it isn't installed anyway, so work around the issue by only building the fbgrab application.

Signed-off-by Peter Korsgaard <[email protected]>

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard