ARM: dts: am335x: disable mmc3

PATCH New Jean-Jacques Hiblot 2 participants 8 messages May 17, 2017 Arm (32-bit)

lore

Share & tools

lore

Jean-Jacques Hiblot

author

2017-05-17 11:55 UTC #0 lore raw

PATCH 1/1 ARM: dts: am335x: disable mmc3

SDIO is not supported in u-boot, there is no point in enabling mmc3.

Signed-off-by Jean-Jacques Hiblot <[email protected]>

---

Tom,

this will fix the problem youreported with commit b5511d6cb8dc601efc14b8cf60755 on am335x-evm. For the record, the problem is that the clock of mmc 3 is not enbled by the arch code. With DM_MMC enabled, mmc3 gets probed and u-boot crashes when mmc3's registers are accessed for the first time.

Jean-Jacques

 arch/arm/dts/am335x-evm.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

arch/arm/dts/am335x-evm.dts +3 -1

index a6f20af..e94fcad 100644
@@ -721,12 +721,14 @@
 };
 
 &mmc3 {
+	/* disable MMC3 as SDIO is not supported in U-Boot */
+	status = "disabled";
+
 	/* these are on the crossbar and are outlined in the
 	   xbar-event-map element */
 	dmas = <&edma 12
 		&edma 13>;
 	dma-names = "tx", "rx";
-	status = "okay";
 	vmmc-supply = <&wlan_en_reg>;
 	bus-width = <4>;
 	pinctrl-names = "default";

Signature · 1 line

1.9.1

Tom Rini

2017-05-17 13:04 UTC #1 lore raw

PATCH 1/1 ARM: dts: am335x: disable mmc3

Quoted 28 lines · Jean-Jacques Hiblot

SDIO is not supported in u-boot, there is no point in enabling mmc3.
Signed-off-by Jean-Jacques Hiblot <[email protected]>
---
Tom,
this will fix the problem youreported with commit b5511d6cb8dc601efc14b8cf60755 on am335x-evm. For the record, the problem is that the clock of mmc 3 is not enbled by the arch code. With DM_MMC enabled, mmc3 gets probed and u-boot crashes when mmc3's registers are accessed for the first time.
Jean-Jacques
 arch/arm/dts/am335x-evm.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/dts/am335x-evm.dts +2 -0
index a6f20af..e94fcad 100644
@@ -721,12 +721,14 @@
 };
 
 &mmc3 {
+	/* disable MMC3 as SDIO is not supported in U-Boot */
+	status = "disabled";

arch/arm/dts/am335x-evm.dts line 734

Quoted 10 lines

arch/arm/dts/am335x-evm.dts +1 -1

+
 	/* these are on the crossbar and are outlined in the
 	   xbar-event-map element */
 	dmas = <&edma 12
 		&edma 13>;
 	dma-names = "tx", "rx";
-	status = "okay";
 	vmmc-supply = <&wlan_en_reg>;
 	bus-width = <4>;
 	pinctrl-names = "default";

Please put this into arch/arm/dts/am335x-evm-u-boot.dtsi instead, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170517/95726ee1/attachment.sig>

Jean-Jacques Hiblot

author

2017-05-17 14:46 UTC #2 lore raw

PATCH 1/1 ARM: dts: am335x: disable mmc3

Quoted 27 lines · Tom Rini

Quoted 25 lines · Jean-Jacques Hiblot
SDIO is not supported in u-boot, there is no point in enabling mmc3.
Signed-off-by Jean-Jacques Hiblot <[email protected]>
---
Tom,
this will fix the problem youreported with commit b5511d6cb8dc601efc14b8cf60755 on am335x-evm. For the record, the problem is that the clock of mmc 3 is not enbled by the arch code. With DM_MMC enabled, mmc3 gets probed and u-boot crashes when mmc3's registers are accessed for the first time.
Jean-Jacques
  arch/arm/dts/am335x-evm.dts | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/dts/am335x-evm.dts +0 -0
index a6f20af..e94fcad 100644
@@ -721,12 +721,14 @@
  };
 

Quoted 14 lines

arch/arm/dts/am335x-evm.dts line 734

Quoted 13 lines

arch/arm/dts/am335x-evm.dts +3 -1

  &mmc3 {
+	/* disable MMC3 as SDIO is not supported in U-Boot */
+	status = "disabled";
+
  	/* these are on the crossbar and are outlined in the
  	   xbar-event-map element */
  	dmas = <&edma 12
  		&edma 13>;
  	dma-names = "tx", "rx";
-	status = "okay";
  	vmmc-supply = <&wlan_en_reg>;
  	bus-width = <4>;
  	pinctrl-names = "default";

Please put this into arch/arm/dts/am335x-evm-u-boot.dtsi instead,

I tried and it doesn't work. The XXX-u-boot.dtsi being included at the beginning of the DTS, it cannot override the
'status = "okay"' present in am335x-evm.dts.

Quoted 2 lines

thanks!

Tom Rini

2017-05-17 15:00 UTC #3 lore raw

PATCH 1/1 ARM: dts: am335x: disable mmc3

Quoted 43 lines · Jean-Jacques Hiblot

Quoted 32 lines · Tom Rini
Quoted 30 lines · Jean-Jacques Hiblot
SDIO is not supported in u-boot, there is no point in enabling mmc3.
Signed-off-by Jean-Jacques Hiblot <[email protected]>
---
Tom,
this will fix the problem youreported with commit b5511d6cb8dc601efc14b8cf60755 on am335x-evm. For the record, the problem is that the clock of mmc 3 is not enbled by the arch code. With DM_MMC enabled, mmc3 gets probed and u-boot crashes when mmc3's registers are accessed for the first time.
Jean-Jacques
 arch/arm/dts/am335x-evm.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/dts/am335x-evm.dts +3 -0
index a6f20af..e94fcad 100644
@@ -721,12 +721,14 @@
 };
 &mmc3 {
+	/* disable MMC3 as SDIO is not supported in U-Boot */
+	status = "disabled";
+
 	/* these are on the crossbar and are outlined in the
 	   xbar-event-map element */
Quoted 8 lines
arch/arm/dts/am335x-evm.dts line 734
Quoted 7 lines
arch/arm/dts/am335x-evm.dts +0 -1
 	dmas = <&edma 12
 		&edma 13>;
 	dma-names = "tx", "rx";
-	status = "okay";
 	vmmc-supply = <&wlan_en_reg>;
 	bus-width = <4>;
 	pinctrl-names = "default";
Please put this into arch/arm/dts/am335x-evm-u-boot.dtsi instead,

Quoted 3 lines

I tried and it doesn't work. The XXX-u-boot.dtsi being included at the beginning of the DTS, it cannot override the 'status = "okay"' present in am335x-evm.dts.

Ug, that's a problem. I'm working on it then, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170517/c0f9b6d3/attachment.sig>

Jean-Jacques Hiblot

author

2017-05-17 15:09 UTC #4 lore raw

PATCH 1/1 ARM: dts: am335x: disable mmc3

Quoted 43 lines · Tom Rini

Quoted 42 lines · Jean-Jacques Hiblot
Quoted 40 lines · Tom Rini
Quoted 27 lines · Jean-Jacques Hiblot
SDIO is not supported in u-boot, there is no point in enabling mmc3.
Signed-off-by Jean-Jacques Hiblot <[email protected]>
---
Tom,
this will fix the problem youreported with commit b5511d6cb8dc601efc14b8cf60755 on am335x-evm. For the record, the problem is that the clock of mmc 3 is not enbled by the arch code. With DM_MMC enabled, mmc3 gets probed and u-boot crashes when mmc3's registers are accessed for the first time.
Jean-Jacques
  arch/arm/dts/am335x-evm.dts | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/dts/am335x-evm.dts +2 -0
index a6f20af..e94fcad 100644
@@ -721,12 +721,14 @@
  };
  &mmc3 {
+	/* disable MMC3 as SDIO is not supported in U-Boot */
+	status = "disabled";
arch/arm/dts/am335x-evm.dts line 733
Quoted 10 lines
arch/arm/dts/am335x-evm.dts +1 -1
+
  	/* these are on the crossbar and are outlined in the
  	   xbar-event-map element */
  	dmas = <&edma 12
  		&edma 13>;
  	dma-names = "tx", "rx";
-	status = "okay";
  	vmmc-supply = <&wlan_en_reg>;
  	bus-width = <4>;
  	pinctrl-names = "default";
Please put this into arch/arm/dts/am335x-evm-u-boot.dtsi instead,

Quoted 5 lines

Quoted 3 lines
I tried and it doesn't work. The XXX-u-boot.dtsi being included at the beginning of the DTS, it cannot override the 'status = "okay"' present in am335x-evm.dts.
Ug, that's a problem. I'm working on it then, thanks!

We could include it at the end of the DTS. Since the goal is to be able to amend the DTS it makes more sense.
Also it will greatly simplify this part of Makefile.lib.

Tom Rini

2017-05-17 16:01 UTC #5 lore raw

PATCH 1/1 ARM: dts: am335x: disable mmc3

In reply to Jean-Jacques Hiblot

Quoted 43 lines · Jean-Jacques Hiblot

Quoted 32 lines · Tom Rini
Quoted 30 lines · Jean-Jacques Hiblot
SDIO is not supported in u-boot, there is no point in enabling mmc3.
Signed-off-by Jean-Jacques Hiblot <[email protected]>
---
Tom,
this will fix the problem youreported with commit b5511d6cb8dc601efc14b8cf60755 on am335x-evm. For the record, the problem is that the clock of mmc 3 is not enbled by the arch code. With DM_MMC enabled, mmc3 gets probed and u-boot crashes when mmc3's registers are accessed for the first time.
Jean-Jacques
 arch/arm/dts/am335x-evm.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/dts/am335x-evm.dts +3 -0
index a6f20af..e94fcad 100644
@@ -721,12 +721,14 @@
 };
 &mmc3 {
+	/* disable MMC3 as SDIO is not supported in U-Boot */
+	status = "disabled";
+
 	/* these are on the crossbar and are outlined in the
 	   xbar-event-map element */
Quoted 8 lines
arch/arm/dts/am335x-evm.dts line 734
Quoted 7 lines
arch/arm/dts/am335x-evm.dts +0 -1
 	dmas = <&edma 12
 		&edma 13>;
 	dma-names = "tx", "rx";
-	status = "okay";
 	vmmc-supply = <&wlan_en_reg>;
 	bus-width = <4>;
 	pinctrl-names = "default";
Please put this into arch/arm/dts/am335x-evm-u-boot.dtsi instead,

Quoted 3 lines

I tried and it doesn't work. The XXX-u-boot.dtsi being included at the beginning of the DTS, it cannot override the 'status = "okay"' present in am335x-evm.dts.

OK, I've manually confirmed that
https://patchwork.ozlabs.org/patch/763654/ does what I expect (and you were suggesting too), can you please test that with a patch that adds am335x-evm-u-boot.dtsi? Thanks again!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170517/6764c446/attachment.sig>

Jean-Jacques Hiblot

author

2017-05-17 16:14 UTC #6 lore raw

PATCH 1/1 ARM: dts: am335x: disable mmc3

Quoted 43 lines · Tom Rini

Quoted 42 lines · Jean-Jacques Hiblot
Quoted 40 lines · Tom Rini
Quoted 27 lines · Jean-Jacques Hiblot
SDIO is not supported in u-boot, there is no point in enabling mmc3.
Signed-off-by Jean-Jacques Hiblot <[email protected]>
---
Tom,
this will fix the problem youreported with commit b5511d6cb8dc601efc14b8cf60755 on am335x-evm. For the record, the problem is that the clock of mmc 3 is not enbled by the arch code. With DM_MMC enabled, mmc3 gets probed and u-boot crashes when mmc3's registers are accessed for the first time.
Jean-Jacques
  arch/arm/dts/am335x-evm.dts | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/dts/am335x-evm.dts +2 -0
index a6f20af..e94fcad 100644
@@ -721,12 +721,14 @@
  };
  &mmc3 {
+	/* disable MMC3 as SDIO is not supported in U-Boot */
+	status = "disabled";
arch/arm/dts/am335x-evm.dts line 733
Quoted 10 lines
arch/arm/dts/am335x-evm.dts +1 -1
+
  	/* these are on the crossbar and are outlined in the
  	   xbar-event-map element */
  	dmas = <&edma 12
  		&edma 13>;
  	dma-names = "tx", "rx";
-	status = "okay";
  	vmmc-supply = <&wlan_en_reg>;
  	bus-width = <4>;
  	pinctrl-names = "default";
Please put this into arch/arm/dts/am335x-evm-u-boot.dtsi instead,

Quoted 7 lines

Quoted 3 lines
I tried and it doesn't work. The XXX-u-boot.dtsi being included at the beginning of the DTS, it cannot override the 'status = "okay"' present in am335x-evm.dts.
OK, I've manually confirmed that
https://patchwork.ozlabs.org/patch/763654/ does what I expect (and you were suggesting too), can you please test that with a patch that adds am335x-evm-u-boot.dtsi? Thanks again!

The dependency on the *-u-boot.dtsi is broken. including is better than concatenating in that sense.
Other than that, it does the job.

Quoted 1 line

Tom Rini

2017-05-17 17:46 UTC #7 lore raw

PATCH 1/1 ARM: dts: am335x: disable mmc3

Quoted 49 lines · Jean-Jacques Hiblot

Quoted 46 lines · Tom Rini
Quoted 45 lines · Jean-Jacques Hiblot
Quoted 32 lines · Tom Rini
Quoted 30 lines · Jean-Jacques Hiblot
SDIO is not supported in u-boot, there is no point in enabling mmc3.
Signed-off-by Jean-Jacques Hiblot <[email protected]>
---
Tom,
this will fix the problem youreported with commit b5511d6cb8dc601efc14b8cf60755 on am335x-evm. For the record, the problem is that the clock of mmc 3 is not enbled by the arch code. With DM_MMC enabled, mmc3 gets probed and u-boot crashes when mmc3's registers are accessed for the first time.
Jean-Jacques
 arch/arm/dts/am335x-evm.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/dts/am335x-evm.dts +3 -0
index a6f20af..e94fcad 100644
@@ -721,12 +721,14 @@
 };
 &mmc3 {
+	/* disable MMC3 as SDIO is not supported in U-Boot */
+	status = "disabled";
+
 	/* these are on the crossbar and are outlined in the
 	   xbar-event-map element */
Quoted 8 lines
arch/arm/dts/am335x-evm.dts line 734
Quoted 7 lines
arch/arm/dts/am335x-evm.dts +0 -1
 	dmas = <&edma 12
 		&edma 13>;
 	dma-names = "tx", "rx";
-	status = "okay";
 	vmmc-supply = <&wlan_en_reg>;
 	bus-width = <4>;
 	pinctrl-names = "default";
Please put this into arch/arm/dts/am335x-evm-u-boot.dtsi instead,
I tried and it doesn't work. The XXX-u-boot.dtsi being included at the beginning of the DTS, it cannot override the 'status = "okay"' present in am335x-evm.dts.

Quoted 7 lines

Quoted 4 lines
OK, I've manually confirmed that
https://patchwork.ozlabs.org/patch/763654/ does what I expect (and you were suggesting too), can you please test that with a patch that adds am335x-evm-u-boot.dtsi? Thanks again!
The dependency on the *-u-boot.dtsi is broken. including is better than concatenating in that sense.
Other than that, it does the job.

Ah, OK, let me do a v2 that keeps depends but doesn't clean up the Makefile logic really.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170517/d7fdd129/attachment.sig>