Skip to contentSkip to conversation

acpi: apei: check for pending errors when probing GHES entries

PATCH In review Tyler Baicar 2 participants 2 messages May 18, 2017 – May 21, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 acpi: apei: check for pending errors when probing GHES entries

Check for pending errors when probing GHES entries. It is possible that a fatal error is already pending at this point, so we should handle it as soon as the driver is probed. This also avoids a potential issue if there was an interrupt that was already cleared for an error since the GHES driver wasn't present.

V3: Check for pending errors of all GHES types

---
 drivers/acpi/apei/ghes.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/acpi/apei/ghes.c +3 -0
index d0855c0..5347230 100644
@@ -1039,6 +1039,9 @@ static int ghes_probe(struct platform_device *ghes_dev)
 	}
 	platform_set_drvdata(ghes_dev, ghes);
 
+	/* Handle any pending errors right away */
+	ghes_proc(ghes);
+
 	return 0;
 err_edac_unreg:
 	ghes_edac_unregister(ghes);
Signature · 3 lines
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
Reviewed-by on v3 1/1
#1 lore raw
Quoted 18 lines · Tyler Baicar

Check for pending errors when probing GHES entries. It is possible that a fatal error is already pending at this point, so we should handle it as soon as the driver is probed. This also avoids a potential issue if there was an interrupt that was already cleared for an error since the GHES driver wasn't present.

V3: Check for pending errors of all GHES types

---
 drivers/acpi/apei/ghes.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/acpi/apei/ghes.c +0 -0
index d0855c0..5347230 100644

drivers/acpi/apei/ghes.c static int ghes_probe(struct platform_device *ghes_dev) · line 1047

Quoted 9 lines
drivers/acpi/apei/ghes.c +3 -0
@@ -1039,6 +1039,9 @@ static int ghes_probe(struct platform_device *ghes_dev)
 	}
 	platform_set_drvdata(ghes_dev, ghes);
 
+	/* Handle any pending errors right away */
+	ghes_proc(ghes);
+
 	return 0;
 err_edac_unreg:
 	ghes_edac_unregister(ghes);
Signature · 5 lines
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--