clk: sunxi-ng: select SUNXI_CCU_MULT for sun8i-a83t

We get a link error when CCU_MULT is not set with the newly added driver:

drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.1+0x4): undefined reference to ccu_mult_ops' drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.3+0x4): undefined reference to ccu_mult_ops'

Fixes 46b492116666 ("clk: sunxi-ng: Add driver for A83T CCU")

Signed-off-by Arnd Bergmann <[email protected]>

Quoted 8 lines · Arnd Bergmann

We get a link error when CCU_MULT is not set with the newly added driver:

drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.1+0x4): undefined reference to ccu_mult_ops' drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.3+0x4): undefined reference to ccu_mult_ops'

Fixes 46b492116666 ("clk: sunxi-ng: Add driver for A83T CCU")

Signed-off-by Arnd Bergmann <[email protected]>

Is there any way we can automate finding these build errors and prevent them from creeping into the tree? It may be asking too much, but it seems like we should be able to find these particular problems with some script that greps for ccu_*_ops and checks that any file's Kconfig symbol also has that selected.

Anyway, I'm just tired of seeing these sorts of things in my inbox.

Quoted 4 lines · Stephen Boyd

Quoted 3 lines · Arnd Bergmann

We get a link error when CCU_MULT is not set with the newly added driver:

Quoted 5 lines

Quoted 5 lines

drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.1+0x4): undefined reference to ccu_mult_ops' drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.3+0x4): undefined reference to ccu_mult_ops'

Fixes 46b492116666 ("clk: sunxi-ng: Add driver for A83T CCU")

Signed-off-by Arnd Bergmann <[email protected]>

Acked-by Chen-Yu Tsai <[email protected]>

Quoted 8 lines

Is there any way we can automate finding these build errors and prevent them from creeping into the tree? It may be asking too much, but it seems like we should be able to find these particular problems with some script that greps for ccu_*_ops and checks that any file's Kconfig symbol also has that selected.

Anyway, I'm just tired of seeing these sorts of things in my inbox.

The (ugly) script below does the trick, though it does give results for some symbols that are indirectly selected:

SUN5I_CCU uses SUNXI_CCU_GATE but does not select it SUN5I_CCU uses SUNXI_CCU_MUX but does not select it

SUN5I_CCU uses SUNXI_CCU_NKMP but does not select it

Quoted 5 lines · Chen-Yu Tsai

Quoted 4 lines · Stephen Boyd

Quoted 3 lines · Arnd Bergmann

We get a link error when CCU_MULT is not set with the newly added driver:

Quoted 16 lines

Quoted 5 lines

Quoted 5 lines

drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.1+0x4): undefined reference to ccu_mult_ops' drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.3+0x4): undefined reference to ccu_mult_ops'

Fixes 46b492116666 ("clk: sunxi-ng: Add driver for A83T CCU")

Signed-off-by Arnd Bergmann <[email protected]>

Acked-by Chen-Yu Tsai <[email protected]>

Quoted 8 lines

Is there any way we can automate finding these build errors and prevent them from creeping into the tree? It may be asking too much, but it seems like we should be able to find these particular problems with some script that greps for ccu_*_ops and checks that any file's Kconfig symbol also has that selected.

Anyway, I'm just tired of seeing these sorts of things in my inbox.

Definitely, I'm also tired of writing the patches ;-)

Quoted 5 lines

The (ugly) script below does the trick, though it does give results for some symbols that are indirectly selected:

SUN5I_CCU uses SUNXI_CCU_GATE but does not select it SUN5I_CCU uses SUNXI_CCU_MUX but does not select it

I think they are all caught implicitly, otherwise I would have run into them.

Quoted 1 line

SUN5I_CCU uses SUNXI_CCU_NKMP but does not select it

I sent a patch for this on Feb 14 and again March 13, but haven't gotten around to resubmit again.

An alternative would be to remove all the dependencies as 'lib-y' in the Makefile and remove the individual Kconfig symbols. That way, we would always build all of them when CONFIG_SUNXI_CCU is enabled, but the linker would drop the ones that do not get referenced.

Quoted 6 lines · Arnd Bergmann

On Tue, May 23, 2017 at 9:19 AM, Chen-Yu Tsai <[email protected]> wrote:
An alternative would be to remove all the dependencies as 'lib-y' in the Makefile and remove the individual Kconfig symbols. That way, we would always build all of them when CONFIG_SUNXI_CCU is enabled, but the linker would drop the ones that do not get referenced.

In this case you're right, and we should change them to lib-y in the Makefile and then let the linker figure this all out. No more dependency patches. I think we only need to do this sort of Kconfig stuff when we want to make a library .ko file that each SoC specific driver depends on for common code.

It would be cool if the build system could figure that all out for us, and let us have something like modlib-y that makes it a library (archive) if all objects depending on it are builtin and we have CONFIG_MODULES=n, or makes it into an object file if something is builtin that depends on it, or makes it into a module if everything that depends on it is a module.

Quoted 14 lines · Stephen Boyd

Quoted 6 lines · Arnd Bergmann

On Tue, May 23, 2017 at 9:19 AM, Chen-Yu Tsai <[email protected]> wrote:
An alternative would be to remove all the dependencies as 'lib-y' in the Makefile and remove the individual Kconfig symbols. That way, we would always build all of them when CONFIG_SUNXI_CCU is enabled, but the linker would drop the ones that do not get referenced.

In this case you're right, and we should change them to lib-y in the Makefile and then let the linker figure this all out. No more dependency patches. I think we only need to do this sort of Kconfig stuff when we want to make a library .ko file that each SoC specific driver depends on for common code.

Quoted 6 lines

It would be cool if the build system could figure that all out for us, and let us have something like modlib-y that makes it a library (archive) if all objects depending on it are builtin and we have CONFIG_MODULES=n, or makes it into an object file if something is builtin that depends on it, or makes it into a module if everything that depends on it is a module.

In this case, there are no loadable modules, the sunxi clk drivers can only be built-in, which should simplify the problem a lot.

Hi Stephen,

[auto build test ERROR on sunxi/sunxi/for-next]
[also build test ERROR on next-20170602]
[cannot apply to clk/clk-next v4.12-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Stephen-Boyd/clk-sunxi-ng-Move-all-clock-types-to-a-library/20170603-090538
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git sunxi/for-next
config: arm-sunxi_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705

reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm

All errors (new ones prefixed by >>):

drivers/built-in.o: In function `sun8i_a83t_ccu_probe':

Quoted 1 line

Quoted 1 line

sunxi_sid.c:(.text+0x2dc74): undefined reference to `sunxi_ccu_probe'

drivers/built-in.o: In function `sun9i_a80_ccu_probe':
sunxi_sid.c:(.text+0x2dd14): undefined reference to sunxi_ccu_probe' drivers/built-in.o: In function sun9i_a80_de_clk_probe':
sunxi_sid.c:(.text+0x2de20): undefined reference to sunxi_ccu_probe' drivers/built-in.o: In function sun9i_a80_usb_clk_probe':
sunxi_sid.c:(.text+0x2df34): undefined reference to sunxi_ccu_probe' drivers/built-in.o: In function sun5i_ccu_init':

Quoted 1 line

Quoted 1 line

sunxi_sid.c:(.init.text+0x3f9c): undefined reference to `sunxi_ccu_probe'

drivers/built-in.o:sunxi_sid.c:(.init.text+0x4070): more undefined references to sunxi_ccu_probe' follow drivers/built-in.o: In function sun6i_a31_ccu_setup':

Quoted 1 line

Quoted 1 line

sunxi_sid.c:(.init.text+0x4084): undefined reference to `ccu_mux_notifier_register'

drivers/built-in.o: In function `sun8i_a23_ccu_setup':

   sunxi_sid.c:(.init.text+0x411c): undefined reference to `sunxi_ccu_probe'
   drivers/built-in.o: In function `sun8i_a33_ccu_setup':
   sunxi_sid.c:(.init.text+0x41b8): undefined reference to `sunxi_ccu_probe'

Quoted 1 line

Quoted 1 line

sunxi_sid.c:(.init.text+0x41c0): undefined reference to `ccu_pll_notifier_register'

sunxi_sid.c:(.init.text+0x41d0): undefined reference to ccu_mux_notifier_register' drivers/built-in.o: In function sunxi_h3_h5_ccu_init':

   sunxi_sid.c:(.init.text+0x425c): undefined reference to `sunxi_ccu_probe'
   sunxi_sid.c:(.init.text+0x4270): undefined reference to `ccu_mux_notifier_register'
   drivers/built-in.o: In function `sun8i_v3s_ccu_setup':
   sunxi_sid.c:(.init.text+0x4308): undefined reference to `sunxi_ccu_probe'
   drivers/built-in.o: In function `sunxi_r_ccu_init':
   sunxi_sid.c:(.init.text+0x4368): undefined reference to `sunxi_ccu_probe'
   drivers/built-in.o: In function `.LANCHOR0':

Quoted 3 lines

Quoted 3 lines

sunxi_sid.c:(.data+0x157c4): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x15840): undefined reference to ccu_mp_ops' sunxi_sid.c:(.data+0x158a4): undefined reference to `ccu_div_ops'

sunxi_sid.c:(.data+0x15908): undefined reference to ccu_div_ops' sunxi_sid.c:(.data+0x15940): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x1597c): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x159b8): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x15a20): undefined reference to ccu_div_ops' sunxi_sid.c:(.data+0x15a84): undefined reference to ccu_div_ops' sunxi_sid.c:(.data+0x15aec): undefined reference to `ccu_div_ops'

Quoted 1 line

Quoted 1 line

sunxi_sid.c:(.data+0x15b40): undefined reference to `ccu_mux_ops'

sunxi_sid.c:(.data+0x15ba4): undefined reference to ccu_div_ops' sunxi_sid.c:(.data+0x15c08): undefined reference to ccu_div_ops' sunxi_sid.c:(.data+0x15c40): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x15c7c): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x15cb8): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x15cf4): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x15d30): undefined reference to ccu_gate_ops' drivers/built-in.o:sunxi_sid.c:(.data+0x15d6c): more undefined references to ccu_gate_ops' follow drivers/built-in.o: In function `.LANCHOR0':

   sunxi_sid.c:(.data+0x15e4c): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x15e84): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x15ec0): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x15efc): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x15f78): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x15fcc): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x16020): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x16098): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x16110): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x16188): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x16200): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x16278): undefined reference to `ccu_mp_ops'
   drivers/built-in.o:sunxi_sid.c:(.data+0x162f0): more undefined references to `ccu_mp_ops' follow
   drivers/built-in.o: In function `.LANCHOR0':
   sunxi_sid.c:(.data+0x16508): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x16544): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x16580): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x165bc): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x165f8): undefined reference to `ccu_gate_ops'
   drivers/built-in.o:sunxi_sid.c:(.data+0x16634): more undefined references to `ccu_gate_ops' follow
   drivers/built-in.o: In function `.LANCHOR0':
   sunxi_sid.c:(.data+0x16ee4): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x16f48): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x16fd8): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1703c): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x17094): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x170cc): undefined reference to `ccu_gate_ops'

Quoted 2 lines

Quoted 2 lines

sunxi_sid.c:(.data+0x1713c): undefined reference to ccu_mult_ops' sunxi_sid.c:(.data+0x17190): undefined reference to ccu_nk_ops'

sunxi_sid.c:(.data+0x171f8): undefined reference to ccu_div_ops' sunxi_sid.c:(.data+0x17260): undefined reference to ccu_div_ops' sunxi_sid.c:(.data+0x172b4): undefined reference to `ccu_nk_ops'

Quoted 1 line

Quoted 1 line

sunxi_sid.c:(.data+0x17328): undefined reference to `ccu_nkmp_ops'

sunxi_sid.c:(.data+0x17398): undefined reference to `ccu_mult_ops'

Quoted 1 line

Quoted 1 line

sunxi_sid.c:(.data+0x17404): undefined reference to `ccu_nm_ops'

sunxi_sid.c:(.data+0x17478): undefined reference to ccu_nkmp_ops' drivers/built-in.o: In function .LANCHOR1':

   sunxi_sid.c:(.data+0x17d40): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x17db8): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x17e30): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x17e94): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x17ef8): undefined reference to `ccu_div_ops'
   drivers/built-in.o:sunxi_sid.c:(.data+0x17f5c): more undefined references to `ccu_div_ops' follow
   drivers/built-in.o: In function `.LANCHOR1':
   sunxi_sid.c:(.data+0x18358): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x183d0): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x18408): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x18444): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x184ac): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x184e4): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x18520): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1855c): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x185c4): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1862c): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x18690): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x186f4): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x18758): undefined reference to `ccu_div_ops'
   drivers/built-in.o:sunxi_sid.c:(.data+0x187bc): more undefined references to `ccu_div_ops' follow
   drivers/built-in.o: In function `.LANCHOR1':
   sunxi_sid.c:(.data+0x18810): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x18864): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x188c8): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1892c): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x18990): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x189f4): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x18a58): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x18a90): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x18acc): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x18b08): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x18b44): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x18b80): undefined reference to `ccu_gate_ops'
   drivers/built-in.o:sunxi_sid.c:(.data+0x18bbc): more undefined references to `ccu_gate_ops' follow
   drivers/built-in.o: In function `.LANCHOR1':
   sunxi_sid.c:(.data+0x18d8c): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x18df0): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x18e68): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x18ea0): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x18edc): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x18f18): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x18f54): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x18f90): undefined reference to `ccu_gate_ops'
   drivers/built-in.o:sunxi_sid.c:(.data+0x18fcc): more undefined references to `ccu_gate_ops' follow
   drivers/built-in.o: In function `.LANCHOR1':
   sunxi_sid.c:(.data+0x19024): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x19078): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x190cc): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x19144): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x191bc): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x19234): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x192ac): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x19324): undefined reference to `ccu_mp_ops'
   drivers/built-in.o:sunxi_sid.c:(.data+0x1939c): more undefined references to `ccu_mp_ops' follow
   drivers/built-in.o: In function `.LANCHOR1':

Quoted 1 line

Quoted 1 line

sunxi_sid.c:(.data+0x193d4): undefined reference to `ccu_phase_ops'

sunxi_sid.c:(.data+0x19410): undefined reference to ccu_phase_ops' sunxi_sid.c:(.data+0x1948c): undefined reference to ccu_mp_ops' sunxi_sid.c:(.data+0x194c4): undefined reference to ccu_phase_ops' sunxi_sid.c:(.data+0x19500): undefined reference to ccu_phase_ops' sunxi_sid.c:(.data+0x1957c): undefined reference to ccu_mp_ops' sunxi_sid.c:(.data+0x195b4): undefined reference to ccu_phase_ops' sunxi_sid.c:(.data+0x195f0): undefined reference to ccu_phase_ops' sunxi_sid.c:(.data+0x1966c): undefined reference to ccu_mp_ops' sunxi_sid.c:(.data+0x196a4): undefined reference to ccu_phase_ops' sunxi_sid.c:(.data+0x196e0): undefined reference to ccu_phase_ops' sunxi_sid.c:(.data+0x1975c): undefined reference to ccu_mp_ops' sunxi_sid.c:(.data+0x197d4): undefined reference to ccu_mp_ops' sunxi_sid.c:(.data+0x1984c): undefined reference to ccu_mp_ops' sunxi_sid.c:(.data+0x19884): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x198c0): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x198fc): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x19938): undefined reference to ccu_gate_ops' sunxi_sid.c:(.data+0x19974): undefined reference to ccu_gate_ops' drivers/built-in.o:sunxi_sid.c:(.data+0x199b0): more undefined references to ccu_gate_ops' follow drivers/built-in.o: In function .LANCHOR1':

   sunxi_sid.c:(.data+0x1a56c): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1a5d0): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1a660): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1a6c4): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1a764): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1a7cc): undefined reference to `ccu_nm_ops'
   sunxi_sid.c:(.data+0x1a838): undefined reference to `ccu_nm_ops'

Quoted 1 line

Quoted 1 line

sunxi_sid.c:(.data+0x1a8b0): undefined reference to `ccu_nkm_ops'

sunxi_sid.c:(.data+0x1a918): undefined reference to ccu_nm_ops' sunxi_sid.c:(.data+0x1a984): undefined reference to ccu_nm_ops' sunxi_sid.c:(.data+0x1a9d8): undefined reference to ccu_nk_ops' sunxi_sid.c:(.data+0x1aa50): undefined reference to ccu_nkm_ops' sunxi_sid.c:(.data+0x1aabc): undefined reference to ccu_nm_ops' sunxi_sid.c:(.data+0x1ab28): undefined reference to ccu_nm_ops' sunxi_sid.c:(.data+0x1ab94): undefined reference to ccu_nm_ops' sunxi_sid.c:(.data+0x1abac): undefined reference to ccu_nkm_ops' sunxi_sid.c:(.data+0x1b154): undefined reference to ccu_div_ops' sunxi_sid.c:(.data+0x1b1b8): undefined reference to ccu_div_ops' sunxi_sid.c:(.data+0x1b220): undefined reference to ccu_div_ops' sunxi_sid.c:(.data+0x1b284): undefined reference to ccu_div_ops' sunxi_sid.c:(.data+0x1b2e8): undefined reference to ccu_div_ops' drivers/built-in.o:sunxi_sid.c:(.data+0x1b34c): more undefined references to ccu_div_ops' follow drivers/built-in.o: In function `.LANCHOR1':

   sunxi_sid.c:(.data+0x1b384): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1b3c0): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1b428): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1b490): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1b4f4): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1b558): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1b5ac): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1b610): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1b674): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1b6ac): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1b6e8): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1b724): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1b760): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1b79c): undefined reference to `ccu_gate_ops'
   drivers/built-in.o:sunxi_sid.c:(.data+0x1b7d8): more undefined references to `ccu_gate_ops' follow
   drivers/built-in.o: In function `.LANCHOR1':
   sunxi_sid.c:(.data+0x1b920): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1b974): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1b9ec): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1ba64): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1ba9c): undefined reference to `ccu_phase_ops'
   sunxi_sid.c:(.data+0x1bad8): undefined reference to `ccu_phase_ops'
   sunxi_sid.c:(.data+0x1bb54): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1bb8c): undefined reference to `ccu_phase_ops'
   sunxi_sid.c:(.data+0x1bbc8): undefined reference to `ccu_phase_ops'
   sunxi_sid.c:(.data+0x1bc44): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1bc7c): undefined reference to `ccu_phase_ops'
   sunxi_sid.c:(.data+0x1bcb8): undefined reference to `ccu_phase_ops'
   sunxi_sid.c:(.data+0x1bd34): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1bdac): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1bde4): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1be20): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1be5c): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1be98): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1bed4): undefined reference to `ccu_gate_ops'
   drivers/built-in.o:sunxi_sid.c:(.data+0x1bf10): more undefined references to `ccu_gate_ops' follow
   drivers/built-in.o: In function `.LANCHOR1':
   sunxi_sid.c:(.data+0x1c61c): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1c680): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1c710): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1c774): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1c7cc): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1c834): undefined reference to `ccu_nm_ops'
   sunxi_sid.c:(.data+0x1c8a0): undefined reference to `ccu_nm_ops'
   sunxi_sid.c:(.data+0x1c918): undefined reference to `ccu_nkm_ops'
   sunxi_sid.c:(.data+0x1c984): undefined reference to `ccu_nm_ops'
   sunxi_sid.c:(.data+0x1c9d8): undefined reference to `ccu_nk_ops'
   sunxi_sid.c:(.data+0x1ca50): undefined reference to `ccu_nkm_ops'
   sunxi_sid.c:(.data+0x1cabc): undefined reference to `ccu_nm_ops'
   sunxi_sid.c:(.data+0x1cb28): undefined reference to `ccu_nm_ops'
   sunxi_sid.c:(.data+0x1cb94): undefined reference to `ccu_nm_ops'
   sunxi_sid.c:(.data+0x1cc08): undefined reference to `ccu_nkmp_ops'
   sunxi_sid.c:(.data+0x1d25c): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1d2c0): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1d328): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1d38c): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1d3f0): undefined reference to `ccu_div_ops'
   drivers/built-in.o:sunxi_sid.c:(.data+0x1d454): more undefined references to `ccu_div_ops' follow
   drivers/built-in.o: In function `.LANCHOR1':
   sunxi_sid.c:(.data+0x1d48c): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1d4c8): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1d504): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1d56c): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1d5d4): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1d638): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1d69c): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1d6f0): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1d754): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1d7b8): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1d7f0): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1d82c): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1d868): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1d8a4): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1d8e0): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1d938): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1d99c): undefined reference to `ccu_div_ops'
   sunxi_sid.c:(.data+0x1d9d8): undefined reference to `ccu_gate_ops'

   sunxi_sid.c:(.data+0x1da14): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1da50): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1da8c): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1dac8): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1db20): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1db74): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1dbec): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1dc64): undefined reference to `ccu_mp_ops'

Hi,

Quoted 7 lines · kbuild test robot

Hi Stephen,

[auto build test ERROR on sunxi/sunxi/for-next]
[also build test ERROR on next-20170602]
[cannot apply to clk/clk-next v4.12-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

Quoted 6 lines

   sunxi_sid.c:(.data+0x1da8c): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1dac8): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1db20): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1db74): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1dbec): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1dc64): undefined reference to `ccu_mp_ops'

It seems like even though the lib.a file is compiled properly, it is never linked in. It looks like we would be supposed to add drivers/clk/sunxi-ng/ to libs-y, but that doesn't seem to work for Makefiles in drivers/*

Quoted 17 lines · Maxime Ripard

Hi,

Quoted 7 lines · kbuild test robot

Hi Stephen,

[auto build test ERROR on sunxi/sunxi/for-next]
[also build test ERROR on next-20170602]
[cannot apply to clk/clk-next v4.12-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

Quoted 6 lines

   sunxi_sid.c:(.data+0x1da8c): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1dac8): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1db20): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1db74): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1dbec): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1dc64): undefined reference to `ccu_mp_ops'

Quoted 4 lines

It seems like even though the lib.a file is compiled properly, it is never linked in. It looks like we would be supposed to add drivers/clk/sunxi-ng/ to libs-y, but that doesn't seem to work for Makefiles in drivers/*

Ah, too bad. I see that only one directory under drivers/ uses something with lib.a, in drivers/firmware/efi/libstub/Makefile, but that seems to rely on being special-cased as well.

However, this patch seems to fix it:

drivers/clk/sunxi-ng/Makefile +13 -13

index cbc8cb4f70e3..321d3da7cc6a 100644
@@ -18,16 +18,16 @@ lib-$(CONFIG_SUNXI_CCU) += ccu_nm.o
 lib-$(CONFIG_SUNXI_CCU) += ccu_mp.o
 
 # SoC support
-obj-$(CONFIG_SUN50I_A64_CCU) += ccu-sun50i-a64.o
-obj-$(CONFIG_SUN5I_CCU) += ccu-sun5i.o
-obj-$(CONFIG_SUN6I_A31_CCU) += ccu-sun6i-a31.o
-obj-$(CONFIG_SUN8I_A23_CCU) += ccu-sun8i-a23.o
-obj-$(CONFIG_SUN8I_A33_CCU) += ccu-sun8i-a33.o
-obj-$(CONFIG_SUN8I_A83T_CCU) += ccu-sun8i-a83t.o
-obj-$(CONFIG_SUN8I_H3_CCU) += ccu-sun8i-h3.o
-obj-$(CONFIG_SUN8I_V3S_CCU) += ccu-sun8i-v3s.o
-obj-$(CONFIG_SUN8I_DE2_CCU) += ccu-sun8i-de2.o
-obj-$(CONFIG_SUN8I_R_CCU) += ccu-sun8i-r.o
-obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80.o
-obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-de.o
-obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-usb.o
+obj-$(CONFIG_SUN50I_A64_CCU) += ccu-sun50i-a64.o lib.a
+obj-$(CONFIG_SUN5I_CCU) += ccu-sun5i.o lib.a
+obj-$(CONFIG_SUN6I_A31_CCU) += ccu-sun6i-a31.o lib.a
+obj-$(CONFIG_SUN8I_A23_CCU) += ccu-sun8i-a23.o lib.a
+obj-$(CONFIG_SUN8I_A33_CCU) += ccu-sun8i-a33.o lib.a
+obj-$(CONFIG_SUN8I_A83T_CCU) += ccu-sun8i-a83t.o lib.a
+obj-$(CONFIG_SUN8I_H3_CCU) += ccu-sun8i-h3.o lib.a
+obj-$(CONFIG_SUN8I_V3S_CCU) += ccu-sun8i-v3s.o lib.a
+obj-$(CONFIG_SUN8I_DE2_CCU) += ccu-sun8i-de2.o lib.a
+obj-$(CONFIG_SUN8I_R_CCU) += ccu-sun8i-r.o lib.a
+obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80.o lib.a
+obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-de.o lib.a
+obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-usb.o lib.a

It's not documented behavior, but I think it's still good enough, and improves the current version, unless there is another bug after we add this to your patch.

Quoted 17 lines · Maxime Ripard

Hi,

Quoted 7 lines · kbuild test robot

Hi Stephen,

[auto build test ERROR on sunxi/sunxi/for-next]
[also build test ERROR on next-20170602]
[cannot apply to clk/clk-next v4.12-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

Quoted 6 lines

   sunxi_sid.c:(.data+0x1da8c): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1dac8): undefined reference to `ccu_gate_ops'
   sunxi_sid.c:(.data+0x1db20): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1db74): undefined reference to `ccu_mux_ops'
   sunxi_sid.c:(.data+0x1dbec): undefined reference to `ccu_mp_ops'
   sunxi_sid.c:(.data+0x1dc64): undefined reference to `ccu_mp_ops'

Quoted 4 lines

It seems like even though the lib.a file is compiled properly, it is never linked in. It looks like we would be supposed to add drivers/clk/sunxi-ng/ to libs-y, but that doesn't seem to work for Makefiles in drivers/*

Ah, too bad. I see that only one directory under drivers/ uses something with lib.a, in drivers/firmware/efi/libstub/Makefile, but that seems to rely on being special-cased as well.

However, this patch seems to fix it:

drivers/clk/sunxi-ng/Makefile +13 -13

index cbc8cb4f70e3..321d3da7cc6a 100644
@@ -18,16 +18,16 @@ lib-$(CONFIG_SUNXI_CCU) += ccu_nm.o
 lib-$(CONFIG_SUNXI_CCU) += ccu_mp.o
 
 # SoC support
-obj-$(CONFIG_SUN50I_A64_CCU) += ccu-sun50i-a64.o
-obj-$(CONFIG_SUN5I_CCU) += ccu-sun5i.o
-obj-$(CONFIG_SUN6I_A31_CCU) += ccu-sun6i-a31.o
-obj-$(CONFIG_SUN8I_A23_CCU) += ccu-sun8i-a23.o
-obj-$(CONFIG_SUN8I_A33_CCU) += ccu-sun8i-a33.o
-obj-$(CONFIG_SUN8I_A83T_CCU) += ccu-sun8i-a83t.o
-obj-$(CONFIG_SUN8I_H3_CCU) += ccu-sun8i-h3.o
-obj-$(CONFIG_SUN8I_V3S_CCU) += ccu-sun8i-v3s.o
-obj-$(CONFIG_SUN8I_DE2_CCU) += ccu-sun8i-de2.o
-obj-$(CONFIG_SUN8I_R_CCU) += ccu-sun8i-r.o
-obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80.o
-obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-de.o
-obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-usb.o
+obj-$(CONFIG_SUN50I_A64_CCU) += ccu-sun50i-a64.o lib.a
+obj-$(CONFIG_SUN5I_CCU) += ccu-sun5i.o lib.a
+obj-$(CONFIG_SUN6I_A31_CCU) += ccu-sun6i-a31.o lib.a
+obj-$(CONFIG_SUN8I_A23_CCU) += ccu-sun8i-a23.o lib.a
+obj-$(CONFIG_SUN8I_A33_CCU) += ccu-sun8i-a33.o lib.a
+obj-$(CONFIG_SUN8I_A83T_CCU) += ccu-sun8i-a83t.o lib.a
+obj-$(CONFIG_SUN8I_H3_CCU) += ccu-sun8i-h3.o lib.a
+obj-$(CONFIG_SUN8I_V3S_CCU) += ccu-sun8i-v3s.o lib.a
+obj-$(CONFIG_SUN8I_DE2_CCU) += ccu-sun8i-de2.o lib.a
+obj-$(CONFIG_SUN8I_R_CCU) += ccu-sun8i-r.o lib.a
+obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80.o lib.a
+obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-de.o lib.a
+obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-usb.o lib.a

It's not documented behavior, but I think it's still good enough, and improves the current version, unless there is another bug after we add this to your patch.

Arnd

at the bottom (with a comment) would be cleaner, and we wouldn't need to modify all the existing lines. AFAIK about Makefiles, that should work?

Quoted 3 lines · Chen-Yu Tsai

at the bottom (with a comment) would be cleaner, and we wouldn't need to modify all the existing lines. AFAIK about Makefiles, that should work?

Ah, yes. That's much better.

Arnd

Quoted 5 lines · Chen-Yu Tsai

Quoted 3 lines

at the bottom (with a comment) would be cleaner, and we wouldn't need to modify all the existing lines. AFAIK about Makefiles, that should work?

Quoted 3 lines

Ah, yes. That's much better.

Arnd

I just applied the original patch, with that addition, and a comment as suggested by Stephen.

We get a link error when CCU_MULT is not set with the newly added driver:

drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.1+0x4): undefined reference to ccu_mult_ops' drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.3+0x4): undefined reference to ccu_mult_ops'

Fixes 46b492116666 ("clk: sunxi-ng: Add driver for A83T CCU")

Signed-off-by Arnd Bergmann <[email protected]>