net: fix potential null pointer dereference

PATCH Applied Gustavo A. R. Silva 3 participants 3 messages May 23, 2017 – May 25, 2017

Subsystems (3)

Networking Network drivers GTP (GPRS Tunneling Protocol)

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-05-23 23:18 UTC #0 lore raw

PATCH 1/1 net: fix potential null pointer dereference

Add null check to avoid a potential null pointer dereference.

Addresses-Coverity-ID: 1408831

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/net/gtp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/net/gtp.c +1 -1

index 4fea1b3..7b652bb 100644
@@ -873,7 +873,7 @@ static struct gtp_dev *gtp_find_dev(struct net *src_net, struct nlattr *nla[])
 
 	/* Check if there's an existing gtpX device to configure */
 	dev = dev_get_by_index_rcu(net, nla_get_u32(nla[GTPA_LINK]));
-	if (dev->netdev_ops == &gtp_netdev_ops)
+	if (dev && dev->netdev_ops == &gtp_netdev_ops)
 		gtp = netdev_priv(dev);
 
 	put_net(net);