Skip to contentSkip to conversation

test-appliance: revert logging change on startup

PATCH New Eric Biggers 1 participant 1 message May 24, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test-appliance: revert logging change on startup

From: Eric Biggers <[email protected]>

Commit 458ce3391003 ("Add support to optionally build gce-xfstests for Debian stretch") made the output of kvm-xfstests.boot get redirected to a file /var/log/kvm-xfstests-boot.log. This actually isn't desirable, because the output is supposed to be shown on the console. This was especially apparent for kvm-xfstests, since it hid the output of runtests.sh. But it was also applicable to gce-xfstests, since 'gce-xfstests console' can be used to show the console output.

We could send the output to both places using 'tee', but this seems useless since the output can just be retrieved from the console instead of from the log file. Also, the 'set -vx' output is too verbose for the console, and I don't think there would be a way to send it just to the log file.

So just revert the change to kvm-xfstests.boot.

---
 kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot | 7 -------
 1 file changed, 7 deletions(-)
kvm-xfstests/test-appliance/files/root/kvm-xfstests.boot +0 -7
index 4b687d0..26ef2fd 100755
@@ -11,13 +11,6 @@ else
 fi
 }
 
-date >> /var/log/kvm-xfstests-boot.log
-exec 1<&-
-exec 2<&-
-exec 1>> /var/log/kvm-xfstests-boot.log
-exec 2>&1
-set -vx
-
 . /root/test-config
 
 FSTESTCFG=$(parse fstestcfg | sed -e 's/,/ /g')
Signature · 1 line
2.13.0