Skip to contentSkip to conversation

ARM: dts: imx23-sansa: Remove 'enable-active-low' property

PATCH New Fabio Estevam 3 participants 4 messages May 23, 2017 – May 25, 2017

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH v2 1/2 ARM: dts: imx23-sansa: Remove 'enable-active-low' property

Property 'enable-active-low' does not exist. Only 'enable-active-high' is valid, and when this property is absent the gpio regulator will act as active low by default.

So remove the unexisting 'enable-active-low' property.

Currently the GPIO flag is 0, which means active-high. In order to make the dts description accurate, pass the GPIO_ACTIVE_LOW flag instead.

This change is safe because the gpio regulator driver does not take the GPIO flag polarity into account.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Improve commit log and explain why this change is safe (Stefan).

 arch/arm/boot/dts/imx23-sansa.dts | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx23-sansa.dts +3 -4
index 4ec32f4..221fd55 100644
@@ -42,6 +42,7 @@
  */
 
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "imx23.dtsi"
 
 / {

@@ -149,9 +150,8 @@
 		regulator-name = "vdd-touchpad0";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
-		gpio = <&gpio0 26 0>;
+		gpio = <&gpio0 26 GPIO_ACTIVE_LOW>;
 		regulator-always-on;
-		enable-active-low;
 	};
 
 	reg_vdd_tuner: regulator-vdd-tuner0 {

@@ -159,9 +159,8 @@
 		regulator-name = "vdd-tuner0";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
-		gpio = <&gpio0 29 0>;
+		gpio = <&gpio0 29 GPIO_ACTIVE_LOW>;
 		regulator-always-on;
-		enable-active-low;
 	};
 
 	backlight {
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v2 2/2 ARM: dts: tx6: Remove 'enable-active-low' property

Property 'enable-active-low' does not exist. Only 'enable-active-high' is valid, and when this property is absent the gpio regulator will act as active low by default.

So remove the unexisting 'enable-active-low' property.

Currently the GPIO flag is GPIO_ACTIVE_HIGH. In order to make the dts description accurate, pass the GPIO_ACTIVE_LOW flag instead.

This change is safe because the gpio regulator driver does not take the GPIO flag polarity into account.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Improve commit log and explain why this change is safe (Stefan).

 arch/arm/boot/dts/imx6qdl-tx6.dtsi  | 3 +--
 arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx6qdl-tx6.dtsi +1 -2
index 1691714..a146fe7 100644
@@ -133,8 +133,7 @@
 		regulator-max-microvolt = <3300000>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_flexcan_xcvr>;
-		gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
-		enable-active-low;
+		gpio = <&gpio4 21 GPIO_ACTIVE_LOW>;
 	};
 
 	reg_lcd0_pwr: regulator-lcd0-pwr {
arch/arm/boot/dts/imx6ul-tx6ul.dtsi +1 -2
index c784a0b..4ccc9e9 100644
@@ -173,8 +173,7 @@
 		regulator-max-microvolt = <3300000>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_flexcan_xcvr>;
-		gpio = <&gpio3 5 GPIO_ACTIVE_HIGH>;
-		enable-active-low;
+		gpio = <&gpio3 5 GPIO_ACTIVE_LOW>;
 	};
 
 	reg_lcd_pwr: regulator-lcdpwr {
Signature · 1 line
2.7.4
#2 lore raw

PATCH v2 2/2 ARM: dts: tx6: Remove 'enable-active-low' property

Quoted 40 lines · Fabio Estevam

Property 'enable-active-low' does not exist. Only 'enable-active-high' is valid, and when this property is absent the gpio regulator will act as active low by default.

So remove the unexisting 'enable-active-low' property.

Currently the GPIO flag is GPIO_ACTIVE_HIGH. In order to make the dts description accurate, pass the GPIO_ACTIVE_LOW flag instead.

This change is safe because the gpio regulator driver does not take the GPIO flag polarity into account.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Improve commit log and explain why this change is safe (Stefan).

 arch/arm/boot/dts/imx6qdl-tx6.dtsi  | 3 +--
 arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx6qdl-tx6.dtsi +1 -2
index 1691714..a146fe7 100644
@@ -133,8 +133,7 @@
 		regulator-max-microvolt = <3300000>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_flexcan_xcvr>;
-		gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
-		enable-active-low;
+		gpio = <&gpio4 21 GPIO_ACTIVE_LOW>;
 	};
 
 	reg_lcd0_pwr: regulator-lcd0-pwr {
arch/arm/boot/dts/imx6ul-tx6ul.dtsi +0 -0
index c784a0b..4ccc9e9 100644

arch/arm/boot/dts/imx6ul-tx6ul.dtsi line 179

Quoted 9 lines
arch/arm/boot/dts/imx6ul-tx6ul.dtsi +1 -2
@@ -173,8 +173,7 @@
 		regulator-max-microvolt = <3300000>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_flexcan_xcvr>;
-		gpio = <&gpio3 5 GPIO_ACTIVE_HIGH>;
-		enable-active-low;
+		gpio = <&gpio3 5 GPIO_ACTIVE_LOW>;
 	};
 
 	reg_lcd_pwr: regulator-lcdpwr {
Acked-by Lothar Wa?mann <[email protected]>

Thanks for the cleanup,
Lothar Wa?mann

Signature · 9 lines
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
Applied
#3 lore raw

PATCH v2 1/2 ARM: dts: imx23-sansa: Remove 'enable-active-low' property

In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

Property 'enable-active-low' does not exist. Only 'enable-active-high' is valid, and when this property is absent the gpio regulator will act as active low by default.

So remove the unexisting 'enable-active-low' property.

Quoted 7 lines

Currently the GPIO flag is 0, which means active-high. In order to make the dts description accurate, pass the GPIO_ACTIVE_LOW flag instead.

This change is safe because the gpio regulator driver does not take the GPIO flag polarity into account.

Signed-off-by Fabio Estevam <[email protected]>

Applied both, thanks.