Skip to contentSkip to conversation

malloc: Turn on DEBUG when enabling unit tests

PATCH In review Pantelis Antoniou 3 participants 4 messages May 25, 2017 – Jun 6, 2017

lore
Share & tools
lore

Pantelis Antoniou

author
#0 lore raw

PATCH 1/1 malloc: Turn on DEBUG when enabling unit tests

Unit tests require mallinfo which in turn requires DEBUG on dlmalloc to be enabled.

The dependancy on CONFIG_SANDBOX is wrong.

Signed-off-by Pantelis Antoniou <[email protected]>
---
 common/dlmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/dlmalloc.c +1 -1
index adc680e..fc1e8b3 100644
@@ -1,6 +1,6 @@
 #include <common.h>
 
-#ifdef CONFIG_SANDBOX
+#if defined(CONFIG_UNIT_TEST)
 #define DEBUG
 #endif
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 malloc: Turn on DEBUG when enabling unit tests

Quoted 6 lines · Pantelis Antoniou

Unit tests require mallinfo which in turn requires DEBUG on dlmalloc to be enabled.

The dependancy on CONFIG_SANDBOX is wrong.

Signed-off-by Pantelis Antoniou <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170525/04055f45/attachment.sig>
#3 lore raw
In reply to Pantelis Antoniou
Quoted 8 lines · Pantelis Antoniou

Unit tests require mallinfo which in turn requires DEBUG on dlmalloc to be enabled.

The dependancy on CONFIG_SANDBOX is wrong.

Signed-off-by Pantelis Antoniou <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Reviewed-by Simon Glass <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170605/a32b333e/attachment.sig>