drm/amdgpu: Really leave SI support disabled by default
Subsystems (2)
PATCH 1/3 drm/amdgpu: Really leave SI support disabled by default
From: Michel Dänzer <[email protected]>
The default option value didn't match the help text and intention.
---
Maybe this can be squashed into the commit adding this option when it goes upstream.
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 -1
@@ -234,7 +234,7 @@ MODULE_PARM_DESC(param_buf_per_se, "the size of Off-Chip Pramater Cache per Shadmodule_param_named (param_buf_per_se, amdgpu_param_buf_per_se, int,0444 );#ifdef CONFIG_DRM_AMDGPU_SI -int amdgpu_si_support =1 ; +int amdgpu_si_support =0 ;MODULE_PARM_DESC (si_support,"SI support (1 = enabled, 0 = disabled (default))" );module_param_named (si_support, amdgpu_si_support, int,0444 );#endif
Signature · 6 lines
2.11.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20170529092026.5567-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org
PATCH 2/3 drm/radeon: Make si_support and cik_support parameters always available
From: Michel Dänzer <[email protected]>
This will allow amdgpu-pro / other out-of-tree amdgpu builds to make use of these options for using the out-of-tree amdgpu driver instead of the in-tree radeon driver in a clean way.
--- drivers/gpu/drm/radeon/radeon.h | 5 ----- drivers/gpu/drm/radeon/radeon_drv.c | 4 ---- drivers/gpu/drm/radeon/radeon_kms.c | 4 ---- 3 files changed, 13 deletions(-)
drivers/gpu/drm/radeon/radeon.h +0 -5
@@ -116,13 +116,8 @@ extern int radeon_auxch;extern int radeon_mst;extern int radeon_uvd;extern int radeon_vce; - -#ifdef CONFIG_DRM_AMDGPU_SI extern int radeon_si_support; -#endif -#ifdef CONFIG_DRM_AMDGPU_CIK extern int radeon_cik_support; -#endif /* * Copy from radeon_drv.h so we don't have to include both and have conflicting
drivers/gpu/drm/radeon/radeon_drv.c +0 -4
@@ -303,17 +303,13 @@ module_param_named(uvd, radeon_uvd, int, 0444);MODULE_PARM_DESC (vce,"vce enable/disable vce support (1 = enable, 0 = disable)" );module_param_named (vce, radeon_vce, int,0444 ); -#ifdef CONFIG_DRM_AMDGPU_SI int radeon_si_support =1 ;MODULE_PARM_DESC (si_support,"SI support (1 = enabled (default), 0 = disabled)" );module_param_named (si_support, radeon_si_support, int,0444 ); -#endif -#ifdef CONFIG_DRM_AMDGPU_CIK int radeon_cik_support =0 ;MODULE_PARM_DESC (cik_support,"CIK support (1 = enabled, 0 = disabled (default))" );module_param_named (cik_support, radeon_cik_support, int,0444 ); -#endif static struct pci_device_id pciidlist[] = { radeon_PCI_IDS
drivers/gpu/drm/radeon/radeon_kms.c +0 -4
@@ -98,7 +98,6 @@ int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags)struct radeon_device *rdev;int r, acpi_status; -#ifdef CONFIG_DRM_AMDGPU_SI if (!radeon_si_support) {switch (flags &RADEON_FAMILY_MASK ) {case CHIP_TAHITI :
@@ -111,8 +110,6 @@ int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags)return -ENODEV ; } } -#endif -#ifdef CONFIG_DRM_AMDGPU_CIK if (!radeon_cik_support) {switch (flags &RADEON_FAMILY_MASK ) {case CHIP_KAVERI :
@@ -128,7 +125,6 @@ int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags)return -ENODEV ; } } -#endif rdev =kzalloc (sizeof (struct radeon_device ),GFP_KERNEL );if (rdev ==NULL ) {
Signature · 6 lines
2.11.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 3/3 drm/amdgpu/radeon: Use radeon by default for CIK GPUs
In reply to a message not in the archiveFrom: Michel Dänzer <[email protected]>
Even if CONFIG_DRM_AMDGPU_CIK is enabled.
There is no feature parity yet for CIK, in particular amdgpu doesn't support HDMI/DisplayPort without DC.
--- drivers/gpu/drm/amd/amdgpu/Kconfig | 8 ++++---- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 7 +++++-- drivers/gpu/drm/radeon/radeon_drv.c | 4 ++-- drivers/gpu/drm/radeon/radeon_kms.c | 5 +---- 5 files changed, 14 insertions(+), 14 deletions(-)
drivers/gpu/drm/amd/amdgpu/Kconfig +4 -4
@@ -17,11 +17,11 @@ config DRM_AMDGPU_CIK help Choose this option if you want to enable support for CIK asics. - CIK is already supported in radeon. If you enable this option, - support for CIK will be provided by amdgpu and disabled in - radeon by default. Use module options to override this: + CIK is already supported in radeon. Support for SI in amdgpu + will be disabled by default and is still provided by radeon. + Use module options to override this: - radeon.cik_support=1 amdgpu.cik_support=0 + radeon.cik_support=0 amdgpu.cik_support=1 config DRM_AMDGPU_USERPTR bool "Always enable userptr write support"
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2 -2
@@ -240,8 +240,8 @@ module_param_named(si_support, amdgpu_si_support, int, 0444);#endif #ifdef CONFIG_DRM_AMDGPU_CIK -int amdgpu_cik_support =1 ; -MODULE_PARM_DESC (cik_support,"CIK support (1 = enabled (default), 0 = disabled)" ); +int amdgpu_cik_support =0 ; +MODULE_PARM_DESC (cik_support,"CIK support (1 = enabled, 0 = disabled (default))" );module_param_named (cik_support, amdgpu_cik_support, int,0444 );#endif
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +5 -2
@@ -98,7 +98,7 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)dev_info (dev->dev,"SI support provided by radeon.\n" );dev_info (dev->dev, -"Use radeon.si_support=0 amdgpu.si_support=1 to override.\n" +"Use radeon.si_support=0 amdgpu.si_support=1 to override.\n" );return -ENODEV ; }
@@ -113,7 +113,10 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)case CHIP_KABINI :case CHIP_MULLINS :dev_info (dev->dev, -"CIK support disabled by module param\n" ); +"CIK support provided by radeon.\n" ); +dev_info (dev->dev, +"Use radeon.cik_support=0 amdgpu.cik_support=1 to override.\n" + );return -ENODEV ; } }
drivers/gpu/drm/radeon/radeon_drv.c +2 -2
@@ -307,8 +307,8 @@ int radeon_si_support = 1;MODULE_PARM_DESC (si_support,"SI support (1 = enabled (default), 0 = disabled)" );module_param_named (si_support, radeon_si_support, int,0444 ); -int radeon_cik_support =0 ; -MODULE_PARM_DESC (cik_support,"CIK support (1 = enabled, 0 = disabled (default))" ); +int radeon_cik_support =1 ; +MODULE_PARM_DESC (cik_support,"CIK support (1 = enabled (default), 0 = disabled)" );module_param_named (cik_support, radeon_cik_support, int,0444 );static struct pci_device_id pciidlist[] = {
drivers/gpu/drm/radeon/radeon_kms.c +1 -4
@@ -118,10 +118,7 @@ int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags)case CHIP_KABINI :case CHIP_MULLINS :dev_info (dev->dev, -"CIK support provided by amdgpu.\n" ); -dev_info (dev->dev, -"Use radeon.cik_support=1 amdgpu.cik_support=0 to override.\n" - ); +"CIK support disabled by module param\n" );return -ENODEV ; } }
Signature · 6 lines
2.11.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20170529092026.5567-3-michel-otUistvHUpPR7s880joybQ@public.gmane.org
Re: [PATCH 3/3] drm/amdgpu/radeon: Use radeon by default for CIK GPUs
Hey Michel,
Michel Dänzer wrote on 29.05.2017 11:20:
Quoted 6 lines
From: Michel Dänzer <[email protected]>
Even if
CONFIG_DRM_AMDGPU_CIKis enabled.There is no feature parity yet for CIK, in particular amdgpu doesn't support HDMI/DisplayPort without DC.
that can't be correct. I'm using amdgpu on a CIK ASIC (Hawaii Pro) and my monitor is connected by DisplayPort. From my Xorg.0.log:
Quoted 8 lines
[ 37.811] (II) AMDGPU(0): EDID for output DisplayPort-0 [ 37.811] (II) AMDGPU(0): Manufacturer: SAM Model: 83d Serial#: 0 [ 37.811] (II) AMDGPU(0): Year: 2011 Week: 7 [ 37.811] (II) AMDGPU(0): EDID Version: 1.4 [ 37.811] (II) AMDGPU(0): Digital Display Input [ 37.811] (II) AMDGPU(0): 8 bits per channel [ 37.811] (II) AMDGPU(0): Digital interface is DisplayPort [ 37.811] (II) AMDGPU(0): Max Image Size [cm]: horiz.: 52 vert.: 32
Quoted 8 lines
[ 37.811] (II) AMDGPU(0): Gamma: 2.20 [ 37.811] (II) AMDGPU(0): DPMS capabilities: Off [ 37.811] (II) AMDGPU(0): Supported color encodings: RGB 4:4:4 [ 37.811] (II) AMDGPU(0): First detailed timing is preferred mode [ 37.811] (II) AMDGPU(0): Preferred mode is native pixel format and refresh rate [ 37.811] (II) AMDGPU(0): redX: 0.650 redY: 0.337 greenX: 0.296 greenY: 0.604 [ 37.811] (II) AMDGPU(0): blueX: 0.147 blueY: 0.074 whiteX: 0.312 whiteY: 0.329 [ 37.811] (II) AMDGPU(0): Supported established timings: [...]
Or do you mean some features like audio over HDMI/DP?
Quoted 16 lines
Signed-off-by Michel Dänzer <[email protected]>--- drivers/gpu/drm/amd/amdgpu/Kconfig | 8 ++++---- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 7 +++++-- drivers/gpu/drm/radeon/radeon_drv.c | 4 ++-- drivers/gpu/drm/radeon/radeon_kms.c | 5 +---- 5 files changed, 14 insertions(+), 14 deletions(-)drivers/gpu/drm/amd/amdgpu/Kconfig +0
-0@@ -17,11 +17,11 @@ config DRM_AMDGPU_CIK help Choose this option if you want to enable support for CIK asics.
drivers/gpu/drm/amd/amdgpu/Kconfig config DRM_AMDGPU_CIK · line 24
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/Kconfig +4
-4- CIK is already supported in radeon. If you enable this option, - support for CIK will be provided by amdgpu and disabled in - radeon by default. Use module options to override this: + CIK is already supported in radeon. Support for SI in amdgpu + will be disabled by default and is still provided by radeon. + Use module options to override this: - radeon.cik_support=1 amdgpu.cik_support=0 + radeon.cik_support=0 amdgpu.cik_support=1
What happens if I have radeon blacklisted? Do I still need to set this additional flag? If so I'd kindly request to at least fall back to amdgpu if somebody blacklisted radeon (or didn't compile it). Maybe issue a warning that not all features are supported yet.
Thank you for your consideration!
Cheers,
Kai
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 27357f85-4149-40c5-f408-6091b07fcd2b-1ZKVMVCtJ2dx9oSEVPI0kiST3g8Odh+X@public.gmane.org
Re: [PATCH 3/3] drm/amdgpu/radeon: Use radeon by default for CIK GPUs
Quoted 10 lines · Kai Wasserbäch
Hey Michel,
Michel Dänzer wrote on 29.05.2017 11:20:Quoted 6 lines
From: Michel Dänzer <[email protected]>
Even if
CONFIG_DRM_AMDGPU_CIKis enabled.There is no feature parity yet for CIK, in particular amdgpu doesn't support HDMI/DisplayPort without DC.
that can't be correct.
Indeed, I meant "HDMI/DisplayPort audio", sorry for the confusion. Will be fixed in v2.
Quoted 15 lines
Quoted 15 lines
drivers/gpu/drm/amd/amdgpu/Kconfig +3
-3@@ -17,11 +17,11 @@ config DRM_AMDGPU_CIK help Choose this option if you want to enable support for CIK asics. - CIK is already supported in radeon. If you enable this option, - support for CIK will be provided by amdgpu and disabled in - radeon by default. Use module options to override this: + CIK is already supported in radeon. Support for SI in amdgpu + will be disabled by default and is still provided by radeon. + Use module options to override this:
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/Kconfig config DRM_AMDGPU_CIK · line 24
Quoted 2 lines
drivers/gpu/drm/amd/amdgpu/Kconfig +1
-1- radeon.cik_support=1 amdgpu.cik_support=0 + radeon.cik_support=0 amdgpu.cik_support=1What happens if I have radeon blacklisted? Do I still need to set this additional flag?
Yes, you still need to set amdgpu.cik_support=1.
Quoted 2 lines
If so I'd kindly request to at least fall back to amdgpu if somebody blacklisted radeon (or didn't compile it).
I'm afraid that's not possible, at least I don't know how it could be done.
The intention is that these options provide a cleaner way than blacklisting for choosing between the drivers, so the options should be used instead of blacklisting.
Quoted 1 line
Maybe issue a warning that not all features are supported yet.
The drivers print a message when they're ignoring a GPU due to these options.
Signature · 6 lines
Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 3/3] drm/amdgpu/radeon: Use radeon by default for CIK GPUs
In reply to a message not in the archiveQuoted 8 lines · Michel Dänzer
From: Michel Dänzer <[email protected]>
Even if
CONFIG_DRM_AMDGPU_CIKis enabled.There is no feature parity yet for CIK, in particular amdgpu doesn't support HDMI/DisplayPort without DC.
Signed-off-by Michel Dänzer <[email protected]>
[...]
drivers/gpu/drm/amd/amdgpu/Kconfig config DRM_AMDGPU_CIK · line 20
Quoted 12 lines
drivers/gpu/drm/amd/amdgpu/Kconfig +1
-3@@ -17,11 +17,11 @@ config DRM_AMDGPU_CIK help Choose this option if you want to enable support for CIK asics. - CIK is already supported in radeon. If you enable this option, - support for CIK will be provided by amdgpu and disabled in - radeon by default. Use module options to override this: + CIK is already supported in radeon. Support for SI in amdgpu
Consider this "SI" typo fixed in v2.
Signature · 6 lines
Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 42a9725f-58f7-d862-0a39-f8f3f6ed615a-otUistvHUpPR7s880joybQ@public.gmane.org
Re: [PATCH 3/3] drm/amdgpu/radeon: Use radeon by default for CIK GPUs
Quoted 20 lines · Michel Dänzer
Quoted 8 lines · Michel Dänzer
From: Michel Dänzer <[email protected]>
Even if
CONFIG_DRM_AMDGPU_CIKis enabled.There is no feature parity yet for CIK, in particular amdgpu doesn't support HDMI/DisplayPort without DC.
Signed-off-by Michel Dänzer <[email protected]>[...]
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/Kconfig +0
-0@@ -17,11 +17,11 @@ config DRM_AMDGPU_CIK help Choose this option if you want to enable support for CIK asics.
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/Kconfig config DRM_AMDGPU_CIK · line 20
Quoted 4 lines
drivers/gpu/drm/amd/amdgpu/Kconfig +1
-3- CIK is already supported in radeon. If you enable this option, - support for CIK will be provided by amdgpu and disabled in - radeon by default. Use module options to override this: + CIK is already supported in radeon. Support for SI in amdgpuConsider this "SI" typo fixed in v2.
While you are here, what about adding the full codenames here? You can't expect every user configuring the kernel to know what SI/CIK means, it's not even documented in
https://www.x.org/wiki/RadeonFeature/ or wikipedia, while the long codenames are.
Gražvydas
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CANOLnOOO574oSPA_A9Yz=dRJGsXkPcjWn8OHEmpg4qtoeadVNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: [PATCH 3/3] drm/amdgpu/radeon: Use radeon by default for CIK GPUs
Quoted 28 lines · Grazvydas Ignotas
Quoted 20 lines · Michel Dänzer
Quoted 8 lines · Michel Dänzer
From: Michel Dänzer <[email protected]>
Even if
CONFIG_DRM_AMDGPU_CIKis enabled.There is no feature parity yet for CIK, in particular amdgpu doesn't support HDMI/DisplayPort without DC.
Signed-off-by Michel Dänzer <[email protected]>[...]
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/Kconfig +0
-0@@ -17,11 +17,11 @@ config DRM_AMDGPU_CIK help Choose this option if you want to enable support for CIK asics.Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/Kconfig config DRM_AMDGPU_CIK · line 20
Quoted 4 lines
drivers/gpu/drm/amd/amdgpu/Kconfig +1
-3- CIK is already supported in radeon. If you enable this option, - support for CIK will be provided by amdgpu and disabled in - radeon by default. Use module options to override this: + CIK is already supported in radeon. Support for SI in amdgpuConsider this "SI" typo fixed in v2.
Quoted 5 lines
While you are here, what about adding the full codenames here? You can't expect every user configuring the kernel to know what SI/CIK means, it's not even documented in
https://www.x.org/wiki/RadeonFeature/ or wikipedia, while the long codenames are.
That's out of scope for this series, and I definitely won't get around to doing that before next week. Anybody feel free to beat me to it.
Signature · 6 lines
Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Deucher, Alexander
Reviewed-by Alex DeucherRE: [PATCH 3/3] drm/amdgpu/radeon: Use radeon by default for CIK GPUs
In reply to a message not in the archiveQuoted 8 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Michel Dänzer
Sent: Monday, May 29, 2017 5:20 AM
To: [email protected]
Subject: [PATCH 3/3] drm/amdgpu/radeon: Use radeon by default for CIK GPUs
Quoted 6 lines
From: Michel Dänzer <[email protected]>
Even if
CONFIG_DRM_AMDGPU_CIKis enabled.There is no feature parity yet for CIK, in particular amdgpu doesn't support HDMI/DisplayPort without DC.
"HDMI/DisplayPort audio"
With that fixed, the series is:
Quoted 122 lines
Signed-off-by Michel Dänzer <[email protected]>--- drivers/gpu/drm/amd/amdgpu/Kconfig | 8 ++++---- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 7 +++++-- drivers/gpu/drm/radeon/radeon_drv.c | 4 ++-- drivers/gpu/drm/radeon/radeon_kms.c | 5 +---- 5 files changed, 14 insertions(+), 14 deletions(-)drivers/gpu/drm/amd/amdgpu/Kconfig +4
-4@@ -17,11 +17,11 @@ config DRM_AMDGPU_CIK help Choose this option if you want to enable support for CIK asics. - CIK is already supported in radeon. If you enable this option, - support for CIK will be provided by amdgpu and disabled in - radeon by default. Use module options to override this: + CIK is already supported in radeon. Support for SI in amdgpu + will be disabled by default and is still provided by radeon. + Use module options to override this: - radeon.cik_support=1 amdgpu.cik_support=0 + radeon.cik_support=0 amdgpu.cik_support=1 config DRM_AMDGPU_USERPTR bool "Always enable userptr write support"drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2
-2@@ -240,8 +240,8 @@ module_param_named(si_support, amdgpu_si_support, int, 0444);#endif #ifdef CONFIG_DRM_AMDGPU_CIK -int amdgpu_cik_support =1 ; -MODULE_PARM_DESC(cik_support, "CIK support (1 = enabled (default), 0 = disabled)"); +int amdgpu_cik_support = 0; +MODULE_PARM_DESC(cik_support, "CIK support (1 = enabled, 0 = disabled (default))");
module_param_named(cik_support, amdgpu_cik_support, int, 0444); #endifdrivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0
-1@@ -98,7 +98,7 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags) dev_info(dev->dev, "SI support provided by radeon.\n"); dev_info(dev->dev, - "Use radeon.si_support=0 amdgpu.si_support=1 tooverride.\n"
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1
-0+ "Use radeon.si_support=0amdgpu.si_support=1 to override.\n"
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +3
-1);return -ENODEV ; }@@ -113,7 +113,10 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)case CHIP_KABINI :case CHIP_MULLINS :dev_info (dev->dev, -"CIK support disabled by module param\n" ); +"CIK support provided by radeon.\n" ); + dev_info(dev->dev, + "Use radeon.cik_support=0amdgpu.cik_support=1 to override.\n"
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1
-0+ );return -ENODEV ; } }drivers/gpu/drm/radeon/radeon_drv.c +2
-2@@ -307,8 +307,8 @@ int radeon_si_support = 1; MODULE_PARM_DESC(si_support, "SI support (1 = enabled (default), 0 = disabled)"); module_param_named(si_support, radeon_si_support, int,0444 ); -int radeon_cik_support =0 ; -MODULE_PARM_DESC(cik_support, "CIK support (1 = enabled, 0 = disabled (default))"); +int radeon_cik_support =1 ; +MODULE_PARM_DESC(cik_support, "CIK support (1 = enabled (default), 0 = disabled)");
module_param_named(cik_support, radeon_cik_support, int, 0444);static struct
pci_device_idpciidlist[] = {drivers/gpu/drm/radeon/radeon_kms.c +0
-3@@ -118,10 +118,7 @@ int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags)case CHIP_KABINI :case CHIP_MULLINS : dev_info(dev->dev, -"CIK support provided by amdgpu.\n" ); - dev_info(dev->dev, - "Use radeon.cik_support=1 amdgpu.cik_support=0 tooverride.\n"
drivers/gpu/drm/radeon/radeon_kms.c +1
-2- ); + "CIK support disabled by module param\n");return -ENODEV ; } } --2.11.0
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Am 29.05.2017 um 11:20 schrieb Michel Dänzer:
Quoted 5 lines
From: Michel Dänzer <[email protected]>
The default option value didn't match the help text and intention.
Signed-off-by Michel Dänzer <[email protected]>
I'm still unsure about the last one. The feature parity is a good argument but on the other hand we want people to use amdgpu for CIK these days, don't we?
Anyway Reviewed-by: Christian König <[email protected]>.
Regards,
Christian.
Quoted 13 lines
---
Maybe this can be squashed into the commit adding this option when it goes upstream.
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c MODULE_PARM_DESC(param_buf_per_se, "the size of Off-Chip Pramater Cache per Shad · line 240
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1
-1@@ -234,7 +234,7 @@ MODULE_PARM_DESC(param_buf_per_se, "the size of Off-Chip Pramater Cache per Shadmodule_param_named (param_buf_per_se, amdgpu_param_buf_per_se, int,0444 );#ifdef CONFIG_DRM_AMDGPU_SI -int amdgpu_si_support =1 ; +int amdgpu_si_support =0 ;MODULE_PARM_DESC (si_support,"SI support (1 = enabled, 0 = disabled (default))" );module_param_named (si_support, amdgpu_si_support, int,0444 );#endif
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): b0db57f8-ccdf-4af7-c9fd-0a5cd3545099-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org
Quoted 10 lines · Christian König
Am 29.05.2017 um 11:20 schrieb Michel Dänzer:
Quoted 5 lines
From: Michel Dänzer <[email protected]>
The default option value didn't match the help text and intention.
Signed-off-by Michel Dänzer <[email protected]>I'm still unsure about the last one. The feature parity is a good argument but on the other hand we want people to use amdgpu for CIK these days, don't we?
We want to make it easy for people to test amdgpu on CIK, which is what the options added by Felix are for. IMO we should not flip the default (upstream) before there is feature parity.
Quoted 1 line
Anyway Reviewed-by: Christian König <[email protected]>.
Thanks, I assume that applies to the whole series?
Signature · 6 lines
Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 3f76e24c-d27c-62af-dd81-02080d058753-otUistvHUpPR7s880joybQ@public.gmane.org
Am 30.05.2017 um 05:26 schrieb Michel Dänzer:
Quoted 10 lines · Christian König
Quoted 9 lines
Am 29.05.2017 um 11:20 schrieb Michel Dänzer:
Quoted 5 lines
From: Michel Dänzer <[email protected]>
The default option value didn't match the help text and intention.
Signed-off-by Michel Dänzer <[email protected]>I'm still unsure about the last one. The feature parity is a good argument but on the other hand we want people to use amdgpu for CIK these days, don't we?
Quoted 7 lines
We want to make it easy for people to test amdgpu on CIK, which is what the options added by Felix are for. IMO we should not flip the default (upstream) before there is feature parity.
Quoted 1 line
Anyway Reviewed-by: Christian König <[email protected]>.
Thanks, I assume that applies to the whole series?
With the SI typo and the HDMI/DP audio thing pointed out by Kai fixed, than yes that rb applies to the whole series.
Christian.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx