introduce Rockchip rockusb

PATCH Superseded Eddie Cai 3 participants 22 messages May 25, 2017 – Jun 30, 2017

Subsystems (4)

Arm (32-bit) USB Arm sub-architectures Arm Rockchip

lore

Share & tools

lore

Eddie Cai

author

2017-05-25 08:50 UTC #0 lore raw

v7 cover introduce Rockchip rockusb

Changes in v7:
-use imply in the Kconfig to enable rockusb

Changes in v6:
-enable rockusb in defconfig
-move some data to f_rockusb structure

Changes in v5:
-fix build error when build other board
-fix checkpatch error

Changes in v4:
-use enum instead of macro define
-move some structure define and macro to f_rockusb.h -add some function comment as Simon required -address other comment from Simon
-fix build error as Lukasz point out

Changes in v3:
-switch back to use g_dnl code
-address comment from Lukasz and Simon
-fix checkpatch error

Changes in v2:
-switch to use usb masstorage framework
-add readme for rockusb

Eddie Cai (4):
usb: rockchip: add the rockusb gadget
usb: rockchip: add rockusb command
rockchip:usb: add a simple readme for rockusb
rockchip: rk3288: enable rockusb support on rk3288 based device

 arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +++++
 arch/arm/mach-rockchip/Kconfig                 |   2 +
 cmd/Kconfig                                    |   9 +
 cmd/Makefile                                   |   1 +
 cmd/rockusb.c                                  |  74 +++
 configs/evb-rk3288_defconfig                   |   9 +
 configs/fennec-rk3288_defconfig                |   6 +
 configs/firefly-rk3288_defconfig               |   6 +
 configs/miqi-rk3288_defconfig                  |   6 +
 configs/popmetal-rk3288_defconfig              |   6 +
 configs/tinker-rk3288_defconfig                |   6 +
 doc/README.rockusb                             |  51 ++
 drivers/usb/gadget/Kconfig                     |   8 +
 drivers/usb/gadget/Makefile                    |   1 +
 drivers/usb/gadget/f_rockusb.c                 | 691 +++++++++++++++++++++++++
 include/configs/rk3288_common.h                |   7 -
 16 files changed, 1008 insertions(+), 7 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
 create mode 100644 cmd/rockusb.c
 create mode 100644 doc/README.rockusb
 create mode 100644 drivers/usb/gadget/f_rockusb.c

Signature · 1 line

1.9.1

Eddie Cai

author

2017-05-25 08:50 UTC #1 lore raw

PATCH v7 1/4 usb: rockchip: add the rockusb gadget

this patch implement rockusb protocol on the device side. this is based on USB download gadget infrastructure. the rockusb function implements the rd, wl, rid commands. it can work with rkdeveloptool

Signed-off-by Eddie Cai <[email protected]>

Reviewed-by Simon Glass <[email protected]>

Changes in v7:
-none

Changes in v6:
-move some data to f_rockusb structure

Changes in v5:
-fix build error when build non-rockchip board
-fix checkpatch error

Changes in v3:
-split the macro to f_rockusb.h
-use ALLOC_CACHE_ALIGN_BUFFER to define cache safe struct inside the function. -fix checkpatch error

---
 arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +++++
 drivers/usb/gadget/Kconfig                     |   8 +
 drivers/usb/gadget/Makefile                    |   1 +
 drivers/usb/gadget/f_rockusb.c                 | 691 +++++++++++++++++++++++++
 4 files changed, 832 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
 create mode 100644 drivers/usb/gadget/f_rockusb.c

arch/arm/include/asm/arch-rockchip/f_rockusb.h new file +132 -0

new file mode 100644
index 0000000..c207a78
@@ -0,0 +1,132 @@
+/*
+ * (C) Copyright 2017
+ *
+ * Eddie Cai <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef _F_ROCKUSB_H_
+#define _F_ROCKUSB_H_
+#include <blk.h>
+
+#define ROCKUSB_VERSION		"0.1"
+
+#define ROCKUSB_INTERFACE_CLASS	0xff
+#define ROCKUSB_INTERFACE_SUB_CLASS	0x06
+#define ROCKUSB_INTERFACE_PROTOCOL	0x05
+
+#define RX_ENDPOINT_MAXIMUM_PACKET_SIZE_2_0  (0x0200)
+#define RX_ENDPOINT_MAXIMUM_PACKET_SIZE_1_1  (0x0040)
+#define TX_ENDPOINT_MAXIMUM_PACKET_SIZE      (0x0040)
+
+#define EP_BUFFER_SIZE			4096
+/*
+ * EP_BUFFER_SIZE must always be an integral multiple of maxpacket size
+ * (64 or 512 or 1024), else we break on certain controllers like DWC3
+ * that expect bulk OUT requests to be divisible by maxpacket size.
+ */
+
+#define CONFIG_ROCKUSB_BUF_ADDR		CONFIG_SYS_LOAD_ADDR
+#define CONFIG_ROCKUSB_BUF_SIZE		0x08000000
+
+#define RKUSB_STATUS_IDLE			0
+#define RKUSB_STATUS_CMD			1
+#define RKUSB_STATUS_RXDATA			2
+#define RKUSB_STATUS_TXDATA			3
+#define RKUSB_STATUS_CSW			4
+#define RKUSB_STATUS_RXDATA_PREPARE		5
+#define RKUSB_STATUS_TXDATA_PREPARE		6
+
+enum rkusb_command {
+K_FW_TEST_UNIT_READY	= 0x00,
+K_FW_READ_FLASH_ID = 0x01,
+K_FW_SET_DEVICE_ID = 0x02,
+K_FW_TEST_BAD_BLOCK = 0x03,
+K_FW_READ_10 = 0x04,
+K_FW_WRITE_10 = 0x05,
+K_FW_ERASE_10 = 0x06,
+K_FW_WRITE_SPARE = 0x07,
+K_FW_READ_SPARE = 0x08,
+
+K_FW_ERASE_10_FORCE = 0x0b,
+K_FW_GET_VERSION = 0x0c,
+
+K_FW_LBA_READ_10 = 0x14,
+K_FW_LBA_WRITE_10 = 0x15,
+K_FW_ERASE_SYS_DISK = 0x16,
+K_FW_SDRAM_READ_10 = 0x17,
+K_FW_SDRAM_WRITE_10 = 0x18,
+K_FW_SDRAM_EXECUTE = 0x19,
+K_FW_READ_FLASH_INFO = 0x1A,
+K_FW_GET_CHIP_VER = 0x1B,
+K_FW_LOW_FORMAT = 0x1C,
+K_FW_SET_RESET_FLAG = 0x1E,
+K_FW_SPI_READ_10 = 0x21,
+K_FW_SPI_WRITE_10 = 0x22,
+
+K_FW_SESSION = 0X30,
+K_FW_RESET = 0xff,
+};
+
+#define CBW_DIRECTION_OUT		0x00
+#define CBW_DIRECTION_IN		0x80
+
+struct cmd_dispatch_info {
+	enum rkusb_command cmd;
+	/* call back function to handle rockusb command */
+	void (*cb)(struct usb_ep *ep, struct usb_request *req);
+};
+
+/* Bulk-only data structures */
+
+/* Command Block Wrapper */
+struct fsg_bulk_cb_wrap {
+	__le32  signature;              /* Contains 'USBC' */
+	u32     tag;                    /* Unique per command id */
+	__le32  data_transfer_length;   /* Size of the data */
+	u8      flags;                  /* Direction in bit 7 */
+	u8      lun;                    /* lun (normally 0) */
+	u8      length;                 /* Of the CDB, <= MAX_COMMAND_SIZE */
+	u8      CDB[16];                /* Command Data Block */
+};
+
+#define USB_BULK_CB_WRAP_LEN    31
+#define USB_BULK_CB_SIG         0x43425355      /* Spells out USBC */
+#define USB_BULK_IN_FLAG        0x80
+
+/* Command status Wrapper */
+struct bulk_cs_wrap {
+	__le32  signature;              /* Should = 'USBS' */
+	u32     tag;                    /* Same as original command */
+	__le32  residue;                /* Amount not transferred */
+	u8      status;                 /* See below */
+};
+
+#define USB_BULK_CS_WRAP_LEN    13
+#define USB_BULK_CS_SIG         0x53425355      /* Spells out 'USBS' */
+#define USB_STATUS_PASS         0
+#define USB_STATUS_FAIL         1
+#define USB_STATUS_PHASE_ERROR  2
+
+#define CSW_GOOD                0x00
+#define CSW_FAIL                0x01
+
+struct f_rockusb {
+	struct usb_function usb_function;
+	struct usb_ep *in_ep, *out_ep;
+	struct usb_request *in_req, *out_req;
+	char *rockusb_dev_type;
+	unsigned int rockusb_dev_index;
+	unsigned int download_tag;
+	unsigned int download_lba;
+	unsigned int download_size;
+	unsigned int download_bytes;
+	struct blk_desc *download_desc;
+	int reboot_flag;
+};
+
+/* init rockusb device, tell rockusb which device you want to read/write*/
+void rockusb_dev_init(char *dev_type, int dev_index);
+#endif /* _F_ROCKUSB_H_ */
+

drivers/usb/gadget/Kconfig +8 -0

index 261ed12..d61d9ad 100644
@@ -112,6 +112,14 @@ config G_DNL_VENDOR_NUM
 config G_DNL_PRODUCT_NUM
 	hex "Product ID of USB device"
 
+config USB_FUNCTION_ROCKUSB
+	bool "Enable USB rockusb gadget"
+	help
+	  Rockusb protocol is widely used by Rockchip SoC based devices. It can
+	  read/write info, image to/from devices. This enables the USB part of
+	  the rockusb gadget.for more detail about Rockusb protocol, please see
+	  doc/README.rockusb
+
 config USBNET_DEVADDR
 	string "USB Gadget Ethernet device mac address"
 	default "de:ad:be:ef:00:01"

drivers/usb/gadget/Makefile +1 -0

index 0fbbb7c..0eb27a3 100644
@@ -28,6 +28,7 @@ obj-$(CONFIG_USB_FUNCTION_THOR) += f_thor.o
 obj-$(CONFIG_USB_FUNCTION_DFU) += f_dfu.o
 obj-$(CONFIG_USB_FUNCTION_MASS_STORAGE) += f_mass_storage.o
 obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += f_fastboot.o
+obj-$(CONFIG_USB_FUNCTION_ROCKUSB) += f_rockusb.o
 endif
 endif
 ifdef CONFIG_USB_ETHER

drivers/usb/gadget/f_rockusb.c new file +691 -0

691 lines not on this page · raw message

Signature · 1 line

1.9.1

Eddie Cai

author

2017-05-25 08:50 UTC #2 lore raw

PATCH v7 2/4 usb: rockchip: add rockusb command

In reply to Eddie Cai

this patch add rockusb command. the usage is rockusb <USB_controller> <devtype> <dev[:part]> e.g. rockusb 0 mmc 0

Signed-off-by Eddie Cai <[email protected]>

Reviewed-by Simon Glass <[email protected]>

Changes in v7:
-none

Changes in v6:
-none

Changes in v5:
-none

Changes in v4:
-move USB_FUNCTION_ROCKUSB to drivers/usb/gadget/Kconfig -modify the dependence

Changes in v3:
-fix comment from Simon and Lukasz
-fix checkpactch error

---
 cmd/Kconfig   |  9 ++++++++
 cmd/Makefile  |  1 +
 cmd/rockusb.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 84 insertions(+)
 create mode 100644 cmd/rockusb.c

cmd/Kconfig +9 -0

index d9f7151..81e9bdf 100644
@@ -518,6 +518,15 @@ config CMD_DFU
 	  Enables the command "dfu" which is used to have U-Boot create a DFU
 	  class device via USB.
 
+config CMD_ROCKUSB
+	bool "rockusb"
+	depends on USB_FUNCTION_ROCKUSB
+	help
+          Rockusb protocol is widely used by Rockchip SoC based devices. It can
+	  read/write info, image to/from devices. This enable rockusb command
+	  support to comunication with rockusb device. for more detail about
+	  this command, please read doc/README.rockusb.
+
 config CMD_USB_MASS_STORAGE
 	bool "UMS usb mass storage"
 	help

cmd/Makefile +1 -0

index e987868..65d998d 100644
@@ -109,6 +109,7 @@ obj-$(CONFIG_CMD_READ) += read.o
 obj-$(CONFIG_CMD_REGINFO) += reginfo.o
 obj-$(CONFIG_CMD_REISER) += reiser.o
 obj-$(CONFIG_CMD_REMOTEPROC) += remoteproc.o
+obj-$(CONFIG_CMD_ROCKUSB) += rockusb.o
 obj-$(CONFIG_SANDBOX) += host.o
 obj-$(CONFIG_CMD_SATA) += sata.o
 obj-$(CONFIG_CMD_SF) += sf.o

cmd/rockusb.c new file +74 -0

74 lines not on this page · raw message

Signature · 1 line

1.9.1

Eddie Cai

author

2017-05-25 08:50 UTC #3 lore raw

PATCH v7 3/4 rockchip:usb: add a simple readme for rockusb

In reply to Eddie Cai

add a simple readme to introduce rockusb and tell people how to use it

Signed-off-by Eddie Cai <[email protected]>

Reviewed-by Simon Glass <[email protected]>

Changes in v7:
-none

Changes in v6:
-none

Changes in v5:
-none

Changes in v4:
-add some blank line to make it look better

Changes in v3:
-fix checkpatch error

---
 doc/README.rockusb | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 doc/README.rockusb

doc/README.rockusb new file +51 -0

new file mode 100644
index 0000000..5405dc4
@@ -0,0 +1,51 @@
+Rockusb (Rockchip USB protocol)
+=====================================================
+
+Overview
+--------
+
+Rockusb protocol is widely used by Rockchip SoC based devices. It can
+read/write info, image to/from devices. This document briefly describes how to
+use Rockusb for upgrading firmware (e.g. kernel, u-boot, rootfs, etc.).
+
+Tools
+--------
+There are many tools can support Rockusb protocol. rkdeveloptool
+(https://github.com/rockchip-linux/rkdeveloptool) is open source,
+It is maintained by Rockchip. People don't want to build from source
+can download from here
+(https://github.com/rockchip-linux/rkbin/blob/master/tools/rkdeveloptool)
+
+Usage
+--------
+The Usage of Rockusb command is:
+
+rockusb <USB_controller> <devtype> <dev[:part]>
+
+e.g. rockusb 0 mmc 0
+
+On your U-Boot console, type this command to enter rockusb mode.
+On your host PC. use lsusb command. you should see a usb device
+using 0x2207 as its USB verdor id.
+
+for more detail about the rkdeveloptool. please read the usage.
+
+rkdeveloptool -h
+
+use rkdeveloptool wl command to write lba. BeginSec is the lba on device
+you want to write.
+
+sudo rkdeveloptool wl  <BeginSec> <File>
+
+to flash U-Boot image use below command. U-Boot binary is made by mkimage.
+see doc/README.rockchip for more detail about how to get U-Boot binary.
+
+sudo rkdeveloptool wl  64 <U-Boot binary>
+
+There are plenty of Rockusb command. but wl(write lba) and
+rd(reboot) command. These two command can let people flash
+image to device.
+
+To do
+-----
+* Fully support Rockusb protocol

Signature · 1 line

1.9.1

Eddie Cai

author

2017-05-25 08:50 UTC #4 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

In reply to Eddie Cai

this patch enable rockusb support on rk3288 based device.

Signed-off-by Eddie Cai <[email protected]>

Reviewed-by Simon Glass <[email protected]>

Changes in v7:
-use imply in the Kconfig to enable rockusb

Changes in v6:
-enable rockusb in defconfig

Changes in v5:
-none

Changes in v4:
-move to rk3288_common.h

Changes in v3:
-move to defconfig

---
 arch/arm/mach-rockchip/Kconfig    | 2 ++
 configs/evb-rk3288_defconfig      | 9 +++++++++
 configs/fennec-rk3288_defconfig   | 6 ++++++
 configs/firefly-rk3288_defconfig  | 6 ++++++
 configs/miqi-rk3288_defconfig     | 6 ++++++
 configs/popmetal-rk3288_defconfig | 6 ++++++
 configs/tinker-rk3288_defconfig   | 6 ++++++
 include/configs/rk3288_common.h   | 7 -------
 8 files changed, 41 insertions(+), 7 deletions(-)

arch/arm/mach-rockchip/Kconfig +2 -0

index 2b752ad..8a87812 100644
@@ -32,6 +32,8 @@ config ROCKCHIP_RK3288
 	select CPU_V7
 	select SUPPORT_SPL
 	select SPL
+	imply USB_FUNCTION_ROCKUSB
+	imply CMD_ROCKUSB
 	help
 	  The Rockchip RK3288 is a ARM-based SoC with a quad-core Cortex-A17
 	  including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two

configs/evb-rk3288_defconfig +9 -0

index 227150d..cf66e09 100644
@@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
 CONFIG_CMD_GPIO=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y

@@ -61,6 +62,14 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/fennec-rk3288_defconfig +6 -0

index befba18..eb33d00 100644
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/firefly-rk3288_defconfig +6 -0

index f2872a6..1f4ca32 100644
@@ -73,3 +73,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/miqi-rk3288_defconfig +6 -0

index d93bd97..b8b6fd5 100644
@@ -70,3 +70,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/popmetal-rk3288_defconfig +6 -0

index 748cda4..1181a20 100644
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

configs/tinker-rk3288_defconfig +6 -0

index ada5950..f863df8 100644
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

include/configs/rk3288_common.h +0 -7

index e7a8f72..421ba60 100644
@@ -58,11 +58,9 @@
 
 #ifndef CONFIG_SPL_BUILD
 /* usb otg */
-#define CONFIG_USB_GADGET
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_DWC2_OTG
 #define CONFIG_ROCKCHIP_USB2_PHY
-#define CONFIG_USB_GADGET_VBUS_DRAW	0
 
 /* fastboot  */
 #define CONFIG_CMD_FASTBOOT

@@ -76,11 +74,6 @@
 #define CONFIG_USB_FUNCTION_MASS_STORAGE
 #define CONFIG_CMD_USB_MASS_STORAGE
 
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER	"Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM		0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM	0x320a
-
 /* usb host support */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_USB_DWC2

Signature · 1 line

1.9.1

Lukasz Majewski

2017-05-29 07:51 UTC #5 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

Good morning Eddie,

Quoted 5 lines

this patch enable rockusb support on rk3288 based device.
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>

I've give this patch set a try on travisCI:

https://travis-ci.org/lmajewski/u-boot-dfu/jobs/237068149

Unfortunately, there are some problem with following boards:

chromebook_jerry, chromebook_minnie ...

caused by "undefined references to ...."

I've tried your patches on top of:
u-boot-usb/HEAD
SHA1: 3426b2038cfb831d74ac0407fc7a04e990b44540

Maybe you have built tested it on other branch/commit?

Best regards,
Łukasz Majewski

p.s. My travis CI .travis.yml attached.

Quoted 154 lines

Changes in v7:
-use imply in the Kconfig to enable rockusb

Changes in v6:
-enable rockusb in defconfig

Changes in v5:
-none

Changes in v4:
-move to rk3288_common.h

Changes in v3:

(quoted diff) +0 -2

-move to defconfig
 
---
 arch/arm/mach-rockchip/Kconfig    | 2 ++
 configs/evb-rk3288_defconfig      | 9 +++++++++
 configs/fennec-rk3288_defconfig   | 6 ++++++
 configs/firefly-rk3288_defconfig  | 6 ++++++
 configs/miqi-rk3288_defconfig     | 6 ++++++
 configs/popmetal-rk3288_defconfig | 6 ++++++
 configs/tinker-rk3288_defconfig   | 6 ++++++
 include/configs/rk3288_common.h   | 7 -------
 8 files changed, 41 insertions(+), 7 deletions(-)

(quoted diff) +0 -0

b/arch/arm/mach-rockchip/Kconfig index 2b752ad..8a87812 100644

arch/arm/mach-rockchip/Kconfig +2 -0

@@ -32,6 +32,8 @@ config ROCKCHIP_RK3288
 	select CPU_V7
 	select SUPPORT_SPL
 	select SPL
+	imply USB_FUNCTION_ROCKUSB
+	imply CMD_ROCKUSB
 	help
 	  The Rockchip RK3288 is a ARM-based SoC with a quad-core

Cortex-A17 including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two

(quoted diff) +0 -0

b/configs/evb-rk3288_defconfig index 227150d..cf66e09 100644

configs/evb-rk3288_defconfig +9 -0

@@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
 CONFIG_CMD_GPIO=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y

@@ -61,6 +62,14 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/configs/fennec-rk3288_defconfig index befba18..eb33d00 100644

configs/fennec-rk3288_defconfig +6 -0

@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/configs/firefly-rk3288_defconfig index f2872a6..1f4ca32 100644

configs/firefly-rk3288_defconfig +6 -0

@@ -73,3 +73,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/configs/miqi-rk3288_defconfig index d93bd97..b8b6fd5 100644

configs/miqi-rk3288_defconfig +6 -0

@@ -70,3 +70,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/configs/popmetal-rk3288_defconfig index 748cda4..1181a20 100644

configs/popmetal-rk3288_defconfig +6 -0

@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/configs/tinker-rk3288_defconfig index ada5950..f863df8 100644

configs/tinker-rk3288_defconfig +6 -0

@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/include/configs/rk3288_common.h index e7a8f72..421ba60 100644

include/configs/rk3288_common.h +0 -2

@@ -58,11 +58,9 @@
 
 #ifndef CONFIG_SPL_BUILD
 /* usb otg */
-#define CONFIG_USB_GADGET
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_DWC2_OTG
 #define CONFIG_ROCKCHIP_USB2_PHY
-#define CONFIG_USB_GADGET_VBUS_DRAW	0
 
 /* fastboot  */
 #define CONFIG_CMD_FASTBOOT

@@ -76,11 +74,6 @@
 #define CONFIG_USB_FUNCTION_MASS_STORAGE

include/configs/rk3288_common.h line 79

Quoted 10 lines

include/configs/rk3288_common.h +0 -5

 #define CONFIG_CMD_USB_MASS_STORAGE
 
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER	"Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM		0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM	0x320a
-
 /* usb host support */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_USB_DWC2

Best regards,

Lukasz Majewski

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: dot_travis.yml
Type: application/x-yaml
Size: 2938 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170529/dc7ee0e3/attachment.bin>

Eddie Cai

author

2017-05-31 02:27 UTC #6 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

Hi Lukasz

2017-05-29 15:51 GMT+08:00 Lukasz Majewski <[email protected]>:

Quoted 8 lines

Good morning Eddie,
Quoted 5 lines
this patch enable rockusb support on rk3288 based device.
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>

Quoted 7 lines

I've give this patch set a try on travisCI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/237068149
Unfortunately, there are some problem with following boards:
chromebook_jerry, chromebook_minnie ...

I did it by myself last week. i got the same error. then i fix those chromebook error
and test again. I still got some 3036 board error. But it build successfully when i
build it on my computer. here is the travis-ci.org error log
https://travis-ci.org/eddiecailinux/u-boot/jobs/236232837
I have no idea what can i do to fix it.

Quoted 191 lines

caused by "undefined references to ...."
I've tried your patches on top of:
u-boot-usb/HEAD
SHA1: 3426b2038cfb831d74ac0407fc7a04e990b44540
Maybe you have built tested it on other branch/commit?
Best regards,
Łukasz Majewski
p.s. My travis CI .travis.yml attached.
Quoted 154 lines
Changes in v7:
-use imply in the Kconfig to enable rockusb
Changes in v6:
-enable rockusb in defconfig
Changes in v5:
-none
Changes in v4:
-move to rk3288_common.h
Changes in v3:
(quoted diff) +0 -2
-move to defconfig
 
---
 arch/arm/mach-rockchip/Kconfig    | 2 ++
 configs/evb-rk3288_defconfig      | 9 +++++++++
 configs/fennec-rk3288_defconfig   | 6 ++++++
 configs/firefly-rk3288_defconfig  | 6 ++++++
 configs/miqi-rk3288_defconfig     | 6 ++++++
 configs/popmetal-rk3288_defconfig | 6 ++++++
 configs/tinker-rk3288_defconfig   | 6 ++++++
 include/configs/rk3288_common.h   | 7 -------
 8 files changed, 41 insertions(+), 7 deletions(-)
(quoted diff) +0 -0
b/arch/arm/mach-rockchip/Kconfig index 2b752ad..8a87812 100644
arch/arm/mach-rockchip/Kconfig +2 -0
@@ -32,6 +32,8 @@ config ROCKCHIP_RK3288
      select CPU_V7
      select SUPPORT_SPL
      select SPL
+     imply USB_FUNCTION_ROCKUSB
+     imply CMD_ROCKUSB
      help
        The Rockchip RK3288 is a ARM-based SoC with a quad-core
Cortex-A17 including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two
(quoted diff) +0 -0
b/configs/evb-rk3288_defconfig index 227150d..cf66e09 100644
configs/evb-rk3288_defconfig +9 -0
@@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
 CONFIG_CMD_GPIO=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
@@ -61,6 +62,14 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/fennec-rk3288_defconfig index befba18..eb33d00 100644
configs/fennec-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/firefly-rk3288_defconfig index f2872a6..1f4ca32 100644
configs/firefly-rk3288_defconfig +6 -0
@@ -73,3 +73,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/miqi-rk3288_defconfig index d93bd97..b8b6fd5 100644
configs/miqi-rk3288_defconfig +6 -0
@@ -70,3 +70,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/popmetal-rk3288_defconfig index 748cda4..1181a20 100644
configs/popmetal-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/tinker-rk3288_defconfig index ada5950..f863df8 100644
configs/tinker-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/include/configs/rk3288_common.h index e7a8f72..421ba60 100644
include/configs/rk3288_common.h +0 -2
@@ -58,11 +58,9 @@
 
 #ifndef CONFIG_SPL_BUILD
 /* usb otg */
-#define CONFIG_USB_GADGET
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_DWC2_OTG
 #define CONFIG_ROCKCHIP_USB2_PHY
-#define CONFIG_USB_GADGET_VBUS_DRAW  0
 
 /* fastboot  */
 #define CONFIG_CMD_FASTBOOT
@@ -76,11 +74,6 @@
 #define CONFIG_USB_FUNCTION_MASS_STORAGE
include/configs/rk3288_common.h line 79
Quoted 10 lines
include/configs/rk3288_common.h +0 -5
 #define CONFIG_CMD_USB_MASS_STORAGE
 
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER    "Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM              0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM     0x320a
-
 /* usb host support */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_USB_DWC2
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

Tom Rini

2017-05-31 02:30 UTC #7 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

Quoted 17 lines · Eddie Cai

Hi Lukasz
2017-05-29 15:51 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 14 lines
Good morning Eddie,
Quoted 5 lines
this patch enable rockusb support on rk3288 based device.
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>
I've give this patch set a try on travisCI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/237068149
Unfortunately, there are some problem with following boards:

Quoted 8 lines

Quoted 1 line
chromebook_jerry, chromebook_minnie ...
I did it by myself last week. i got the same error. then i fix those chromebook error
and test again. I still got some 3036 board error. But it build successfully when i
build it on my computer. here is the travis-ci.org error log
https://travis-ci.org/eddiecailinux/u-boot/jobs/236232837
I have no idea what can i do to fix it.

You can try using the same toolchain, from .travis.yml:

       wget http://releases.linaro.org/components/toolchain/binaries/6.3-2017.02/aarch64-linux-gnu/gcc-linaro-6.3.1-2017.02-x86_64_aarch64-linux-gnu.tar.xz &&
       wget http://releases.linaro.org/components/toolchain/binaries/6.3-2017.02/arm-linux-gnueabihf/gcc-linaro-6.3.1-2017.02-x86_64_arm-linux-gnueabihf.tar.xz &&
       tar -C /tmp -xf gcc-linaro-6.3.1-2017.02-x86_64_aarch64-linux-gnu.tar.xz &&
       tar -C /tmp -xf gcc-linaro-6.3.1-2017.02-x86_64_arm-linux-gnueabihf.tar.xz;

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170530/6d11ce5a/attachment.sig>

Lukasz Majewski

2017-05-31 07:12 UTC #8 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

In reply to Eddie Cai

Quoted 17 lines · On Wed, 31 May 2017 10:27:23 +0800 Eddie Cai <[email protected]> wrote:

Hi Lukasz
2017-05-29 15:51 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 14 lines
Good morning Eddie,
Quoted 5 lines
this patch enable rockusb support on rk3288 based device.
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>
I've give this patch set a try on travisCI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/237068149
Unfortunately, there are some problem with following boards:

Quoted 8 lines

Quoted 1 line
chromebook_jerry, chromebook_minnie ...
I did it by myself last week. i got the same error. then i fix those chromebook error
and test again. I still got some 3036 board error. But it build successfully when i
build it on my computer. here is the travis-ci.org error log
https://travis-ci.org/eddiecailinux/u-boot/jobs/236232837
I have no idea what can i do to fix it.

Can you share the SHA1 of commit on top of which you applied your patches?

I take u-boot-usb (the USB u-boot tree from Marek Vasut) as a base and then apply commits on top of it.

Quoted 184 lines

caused by "undefined references to ...."

I've tried your patches on top of:
u-boot-usb/HEAD
SHA1: 3426b2038cfb831d74ac0407fc7a04e990b44540

Maybe you have built tested it on other branch/commit?

Best regards,
Łukasz Majewski

p.s. My travis CI .travis.yml attached.

Quoted 154 lines

Changes in v7:
-use imply in the Kconfig to enable rockusb

Changes in v6:
-enable rockusb in defconfig

Changes in v5:
-none

Changes in v4:
-move to rk3288_common.h

Changes in v3:

(quoted diff) +0 -2

-move to defconfig
 
---
 arch/arm/mach-rockchip/Kconfig    | 2 ++
 configs/evb-rk3288_defconfig      | 9 +++++++++
 configs/fennec-rk3288_defconfig   | 6 ++++++
 configs/firefly-rk3288_defconfig  | 6 ++++++
 configs/miqi-rk3288_defconfig     | 6 ++++++
 configs/popmetal-rk3288_defconfig | 6 ++++++
 configs/tinker-rk3288_defconfig   | 6 ++++++
 include/configs/rk3288_common.h   | 7 -------
 8 files changed, 41 insertions(+), 7 deletions(-)

(quoted diff) +0 -0

b/arch/arm/mach-rockchip/Kconfig index 2b752ad..8a87812 100644

arch/arm/mach-rockchip/Kconfig +2 -0

@@ -32,6 +32,8 @@ config ROCKCHIP_RK3288
      select CPU_V7
      select SUPPORT_SPL
      select SPL
+     imply USB_FUNCTION_ROCKUSB
+     imply CMD_ROCKUSB
      help
        The Rockchip RK3288 is a ARM-based SoC with a quad-core
 Cortex-A17 including NEON and GPU, 1MB L2 cache, Mali-T7 graphics,

two diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig index 227150d..cf66e09 100644

configs/evb-rk3288_defconfig +9 -0

@@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
 CONFIG_CMD_GPIO=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y

@@ -61,6 +62,14 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/configs/fennec-rk3288_defconfig index befba18..eb33d00 100644

configs/fennec-rk3288_defconfig +6 -0

@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/configs/firefly-rk3288_defconfig index f2872a6..1f4ca32 100644

configs/firefly-rk3288_defconfig +6 -0

@@ -73,3 +73,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/configs/miqi-rk3288_defconfig index d93bd97..b8b6fd5 100644

configs/miqi-rk3288_defconfig +6 -0

@@ -70,3 +70,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/configs/popmetal-rk3288_defconfig index 748cda4..1181a20 100644

configs/popmetal-rk3288_defconfig +6 -0

@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/configs/tinker-rk3288_defconfig index ada5950..f863df8 100644

configs/tinker-rk3288_defconfig +6 -0

@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a

(quoted diff) +0 -0

b/include/configs/rk3288_common.h index e7a8f72..421ba60 100644

include/configs/rk3288_common.h +0 -2

@@ -58,11 +58,9 @@
 
 #ifndef CONFIG_SPL_BUILD
 /* usb otg */
-#define CONFIG_USB_GADGET
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_DWC2_OTG
 #define CONFIG_ROCKCHIP_USB2_PHY
-#define CONFIG_USB_GADGET_VBUS_DRAW  0
 
 /* fastboot  */
 #define CONFIG_CMD_FASTBOOT

@@ -76,11 +74,6 @@
 #define CONFIG_USB_FUNCTION_MASS_STORAGE

include/configs/rk3288_common.h line 79

Quoted 10 lines

include/configs/rk3288_common.h +0 -5

 #define CONFIG_CMD_USB_MASS_STORAGE
 
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER    "Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM              0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM     0x320a
-
 /* usb host support */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_USB_DWC2

Best regards,

Quoted 8 lines

Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de

Best regards,

Lukasz Majewski

Eddie Cai

author

2017-05-31 08:02 UTC #9 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

2017-05-31 15:12 GMT+08:00 Lukasz Majewski <[email protected]>:

Quoted 29 lines

Quoted 17 lines · On Wed, 31 May 2017 10:27:23 +0800 Eddie Cai <[email protected]> wrote:
Hi Lukasz
2017-05-29 15:51 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 14 lines
Good morning Eddie,
Quoted 5 lines
this patch enable rockusb support on rk3288 based device.
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>
I've give this patch set a try on travisCI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/237068149
Unfortunately, there are some problem with following boards:
Quoted 8 lines
Quoted 1 line
chromebook_jerry, chromebook_minnie ...
I did it by myself last week. i got the same error. then i fix those chromebook error
and test again. I still got some 3036 board error. But it build successfully when i
build it on my computer. here is the travis-ci.org error log
https://travis-ci.org/eddiecailinux/u-boot/jobs/236232837
I have no idea what can i do to fix it.

Quoted 5 lines

Can you share the SHA1 of commit on top of which you applied your patches?
I take u-boot-usb (the USB u-boot tree from Marek Vasut) as a base and then apply commits on top of it.

here is my branch https://github.com/eddiecailinux/u-boot/tree/rockusb-v8
I apply my patch on top of below commit
commit a63d800196ebee59b0f8ff924f67843cd597a8c1

Author: Tom Rini <[email protected]>
Date:   Mon May 1 19:54:41 2017 -0400

Prepare v2017.05-rc3

Signed-off-by Tom Rini <[email protected]>

Quoted 206 lines

Quoted 185 lines
Quoted 185 lines
caused by "undefined references to ...."
I've tried your patches on top of:
u-boot-usb/HEAD
SHA1: 3426b2038cfb831d74ac0407fc7a04e990b44540
Maybe you have built tested it on other branch/commit?
Best regards,
Łukasz Majewski
p.s. My travis CI .travis.yml attached.
Quoted 154 lines
Changes in v7:
-use imply in the Kconfig to enable rockusb
Changes in v6:
-enable rockusb in defconfig
Changes in v5:
-none
Changes in v4:
-move to rk3288_common.h
Changes in v3:
(quoted diff) +0 -2
-move to defconfig
 
---
 arch/arm/mach-rockchip/Kconfig    | 2 ++
 configs/evb-rk3288_defconfig      | 9 +++++++++
 configs/fennec-rk3288_defconfig   | 6 ++++++
 configs/firefly-rk3288_defconfig  | 6 ++++++
 configs/miqi-rk3288_defconfig     | 6 ++++++
 configs/popmetal-rk3288_defconfig | 6 ++++++
 configs/tinker-rk3288_defconfig   | 6 ++++++
 include/configs/rk3288_common.h   | 7 -------
 8 files changed, 41 insertions(+), 7 deletions(-)
(quoted diff) +0 -0
b/arch/arm/mach-rockchip/Kconfig index 2b752ad..8a87812 100644
arch/arm/mach-rockchip/Kconfig +2 -0
@@ -32,6 +32,8 @@ config ROCKCHIP_RK3288
      select CPU_V7
      select SUPPORT_SPL
      select SPL
+     imply USB_FUNCTION_ROCKUSB
+     imply CMD_ROCKUSB
      help
        The Rockchip RK3288 is a ARM-based SoC with a quad-core
 Cortex-A17 including NEON and GPU, 1MB L2 cache, Mali-T7 graphics,
two diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig index 227150d..cf66e09 100644
configs/evb-rk3288_defconfig +9 -0
@@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
 CONFIG_CMD_GPIO=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
@@ -61,6 +62,14 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/fennec-rk3288_defconfig index befba18..eb33d00 100644
configs/fennec-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/firefly-rk3288_defconfig index f2872a6..1f4ca32 100644
configs/firefly-rk3288_defconfig +6 -0
@@ -73,3 +73,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/miqi-rk3288_defconfig index d93bd97..b8b6fd5 100644
configs/miqi-rk3288_defconfig +6 -0
@@ -70,3 +70,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/popmetal-rk3288_defconfig index 748cda4..1181a20 100644
configs/popmetal-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/tinker-rk3288_defconfig index ada5950..f863df8 100644
configs/tinker-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/include/configs/rk3288_common.h index e7a8f72..421ba60 100644
include/configs/rk3288_common.h +0 -2
@@ -58,11 +58,9 @@
 
 #ifndef CONFIG_SPL_BUILD
 /* usb otg */
-#define CONFIG_USB_GADGET
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_DWC2_OTG
 #define CONFIG_ROCKCHIP_USB2_PHY
-#define CONFIG_USB_GADGET_VBUS_DRAW  0
 
 /* fastboot  */
 #define CONFIG_CMD_FASTBOOT
@@ -76,11 +74,6 @@
 #define CONFIG_USB_FUNCTION_MASS_STORAGE
include/configs/rk3288_common.h line 79
Quoted 10 lines
include/configs/rk3288_common.h +0 -5
 #define CONFIG_CMD_USB_MASS_STORAGE
 
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER    "Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM              0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM     0x320a
-
 /* usb host support */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_USB_DWC2
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

Lukasz Majewski

2017-05-31 08:18 UTC #10 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

Quoted 41 lines · On Wed, 31 May 2017 16:02:27 +0800 Eddie Cai <[email protected]> wrote:

2017-05-31 15:12 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 29 lines
Quoted 17 lines · On Wed, 31 May 2017 10:27:23 +0800 Eddie Cai <[email protected]> wrote:
Hi Lukasz
2017-05-29 15:51 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 14 lines
Good morning Eddie,
Quoted 5 lines
this patch enable rockusb support on rk3288 based device.
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>
I've give this patch set a try on travisCI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/237068149
Unfortunately, there are some problem with following boards:
Quoted 8 lines
Quoted 1 line
chromebook_jerry, chromebook_minnie ...
I did it by myself last week. i got the same error. then i fix those chromebook error
and test again. I still got some 3036 board error. But it build successfully when i
build it on my computer. here is the travis-ci.org error log
https://travis-ci.org/eddiecailinux/u-boot/jobs/236232837
I have no idea what can i do to fix it.
Quoted 5 lines
Can you share the SHA1 of commit on top of which you applied your patches?
I take u-boot-usb (the USB u-boot tree from Marek Vasut) as a base and then apply commits on top of it.
here is my branch
https://github.com/eddiecailinux/u-boot/tree/rockusb-v8 I apply my patch on top of below commit commit a63d800196ebee59b0f8ff924f67843cd597a8c1 Author: Tom Rini
<[email protected]> Date: Mon May 1 19:54:41 2017 -0400

Quoted 3 lines

Prepare v2017.05-rc3
Signed-off-by Tom Rini <[email protected]>

Ok. Thanks for the info.

The u-boot-usb seems to be a bit older.

Anyway, have you tried with compiling your code with toolchains suggested by Tom?

Best regards,
Łukasz Majewski

Quoted 199 lines

Quoted 199 lines
Quoted 185 lines
Quoted 185 lines
caused by "undefined references to ...."
I've tried your patches on top of:
u-boot-usb/HEAD
SHA1: 3426b2038cfb831d74ac0407fc7a04e990b44540
Maybe you have built tested it on other branch/commit?
Best regards,
Łukasz Majewski
p.s. My travis CI .travis.yml attached.
Quoted 154 lines
Changes in v7:
-use imply in the Kconfig to enable rockusb
Changes in v6:
-enable rockusb in defconfig
Changes in v5:
-none
Changes in v4:
-move to rk3288_common.h
Changes in v3:
(quoted diff) +0 -2
-move to defconfig
 
---
 arch/arm/mach-rockchip/Kconfig    | 2 ++
 configs/evb-rk3288_defconfig      | 9 +++++++++
 configs/fennec-rk3288_defconfig   | 6 ++++++
 configs/firefly-rk3288_defconfig  | 6 ++++++
 configs/miqi-rk3288_defconfig     | 6 ++++++
 configs/popmetal-rk3288_defconfig | 6 ++++++
 configs/tinker-rk3288_defconfig   | 6 ++++++
 include/configs/rk3288_common.h   | 7 -------
 8 files changed, 41 insertions(+), 7 deletions(-)
(quoted diff) +0 -0
b/arch/arm/mach-rockchip/Kconfig index 2b752ad..8a87812 100644
arch/arm/mach-rockchip/Kconfig +2 -0
@@ -32,6 +32,8 @@ config ROCKCHIP_RK3288
      select CPU_V7
      select SUPPORT_SPL
      select SPL
+     imply USB_FUNCTION_ROCKUSB
+     imply CMD_ROCKUSB
      help
        The Rockchip RK3288 is a ARM-based SoC with a quad-core
Cortex-A17 including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig index 227150d..cf66e09 100644
configs/evb-rk3288_defconfig +9 -0
@@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
 CONFIG_CMD_GPIO=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
@@ -61,6 +62,14 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/fennec-rk3288_defconfig index befba18..eb33d00 100644
configs/fennec-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/firefly-rk3288_defconfig index f2872a6..1f4ca32 100644
configs/firefly-rk3288_defconfig +6 -0
@@ -73,3 +73,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/miqi-rk3288_defconfig index d93bd97..b8b6fd5 100644
configs/miqi-rk3288_defconfig +6 -0
@@ -70,3 +70,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/popmetal-rk3288_defconfig index 748cda4..1181a20 100644 --- a/configs/popmetal-rk3288_defconfig +++ b/configs/popmetal-rk3288_defconfig
configs/evb-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/tinker-rk3288_defconfig index ada5950..f863df8 100644
configs/tinker-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/include/configs/rk3288_common.h index e7a8f72..421ba60 100644
include/configs/rk3288_common.h +0 -2
@@ -58,11 +58,9 @@
 
 #ifndef CONFIG_SPL_BUILD
 /* usb otg */
-#define CONFIG_USB_GADGET
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_DWC2_OTG
 #define CONFIG_ROCKCHIP_USB2_PHY
-#define CONFIG_USB_GADGET_VBUS_DRAW  0
 
 /* fastboot  */
 #define CONFIG_CMD_FASTBOOT
@@ -76,11 +74,6 @@
 #define CONFIG_USB_FUNCTION_MASS_STORAGE
include/configs/rk3288_common.h line 79
Quoted 10 lines
include/configs/rk3288_common.h +0 -5
 #define CONFIG_CMD_USB_MASS_STORAGE
 
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER    "Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM              0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM     0x320a
-
 /* usb host support */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_USB_DWC2
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax:
(+49)-8142-66989-80 Email: wd at denx.de
Best regards,

Quoted 8 lines

Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de

Best regards,

Lukasz Majewski

2017-05-31 08:22 UTC #11 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

Hi Eddie,

Quoted 7 lines

Quoted 3 lines
Prepare v2017.05-rc3
Signed-off-by Tom Rini <[email protected]>
Ok. Thanks for the info.
The u-boot-usb seems to be a bit older.

				   ^^^^^^ sorry newer :-)

"usb: ehci: Add Renesas RCar M3/H3 EHCI support"
3426b2038cfb831d74ac0407fc7a04e990b44540

Quoted 8 lines

Anyway, have you tried with compiling your code with toolchains suggested by Tom?
Best regards,
Å�ukasz Majewski
Quoted 1 line
Quoted 1 line

Best regards,

Lukasz Majewski

Eddie Cai

author

2017-05-31 08:41 UTC #12 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

2017-05-31 16:22 GMT+08:00 Lukasz Majewski <[email protected]>:

Quoted 6 lines

Hi Eddie,
Quoted 4 lines
Quoted 3 lines
Prepare v2017.05-rc3
Signed-off-by Tom Rini <[email protected]>

Quoted 11 lines

Quoted 3 lines
Ok. Thanks for the info.
The u-boot-usb seems to be a bit older.
                                   ^^^^^^ sorry newer :-)
"usb: ehci: Add Renesas RCar M3/H3 EHCI support"
3426b2038cfb831d74ac0407fc7a04e990b44540
Quoted 3 lines
Anyway, have you tried with compiling your code with toolchains suggested by Tom?

Yes. I tried to build with this toolchain on my computer. It build successfully, but i got below warning.

CC spl/arch/arm/mach-rockchip/rk3036-board-spl.o
arch/arm/mach-rockchip/rk3036-board-spl.c:20:34: warning: ‘grf’ defined but not used [-Wunused-const-variable=]
static struct rk3036_grf * const grf = (void *)GRF_BASE;

I don't think it relate to my patches. so i checkout below commit and build with the same toolchain again. i got the same warning. commit a63d800196ebee59b0f8ff924f67843cd597a8c1

Author: Tom Rini <[email protected]>
Date:   Mon May 1 19:54:41 2017 -0400

Prepare v2017.05-rc3

Signed-off-by Tom Rini <[email protected]>

Quoted 17 lines

Quoted 5 lines
Best regards,
Łukasz Majewski
Quoted 1 line
Quoted 1 line
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

Eddie Cai

author

2017-05-31 08:43 UTC #13 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

2017-05-31 16:41 GMT+08:00 Eddie Cai <[email protected]>:

Quoted 29 lines

2017-05-31 16:22 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 6 lines
Hi Eddie,
Quoted 4 lines
Quoted 3 lines
Prepare v2017.05-rc3
Signed-off-by Tom Rini <[email protected]>
Quoted 11 lines
Quoted 3 lines
Ok. Thanks for the info.
The u-boot-usb seems to be a bit older.
                                   ^^^^^^ sorry newer :-)
"usb: ehci: Add Renesas RCar M3/H3 EHCI support"
3426b2038cfb831d74ac0407fc7a04e990b44540
Quoted 3 lines
Anyway, have you tried with compiling your code with toolchains suggested by Tom?
Yes. I tried to build with this toolchain on my computer. It build successfully, but i got below warning.
CC spl/arch/arm/mach-rockchip/rk3036-board-spl.o
arch/arm/mach-rockchip/rk3036-board-spl.c:20:34: warning: ‘grf’ defined but not used [-Wunused-const-variable=]
static struct rk3036_grf * const grf = (void *)GRF_BASE;
I don't think it relate to my patches. so i checkout below commit and build with the same toolchain again. i got the same warning. commit a63d800196ebee59b0f8ff924f67843cd597a8c1

Quoted 6 lines

Author: Tom Rini <[email protected]>
Date:   Mon May 1 19:54:41 2017 -0400
Prepare v2017.05-rc3
Signed-off-by Tom Rini <[email protected]>

Anyway, This warning is not the same error travis-ci report.

Quoted 17 lines

Quoted 17 lines
Quoted 5 lines
Best regards,
Łukasz Majewski
Quoted 1 line
Quoted 1 line
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

Lukasz Majewski

2017-06-03 14:23 UTC #14 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

In reply to Eddie Cai

Hi Eddie,

Quoted 41 lines

2017-05-31 15:12 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 29 lines
Quoted 17 lines · On Wed, 31 May 2017 10:27:23 +0800 Eddie Cai <[email protected]> wrote:
Hi Lukasz
2017-05-29 15:51 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 14 lines
Good morning Eddie,
Quoted 5 lines
this patch enable rockusb support on rk3288 based device.
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>
I've give this patch set a try on travisCI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/237068149
Unfortunately, there are some problem with following boards:
Quoted 8 lines
Quoted 1 line
chromebook_jerry, chromebook_minnie ...
I did it by myself last week. i got the same error. then i fix those chromebook error
and test again. I still got some 3036 board error. But it build successfully when i
build it on my computer. here is the travis-ci.org error log
https://travis-ci.org/eddiecailinux/u-boot/jobs/236232837
I have no idea what can i do to fix it.
Quoted 5 lines
Can you share the SHA1 of commit on top of which you applied your patches?
I take u-boot-usb (the USB u-boot tree from Marek Vasut) as a base and then apply commits on top of it.
here is my branch
https://github.com/eddiecailinux/u-boot/tree/rockusb-v8 I apply my patch on top of below commit commit a63d800196ebee59b0f8ff924f67843cd597a8c1 Author: Tom Rini
<[email protected]> Date: Mon May 1 19:54:41 2017 -0400

Quoted 3 lines

Prepare v2017.05-rc3
Signed-off-by Tom Rini <[email protected]>

I've looked thoroughly at your patches:

Your patches has been applied on top of the above commit:
SHA1: a63d800196ebee59b0f8ff924f67843cd597a8c1

Before applying your patches:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/239069544

After applying them:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/239074799

To be more precise:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/239074800

For example:

arm: + rock2
+cmd/built-in.o: In function `do_fastboot':
+cmd/fastboot.c:28: undefined reference to board_usb_init' +cmd/fastboot.c:34: undefined reference to g_dnl_clear_detach' +cmd/fastboot.c:35: undefined reference to `g_dnl_register' +cmd/fastboot.c:39: undefined reference to
g_dnl_board_usb_cable_connected' +cmd/fastboot.c:57: undefined reference to g_dnl_unregister' +cmd/fastboot.c:58: undefined reference to g_dnl_clear_detach' +cmd/fastboot.c:59: undefined reference to board_usb_cleanup' +cmd/fastboot.c:47: undefined reference to g_dnl_detach' +cmd/fastboot.c:51: undefined reference to usb_gadget_handle_interrupts' +cmd/built-in.o: In function `do_usb_mass_storage':

For me it seems like you have enabled fastboot support on too many rochchip's boards.

Can you look on it?

I've also updated my .travis.ml file to be in sync with mainline, so we will use recommended arm toolchain.

Please find this file attached.

If there are any other patches required before applying this patch series, please let me know (or better post them to ML).

Best regards,
Łukasz Majewski

Quoted 199 lines

Quoted 199 lines
Quoted 185 lines
Quoted 185 lines
caused by "undefined references to ...."
I've tried your patches on top of:
u-boot-usb/HEAD
SHA1: 3426b2038cfb831d74ac0407fc7a04e990b44540
Maybe you have built tested it on other branch/commit?
Best regards,
Łukasz Majewski
p.s. My travis CI .travis.yml attached.
Quoted 154 lines
Changes in v7:
-use imply in the Kconfig to enable rockusb
Changes in v6:
-enable rockusb in defconfig
Changes in v5:
-none
Changes in v4:
-move to rk3288_common.h
Changes in v3:
(quoted diff) +0 -2
-move to defconfig
 
---
 arch/arm/mach-rockchip/Kconfig    | 2 ++
 configs/evb-rk3288_defconfig      | 9 +++++++++
 configs/fennec-rk3288_defconfig   | 6 ++++++
 configs/firefly-rk3288_defconfig  | 6 ++++++
 configs/miqi-rk3288_defconfig     | 6 ++++++
 configs/popmetal-rk3288_defconfig | 6 ++++++
 configs/tinker-rk3288_defconfig   | 6 ++++++
 include/configs/rk3288_common.h   | 7 -------
 8 files changed, 41 insertions(+), 7 deletions(-)
(quoted diff) +0 -0
b/arch/arm/mach-rockchip/Kconfig index 2b752ad..8a87812 100644
arch/arm/mach-rockchip/Kconfig +2 -0
@@ -32,6 +32,8 @@ config ROCKCHIP_RK3288
      select CPU_V7
      select SUPPORT_SPL
      select SPL
+     imply USB_FUNCTION_ROCKUSB
+     imply CMD_ROCKUSB
      help
        The Rockchip RK3288 is a ARM-based SoC with a quad-core
Cortex-A17 including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig index 227150d..cf66e09 100644
configs/evb-rk3288_defconfig +9 -0
@@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
 CONFIG_CMD_GPIO=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
@@ -61,6 +62,14 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/fennec-rk3288_defconfig index befba18..eb33d00 100644
configs/fennec-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/firefly-rk3288_defconfig index f2872a6..1f4ca32 100644
configs/firefly-rk3288_defconfig +6 -0
@@ -73,3 +73,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/miqi-rk3288_defconfig index d93bd97..b8b6fd5 100644
configs/miqi-rk3288_defconfig +6 -0
@@ -70,3 +70,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/popmetal-rk3288_defconfig index 748cda4..1181a20 100644 --- a/configs/popmetal-rk3288_defconfig +++ b/configs/popmetal-rk3288_defconfig
configs/evb-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/tinker-rk3288_defconfig index ada5950..f863df8 100644
configs/tinker-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/include/configs/rk3288_common.h index e7a8f72..421ba60 100644
include/configs/rk3288_common.h +0 -2
@@ -58,11 +58,9 @@
 
 #ifndef CONFIG_SPL_BUILD
 /* usb otg */
-#define CONFIG_USB_GADGET
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_DWC2_OTG
 #define CONFIG_ROCKCHIP_USB2_PHY
-#define CONFIG_USB_GADGET_VBUS_DRAW  0
 
 /* fastboot  */
 #define CONFIG_CMD_FASTBOOT
@@ -76,11 +74,6 @@
 #define CONFIG_USB_FUNCTION_MASS_STORAGE
include/configs/rk3288_common.h line 79
Quoted 10 lines
include/configs/rk3288_common.h +0 -5
 #define CONFIG_CMD_USB_MASS_STORAGE
 
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER    "Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM              0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM     0x320a
-
 /* usb host support */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_USB_DWC2
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax:
(+49)-8142-66989-80 Email: wd at denx.de
Best regards,

Quoted 8 lines

Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de

Best regards,

Lukasz Majewski

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: dot_travis.yml
Type: application/x-yaml
Size: 5478 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170603/14b0dbde/attachment.bin>

Lukasz Majewski

2017-06-21 07:44 UTC #15 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

Hi Eddie,

Quoted 80 lines

Hi Eddie,
Quoted 41 lines
2017-05-31 15:12 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 29 lines
Quoted 17 lines · On Wed, 31 May 2017 10:27:23 +0800 Eddie Cai <[email protected]> wrote:
Hi Lukasz
2017-05-29 15:51 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 14 lines
Good morning Eddie,
Quoted 5 lines
this patch enable rockusb support on rk3288 based device.
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>
I've give this patch set a try on travisCI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/237068149
Unfortunately, there are some problem with following boards:
Quoted 8 lines
Quoted 1 line
chromebook_jerry, chromebook_minnie ...
I did it by myself last week. i got the same error. then i fix those chromebook error
and test again. I still got some 3036 board error. But it build successfully when i
build it on my computer. here is the travis-ci.org error log
https://travis-ci.org/eddiecailinux/u-boot/jobs/236232837
I have no idea what can i do to fix it.
Quoted 5 lines
Can you share the SHA1 of commit on top of which you applied your patches?
I take u-boot-usb (the USB u-boot tree from Marek Vasut) as a base and then apply commits on top of it.
here is my branch
https://github.com/eddiecailinux/u-boot/tree/rockusb-v8 I apply my patch on top of below commit commit a63d800196ebee59b0f8ff924f67843cd597a8c1 Author: Tom Rini
<[email protected]> Date: Mon May 1 19:54:41 2017 -0400
Quoted 3 lines
Prepare v2017.05-rc3
Signed-off-by Tom Rini <[email protected]>
I've looked thoroughly at your patches:
Your patches has been applied on top of the above commit:
SHA1: a63d800196ebee59b0f8ff924f67843cd597a8c1
Before applying your patches:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/239069544
After applying them:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/239074799
To be more precise:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/239074800
For example:
arm: + rock2
(quoted diff) +5 -0
+cmd/built-in.o: In function `do_fastboot':
+cmd/fastboot.c:28: undefined reference to `board_usb_init'
+cmd/fastboot.c:34: undefined reference to `g_dnl_clear_detach'
+cmd/fastboot.c:35: undefined reference to `g_dnl_register'
+cmd/fastboot.c:39: undefined reference to
      `g_dnl_board_usb_cable_connected' +cmd/fastboot.c:57: undefined
      reference to `g_dnl_unregister' +cmd/fastboot.c:58: undefined
      reference to `g_dnl_clear_detach' +cmd/fastboot.c:59: undefined
      reference to `board_usb_cleanup' +cmd/fastboot.c:47: undefined
      reference to `g_dnl_detach' +cmd/fastboot.c:51: undefined
      reference to `usb_gadget_handle_interrupts' +cmd/built-in.o: In
      function `do_usb_mass_storage':

Quoted 4 lines

For me it seems like you have enabled fastboot support on too many rochchip's boards.
Can you look on it?

If I might ask - have you managed to investigate this issue?

Quoted 226 lines

I've also updated my .travis.ml file to be in sync with mainline, so we will use recommended arm toolchain.
Please find this file attached.
If there are any other patches required before applying this patch series, please let me know (or better post them to ML).
Best regards,
Łukasz Majewski
Quoted 199 lines
Quoted 199 lines
Quoted 185 lines
Quoted 185 lines
caused by "undefined references to ...."
I've tried your patches on top of:
u-boot-usb/HEAD
SHA1: 3426b2038cfb831d74ac0407fc7a04e990b44540
Maybe you have built tested it on other branch/commit?
Best regards,
Łukasz Majewski
p.s. My travis CI .travis.yml attached.
Quoted 154 lines
Changes in v7:
-use imply in the Kconfig to enable rockusb
Changes in v6:
-enable rockusb in defconfig
Changes in v5:
-none
Changes in v4:
-move to rk3288_common.h
Changes in v3:
(quoted diff) +0 -2
-move to defconfig
 
---
 arch/arm/mach-rockchip/Kconfig    | 2 ++
 configs/evb-rk3288_defconfig      | 9 +++++++++
 configs/fennec-rk3288_defconfig   | 6 ++++++
 configs/firefly-rk3288_defconfig  | 6 ++++++
 configs/miqi-rk3288_defconfig     | 6 ++++++
 configs/popmetal-rk3288_defconfig | 6 ++++++
 configs/tinker-rk3288_defconfig   | 6 ++++++
 include/configs/rk3288_common.h   | 7 -------
 8 files changed, 41 insertions(+), 7 deletions(-)
(quoted diff) +0 -0
b/arch/arm/mach-rockchip/Kconfig index 2b752ad..8a87812 100644
arch/arm/mach-rockchip/Kconfig +2 -0
@@ -32,6 +32,8 @@ config ROCKCHIP_RK3288
      select CPU_V7
      select SUPPORT_SPL
      select SPL
+     imply USB_FUNCTION_ROCKUSB
+     imply CMD_ROCKUSB
      help
        The Rockchip RK3288 is a ARM-based SoC with a
 quad-core Cortex-A17 including NEON and GPU, 1MB L2 cache,
Mali-T7 graphics, two diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig index 227150d..cf66e09 100644 --- a/configs/evb-rk3288_defconfig +++ b/configs/evb-rk3288_defconfig @@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y CONFIG_CMD_SF=y
CONFIG_CMD_SPI=y
CONFIG_CMD_I2C=y
arch/arm/mach-rockchip/Kconfig +9 -0
+CONFIG_CMD_USB=y
 CONFIG_CMD_GPIO=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
@@ -61,6 +62,14 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/fennec-rk3288_defconfig index befba18..eb33d00 100644 --- a/configs/fennec-rk3288_defconfig +++ b/configs/fennec-rk3288_defconfig
configs/evb-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/firefly-rk3288_defconfig index f2872a6..1f4ca32 100644 --- a/configs/firefly-rk3288_defconfig +++ b/configs/firefly-rk3288_defconfig
configs/evb-rk3288_defconfig +6 -0
@@ -73,3 +73,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/miqi-rk3288_defconfig index d93bd97..b8b6fd5 100644
configs/miqi-rk3288_defconfig +6 -0
@@ -70,3 +70,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/popmetal-rk3288_defconfig index 748cda4..1181a20 100644 --- a/configs/popmetal-rk3288_defconfig +++ b/configs/popmetal-rk3288_defconfig
configs/evb-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/tinker-rk3288_defconfig index ada5950..f863df8 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig
configs/evb-rk3288_defconfig +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/include/configs/rk3288_common.h index e7a8f72..421ba60 100644 --- a/include/configs/rk3288_common.h +++ b/include/configs/rk3288_common.h
include/configs/rk3288_common.h +0 -2
@@ -58,11 +58,9 @@
 
 #ifndef CONFIG_SPL_BUILD
 /* usb otg */
-#define CONFIG_USB_GADGET
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_DWC2_OTG
 #define CONFIG_ROCKCHIP_USB2_PHY
-#define CONFIG_USB_GADGET_VBUS_DRAW  0
 
 /* fastboot  */
 #define CONFIG_CMD_FASTBOOT
@@ -76,11 +74,6 @@
 #define CONFIG_USB_FUNCTION_MASS_STORAGE
include/configs/rk3288_common.h line 79
Quoted 10 lines
include/configs/rk3288_common.h +0 -5
 #define CONFIG_CMD_USB_MASS_STORAGE
 
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER    "Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM              0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM     0x320a
-
 /* usb host support */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_USB_DWC2
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director:
Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax:
(+49)-8142-66989-80 Email: wd at denx.de
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de
Best regards,

Quoted 7 lines

Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

Best regards,

Lukasz Majewski

Eddie Cai

author

2017-06-28 07:33 UTC #16 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

Hi Lukasz

2017-06-21 15:44 GMT+08:00 Lukasz Majewski <[email protected]>:

Quoted 82 lines

Hi Eddie,
Quoted 80 lines
Hi Eddie,
Quoted 41 lines
2017-05-31 15:12 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 29 lines
Quoted 17 lines · On Wed, 31 May 2017 10:27:23 +0800 Eddie Cai <[email protected]> wrote:
Hi Lukasz
2017-05-29 15:51 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 14 lines
Good morning Eddie,
Quoted 5 lines
this patch enable rockusb support on rk3288 based device.
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>
I've give this patch set a try on travisCI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/237068149
Unfortunately, there are some problem with following boards:
Quoted 8 lines
Quoted 1 line
chromebook_jerry, chromebook_minnie ...
I did it by myself last week. i got the same error. then i fix those chromebook error
and test again. I still got some 3036 board error. But it build successfully when i
build it on my computer. here is the travis-ci.org error log
https://travis-ci.org/eddiecailinux/u-boot/jobs/236232837
I have no idea what can i do to fix it.
Quoted 5 lines
Can you share the SHA1 of commit on top of which you applied your patches?
I take u-boot-usb (the USB u-boot tree from Marek Vasut) as a base and then apply commits on top of it.
here is my branch
https://github.com/eddiecailinux/u-boot/tree/rockusb-v8 I apply my patch on top of below commit commit a63d800196ebee59b0f8ff924f67843cd597a8c1 Author: Tom Rini
<[email protected]> Date: Mon May 1 19:54:41 2017 -0400
Quoted 3 lines
Prepare v2017.05-rc3
Signed-off-by Tom Rini <[email protected]>
I've looked thoroughly at your patches:
Your patches has been applied on top of the above commit:
SHA1: a63d800196ebee59b0f8ff924f67843cd597a8c1
Before applying your patches:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/239069544
After applying them:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/239074799
To be more precise:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/239074800
For example:
arm: + rock2
(quoted diff) +5 -0
+cmd/built-in.o: In function `do_fastboot':
+cmd/fastboot.c:28: undefined reference to `board_usb_init'
+cmd/fastboot.c:34: undefined reference to `g_dnl_clear_detach'
+cmd/fastboot.c:35: undefined reference to `g_dnl_register'
+cmd/fastboot.c:39: undefined reference to
      `g_dnl_board_usb_cable_connected' +cmd/fastboot.c:57: undefined
      reference to `g_dnl_unregister' +cmd/fastboot.c:58: undefined
      reference to `g_dnl_clear_detach' +cmd/fastboot.c:59: undefined
      reference to `board_usb_cleanup' +cmd/fastboot.c:47: undefined
      reference to `g_dnl_detach' +cmd/fastboot.c:51: undefined
      reference to `usb_gadget_handle_interrupts' +cmd/built-in.o: In
      function `do_usb_mass_storage':

Quoted 6 lines

Quoted 4 lines
For me it seems like you have enabled fastboot support on too many rochchip's boards.
Can you look on it?
If I might ask - have you managed to investigate this issue?

I can fix the chromebook error. But i didn't enable rockusb support on rk3036 based board. I built these board on my desktop. It work fine.

Quoted 247 lines

Quoted 227 lines
I've also updated my .travis.ml file to be in sync with mainline, so we will use recommended arm toolchain.
Please find this file attached.
If there are any other patches required before applying this patch series, please let me know (or better post them to ML).
Best regards,
Łukasz Majewski
Quoted 199 lines
Quoted 199 lines
Quoted 185 lines
Quoted 185 lines
caused by "undefined references to ...."
I've tried your patches on top of:
u-boot-usb/HEAD
SHA1: 3426b2038cfb831d74ac0407fc7a04e990b44540
Maybe you have built tested it on other branch/commit?
Best regards,
Łukasz Majewski
p.s. My travis CI .travis.yml attached.
Quoted 154 lines
Changes in v7:
-use imply in the Kconfig to enable rockusb
Changes in v6:
-enable rockusb in defconfig
Changes in v5:
-none
Changes in v4:
-move to rk3288_common.h
Changes in v3:
(quoted diff) +0 -2
-move to defconfig
 
---
 arch/arm/mach-rockchip/Kconfig    | 2 ++
 configs/evb-rk3288_defconfig      | 9 +++++++++
 configs/fennec-rk3288_defconfig   | 6 ++++++
 configs/firefly-rk3288_defconfig  | 6 ++++++
 configs/miqi-rk3288_defconfig     | 6 ++++++
 configs/popmetal-rk3288_defconfig | 6 ++++++
 configs/tinker-rk3288_defconfig   | 6 ++++++
 include/configs/rk3288_common.h   | 7 -------
 8 files changed, 41 insertions(+), 7 deletions(-)
(quoted diff) +0 -0
b/arch/arm/mach-rockchip/Kconfig index 2b752ad..8a87812 100644
arch/arm/mach-rockchip/Kconfig +2 -0
@@ -32,6 +32,8 @@ config ROCKCHIP_RK3288
      select CPU_V7
      select SUPPORT_SPL
      select SPL
+     imply USB_FUNCTION_ROCKUSB
+     imply CMD_ROCKUSB
      help
        The Rockchip RK3288 is a ARM-based SoC with a
 quad-core Cortex-A17 including NEON and GPU, 1MB L2 cache,
Mali-T7 graphics, two diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig index 227150d..cf66e09 100644 --- a/configs/evb-rk3288_defconfig +++ b/configs/evb-rk3288_defconfig @@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y CONFIG_CMD_SF=y
CONFIG_CMD_SPI=y
CONFIG_CMD_I2C=y
arch/arm/mach-rockchip/Kconfig +9 -0
+CONFIG_CMD_USB=y
 CONFIG_CMD_GPIO=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
@@ -61,6 +62,14 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/fennec-rk3288_defconfig index befba18..eb33d00 100644 --- a/configs/fennec-rk3288_defconfig +++ b/configs/fennec-rk3288_defconfig
(quoted diff) +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/firefly-rk3288_defconfig index f2872a6..1f4ca32 100644 --- a/configs/firefly-rk3288_defconfig +++ b/configs/firefly-rk3288_defconfig
(quoted diff) +6 -0
@@ -73,3 +73,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/miqi-rk3288_defconfig index d93bd97..b8b6fd5 100644
configs/miqi-rk3288_defconfig +6 -0
@@ -70,3 +70,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/popmetal-rk3288_defconfig index 748cda4..1181a20 100644 --- a/configs/popmetal-rk3288_defconfig +++ b/configs/popmetal-rk3288_defconfig
(quoted diff) +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/tinker-rk3288_defconfig index ada5950..f863df8 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig
(quoted diff) +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/include/configs/rk3288_common.h index e7a8f72..421ba60 100644 --- a/include/configs/rk3288_common.h +++ b/include/configs/rk3288_common.h
(quoted diff) +0 -2
@@ -58,11 +58,9 @@
 
 #ifndef CONFIG_SPL_BUILD
 /* usb otg */
-#define CONFIG_USB_GADGET
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_DWC2_OTG
 #define CONFIG_ROCKCHIP_USB2_PHY
-#define CONFIG_USB_GADGET_VBUS_DRAW  0
 
 /* fastboot  */
 #define CONFIG_CMD_FASTBOOT
@@ -76,11 +74,6 @@
 #define CONFIG_USB_FUNCTION_MASS_STORAGE
Review line 79
Quoted 10 lines
(quoted diff) +0 -5
 #define CONFIG_CMD_USB_MASS_STORAGE
 
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER    "Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM              0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM     0x320a
-
 /* usb host support */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_USB_DWC2
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director:
Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax:
(+49)-8142-66989-80 Email: wd at denx.de
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de
Best regards,
Quoted 7 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

Lukasz Majewski

2017-06-28 07:55 UTC #17 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

Hi Eddie,

Quoted 85 lines

Hi Lukasz
2017-06-21 15:44 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 82 lines
Hi Eddie,
Quoted 80 lines
Hi Eddie,
Quoted 41 lines
2017-05-31 15:12 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 29 lines
Quoted 17 lines · On Wed, 31 May 2017 10:27:23 +0800 Eddie Cai <[email protected]> wrote:
Hi Lukasz
2017-05-29 15:51 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 14 lines
Good morning Eddie,
Quoted 5 lines
this patch enable rockusb support on rk3288 based device.
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>
I've give this patch set a try on travisCI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/237068149
Unfortunately, there are some problem with following boards:
Quoted 8 lines
Quoted 1 line
chromebook_jerry, chromebook_minnie ...
I did it by myself last week. i got the same error. then i fix those chromebook error
and test again. I still got some 3036 board error. But it build successfully when i
build it on my computer. here is the travis-ci.org error log
https://travis-ci.org/eddiecailinux/u-boot/jobs/236232837
I have no idea what can i do to fix it.
Quoted 5 lines
Can you share the SHA1 of commit on top of which you applied your patches?
I take u-boot-usb (the USB u-boot tree from Marek Vasut) as a base and then apply commits on top of it.
here is my branch
https://github.com/eddiecailinux/u-boot/tree/rockusb-v8 I apply my patch on top of below commit commit a63d800196ebee59b0f8ff924f67843cd597a8c1 Author: Tom Rini
<[email protected]> Date: Mon May 1 19:54:41 2017 -0400
Quoted 3 lines
Prepare v2017.05-rc3
Signed-off-by Tom Rini <[email protected]>
I've looked thoroughly at your patches:
Your patches has been applied on top of the above commit:
SHA1: a63d800196ebee59b0f8ff924f67843cd597a8c1
Before applying your patches:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/239069544
After applying them:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/239074799
To be more precise:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/239074800
For example:
arm: + rock2
(quoted diff) +5 -0
+cmd/built-in.o: In function `do_fastboot':
+cmd/fastboot.c:28: undefined reference to `board_usb_init'
+cmd/fastboot.c:34: undefined reference to `g_dnl_clear_detach'
+cmd/fastboot.c:35: undefined reference to `g_dnl_register'
+cmd/fastboot.c:39: undefined reference to
      `g_dnl_board_usb_cable_connected' +cmd/fastboot.c:57:
undefined reference to `g_dnl_unregister' +cmd/fastboot.c:58:
undefined reference to `g_dnl_clear_detach' +cmd/fastboot.c:59:
undefined reference to `board_usb_cleanup' +cmd/fastboot.c:47:
undefined reference to `g_dnl_detach' +cmd/fastboot.c:51: undefined
reference to `usb_gadget_handle_interrupts' +cmd/built-in.o:
In function `do_usb_mass_storage':

Quoted 7 lines

Quoted 6 lines
Quoted 4 lines
For me it seems like you have enabled fastboot support on too many rochchip's boards.
Can you look on it?
If I might ask - have you managed to investigate this issue?
I can fix the chromebook error.

Ok.

Quoted 2 lines

But i didn't enable rockusb support on
rk3036 based board. I built these board on my desktop. It work fine.

The issue is not with this one particular board.

I'm concerned, since your patch set causes build errors for other boards.

Can you build test (with travis-CI) your patches and check if you can reproduce those errors?

Best regards,
Łukasz

Quoted 241 lines

Quoted 241 lines
Quoted 227 lines
I've also updated my .travis.ml file to be in sync with mainline, so we will use recommended arm toolchain.
Please find this file attached.
If there are any other patches required before applying this patch series, please let me know (or better post them to ML).
Best regards,
Łukasz Majewski
Quoted 199 lines
Quoted 199 lines
Quoted 185 lines
Quoted 185 lines
caused by "undefined references to ...."
I've tried your patches on top of:
u-boot-usb/HEAD
SHA1: 3426b2038cfb831d74ac0407fc7a04e990b44540
Maybe you have built tested it on other branch/commit?
Best regards,
Łukasz Majewski
p.s. My travis CI .travis.yml attached.
Quoted 154 lines
Changes in v7:
-use imply in the Kconfig to enable rockusb
Changes in v6:
-enable rockusb in defconfig
Changes in v5:
-none
Changes in v4:
-move to rk3288_common.h
Changes in v3:
(quoted diff) +0 -2
-move to defconfig
 
---
 arch/arm/mach-rockchip/Kconfig    | 2 ++
 configs/evb-rk3288_defconfig      | 9 +++++++++
 configs/fennec-rk3288_defconfig   | 6 ++++++
 configs/firefly-rk3288_defconfig  | 6 ++++++
 configs/miqi-rk3288_defconfig     | 6 ++++++
 configs/popmetal-rk3288_defconfig | 6 ++++++
 configs/tinker-rk3288_defconfig   | 6 ++++++
 include/configs/rk3288_common.h   | 7 -------
 8 files changed, 41 insertions(+), 7 deletions(-)
(quoted diff) +0 -0
b/arch/arm/mach-rockchip/Kconfig index 2b752ad..8a87812 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig
(quoted diff) +2 -0
@@ -32,6 +32,8 @@ config ROCKCHIP_RK3288
      select CPU_V7
      select SUPPORT_SPL
      select SPL
+     imply USB_FUNCTION_ROCKUSB
+     imply CMD_ROCKUSB
      help
        The Rockchip RK3288 is a ARM-based SoC with a
 quad-core Cortex-A17 including NEON and GPU, 1MB L2 cache,
Mali-T7 graphics, two diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig index 227150d..cf66e09 100644 --- a/configs/evb-rk3288_defconfig +++ b/configs/evb-rk3288_defconfig @@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y CONFIG_CMD_SF=y
CONFIG_CMD_SPI=y
CONFIG_CMD_I2C=y
(quoted diff) +9 -0
+CONFIG_CMD_USB=y
 CONFIG_CMD_GPIO=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
@@ -61,6 +62,14 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/fennec-rk3288_defconfig index befba18..eb33d00 100644 --- a/configs/fennec-rk3288_defconfig +++ b/configs/fennec-rk3288_defconfig
(quoted diff) +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/firefly-rk3288_defconfig index f2872a6..1f4ca32 100644 --- a/configs/firefly-rk3288_defconfig +++ b/configs/firefly-rk3288_defconfig
(quoted diff) +6 -0
@@ -73,3 +73,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/miqi-rk3288_defconfig index d93bd97..b8b6fd5 100644 --- a/configs/miqi-rk3288_defconfig +++ b/configs/miqi-rk3288_defconfig
(quoted diff) +6 -0
@@ -70,3 +70,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/popmetal-rk3288_defconfig index 748cda4..1181a20 100644 --- a/configs/popmetal-rk3288_defconfig +++ b/configs/popmetal-rk3288_defconfig
(quoted diff) +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/tinker-rk3288_defconfig index ada5950..f863df8 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig
(quoted diff) +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/include/configs/rk3288_common.h index e7a8f72..421ba60 100644 --- a/include/configs/rk3288_common.h +++ b/include/configs/rk3288_common.h
(quoted diff) +0 -2
@@ -58,11 +58,9 @@
 
 #ifndef CONFIG_SPL_BUILD
 /* usb otg */
-#define CONFIG_USB_GADGET
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_DWC2_OTG
 #define CONFIG_ROCKCHIP_USB2_PHY
-#define CONFIG_USB_GADGET_VBUS_DRAW  0
 
 /* fastboot  */
 #define CONFIG_CMD_FASTBOOT
@@ -76,11 +74,6 @@
 #define CONFIG_USB_FUNCTION_MASS_STORAGE
Review line 79
Quoted 10 lines
(quoted diff) +0 -5
 #define CONFIG_CMD_USB_MASS_STORAGE
 
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER    "Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM              0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM     0x320a
-
 /* usb host support */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_USB_DWC2
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director:
Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax:
(+49)-8142-66989-80 Email: wd at denx.de
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director:
Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax:
(+49)-8142-66989-80 Email: wd at denx.de
Best regards,
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de
Best regards,

Quoted 8 lines

Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de

Best regards,

Lukasz Majewski

Eddie Cai

author

2017-06-29 00:44 UTC #18 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

2017-06-28 15:55 GMT+08:00 Lukasz Majewski <[email protected]>:

Quoted 100 lines

Hi Eddie,
Quoted 85 lines
Hi Lukasz
2017-06-21 15:44 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 82 lines
Hi Eddie,
Quoted 80 lines
Hi Eddie,
Quoted 41 lines
2017-05-31 15:12 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 29 lines
Quoted 17 lines · On Wed, 31 May 2017 10:27:23 +0800 Eddie Cai <[email protected]> wrote:
Hi Lukasz
2017-05-29 15:51 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 14 lines
Good morning Eddie,
Quoted 5 lines
this patch enable rockusb support on rk3288 based device.
Signed-off-by Eddie Cai <[email protected]>
Reviewed-by Simon Glass <[email protected]>
I've give this patch set a try on travisCI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/237068149
Unfortunately, there are some problem with following boards:
Quoted 8 lines
Quoted 1 line
chromebook_jerry, chromebook_minnie ...
I did it by myself last week. i got the same error. then i fix those chromebook error
and test again. I still got some 3036 board error. But it build successfully when i
build it on my computer. here is the travis-ci.org error log
https://travis-ci.org/eddiecailinux/u-boot/jobs/236232837
I have no idea what can i do to fix it.
Quoted 5 lines
Can you share the SHA1 of commit on top of which you applied your patches?
I take u-boot-usb (the USB u-boot tree from Marek Vasut) as a base and then apply commits on top of it.
here is my branch
https://github.com/eddiecailinux/u-boot/tree/rockusb-v8 I apply my patch on top of below commit commit a63d800196ebee59b0f8ff924f67843cd597a8c1 Author: Tom Rini
<[email protected]> Date: Mon May 1 19:54:41 2017 -0400
Quoted 3 lines
Prepare v2017.05-rc3
Signed-off-by Tom Rini <[email protected]>
I've looked thoroughly at your patches:
Your patches has been applied on top of the above commit:
SHA1: a63d800196ebee59b0f8ff924f67843cd597a8c1
Before applying your patches:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/239069544
After applying them:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/239074799
To be more precise:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/239074800
For example:
arm: + rock2
(quoted diff) +5 -0
+cmd/built-in.o: In function `do_fastboot':
+cmd/fastboot.c:28: undefined reference to `board_usb_init'
+cmd/fastboot.c:34: undefined reference to `g_dnl_clear_detach'
+cmd/fastboot.c:35: undefined reference to `g_dnl_register'
+cmd/fastboot.c:39: undefined reference to
      `g_dnl_board_usb_cable_connected' +cmd/fastboot.c:57:
undefined reference to `g_dnl_unregister' +cmd/fastboot.c:58:
undefined reference to `g_dnl_clear_detach' +cmd/fastboot.c:59:
undefined reference to `board_usb_cleanup' +cmd/fastboot.c:47:
undefined reference to `g_dnl_detach' +cmd/fastboot.c:51: undefined
reference to `usb_gadget_handle_interrupts' +cmd/built-in.o:
In function `do_usb_mass_storage':
Quoted 7 lines
Quoted 6 lines
Quoted 4 lines
For me it seems like you have enabled fastboot support on too many rochchip's boards.
Can you look on it?
If I might ask - have you managed to investigate this issue?
I can fix the chromebook error.
Ok.
Quoted 2 lines
But i didn't enable rockusb support on
rk3036 based board. I built these board on my desktop. It work fine.

Quoted 7 lines

The issue is not with this one particular board.
I'm concerned, since your patch set causes build errors for other boards.
Can you build test (with travis-CI) your patches and check if you can reproduce those errors?

I can reproduce this error with travis-CI. but i can't not reproduce this rk3036 board error on my desktop.
can you try to local build rk3036 board and see if can reproduce this error?

Quoted 266 lines

Best regards,
Łukasz
Quoted 241 lines
Quoted 241 lines
Quoted 227 lines
I've also updated my .travis.ml file to be in sync with mainline, so we will use recommended arm toolchain.
Please find this file attached.
If there are any other patches required before applying this patch series, please let me know (or better post them to ML).
Best regards,
Łukasz Majewski
Quoted 199 lines
Quoted 199 lines
Quoted 185 lines
Quoted 185 lines
caused by "undefined references to ...."
I've tried your patches on top of:
u-boot-usb/HEAD
SHA1: 3426b2038cfb831d74ac0407fc7a04e990b44540
Maybe you have built tested it on other branch/commit?
Best regards,
Łukasz Majewski
p.s. My travis CI .travis.yml attached.
Quoted 154 lines
Changes in v7:
-use imply in the Kconfig to enable rockusb
Changes in v6:
-enable rockusb in defconfig
Changes in v5:
-none
Changes in v4:
-move to rk3288_common.h
Changes in v3:
(quoted diff) +0 -2
-move to defconfig
 
---
 arch/arm/mach-rockchip/Kconfig    | 2 ++
 configs/evb-rk3288_defconfig      | 9 +++++++++
 configs/fennec-rk3288_defconfig   | 6 ++++++
 configs/firefly-rk3288_defconfig  | 6 ++++++
 configs/miqi-rk3288_defconfig     | 6 ++++++
 configs/popmetal-rk3288_defconfig | 6 ++++++
 configs/tinker-rk3288_defconfig   | 6 ++++++
 include/configs/rk3288_common.h   | 7 -------
 8 files changed, 41 insertions(+), 7 deletions(-)
(quoted diff) +0 -0
b/arch/arm/mach-rockchip/Kconfig index 2b752ad..8a87812 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig
(quoted diff) +2 -0
@@ -32,6 +32,8 @@ config ROCKCHIP_RK3288
      select CPU_V7
      select SUPPORT_SPL
      select SPL
+     imply USB_FUNCTION_ROCKUSB
+     imply CMD_ROCKUSB
      help
        The Rockchip RK3288 is a ARM-based SoC with a
 quad-core Cortex-A17 including NEON and GPU, 1MB L2 cache,
Mali-T7 graphics, two diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig index 227150d..cf66e09 100644 --- a/configs/evb-rk3288_defconfig +++ b/configs/evb-rk3288_defconfig @@ -17,6 +17,7 @@ CONFIG_CMD_MMC=y CONFIG_CMD_SF=y
CONFIG_CMD_SPI=y
CONFIG_CMD_I2C=y
(quoted diff) +9 -0
+CONFIG_CMD_USB=y
 CONFIG_CMD_GPIO=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
@@ -61,6 +62,14 @@ CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/fennec-rk3288_defconfig index befba18..eb33d00 100644 --- a/configs/fennec-rk3288_defconfig +++ b/configs/fennec-rk3288_defconfig
(quoted diff) +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/firefly-rk3288_defconfig index f2872a6..1f4ca32 100644 --- a/configs/firefly-rk3288_defconfig +++ b/configs/firefly-rk3288_defconfig
(quoted diff) +6 -0
@@ -73,3 +73,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/miqi-rk3288_defconfig index d93bd97..b8b6fd5 100644 --- a/configs/miqi-rk3288_defconfig +++ b/configs/miqi-rk3288_defconfig
(quoted diff) +6 -0
@@ -70,3 +70,9 @@ CONFIG_CONSOLE_SCROLL_LINES=10
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/popmetal-rk3288_defconfig index 748cda4..1181a20 100644 --- a/configs/popmetal-rk3288_defconfig +++ b/configs/popmetal-rk3288_defconfig
(quoted diff) +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/configs/tinker-rk3288_defconfig index ada5950..f863df8 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig
(quoted diff) +6 -0
@@ -66,3 +66,9 @@ CONFIG_USB_STORAGE=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_GADGET_VBUS_DRAW=0
+CONFIG_G_DNL_MANUFACTURER="Rockchip"
+CONFIG_G_DNL_VENDOR_NUM=0x2207
+CONFIG_G_DNL_PRODUCT_NUM=0x320a
(quoted diff) +0 -0
b/include/configs/rk3288_common.h index e7a8f72..421ba60 100644 --- a/include/configs/rk3288_common.h +++ b/include/configs/rk3288_common.h
(quoted diff) +0 -2
@@ -58,11 +58,9 @@
 
 #ifndef CONFIG_SPL_BUILD
 /* usb otg */
-#define CONFIG_USB_GADGET
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_DWC2_OTG
 #define CONFIG_ROCKCHIP_USB2_PHY
-#define CONFIG_USB_GADGET_VBUS_DRAW  0
 
 /* fastboot  */
 #define CONFIG_CMD_FASTBOOT
@@ -76,11 +74,6 @@
 #define CONFIG_USB_FUNCTION_MASS_STORAGE
Review line 79
Quoted 10 lines
(quoted diff) +0 -5
 #define CONFIG_CMD_USB_MASS_STORAGE
 
-#define CONFIG_USB_GADGET_DOWNLOAD
-#define CONFIG_G_DNL_MANUFACTURER    "Rockchip"
-#define CONFIG_G_DNL_VENDOR_NUM              0x2207
-#define CONFIG_G_DNL_PRODUCT_NUM     0x320a
-
 /* usb host support */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_USB_DWC2
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director:
Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax:
(+49)-8142-66989-80 Email: wd at denx.de
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director:
Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax:
(+49)-8142-66989-80 Email: wd at denx.de
Best regards,
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de
Best regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

Lukasz Majewski

2017-06-29 10:49 UTC #19 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

Quoted 6 lines · On Thu, 29 Jun 2017 08:44:47 +0800 Eddie Cai <[email protected]> wrote:

Quoted 6 lines
The issue is not with this one particular board.
I'm concerned, since your patch set causes build errors for other boards.

Quoted 7 lines

Quoted 2 lines
Can you build test (with travis-CI) your patches and check if you can reproduce those errors?
I can reproduce this error with travis-CI. but i can't not reproduce this rk3036 board error on my desktop.
can you try to local build rk3036 board and see if can reproduce this error?
Quoted 1 line

The rk3036 (evb-rk3036_defconfig) builds fine (with my old 4.8 gcc).

However, your patches cause other issues [1]:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/248264628

And for example I can reproduce the issue on
rock2_defconfig at my local PC.

Can you build rock2 on your PC with your patches applied without any issues?

[1] The "testing" tree can be found at:
https://github.com/lmajewski/u-boot-dfu/tree/testing

Best regards,

Lukasz Majewski

Eddie Cai

author

2017-06-30 03:38 UTC #20 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

2017-06-29 18:49 GMT+08:00 Lukasz Majewski <[email protected]>:

Quoted 18 lines

Quoted 6 lines · On Thu, 29 Jun 2017 08:44:47 +0800 Eddie Cai <[email protected]> wrote:
Quoted 6 lines
The issue is not with this one particular board.
I'm concerned, since your patch set causes build errors for other boards.
Quoted 7 lines
Quoted 2 lines
Can you build test (with travis-CI) your patches and check if you can reproduce those errors?
I can reproduce this error with travis-CI. but i can't not reproduce this rk3036 board error on my desktop.
can you try to local build rk3036 board and see if can reproduce this error?
Quoted 1 line
The rk3036 (evb-rk3036_defconfig) builds fine (with my old 4.8 gcc).

Quoted 8 lines

However, your patches cause other issues [1]:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/248264628
And for example I can reproduce the issue on
rock2_defconfig at my local PC.
Can you build rock2 on your PC with your patches applied without any issues?

I reproduced and fixed this issue long time ago. I didn't send my next version because i don't know how to reproduce 3036 issue. It looks like 3036 work fine on your side now. Can i ignore this 3036 issue?

Quoted 17 lines

[1] The "testing" tree can be found at:
https://github.com/lmajewski/u-boot-dfu/tree/testing
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

Lukasz Majewski

2017-06-30 08:15 UTC #21 lore raw

PATCH v7 4/4 rockchip: rk3288: enable rockusb support on rk3288 based device

Hi Eddie,

Quoted 26 lines

2017-06-29 18:49 GMT+08:00 Lukasz Majewski <[email protected]>:
Quoted 25 lines
Quoted 6 lines · On Thu, 29 Jun 2017 08:44:47 +0800 Eddie Cai <[email protected]> wrote:
Quoted 6 lines
The issue is not with this one particular board.
I'm concerned, since your patch set causes build errors for other boards.
Quoted 7 lines
Quoted 2 lines
Can you build test (with travis-CI) your patches and check if you can reproduce those errors?
I can reproduce this error with travis-CI. but i can't not reproduce this rk3036 board error on my desktop.
can you try to local build rk3036 board and see if can reproduce this error?
Quoted 1 line
The rk3036 (evb-rk3036_defconfig) builds fine (with my old 4.8
gcc).
However, your patches cause other issues [1]:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/248264628
And for example I can reproduce the issue on
rock2_defconfig at my local PC.

Quoted 6 lines

Quoted 2 lines
Can you build rock2 on your PC with your patches applied without any issues?
I reproduced and fixed this issue long time ago. I didn't send my next version because i don't know how to reproduce 3036 issue. It looks like 3036 work fine on your side now. Can i ignore this 3036 issue?

Please before posting next version make sure that no build breaks shows up in TravisCI.

Please as a reference use mainline .travis.yml. (especially build for rockchip)

Please let me know if you need any assistance at fixing problems.

Quoted 10 lines

Quoted 10 lines
[1] The "testing" tree can be found at:
https://github.com/lmajewski/u-boot-dfu/tree/testing
Best regards,

Quoted 8 lines

Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
wd at denx.de

Best regards,

Lukasz Majewski