Skip to contentSkip to conversation

linux-raspberrypi_dev: don't use AUTOREV

PATCH In review Martin Jansa 5 participants 12 messages May 30, 2017 – Jun 1, 2017 Broadcom BCM2711/BCM2835 Arm architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux-raspberrypi_dev: don't use AUTOREV

* use latest revision in rpi-4.11.y branch
* using AUTOREV causes bitbake to run git ls-remote on the github.com repository in order to convert AUTOREV to currently latest SRCREV even when you don't use linux-raspberrypi_dev at all, just happen to have meta-raspberrypi layer in your bblayers.conf, that's bad for people who want to be able to build without network access (completely from premirror)

---
 recipes-kernel/linux/linux-raspberrypi_dev.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-kernel/linux/linux-raspberrypi_dev.bb +1 -1
index 239d630..06771b9 100644
@@ -3,7 +3,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-dev:"
 LINUX_VERSION ?= "4.11"
 LINUX_RPI_DEV_BRANCH ?= "rpi-4.11.y"
 
-SRCREV = "${AUTOREV}"
+SRCREV = "3b3178eb6c0ddea0a6856f16f52b5d2c21ed9299"
 SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=${LINUX_RPI_DEV_BRANCH} \
            file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \
 "
Signature · 1 line
2.13.0
#1 lore raw
Quoted 6 lines · Martin Jansa

* use latest revision in rpi-4.11.y branch
* using AUTOREV causes bitbake to run git ls-remote on the github.com repository in order to convert AUTOREV to currently latest SRCREV even when you don't use linux-raspberrypi_dev at all, just happen to have meta-raspberrypi layer in your bblayers.conf, that's bad for people who want to be able to build without network access (completely from premirror)

These branches get rebased often so locking SRCREV caused another kind of problem. what we can do is.

1. Let user like you override the SRCREC via a bbappend or conf file. so change the assignment to ?=
2. Delete the recipe completely. We lose some of upstream testing.

Quoted 26 lines
---
 recipes-kernel/linux/linux-raspberrypi_dev.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-kernel/linux/linux-raspberrypi_dev.bb +1 -2
index 239d630..06771b9 100644
@@ -3,7 +3,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-dev:"
 LINUX_VERSION ?= "4.11"
 LINUX_RPI_DEV_BRANCH ?= "rpi-4.11.y"
 
-SRCREV = "${AUTOREV}"
+SRCREV = "3b3178eb6c0ddea0a6856f16f52b5d2c21ed9299"
 SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=${LINUX_RPI_DEV_BRANCH} \
            file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \
 "
--

2.13.0

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#2 lore raw

On 30 May 2017 5:08 p.m., "Khem Raj" <[email protected]> wrote:

Quoted 2 lines · Martin Jansa

* use latest revision in rpi-4.11.y branch
* using AUTOREV causes bitbake to run git ls-remote on the github.com

repository in order

Quoted 1 line

to convert AUTOREV to currently latest SRCREV even when you don't use

linux-raspberrypi_dev

Quoted 1 line

at all, just happen to have meta-raspberrypi layer in your

bblayers.conf, that's bad for

Quoted 1 line

people who want to be able to build without network access (completely

from premirror)

Quoted 1 line

These branches get rebased often so locking SRCREV caused another kind of problem. what we can do is.

1. Let user like you override the SRCREC via a bbappend or conf file. so change the assignment to ?=
2. Delete the recipe completely. We lose some of upstream testing.

We should be able to skip the recipe if it isn't selected as the preferred version and/or provider of "virtual/kernel". I'm out at the minute so can't look at it now but will try to take a look later this week.

#3 lore raw
Quoted 18 lines · Paul Barker

On 30 May 2017 5:08 p.m., "Khem Raj" <[email protected]> wrote:

Quoted 10 lines · Martin Jansa

* use latest revision in rpi-4.11.y branch
* using AUTOREV causes bitbake to run git ls-remote on the github.com repository in order
to convert AUTOREV to currently latest SRCREV even when you don't use
linux-raspberrypi_dev
at all, just happen to have meta-raspberrypi layer in your
bblayers.conf, that's bad for
people who want to be able to build without network access (completely
from premirror)

These branches get rebased often so locking SRCREV caused another kind of problem. what we can do is.

Quoted 7 lines

1. Let user like you override the SRCREC via a bbappend or conf file. so change the assignment to ?=
2. Delete the recipe completely. We lose some of upstream testing.

We should be able to skip the recipe if it isn't selected as the preferred version and/or provider of "virtual/kernel". I'm out at the minute so can't look at it now but will try to take a look later this week.

The linux-yocto-dev.bb recipe contains an example of doing that.

Quoted 6 lines

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#4 lore raw
Quoted 23 lines · Andre McCurdy
Quoted 22 lines · Paul Barker

On 30 May 2017 5:08 p.m., "Khem Raj" <[email protected]> wrote:

Quoted 10 lines · Martin Jansa

* use latest revision in rpi-4.11.y branch
* using AUTOREV causes bitbake to run git ls-remote on the github.com repository in order
to convert AUTOREV to currently latest SRCREV even when you don't use
linux-raspberrypi_dev
at all, just happen to have meta-raspberrypi layer in your
bblayers.conf, that's bad for
people who want to be able to build without network access (completely
from premirror)

These branches get rebased often so locking SRCREV caused another kind of problem. what we can do is.

1. Let user like you override the SRCREC via a bbappend or conf file. so change the assignment to ?=
2. Delete the recipe completely. We lose some of upstream testing.

Quoted 6 lines
Quoted 3 lines

We should be able to skip the recipe if it isn't selected as the preferred version and/or provider of "virtual/kernel". I'm out at the minute so can't look at it now but will try to take a look later this week.

The linux-yocto-dev.bb recipe contains an example of doing that.

ah perfect. Thats what we need here

http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-kernel/linux/linux-yocto-dev.bb?h=master#n28

please rename the recipe to be linux-raspberrypi-dev.bb and add the magic above and send a v2

Quoted 6 lines
Quoted 6 lines

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#5 lore raw
Quoted 36 lines · Khem Raj
Quoted 1 line · Andre McCurdy

On Tue, May 30, 2017 at 10:15 AM, Paul Barker <[email protected]>

Quoted 4 lines · wrote:
Quoted 4 lines · Khem Raj

On Tue, May 30, 2017 at 12:57 AM, Martin Jansa <[email protected]> wrote:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

* use latest revision in rpi-4.11.y branch
* using AUTOREV causes bitbake to run git ls-remote on the github.com repository in order
to convert AUTOREV to currently latest SRCREV even when you don't use
linux-raspberrypi_dev
at all, just happen to have meta-raspberrypi layer in your
bblayers.conf, that's bad for
people who want to be able to build without network access

(completely

Quoted 11 lines
Quoted 11 lines
Quoted 2 lines

from premirror)

These branches get rebased often so locking SRCREV caused another kind of problem. what we can do is.

1. Let user like you override the SRCREC via a bbappend or conf file. so change the assignment to ?=
2. Delete the recipe completely. We lose some of upstream testing.

We should be able to skip the recipe if it isn't selected as the

preferred

Quoted 1 line
Quoted 1 line

version and/or provider of "virtual/kernel". I'm out at the minute so

can't

Quoted 4 lines
Quoted 1 line

look at it now but will try to take a look later this week.

The linux-yocto-dev.bb recipe contains an example of doing that.

Quoted 9 lines

ah perfect. Thats what we need here

http://cgit.openembedded.org/openembedded-core/tree/meta/
recipes-kernel/linux/linux-yocto-dev.bb?h=master#n28

please rename the recipe to be linux-raspberrypi-dev.bb and add the magic above and send a v2

Using the magic above we still hardcode a revision there. So if a user wants to compile the recipe without setting the preferred provider it will fail.

--
Andrei Gherzan

#6 lore raw
Quoted 43 lines · Andrei Gherzan
Quoted 41 lines · Khem Raj
Quoted 26 lines · Andre McCurdy
Quoted 24 lines · Paul Barker

On 30 May 2017 5:08 p.m., "Khem Raj" <[email protected]> wrote:

Quoted 12 lines · Martin Jansa

* use latest revision in rpi-4.11.y branch
* using AUTOREV causes bitbake to run git ls-remote on the github.com repository in order
to convert AUTOREV to currently latest SRCREV even when you don't
use
linux-raspberrypi_dev
at all, just happen to have meta-raspberrypi layer in your
bblayers.conf, that's bad for
people who want to be able to build without network access
(completely
from premirror)

These branches get rebased often so locking SRCREV caused another kind of problem. what we can do is.

1. Let user like you override the SRCREC via a bbappend or conf file. so change the assignment to ?=
2. Delete the recipe completely. We lose some of upstream testing.

Quoted 8 lines
Quoted 5 lines

We should be able to skip the recipe if it isn't selected as the preferred
version and/or provider of "virtual/kernel". I'm out at the minute so can't
look at it now but will try to take a look later this week.

The linux-yocto-dev.bb recipe contains an example of doing that.

ah perfect. Thats what we need here

Quoted 8 lines
Quoted 5 lines

http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-kernel/linux/linux-yocto-dev.bb?h=master#n28

please rename the recipe to be linux-raspberrypi-dev.bb and add the magic above and send a v2

Using the magic above we still hardcode a revision there. So if a user wants to compile the recipe without setting the preferred provider it will fail.

what will be the usecase ? when you have a different kernel selected but woould like to compile yet another kernel

that rev can be a well known rev like branchpoint. Moreover, I think if someone wants to use the dev recipe then its expected that they switch
to using AUTOREV or some other local mechanism for pinning if needed.

Quoted 3 lines

--
Andrei Gherzan

#7 lore raw
Quoted 53 lines · Khem Raj
Quoted 43 lines · Andrei Gherzan
Quoted 41 lines · Khem Raj
Quoted 26 lines · Andre McCurdy
Quoted 24 lines · Paul Barker

On 30 May 2017 5:08 p.m., "Khem Raj" <[email protected]> wrote:

Quoted 12 lines · Martin Jansa

* use latest revision in rpi-4.11.y branch
* using AUTOREV causes bitbake to run git ls-remote on the github.com repository in order
to convert AUTOREV to currently latest SRCREV even when you don't
use
linux-raspberrypi_dev
at all, just happen to have meta-raspberrypi layer in your
bblayers.conf, that's bad for
people who want to be able to build without network access
(completely
from premirror)

These branches get rebased often so locking SRCREV caused another kind of problem. what we can do is.

1. Let user like you override the SRCREC via a bbappend or conf file. so change the assignment to ?=
2. Delete the recipe completely. We lose some of upstream testing.

Quoted 8 lines
Quoted 5 lines

We should be able to skip the recipe if it isn't selected as the preferred
version and/or provider of "virtual/kernel". I'm out at the minute so can't
look at it now but will try to take a look later this week.

The linux-yocto-dev.bb recipe contains an example of doing that.

ah perfect. Thats what we need here

Quoted 8 lines
Quoted 5 lines

http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-kernel/linux/linux-yocto-dev.bb?h=master#n28

please rename the recipe to be linux-raspberrypi-dev.bb and add the magic above and send a v2

Using the magic above we still hardcode a revision there. So if a user wants to compile the recipe without setting the preferred provider it will fail.

Quoted 8 lines

what will be the usecase ? when you have a different kernel selected but woould like to compile yet another kernel

that rev can be a well known rev like branchpoint. Moreover, I think if someone wants to use the dev recipe then its expected that they switch
to using AUTOREV or some other local mechanism for pinning if needed.

I was thinking of a different approach entirerly. We can add the following at the top of the recipe file:

python __anonymous() {
if "linux-raspberrypi-dev" not in
d.getVar("PREFERRED_PROVIDER_virtual/kernel"):
msg = "Skipping linux-raspberrypi-dev as it is not the preferred " + \
"provider of virtual/kernel."
raise bb.parse.SkipRecipe(msg)
}

(Hopefully gmail won't mangle that too much)

I've just tested it and it works fine as long as it's before the use of ${AUTOREV}. If there's no objections to this approach I'll submit a patch.

Cheers,

Signature · 3 lines
Paul Barker
Co-Founder & Principal Engineer
Togán Labs Ltd
#8 lore raw

Yes, Paul approach looks good to me, I think it was what was suggested in first replies to my SRCREV change and I agree with that, I just haven't had time to send updated patch.

Paul if you have the patch ready please send it, thanks!.

Quoted 103 lines · Paul Barker
Quoted 1 line · Khem Raj

On Wed, May 31, 2017 at 5:00 PM, Andrei Gherzan <[email protected]>

Quoted 11 lines · wrote:
Quoted 11 lines · Khem Raj
Quoted 9 lines
Quoted 6 lines · Andre McCurdy

On Tue, May 30, 2017 at 10:15 AM, Paul Barker <[email protected]

Quoted 3 lines · wrote:

On 30 May 2017 5:08 p.m., "Khem Raj" <[email protected]> wrote:

On Tue, May 30, 2017 at 12:57 AM, Martin Jansa <

[email protected]>

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines · wrote:

* use latest revision in rpi-4.11.y branch
* using AUTOREV causes bitbake to run git ls-remote on the

github.com

Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines

repository in order
to convert AUTOREV to currently latest SRCREV even when you don't
use
linux-raspberrypi_dev
at all, just happen to have meta-raspberrypi layer in your
bblayers.conf, that's bad for
people who want to be able to build without network access
(completely
from premirror)

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

These branches get rebased often so locking SRCREV caused another kind of problem. what we can do is.

1. Let user like you override the SRCREC via a bbappend or conf

file.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

so change the assignment to ?=
2. Delete the recipe completely. We lose some of upstream testing.

We should be able to skip the recipe if it isn't selected as the preferred
version and/or provider of "virtual/kernel". I'm out at the minute

so

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 5 lines
Quoted 2 lines

can't
look at it now but will try to take a look later this week.

The linux-yocto-dev.bb recipe contains an example of doing that.

ah perfect. Thats what we need here

http://cgit.openembedded.org/openembedded-core/tree/meta/

recipes-kernel/linux/linux-yocto-dev.bb?h=master#n28

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

please rename the recipe to be linux-raspberrypi-dev.bb and add the

magic

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

above and send a v2

Using the magic above we still hardcode a revision there. So if a user

wants

Quoted 1 line
Quoted 1 line

to compile the recipe without setting the preferred provider it will

fail.

Quoted 9 lines

what will be the usecase ? when you have a different kernel selected but woould like to compile yet another kernel

that rev can be a well known rev like branchpoint. Moreover, I think if someone wants to use the dev recipe then its expected that they switch
to using AUTOREV or some other local mechanism for pinning if needed.

I was thinking of a different approach entirerly. We can add the following at the top of the recipe file:

python __anonymous() {
if "linux-raspberrypi-dev" not in
d.getVar("PREFERRED_PROVIDER_virtual/kernel"):
msg = "Skipping linux-raspberrypi-dev as it is not the preferred "
+ \
"provider of virtual/kernel."
raise bb.parse.SkipRecipe(msg)
}

(Hopefully gmail won't mangle that too much)

I've just tested it and it works fine as long as it's before the use of ${AUTOREV}. If there's no objections to this approach I'll submit a patch.

Cheers,

--
Paul Barker
Co-Founder & Principal Engineer
Togán Labs Ltd
--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#9 lore raw

And it's not clear from the diff you send, but like linux-yocto-dev.bb example above, the recipe needs to be renamed from linux-raspberrypi_dev.bb to linux-raspberrypi-dev.bb to make it different provider.

Quoted 114 lines · Martin Jansa

Yes, Paul approach looks good to me, I think it was what was suggested in first replies to my SRCREV change and I agree with that, I just haven't had time to send updated patch.

Paul if you have the patch ready please send it, thanks!.

Quoted 104 lines · Paul Barker
Quoted 1 line · Khem Raj

On Wed, May 31, 2017 at 5:00 PM, Andrei Gherzan <[email protected]>

Quoted 6 lines · wrote:
Quoted 6 lines · Khem Raj
Quoted 4 lines
Quoted 1 line · Andre McCurdy

On Tue, May 30, 2017 at 10:15 AM, Paul Barker <

[email protected]>

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines · wrote:

On 30 May 2017 5:08 p.m., "Khem Raj" <[email protected]> wrote:

On Tue, May 30, 2017 at 12:57 AM, Martin Jansa <

[email protected]>

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines · wrote:

* use latest revision in rpi-4.11.y branch
* using AUTOREV causes bitbake to run git ls-remote on the

github.com

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

repository in order
to convert AUTOREV to currently latest SRCREV even when you

don't

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines

use
linux-raspberrypi_dev
at all, just happen to have meta-raspberrypi layer in your
bblayers.conf, that's bad for
people who want to be able to build without network access
(completely
from premirror)

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

These branches get rebased often so locking SRCREV caused another kind of problem. what we can do is.

1. Let user like you override the SRCREC via a bbappend or conf

file.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

so change the assignment to ?=
2. Delete the recipe completely. We lose some of upstream testing.

We should be able to skip the recipe if it isn't selected as the preferred
version and/or provider of "virtual/kernel". I'm out at the minute

so

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 5 lines
Quoted 2 lines

can't
look at it now but will try to take a look later this week.

The linux-yocto-dev.bb recipe contains an example of doing that.

ah perfect. Thats what we need here

http://cgit.openembedded.org/openembedded-core/tree/meta/rec

ipes-kernel/linux/linux-yocto-dev.bb?h=master#n28

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

please rename the recipe to be linux-raspberrypi-dev.bb and add the

magic

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

above and send a v2

Using the magic above we still hardcode a revision there. So if a user

wants

Quoted 1 line
Quoted 1 line

to compile the recipe without setting the preferred provider it will

fail.

Quoted 9 lines

what will be the usecase ? when you have a different kernel selected but woould like to compile yet another kernel

that rev can be a well known rev like branchpoint. Moreover, I think if someone wants to use the dev recipe then its expected that they switch
to using AUTOREV or some other local mechanism for pinning if needed.

I was thinking of a different approach entirerly. We can add the following at the top of the recipe file:

python __anonymous() {
if "linux-raspberrypi-dev" not in
d.getVar("PREFERRED_PROVIDER_virtual/kernel"):
msg = "Skipping linux-raspberrypi-dev as it is not the preferred
" + \
"provider of virtual/kernel."
raise bb.parse.SkipRecipe(msg)
}

(Hopefully gmail won't mangle that too much)

I've just tested it and it works fine as long as it's before the use of ${AUTOREV}. If there's no objections to this approach I'll submit a patch.

Cheers,

--
Paul Barker
Co-Founder & Principal Engineer
Togán Labs Ltd
--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#10 lore raw
Quoted 4 lines · Martin Jansa

And it's not clear from the diff you send, but like linux-yocto-dev.bb example above, the recipe needs to be renamed from linux-raspberrypi_dev.bb to linux-raspberrypi-dev.bb to make it different provider.

Quoted 8 lines
Quoted 7 lines · Martin Jansa

Yes, Paul approach looks good to me, I think it was what was suggested in first replies to my SRCREV change and I agree with that, I just haven't had time to send updated patch.

Paul if you have the patch ready please send it, thanks!.

I've submitted the patch via GitHub as per the new contributing instructions for meta-raspberrypi.

https://github.com/agherzan/meta-raspberrypi/pull/82

Cheers,

Signature · 3 lines
Paul Barker
Co-Founder & Principal Engineer
Togán Labs Ltd
#11 lore raw
Quoted 16 lines · Paul Barker
Quoted 2 lines · Martin Jansa

And it's not clear from the diff you send, but like linux-yocto-dev.bb example above, the recipe needs to be renamed from

linux-raspberrypi_dev.bb

Quoted 3 lines

to linux-raspberrypi-dev.bb to make it different provider.

On Thu, Jun 1, 2017 at 9:08 AM, Martin Jansa <[email protected]>

Quoted 2 lines · wrote:
Quoted 2 lines

Yes, Paul approach looks good to me, I think it was what was suggested

in

Quoted 1 line
Quoted 1 line

first replies to my SRCREV change and I agree with that, I just haven't

had

Quoted 2 lines
Quoted 2 lines

time to send updated patch.

Quoted 9 lines
Quoted 2 lines
Quoted 2 lines

Paul if you have the patch ready please send it, thanks!.

I've submitted the patch via GitHub as per the new contributing instructions for meta-raspberrypi.

https://github.com/agherzan/meta-raspberrypi/pull/82

Funny. This was exactly what I wanted to propose. If the warning noise does not bother anyone, I'm up for this solution.

PR merged to master.

--
Andrei Gherzan