qcow2: persistent dirty bitmaps
v19 cover qcow2: persistent dirty bitmaps
Hi all!
There is a new update of qcow2-bitmap series - v19.
web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v19
git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v19)
v19:
rebased on master
05: move 'sign-off' over 'reviewed-by's
08: error_report -> error_setg in qcow2_truncate (because of rebase) 09: return EPERM in bdrv_aligned_pwritev and bdrv_co_pdiscard if there
are readonly bitmaps. EPERM is chosen because it is already used for readonly image in bdrv_co_pdiscard.
Also handle readonly bitmap in block_dirty_bitmap_clear_prepare and qmp_block_dirty_bitmap_clear
Max's r-b is not added
10: fix grammar in comment
add Max's r-b
12, 13, 15, 21: add Max's r-b
24: fix grammar in comment
25: fix grammar and wording in comment
also, I see contextual changes in inactiavate mechanism. Hope, they do not affect these series.
v18:
rebased on master (sorry for v17)
08: contextual: qcow2_do_open is changed instead of qcow2_open
rename s/need_update_header/update_header/ in qcow2_do_open, to not do it in 10
save r-b's by Max and John
09: new patch
10: load_bitmap_data: do not clear bitmap parameter - it should be already cleared
(it actually created before single load_bitmap_data() call)
if some bitmaps are loaded, but we can't write the image (it is readonly
or inactive), so we can't mark bitmaps "in use" in the image, mark
corresponding BdrvDirtyBitmap read-only.
change error_setg to error_setg_errno for "Can't update bitmap directory"
no needs to rename s/need_update_header/update_header/ here, as it done in 08
13: function bdrv_has_persistent_bitmaps becomes bdrv_has_changed_persistent_bitmaps,
to handle readonly field.
14: declaration moved to the bottom of .h, save r-b's
15: firstly check bdrv_has_changed_persistent_bitmaps and only then fail on !can_write, and then QSIMPLEQ_INIT(&drop_tables)
skip readonly bitmaps in saving loop
18: remove '#optional', 2.9 -> 2.10, save r-b's
19: remove '#optional', 2.9 -> 2.10, save r-b's
20: 2.9 -> 2.10, save r-b's
21: add check of read-only image open, drop r-b's
24: add comment to qapi/block-core.json, that block-dirty-bitmap-add removes bitmap
from storage. r-b's by Max and John saved
v17:
08: add r-b's by Max and John
09: clear unknown autoclear features from BDRVQcow2State before calling
qcow2_load_autoloading_dirty_bitmaps(), and also do not extra update header if it is updated by qcow2_load_autoloading_dirty_bitmaps().
11: new patch, splitted out from 16
12: rewrite commit message
14: changing bdrv_close moved to separate new patch 11
s/1/1ULL/ ; s/%u/%llu/ for two errors
16: s/No/Not/
add Max's r-b
24: new patch
v16:
mostly by Kevin's comments:
07: just moved here, as preparation for merging refcounts to 08
08: move "qcow2-bitmap: refcounts" staff to this patch, to not break qcow2-img check
drop r-b's
move necessary supporting static functions to this patch too (to not break compilation) fprintf -> error_report
other small changes with error messages and comments
code style
for qcow2-bitmap.c:
'include "exec/log.h"' was dropped
s/1/(1U << 0) for BME_FLAG_IN_USE
add BME_TABLE_ENTRY_FLAG_ALL_ONES to replace magic 1
don't check 'cluster_size <= 0' in check_table_entry
old "[PATCH v15 08/25] block: introduce auto-loading bitmaps" was dropped
09: was "[PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps"
drop r-b's
some staff was moved to 08
update_header_sync - error on bdrv_flush fail
rename disk_sectors_in_bitmap_cluster to sectors_covered_by_bitmap_cluster
and adjust comment.
so, variable for storing this function result: s/dsc/sbc/
s/1/BME_TABLE_ENTRY_FLAG_ALL_ONES/
also, as Qcow2BitmapTable already introduced in 08,
s/table_offset/table.offset/ and s/table_size/table.size, etc..
update_ext_header_and_dir_in_place: add comments, add additional
update_header_sync, to reduce indeterminacy in case of error.
call qcow2_load_autoloading_dirty_bitmaps directly from qcow2_open
no .bdrv_load_autoloading_dirty_bitmaps
11: drop bdrv_store_persistent_dirty_bitmaps at all.
drop r-b's
13: rename patch, rewrite commit msg
drop r-b's
move bdrv_release_named_dirty_bitmaps in bdrv_close() after drv->bdrv_close() Qcow2BitmapTable is already introduced, so no
s/table_offset/table.offset/ and s/table_size/table.size, etc.. here
old 25 with check_constraints_on_bitmap() improvements merged here (Eric)
like in 09, s/dsc/sbc/ and s/disk_sectors_in_bitmap_cluster/sectors_covered_by_bitmap_cluster/ no .bdrv_store_persistent_dirty_bitmaps
call qcow2_store_persistent_dirty_bitmaps directly from qcow2_inactivate
15: corresponding part of 25 merged here. Add John's r-b, as 25 was also reviewed by John. 16: add John's r-b
v15:
13,14: add John's r-b
15: qcow2_can_store_new_dirty_bitmap:
- check max dirty bitmaps and bitmap directory overhead
- switch to error_prepend
rm Max's r-b
not add John's r-b
17-24: add John's r-b
25: changed because 15 changed,
not add John's r-b
v14:
07: use '|=' to update need_update_header
add John's r-b
add Max's r-b
09: remove unused bitmap_table_to_cpu()
left Max's r-b, hope it's ok
add John's r-b
10: remove extra new line
add John's r-b
11: add John's r-b
12: add John's r-b
13: small fixes by John's review:
- remove weird g_free of NULL pointer from
if (tb == NULL) {
g_free(tb);
return -EINVAL;
}
- remove extra comment "/* errp is already set */"
- s/"Too large bitmap directory"/"Bitmap directory is too large"/
left Max's r-b, hope you don't mind
22: add Max's r-b
23: add Max's r-b
24: add Max's r-b
25: new patch to improve error message on check_constraints_on_bitmap fail
v13: Just a fix for style checker.
13: line over 80
14: line over 80
22: s/if () \n{/if () {/
v12:
07: do not update header in qcow2_read_extensions, instead do it in the
end of qcow2_open, where it is updated also to clear unknown autoclear features.
Wrong bdrv_is_root_node used instead of bdrv_is_read_only is fixed automatically.
08: add Max's r-b
09: contextual: s/raw_bsd/raw-format/
qcow2-bitmap.c: copyright s/2016/2017/
fix compilation: move update_header_sync() to this patch
add Max's r-b
13: update_header_sync() is moved to 09
add Max's r-b
15: add Max's r-b
16: As qmp-commands.txt is removed from master, remove it here too.
Sentence "For now only Qcow2 disks support persistent bitmaps.
Default is false." moved to qapi/block-core.json.
Hope that is OK, Max's r-b is not dropped.
17: qmp-commands.txt deleted, r-b is not dropped too.
18: s/is failed/has failed/, add Max's r-b
19: copyright: s/2016/2017/
21: drop "res->corruptions > 0 => ret = -EINVAL", add Max's r-b
22: actually, patch is replaced with a new one, however some parts are the same.
instead of changing bdrv_release_dirty_bitmap behaviour, create new bdrv_remove_persistent_dirty_bitmap
23: improve comment, about not-exists is not an error
24: new patch
Old 24 (qcow2-bitmap: cache bitmap list in BDRVQcow2State) will be sent separately, to be applied after these series.
Also: about bdrv_dirty_bitmap_set_persistance: I've decided not change its behaviour for now and just call bdrv_remove_persistent_dirty_bitmap from qmp_block_dirty_bitmap_remove. Reasons:
1. Do not change reviewed part.
2. I'm not sure, that this complication of BdrvDirtyBitmap.persistent semantics is good (current semantics are just: .persistent means that bitmap should be saved on disk close). .persistent actually is not very related to "is there stored version of the bitmap in the image".
3. It may be done later.
4. It is not actually needed for now, as the only usage is dropping bitmap in bdrv_remove_persistent_dirty_bitmap. May be in future it will be needed, when we will have qmp interfaces for finer control of persistent dirty bitmaps.
v11:
Fix automatic build test fail.
18: wording - "ASCII representation of SHA256 ..."
24: fix redeclaration error. (This is still RFC, may be not needed patch,
see description in v10 below).
v10:
07: rm John's r-b
not add Max's r-b
fix subject s/dirty bitmaps/bitmaps
improve WARNING message
remove header ext if autoclear bit is unset, through qcow2_updata_header() - r-b blocking change
08: move bdrv_load_autoloading_dirty_bitmaps under asserts block (Max)
fix typo in commit message
move bdrv_load_autoloading_dirty_bitmaps after asserts
John's r-b
09: rewrite check_dir_entry
remove extra feature cluster_size=0 from check_table_entry
which clears autoclear bit before trying to update bitmap directory bitmap_list_store - do not free old clusters if in_place=true
changes in comments, fix indents
add functions
bitmap_list_count
update_ext_header_and_dir_in_place (unset autoclear bit before trying to
modify bitmap directory)
(for usage in qcow2_load_autoloading_dirty_bitmaps)
11: add node name to error report
Max's r-b
13: add type Qcow2BitmapTable
move from bm.table_* to bm.table.*
rewrite check_constraints_on_bitmap
flush(bs->file) instead of flush(bs) in update_ext_header_and_dir assert(DIV_ROUND_UP(bm_size, dsc) == tb_size);
and assert(write_size <= s->cluster_size); in store_bitmap_data
fix: s/tb_size/tb_size * sizeof(tb[0]) in store_bitmap
in qcow2_store_persistent_dirty_bitmaps:
fail if !can_write
fix counting of new_nb_bitmaps and new_dir_size
free old clusters _after_ successful directory update (aggregate old bitmap
tables into drop_tables)
2 14: rename to can_store_new_dirty_bitmap
Max's r-b
15: rename to can_store_new_dirty_bitmap
rm extra !!
16: Max's r-b
rename to can_store_new_dirty_bitmap
indenting
Since s/2.8/2.9
17: Max's r-b
Since s/2.8/2.9
18: hashing can fail in comment for qapi
Since s/2.8/2.9
remove dead comment
19: indentation
Max's r-b
20: Max's r-b
21: fix error handling
return 0 if nb_bitmaps == 0
new patches:
22-23: remove bitmap from file on bdrv_release_dirty_bitmap
24: experimental, RFC: cache bitmap list to bs, to not reload it from file.
I'm not sure that is needed now, but if you want I can merge it to earlier patches.
v9:
rebase on master!
01-04,06,07: John's r-b
03: rewording in comment ("The concurrent resetting ..."), John's r-b 07: reword error messages
commit message: dirty bitmap -> bitmap
09: fix uninitialized ret in bitmap_list_store() (fix compilation warning) 18: fix compilation of tests/test-hbitmap
also, change constants names for qcow2: DIRTY_BITMAP -> BITMAP (as it is not dirty bitmaps extension, but just bitmaps extension), QCOW -> QCOW2 (bitmaps are only for qcow2)
v8:
Patches 01-06 are mostly unchanged, except for spelling and wording. 02 - add Eric's r-b
03,04 - add Max's r-b
07-09 is refactored "bitmap-read" part of the feature. Main changes:
- introduce bitmap list - normal list, which represents bitmap directory. Function bitmap_list_load loads bitmap directory, checks everything and creates normal list.
- introduce .bdrv_load_autoloading_dirty_bitmaps : instead of loading bitmaps in qcow2_open, lets load them only in bdrv_open, to avoid reloading in bdrv_snapshot_goto
- do not delete bitmaps after read, but mark them IN_USE
10 has contextual changes and rewording of comment. I've added Max's r-b, hope it's ok.
11: add error_report("Persistent bitmaps are lost") in case of failed bitmap store
12: add Max's r-b
13 is refactored "bitmap-store" part of the feature. see 07-09 description
- for now I just free old clusters and allocate new. This will be improved with a separate patch.
patch about "delete bitmaps on truncate" is removed. This case will be handled later. IN_USE, autoclear, check-constraints things are merged into other patches.
14-15 are mew patches, to early check possibility of creating persistent bitmap with
specified name and granularity in specified BDS
16-17: spelling, rewording, indenting, tiny code simplifying, check can_store (by 14-15),
s/if (autoload && !persistent)/if (has_autoload && !persistent)/, rebase (deleted qmp-commands.hx)
18: alternative to md5 in query-block:
- separated qmp command -x-debug-block-dirty-bitmap-sha256
- as adviced by Daniel P. Berrange in my parallel thread:
- sha256 instead of md5
- use qcrypto_hash_* instead of GChecksum
- fix bug =) (size was wrong in hbitmap_md5)
19: s/3999/3fff/, use x-debug-block-dirty-bitmap-sha256
20: new patch to rename and publish inc_refcounts
21: some fixes and refactoring mostyly by Max's comments.
Max, Eric, great tanks for your review!
I hope, I've covered most of your comments by this update.
TODO:
- handle reopening image RO->RW and incoming migration, set IN_USE for existing loaded bitmaps in these cases.
- reuse old, already allocated data clusters for bitmaps storing
- truncate bitmaps in the image on truncate
v7:
https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=refs%2Ftags%2Fqcow2-bitmap-v7
based on block-next (https://github.com/XanClic/qemu/commits/block-next)
- a lot of refactoring and reordering of patches.
- dead code removed (bdrv_dirty_bitmap_load, etc.)
- do not maintain extra data for now
- do not store dirty bitmap directory in memory (as we use it seldom, we can just reread if needed)
By Kevin's review:
01 - commit message changed: fix->improvement (as it was not a bug) 03 - r-b
04 - r-b
05 - add 21 patch to fix spec, also, removed all (I hope) mentions of
"Bitmap Header", switch to one unified name for it - "Bitmap Directory Entry", to avoid misunderstanding with Qcow2 header. (also, add patch 22, to fix it in spec)
v6.06 - improve for_each_dir_entry loop, reorder patches, other small fixes v6.07 ~> v7.09 - dead code removed, I've moved to one function
.bdrv_store_persistent_bitmaps and have wrapper and callback in one patch (with also some other staff. If it not ok, I can split them)
v6.08 - about keeping bitmap directory instead of bitmap list: no I don't keep
it at all.
v6.16 - old bdrv_ bitmap-storing related functions are removed. The new one is
bdrv_store_persistent_bitmaps.
v6:
https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=refs%2Ftags%2Fqcow2-bitmap-v6
based on block-next (https://github.com/XanClic/qemu/commits/block-next)
There are a lot of changes, reorderings and additions in comparement with v5. One principal thing: now bitmaps are removed from image after loading instead of marking them in_use. It is simpler and we do not need to store superfluous data. Also, we are no more interested in command line interface to dirty bitmaps. So it is dropped. If someone needs it I can add it later.
Vladimir Sementsov-Ogievskiy (25):
specs/qcow2: fix bitmap granularity qemu-specific note specs/qcow2: do not use wording 'bitmap header'
hbitmap: improve dirty iter
tests: add hbitmap iter test
block: fix bdrv_dirty_bitmap_granularity signature block/dirty-bitmap: add deserialize_ones func
qcow2-refcount: rename inc_refcounts() and make it public
qcow2: add bitmaps extension
block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
qcow2: autoloading dirty bitmaps block/dirty-bitmap: add autoload field to BdrvDirtyBitmap
block: bdrv_close: release bitmaps after drv->bdrv_close
block: introduce persistent dirty bitmaps block/dirty-bitmap: add bdrv_dirty_bitmap_next()
qcow2: add persistent dirty bitmaps support
block: add bdrv_can_store_new_dirty_bitmap
qcow2: add .bdrv_can_store_new_dirty_bitmap
qmp: add persistent flag to block-dirty-bitmap-add
qmp: add autoload parameter to block-dirty-bitmap-add
qmp: add x-debug-block-dirty-bitmap-sha256
iotests: test qcow2 persistent dirty bitmap block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap
qcow2: add .bdrv_remove_persistent_dirty_bitmap
qmp: block-dirty-bitmap-remove: remove persistent
block: release persistent bitmaps on inactivate
block.c | 32 +- block/Makefile.objs | 2 +- block/dirty-bitmap.c | 137 ++++- block/io.c | 8 + block/qcow2-bitmap.c | 1397 ++++++++++++++++++++++++++++++++++++++++++ block/qcow2-refcount.c | 59 +- block/qcow2.c | 149 ++++- block/qcow2.h | 41 ++ blockdev.c | 77 ++- docs/specs/qcow2.txt | 8 +- include/block/block.h | 3 + include/block/block_int.h | 8 + include/block/dirty-bitmap.h | 26 +- include/qemu/hbitmap.h | 49 +- qapi/block-core.json | 42 +- tests/Makefile.include | 2 +- tests/qemu-iotests/165 | 105 ++++ tests/qemu-iotests/165.out | 5 + tests/qemu-iotests/group | 1 + tests/test-hbitmap.c | 19 + util/hbitmap.c | 51 +- 21 files changed, 2147 insertions(+), 74 deletions(-) create mode 100644 block/qcow2-bitmap.c create mode 100755 tests/qemu-iotests/165 create mode 100644 tests/qemu-iotests/165.out
Signature · 1 line
2.11.1
PATCH v19 1/25 specs/qcow2: fix bitmap granularity qemu-specific note
--- docs/specs/qcow2.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
docs/specs/qcow2.txt +1 -2
@@ -472,8 +472,7 @@ Structure of a bitmap directory entry: 17: granularity_bits Granularity bits. Valid values: 0 - 63. - Note: Qemu currently doesn't support granularity_bits - greater than 31. + Note: Qemu currently supports only values 9 - 31. Granularity is calculated as granularity = 1 << granularity_bits
Signature · 1 line
2.11.1
PATCH v19 2/25 specs/qcow2: do not use wording 'bitmap header'
In reply to Vladimir Sementsov-OgievskiyA bitmap directory entry is sometimes called a 'bitmap header'. This patch leaves only one name - 'bitmap directory entry'. The name 'bitmap header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap header extension' (which is extension of qcow2 header)
--- docs/specs/qcow2.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
docs/specs/qcow2.txt +2 -3
@@ -201,7 +201,7 @@ The fields of the bitmaps extension are: 8 - 15: bitmap_directory_size Size of the bitmap directory in bytes. It is the cumulative - size of all (nb_bitmaps) bitmap headers. + size of all (nb_bitmaps) bitmap directory entries. 16 - 23: bitmap_directory_offset Offset into the image file at which the bitmap directory
@@ -426,8 +426,7 @@ Each bitmap saved in the image is described in a bitmap directory entry. The bitmap directory is a contiguous area in the image file, whose starting offset and length are given by the header extension fields bitmap_directory_offset and bitmap_directory_size. The entries of the bitmap directory have variable -length, depending on the lengths of the bitmap name and extra data. These -entries are also called bitmap headers. +length, depending on the lengths of the bitmap name and extra data. Structure of a bitmap directory entry:
Signature · 1 line
2.11.1
PATCH v19 3/25 hbitmap: improve dirty iter
In reply to Vladimir Sementsov-OgievskiyMake dirty iter resistant to resetting bits in corresponding HBitmap.
--- include/qemu/hbitmap.h | 26 ++++---------------------- util/hbitmap.c | 23 ++++++++++++++++++++++- 2 files changed, 26 insertions(+), 23 deletions(-)
include/qemu/hbitmap.h +4 -22
@@ -256,10 +256,9 @@ void hbitmap_free(HBitmap *hb);* the lowest-numbered bit that is set in @hb, starting at @first. * * Concurrent setting of bits is acceptable, and will at worst cause the -* iteration to miss some of those bits. Resetting bits before the current -* position of the iterator is also okay. However, concurrent resetting of -* bits can lead to unexpected behavior if the iterator has not yet reached -* those bits. +* iteration to miss some of those bits. +* +* The concurrent resetting of bits is OK. */ void hbitmap_iter_init (HBitmapIter *hbi,const HBitmap *hb,uint64_t first);
@@ -298,24 +297,7 @@ void hbitmap_free_meta(HBitmap *hb);* Return the next bit that is set in @hbi's associated HBitmap, * or -1 if all remaining bits are zero. */ -static inline int64_t hbitmap_iter_next (HBitmapIter *hbi) -{ -unsigned long cur = hbi->cur[HBITMAP_LEVELS -1 ]; -int64_t item; - -if (cur ==0 ) { - cur =hbitmap_iter_skip_words (hbi); -if (cur ==0 ) { -return -1 ; - } - } - -/* The next call will resume work from the next bit. */ - hbi->cur[HBITMAP_LEVELS -1 ] = cur & (cur -1 ); - item = ((uint64_t )hbi->pos <<BITS_PER_LEVEL ) +ctzl (cur); - -return item << hbi->granularity; -} +int64_t hbitmap_iter_next (HBitmapIter *hbi);/** * hbitmap_iter_next_word:
util/hbitmap.c +22 -1
@@ -106,8 +106,9 @@ unsigned long hbitmap_iter_skip_words(HBitmapIter *hbi)unsigned long cur;do { - cur = hbi->cur[--i]; + i--; pos >>=BITS_PER_LEVEL ; + cur = hbi->cur[i] & hb->levels[i][pos]; }while (cur ==0 );/* Check for end of iteration. We always use fewer than BITS_PER_LONG
@@ -139,6 +140,26 @@ unsigned long hbitmap_iter_skip_words(HBitmapIter *hbi)return cur; } +int64_t hbitmap_iter_next (HBitmapIter *hbi) +{ +unsigned long cur = hbi->cur[HBITMAP_LEVELS -1 ] & + hbi->hb->levels[HBITMAP_LEVELS -1 ][hbi->pos]; +int64_t item; + +if (cur ==0 ) { + cur =hbitmap_iter_skip_words (hbi); +if (cur ==0 ) { +return -1 ; + } + } + +/* The next call will resume work from the next bit. */ + hbi->cur[HBITMAP_LEVELS -1 ] = cur & (cur -1 ); + item = ((uint64_t )hbi->pos <<BITS_PER_LEVEL ) +ctzl (cur); + +return item << hbi->granularity; +} +void hbitmap_iter_init (HBitmapIter *hbi,const HBitmap *hb,uint64_t first) {unsigned i, bit;
Signature · 1 line
2.11.1
PATCH v19 4/25 tests: add hbitmap iter test
In reply to Vladimir Sementsov-OgievskiyTest that hbitmap iter is resistant to bitmap resetting.
--- tests/test-hbitmap.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
tests/test-hbitmap.c +19 -0
@@ -909,6 +909,22 @@ static void hbitmap_test_add(const char *testpath, hbitmap_test_teardown); } +static void test_hbitmap_iter_and_reset (TestHBitmapData *data, +const void *unused) +{ +HBitmapIter hbi; + +hbitmap_test_init (data,L1 *2 ,0 ); +hbitmap_set (data->hb,0 , data->size); + +hbitmap_iter_init (&hbi, data->hb,BITS_PER_LONG -1 ); + +hbitmap_iter_next (&hbi); + +hbitmap_reset_all (data->hb); +hbitmap_iter_next (&hbi); +} +int main (int argc,char **argv) {g_test_init (&argc, &argv,NULL );
@@ -966,6 +982,9 @@ int main(int argc, char **argv) test_hbitmap_serialize_part);hbitmap_test_add ("/hbitmap/serialize/zeroes" , test_hbitmap_serialize_zeroes); + +hbitmap_test_add ("/hbitmap/iter/iter_and_reset" , + test_hbitmap_iter_and_reset);g_test_run ();return 0 ;
Signature · 1 line
2.11.1
PATCH v19 5/25 block: fix bdrv_dirty_bitmap_granularity signature
In reply to Vladimir Sementsov-OgievskiyMake getter signature const-correct. This allows other functions with const dirty bitmap parameter use bdrv_dirty_bitmap_granularity().
--- block/dirty-bitmap.c | 2 +- include/block/dirty-bitmap.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
block/dirty-bitmap.c +1 -1
@@ -388,7 +388,7 @@ uint32_t bdrv_get_default_bitmap_granularity(BlockDriverState *bs)return granularity; } -uint32_t bdrv_dirty_bitmap_granularity (BdrvDirtyBitmap *bitmap) +uint32_t bdrv_dirty_bitmap_granularity (const BdrvDirtyBitmap *bitmap) {return BDRV_SECTOR_SIZE <<hbitmap_granularity (bitmap->bitmap); }
include/block/dirty-bitmap.h +1 -1
@@ -29,7 +29,7 @@ void bdrv_disable_dirty_bitmap(BdrvDirtyBitmap *bitmap);void bdrv_enable_dirty_bitmap (BdrvDirtyBitmap *bitmap);BlockDirtyInfoList *bdrv_query_dirty_bitmaps (BlockDriverState *bs);uint32_t bdrv_get_default_bitmap_granularity (BlockDriverState *bs); -uint32_t bdrv_dirty_bitmap_granularity (BdrvDirtyBitmap *bitmap); +uint32_t bdrv_dirty_bitmap_granularity (const BdrvDirtyBitmap *bitmap);uint32_t bdrv_dirty_bitmap_meta_granularity (BdrvDirtyBitmap *bitmap);bool bdrv_dirty_bitmap_enabled (BdrvDirtyBitmap *bitmap);bool bdrv_dirty_bitmap_frozen (BdrvDirtyBitmap *bitmap);
Signature · 1 line
2.11.1
PATCH v19 6/25 block/dirty-bitmap: add deserialize_ones func
In reply to Vladimir Sementsov-OgievskiyAdd bdrv_dirty_bitmap_deserialize_ones() function, which is needed for qcow2 bitmap loading, to handle unallocated bitmap parts, marked as all-ones.
--- block/dirty-bitmap.c | 7 +++++++ include/block/dirty-bitmap.h | 3 +++ include/qemu/hbitmap.h | 15 +++++++++++++++ util/hbitmap.c | 17 +++++++++++++++++ 4 files changed, 42 insertions(+)
block/dirty-bitmap.c +7 -0
@@ -499,6 +499,13 @@ void bdrv_dirty_bitmap_deserialize_zeroes(BdrvDirtyBitmap *bitmap,hbitmap_deserialize_zeroes (bitmap->bitmap, start, count, finish); } +void bdrv_dirty_bitmap_deserialize_ones (BdrvDirtyBitmap *bitmap, +uint64_t start,uint64_t count, +bool finish) +{ +hbitmap_deserialize_ones (bitmap->bitmap, start, count, finish); +} +void bdrv_dirty_bitmap_deserialize_finish (BdrvDirtyBitmap *bitmap) {hbitmap_deserialize_finish (bitmap->bitmap);
include/block/dirty-bitmap.h +3 -0
@@ -70,6 +70,9 @@ void bdrv_dirty_bitmap_deserialize_part(BdrvDirtyBitmap *bitmap,void bdrv_dirty_bitmap_deserialize_zeroes (BdrvDirtyBitmap *bitmap,uint64_t start,uint64_t count,bool finish); +void bdrv_dirty_bitmap_deserialize_ones (BdrvDirtyBitmap *bitmap, +uint64_t start,uint64_t count, +bool finish);void bdrv_dirty_bitmap_deserialize_finish (BdrvDirtyBitmap *bitmap);#endif
include/qemu/hbitmap.h +15 -0
@@ -229,6 +229,21 @@ void hbitmap_deserialize_zeroes(HBitmap *hb, uint64_t start, uint64_t count, bool finish);/** +* hbitmap_deserialize_ones +* @hb: HBitmap to operate on. +* @start: First bit to restore. +* @count: Number of bits to restore. +* @finish: Whether to call hbitmap_deserialize_finish automatically. +* +* Fills the bitmap with ones. +* +* If @finish is false, caller must call hbitmap_serialize_finish before using +* the bitmap. +*/ +void hbitmap_deserialize_ones (HBitmap *hb,uint64_t start,uint64_t count, +bool finish); + +/** * hbitmap_deserialize_finish * @hb: HBitmap to operate on. *
util/hbitmap.c +17 -0
@@ -551,6 +551,23 @@ void hbitmap_deserialize_zeroes(HBitmap *hb, uint64_t start, uint64_t count, } } +void hbitmap_deserialize_ones (HBitmap *hb,uint64_t start,uint64_t count, +bool finish) +{ +uint64_t el_count; +unsigned long *first; + +if (!count) { +return ; + } +serialization_chunk (hb, start, count, &first, &el_count); + +memset (first,0xff , el_count *sizeof (unsigned long )); +if (finish) { +hbitmap_deserialize_finish (hb); + } +} +void hbitmap_deserialize_finish (HBitmap *bitmap) {int64_t i, size, prev_size;
Signature · 1 line
2.11.1
PATCH v19 7/25 qcow2-refcount: rename inc_refcounts() and make it public
In reply to Vladimir Sementsov-OgievskiyThis is needed for the following patch, which will introduce refcounts checking for qcow2 bitmaps.
--- block/qcow2-refcount.c | 53 ++++++++++++++++++++++++++------------------------ block/qcow2.h | 4 ++++ 2 files changed, 32 insertions(+), 25 deletions(-)
block/qcow2-refcount.c +28 -25
@@ -1323,11 +1323,10 @@ static int realloc_refcount_array(BDRVQcow2State *s, void **array,* * Modifies the number of errors in res. */ -static int inc_refcounts (BlockDriverState *bs, -BdrvCheckResult *res, -void **refcount_table, -int64_t *refcount_table_size, -int64_t offset,int64_t size) +int qcow2_inc_refcounts_imrt (BlockDriverState *bs,BdrvCheckResult *res, +void **refcount_table, +int64_t *refcount_table_size, +int64_t offset,int64_t size) {BDRVQcow2State *s = bs->opaque;uint64_t start, last, cluster_offset, k, refcount;
@@ -1420,8 +1419,9 @@ static int check_refcounts_l2(BlockDriverState *bs, BdrvCheckResult *res, nb_csectors = ((l2_entry >> s->csize_shift) & s->csize_mask) +1 ; l2_entry &= s->cluster_offset_mask; - ret =inc_refcounts (bs, res, refcount_table, refcount_table_size, - l2_entry & ~511 , nb_csectors *512 ); + ret =qcow2_inc_refcounts_imrt (bs, res, + refcount_table, refcount_table_size, + l2_entry & ~511 , nb_csectors *512 );if (ret <0 ) { goto fail; }
@@ -1454,8 +1454,9 @@ static int check_refcounts_l2(BlockDriverState *bs, BdrvCheckResult *res, }/* Mark cluster as used */ - ret =inc_refcounts (bs, res, refcount_table, refcount_table_size, - offset, s->cluster_size); + ret =qcow2_inc_refcounts_imrt (bs, res, + refcount_table, refcount_table_size, + offset, s->cluster_size);if (ret <0 ) { goto fail; }
@@ -1508,8 +1509,8 @@ static int check_refcounts_l1(BlockDriverState *bs, l1_size2 = l1_size *sizeof (uint64_t );/* Mark L1 table as used */ - ret =inc_refcounts (bs, res, refcount_table, refcount_table_size, - l1_table_offset, l1_size2); + ret =qcow2_inc_refcounts_imrt (bs, res, refcount_table, refcount_table_size, + l1_table_offset, l1_size2);if (ret <0 ) { goto fail; }
@@ -1538,8 +1539,9 @@ static int check_refcounts_l1(BlockDriverState *bs,if (l2_offset) {/* Mark L2 table as used */ l2_offset &=L1E_OFFSET_MASK ; - ret =inc_refcounts (bs, res, refcount_table, refcount_table_size, - l2_offset, s->cluster_size); + ret =qcow2_inc_refcounts_imrt (bs, res, + refcount_table, refcount_table_size, + l2_offset, s->cluster_size);if (ret <0 ) { goto fail; }
@@ -1757,14 +1759,15 @@ static int check_refblocks(BlockDriverState *bs, BdrvCheckResult *res, } res->corruptions_fixed++; - ret =inc_refcounts (bs, res, refcount_table, nb_clusters, - offset, s->cluster_size); + ret =qcow2_inc_refcounts_imrt (bs, res, + refcount_table, nb_clusters, + offset, s->cluster_size);if (ret <0 ) {return ret; }/* No need to check whether the refcount is now greater than 1: * This area was just allocated and zeroed, so it can only be -* exactly 1 after inc_refcounts() */ +* exactly 1 after qcow2_inc_refcounts_imrt() */ continue ; resize_fail:
@@ -1779,8 +1782,8 @@ resize_fail: }if (offset !=0 ) { - ret =inc_refcounts (bs, res, refcount_table, nb_clusters, - offset, s->cluster_size); + ret =qcow2_inc_refcounts_imrt (bs, res, refcount_table, nb_clusters, + offset, s->cluster_size);if (ret <0 ) {return ret; }
@@ -1820,8 +1823,8 @@ static int calculate_refcounts(BlockDriverState *bs, BdrvCheckResult *res, }/* header */ - ret =inc_refcounts (bs, res, refcount_table, nb_clusters, -0 , s->cluster_size); + ret =qcow2_inc_refcounts_imrt (bs, res, refcount_table, nb_clusters, +0 , s->cluster_size);if (ret <0 ) {return ret; }
@@ -1842,16 +1845,16 @@ static int calculate_refcounts(BlockDriverState *bs, BdrvCheckResult *res,return ret; } } - ret =inc_refcounts (bs, res, refcount_table, nb_clusters, - s->snapshots_offset, s->snapshots_size); + ret =qcow2_inc_refcounts_imrt (bs, res, refcount_table, nb_clusters, + s->snapshots_offset, s->snapshots_size);if (ret <0 ) {return ret; }/* refcount data */ - ret =inc_refcounts (bs, res, refcount_table, nb_clusters, - s->refcount_table_offset, - s->refcount_table_size *sizeof (uint64_t )); + ret =qcow2_inc_refcounts_imrt (bs, res, refcount_table, nb_clusters, + s->refcount_table_offset, + s->refcount_table_size *sizeof (uint64_t ));if (ret <0 ) {return ret; }
block/qcow2.h +4 -0
@@ -527,6 +527,10 @@ int qcow2_check_metadata_overlap(BlockDriverState *bs, int ign, int64_t offset, int64_t size);int qcow2_pre_write_overlap_check (BlockDriverState *bs,int ign,int64_t offset,int64_t size); +int qcow2_inc_refcounts_imrt (BlockDriverState *bs,BdrvCheckResult *res, +void **refcount_table, +int64_t *refcount_table_size, +int64_t offset,int64_t size); int qcow2_change_refcount_order(BlockDriverState *bs, int refcount_order, BlockDriverAmendStatusCB *status_cb,
Signature · 1 line
2.11.1
PATCH v19 8/25 qcow2: add bitmaps extension
In reply to Vladimir Sementsov-OgievskiyAdd bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. Also, calculate refcounts for qcow2 bitmaps, to not break qemu-img check.
For now, disable image resize if it has bitmaps. It will be fixed later.
--- block/Makefile.objs | 2 +- block/qcow2-bitmap.c | 439 +++++++++++++++++++++++++++++++++++++++++++++++++ block/qcow2-refcount.c | 6 + block/qcow2.c | 124 +++++++++++++- block/qcow2.h | 27 +++ 5 files changed, 592 insertions(+), 6 deletions(-) create mode 100644 block/qcow2-bitmap.c
block/Makefile.objs +1 -1
@@ -1,5 +1,5 @@ block-obj-y += raw-format.o qcow.o vdi.o vmdk.o cloop.o bochs.o vpc.o vvfat.o dmg.o -block-obj-y += qcow2.o qcow2-refcount.o qcow2-cluster.o qcow2-snapshot.o qcow2-cache.o +block-obj-y += qcow2.o qcow2-refcount.o qcow2-cluster.o qcow2-snapshot.o qcow2-cache.o qcow2-bitmap.o block-obj-y += qed.o qed-gencb.o qed-l2-cache.o qed-table.o qed-cluster.o block-obj-y += qed-check.o block-obj-y += vhdx.o vhdx-endian.o vhdx-log.o
block/qcow2-bitmap.c new file +439 -0
439 lines not on this page · raw message
block/qcow2-refcount.c +6 -0
@@ -1859,6 +1859,12 @@ static int calculate_refcounts(BlockDriverState *bs, BdrvCheckResult *res,return ret; } +/* bitmaps */ + ret =qcow2_check_bitmaps_refcounts (bs, res, refcount_table, nb_clusters); +if (ret <0 ) { +return ret; + } +return check_refblocks (bs, res, fix, rebuild, refcount_table, nb_clusters); }
block/qcow2.c +119 -5
183 lines not on this page · raw message
block/qcow2.h +27 -0
@@ -52,6 +52,10 @@* space for snapshot names and IDs */ #define QCOW_MAX_SNAPSHOTS_SIZE (1024 * QCOW_MAX_SNAPSHOTS) +/* Bitmap header extension constraints */ +#define QCOW2_MAX_BITMAPS 65535 +#define QCOW2_MAX_BITMAP_DIRECTORY_SIZE (1024 * QCOW2_MAX_BITMAPS) +/* indicate that the refcount of the referenced cluster is exactly one. */ #define QCOW_OFLAG_COPIED (1ULL << 63)/* indicate that the cluster is compressed (they never have the copied flag) */
@@ -195,6 +199,14 @@ enum { QCOW2_COMPAT_FEAT_MASK = QCOW2_COMPAT_LAZY_REFCOUNTS, }; +/* Autoclear feature bits */ +enum { +QCOW2_AUTOCLEAR_BITMAPS_BITNR =0 , +QCOW2_AUTOCLEAR_BITMAPS =1 <<QCOW2_AUTOCLEAR_BITMAPS_BITNR , + +QCOW2_AUTOCLEAR_MASK =QCOW2_AUTOCLEAR_BITMAPS , +}; +enum qcow2_discard_type {QCOW2_DISCARD_NEVER =0 ,QCOW2_DISCARD_ALWAYS ,
@@ -222,6 +234,13 @@ typedef uint64_t Qcow2GetRefcountFunc(const void *refcount_array,typedef void Qcow2SetRefcountFunc (void *refcount_array,uint64_t index,uint64_t value); +typedef struct Qcow2BitmapHeaderExt { +uint32_t nb_bitmaps; +uint32_t reserved32; +uint64_t bitmap_directory_size; +uint64_t bitmap_directory_offset; +} QEMU_PACKED Qcow2BitmapHeaderExt; + typedef struct BDRVQcow2State { int cluster_bits; int cluster_size;
@@ -264,6 +283,10 @@ typedef struct BDRVQcow2State {unsigned int nb_snapshots;QCowSnapshot *snapshots; +uint32_t nb_bitmaps; +uint64_t bitmap_directory_size; +uint64_t bitmap_directory_offset; +int flags;int qcow_version;bool use_lazy_refcounts;
@@ -602,4 +625,8 @@ int qcow2_cache_get_empty(BlockDriverState *bs, Qcow2Cache *c, uint64_t offset, void **table);void qcow2_cache_put (BlockDriverState *bs,Qcow2Cache *c,void **table); +/* qcow2-bitmap.c functions */ +int qcow2_check_bitmaps_refcounts (BlockDriverState *bs,BdrvCheckResult *res, +void **refcount_table, +int64_t *refcount_table_size);#endif
Signature · 1 line
2.11.1
PATCH v19 9/25 block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
In reply to Vladimir Sementsov-OgievskiyIt will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be read-only.
--- block/dirty-bitmap.c | 28 ++++++++++++++++++++++++++++ block/io.c | 8 ++++++++ blockdev.c | 6 ++++++ include/block/dirty-bitmap.h | 4 ++++ 4 files changed, 46 insertions(+)
block/dirty-bitmap.c +28 -0
@@ -44,6 +44,8 @@ struct BdrvDirtyBitmap {int64_t size;/* Size of the bitmap (Number of sectors) */ bool disabled;/* Bitmap is read-only */ int active_iterators;/* How many iterators are active */ +bool readonly;/* Bitmap is read-only and may be changed only +by deserialize* functions */ QLIST_ENTRY (BdrvDirtyBitmap) list; };
@@ -436,6 +438,7 @@ void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) {assert (bdrv_dirty_bitmap_enabled (bitmap )); +assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_set (bitmap->bitmap, cur_sector, nr_sectors); }
@@ -443,12 +446,14 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) {assert (bdrv_dirty_bitmap_enabled (bitmap )); +assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_reset (bitmap->bitmap, cur_sector, nr_sectors); }void bdrv_clear_dirty_bitmap (BdrvDirtyBitmap *bitmap,HBitmap **out) {assert (bdrv_dirty_bitmap_enabled (bitmap)); +assert (!bdrv_dirty_bitmap_readonly (bitmap));if (!out) {hbitmap_reset_all (bitmap->bitmap); }else {
@@ -519,6 +524,7 @@ void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector,if (!bdrv_dirty_bitmap_enabled (bitmap)) {continue ; } +assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_set (bitmap->bitmap, cur_sector, nr_sectors); } }
@@ -540,3 +546,25 @@ int64_t bdrv_get_meta_dirty_count(BdrvDirtyBitmap *bitmap) {return hbitmap_count (bitmap->meta); } + +bool bdrv_dirty_bitmap_readonly (const BdrvDirtyBitmap *bitmap) +{ +return bitmap->readonly; +} + +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap) +{ + bitmap->readonly = true; +} + +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs) +{ +BdrvDirtyBitmap *bm; + QLIST_FOREACH(bm, &bs->dirty_bitmaps, list) { +if (bm->readonly) { +return true; + } + } + +return false; +}
block/io.c +8 -0
@@ -1349,6 +1349,10 @@ static int coroutine_fn bdrv_aligned_pwritev(BdrvChild *child,uint64_t bytes_remaining = bytes;int max_transfer; +if (bdrv_has_readonly_bitmaps (bs)) { +return -EPERM ; + } +assert (is_power_of_2 (align));assert ((offset & (align -1 )) ==0 );assert ((bytes & (align -1 )) ==0 );
@@ -2437,6 +2441,10 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs, int64_t offset,return -ENOMEDIUM ; } +if (bdrv_has_readonly_bitmaps (bs)) { +return -EPERM ; + } + ret =bdrv_check_byte_request (bs, offset, count);if (ret <0 ) {return ret;
blockdev.c +6 -0
@@ -2033,6 +2033,9 @@ static void block_dirty_bitmap_clear_prepare(BlkActionState *common, }else if (!bdrv_dirty_bitmap_enabled (state->bitmap)) {error_setg (errp,"Cannot clear a disabled bitmap" );return ; + }else if (bdrv_dirty_bitmap_readonly (state->bitmap)) { +error_setg (errp,"Cannot clear a readonly bitmap" ); +return ; }bdrv_clear_dirty_bitmap (state->bitmap, &state->backup);
@@ -2813,6 +2816,9 @@ void qmp_block_dirty_bitmap_clear(const char *node, const char *name,"Bitmap '%s' is currently disabled and cannot be cleared" , name); goto out; + }else if (bdrv_dirty_bitmap_readonly (bitmap)) { +error_setg (errp,"Bitmap '%s' is readonly and cannot be cleared" , name); + goto out; }bdrv_clear_dirty_bitmap (bitmap,NULL );
include/block/dirty-bitmap.h +4 -0
@@ -75,4 +75,8 @@ void bdrv_dirty_bitmap_deserialize_ones(BdrvDirtyBitmap *bitmap, bool finish);void bdrv_dirty_bitmap_deserialize_finish (BdrvDirtyBitmap *bitmap); +bool bdrv_dirty_bitmap_readonly (const BdrvDirtyBitmap *bitmap); +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap); +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs); +#endif
Signature · 1 line
2.11.1
Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
Quoted 27 lines · Vladimir Sementsov-Ogievskiy
It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be read-only.
Signed-off-by Vladimir Sementsov-Ogievskiy <[email protected]>--- block/dirty-bitmap.c | 28 ++++++++++++++++++++++++++++ block/io.c | 8 ++++++++ blockdev.c | 6 ++++++ include/block/dirty-bitmap.h | 4 ++++ 4 files changed, 46 insertions(+)block/dirty-bitmap.c +2
-0@@ -44,6 +44,8 @@ struct BdrvDirtyBitmap {int64_t size;/* Size of the bitmap (Number of sectors) */ bool disabled;/* Bitmap is read-only */ int active_iterators;/* How many iterators are active */ +bool readonly;/* Bitmap is read-only and may be changed only +by deserialize* functions */ QLIST_ENTRY (BdrvDirtyBitmap) list; };
block/dirty-bitmap.c void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, · line 441
Quoted 4 lines
block/dirty-bitmap.c +1
-0@@ -436,6 +438,7 @@ void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) {assert (bdrv_dirty_bitmap_enabled (bitmap )); +assert (!bdrv_dirty_bitmap_readonly (bitmap));
Not reasonable to add the condition for !readonly into bdrv_dirty_bitmap_enabled?
As is:
If readonly is set to true on a bitmap, bdrv_dirty_bitmap_status is going to return ACTIVE for such bitmaps, but DISABLED might be more appropriate to indicate the read-only nature.
If you add this condition into _enabled(), you can skip the extra assertions you've added here.
Quoted 57 lines
block/dirty-bitmap.c +25
-0hbitmap_set (bitmap->bitmap, cur_sector, nr_sectors); }@@ -443,12 +446,14 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) {assert (bdrv_dirty_bitmap_enabled (bitmap )); +assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_reset (bitmap->bitmap, cur_sector, nr_sectors); }void bdrv_clear_dirty_bitmap (BdrvDirtyBitmap *bitmap,HBitmap **out) {assert (bdrv_dirty_bitmap_enabled (bitmap)); +assert (!bdrv_dirty_bitmap_readonly (bitmap));if (!out) {hbitmap_reset_all (bitmap->bitmap); }else {@@ -519,6 +524,7 @@ void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector,if (!bdrv_dirty_bitmap_enabled (bitmap)) {continue ; } +assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_set (bitmap->bitmap, cur_sector, nr_sectors); } }@@ -540,3 +546,25 @@ int64_t bdrv_get_meta_dirty_count(BdrvDirtyBitmap *bitmap) {return hbitmap_count (bitmap->meta); } + +bool bdrv_dirty_bitmap_readonly (const BdrvDirtyBitmap *bitmap) +{ +return bitmap->readonly; +} + +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap) +{ + bitmap->readonly = true; +} + +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs) +{ +BdrvDirtyBitmap *bm; + QLIST_FOREACH(bm, &bs->dirty_bitmaps, list) { +if (bm->readonly) { +return true; + } + } + +return false; +}block/io.c +0
-0
block/io.c static int coroutine_fn bdrv_aligned_pwritev(BdrvChild *child, · line 1355
Quoted 7 lines
block/io.c +4
-0@@ -1349,6 +1349,10 @@ static int coroutine_fn bdrv_aligned_pwritev(BdrvChild *child,uint64_t bytes_remaining = bytes;int max_transfer; +if (bdrv_has_readonly_bitmaps (bs)) { +return -EPERM ; + } +
Oh, hardcore. The original design for "disabled" was just that they would become invalid after writes; but in this case a read-only bitmap literally enforces the concept.
I can envision usages for both.
Quoted 19 lines
block/io.c +4
-0assert (is_power_of_2 (align));assert ((offset & (align -1 )) ==0 );assert ((bytes & (align -1 )) ==0 );@@ -2437,6 +2441,10 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs, int64_t offset,return -ENOMEDIUM ; } +if (bdrv_has_readonly_bitmaps (bs)) { +return -EPERM ; + } + ret =bdrv_check_byte_request (bs, offset, count);if (ret <0 ) {return ret;blockdev.c +0
-0
blockdev.c static void block_dirty_bitmap_clear_prepare(BlkActionState *common, · line 2040
Quoted 8 lines
blockdev.c +3
-0@@ -2033,6 +2033,9 @@ static void block_dirty_bitmap_clear_prepare(BlkActionState *common, }else if (!bdrv_dirty_bitmap_enabled (state->bitmap)) {error_setg (errp,"Cannot clear a disabled bitmap" );return ; + }else if (bdrv_dirty_bitmap_readonly (state->bitmap)) { +error_setg (errp,"Cannot clear a readonly bitmap" ); +return ; }
Oh, I see -- perhaps you wanted a better error message? That makes sense to me....
...Though, you know, bdrv_disable_dirty_bitmap accomplishes something pretty similar here: we take the bitmap out of active RW state and put it into RO mode, it's just done under the name enabled/disabled instead of RO.
As of this patch, nothing uses it yet. Is this patch necessary? Would setting a bitmap as "disabled" to mean "RO" be sufficient, or are the two flags truly semantically necessary?
Quoted 17 lines
blockdev.c +3
-0bdrv_clear_dirty_bitmap (state->bitmap, &state->backup);@@ -2813,6 +2816,9 @@ void qmp_block_dirty_bitmap_clear(const char *node, const char *name,"Bitmap '%s' is currently disabled and cannot be cleared" , name); goto out; + }else if (bdrv_dirty_bitmap_readonly (bitmap)) { +error_setg (errp,"Bitmap '%s' is readonly and cannot be cleared" , name); + goto out; }bdrv_clear_dirty_bitmap (bitmap,NULL );include/block/dirty-bitmap.h +0
-0
include/block/dirty-bitmap.h void bdrv_dirty_bitmap_deserialize_ones(BdrvDirtyBitmap *bitmap, · line 82
Quoted 8 lines
include/block/dirty-bitmap.h +4
-0@@ -75,4 +75,8 @@ void bdrv_dirty_bitmap_deserialize_ones(BdrvDirtyBitmap *bitmap, bool finish);void bdrv_dirty_bitmap_deserialize_finish (BdrvDirtyBitmap *bitmap); +bool bdrv_dirty_bitmap_readonly (const BdrvDirtyBitmap *bitmap); +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap); +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs); +#endif
I realize I am being very bike-sheddy about this, so I might give an r-b with a light justification.
--js
Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
Hi John!
Look at our discussion about this in v18 thread.
Shortly: readonly is not the same as disabled. disabled= bitmap just ignores all writes. readonly= writes are not allowed at all.
And I think, I'll try to go through way 2: "dirty" field instead of "readonly" (look at v18 discussion), as it a bit more flexible.
Quoted 184 lines · John Snow
Quoted 27 lines · Vladimir Sementsov-Ogievskiy
It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be read-only.
Signed-off-by Vladimir Sementsov-Ogievskiy <[email protected]>--- block/dirty-bitmap.c | 28 ++++++++++++++++++++++++++++ block/io.c | 8 ++++++++ blockdev.c | 6 ++++++ include/block/dirty-bitmap.h | 4 ++++ 4 files changed, 46 insertions(+)block/dirty-bitmap.c +2
-0@@ -44,6 +44,8 @@ struct BdrvDirtyBitmap {int64_t size;/* Size of the bitmap (Number of sectors) */ bool disabled;/* Bitmap is read-only */ int active_iterators;/* How many iterators are active */ +bool readonly;/* Bitmap is read-only and may be changed only +by deserialize* functions */ QLIST_ENTRY (BdrvDirtyBitmap) list; };block/dirty-bitmap.c void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, · line 441
Quoted 4 lines
block/dirty-bitmap.c +1
-0@@ -436,6 +438,7 @@ void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) {assert (bdrv_dirty_bitmap_enabled (bitmap )); +assert (!bdrv_dirty_bitmap_readonly (bitmap));Not reasonable to add the condition for !readonly into
bdrv_dirty_bitmap_enabled?As is:
If readonly is set to true on a bitmap,
bdrv_dirty_bitmap_statusis going to return ACTIVE for such bitmaps, but DISABLED might be more appropriate to indicate the read-only nature.If you add this condition into
_enabled(), you can skip the extra assertions you've added here.Quoted 57 lines
block/dirty-bitmap.c +25
-0hbitmap_set (bitmap->bitmap, cur_sector, nr_sectors); }@@ -443,12 +446,14 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) {assert (bdrv_dirty_bitmap_enabled (bitmap )); +assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_reset (bitmap->bitmap, cur_sector, nr_sectors); }void bdrv_clear_dirty_bitmap (BdrvDirtyBitmap *bitmap,HBitmap **out) {assert (bdrv_dirty_bitmap_enabled (bitmap)); +assert (!bdrv_dirty_bitmap_readonly (bitmap));if (!out) {hbitmap_reset_all (bitmap->bitmap); }else {@@ -519,6 +524,7 @@ void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector,if (!bdrv_dirty_bitmap_enabled (bitmap)) {continue ; } +assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_set (bitmap->bitmap, cur_sector, nr_sectors); } }@@ -540,3 +546,25 @@ int64_t bdrv_get_meta_dirty_count(BdrvDirtyBitmap *bitmap) {return hbitmap_count (bitmap->meta); } + +bool bdrv_dirty_bitmap_readonly (const BdrvDirtyBitmap *bitmap) +{ +return bitmap->readonly; +} + +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap) +{ + bitmap->readonly = true; +} + +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs) +{ +BdrvDirtyBitmap *bm; + QLIST_FOREACH(bm, &bs->dirty_bitmaps, list) { +if (bm->readonly) { +return true; + } + } + +return false; +}block/io.c +0
-0block/io.c static int coroutine_fn bdrv_aligned_pwritev(BdrvChild *child, · line 1355
Quoted 7 lines
block/io.c +4
-0@@ -1349,6 +1349,10 @@ static int coroutine_fn bdrv_aligned_pwritev(BdrvChild *child,uint64_t bytes_remaining = bytes;int max_transfer; +if (bdrv_has_readonly_bitmaps (bs)) { +return -EPERM ; + } +Oh, hardcore. The original design for "disabled" was just that they would become invalid after writes; but in this case a read-only bitmap literally enforces the concept.
I can envision usages for both.
Quoted 19 lines
block/io.c +4
-0assert (is_power_of_2 (align));assert ((offset & (align -1 )) ==0 );assert ((bytes & (align -1 )) ==0 );@@ -2437,6 +2441,10 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs, int64_t offset,return -ENOMEDIUM ; } +if (bdrv_has_readonly_bitmaps (bs)) { +return -EPERM ; + } + ret =bdrv_check_byte_request (bs, offset, count);if (ret <0 ) {return ret;blockdev.c +0
-0blockdev.c static void block_dirty_bitmap_clear_prepare(BlkActionState *common, · line 2040
Quoted 8 lines
blockdev.c +3
-0@@ -2033,6 +2033,9 @@ static void block_dirty_bitmap_clear_prepare(BlkActionState *common, }else if (!bdrv_dirty_bitmap_enabled (state->bitmap)) {error_setg (errp,"Cannot clear a disabled bitmap" );return ; + }else if (bdrv_dirty_bitmap_readonly (state->bitmap)) { +error_setg (errp,"Cannot clear a readonly bitmap" ); +return ; }Oh, I see -- perhaps you wanted a better error message? That makes sense to me....
...Though, you know,
bdrv_disable_dirty_bitmapaccomplishes something pretty similar here: we take the bitmap out of active RW state and put it into RO mode, it's just done under the name enabled/disabled instead of RO.As of this patch, nothing uses it yet. Is this patch necessary? Would setting a bitmap as "disabled" to mean "RO" be sufficient, or are the two flags truly semantically necessary?
Quoted 17 lines
blockdev.c +3
-0bdrv_clear_dirty_bitmap (state->bitmap, &state->backup);@@ -2813,6 +2816,9 @@ void qmp_block_dirty_bitmap_clear(const char *node, const char *name,"Bitmap '%s' is currently disabled and cannot be cleared" , name); goto out; + }else if (bdrv_dirty_bitmap_readonly (bitmap)) { +error_setg (errp,"Bitmap '%s' is readonly and cannot be cleared" , name); + goto out; }bdrv_clear_dirty_bitmap (bitmap,NULL );include/block/dirty-bitmap.h +0
-0include/block/dirty-bitmap.h void bdrv_dirty_bitmap_deserialize_ones(BdrvDirtyBitmap *bitmap, · line 82
Quoted 8 lines
include/block/dirty-bitmap.h +4
-0@@ -75,4 +75,8 @@ void bdrv_dirty_bitmap_deserialize_ones(BdrvDirtyBitmap *bitmap, bool finish);void bdrv_dirty_bitmap_deserialize_finish (BdrvDirtyBitmap *bitmap); +bool bdrv_dirty_bitmap_readonly (const BdrvDirtyBitmap *bitmap); +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap); +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs); +#endif I realize I am being very bike-sheddy about this, so I might give an r-b with a light justification.
--js
Signature · 2 lines
Best regards, Vladimir.
Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
Quoted 4 lines · Sementsov-Ogievskiy Vladimir
Hi John!
Look at our discussion about this in v18 thread.
I'm batting zero today; I literally missed that entire subthread.
Sigh, thanks, I'll go back and read.
Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
In reply to Sementsov-Ogievskiy VladimirQuoted 9 lines · Sementsov-Ogievskiy Vladimir
Hi John!
Look at our discussion about this in v18 thread.
Quoted 1 line
Shortly: readonly is not the same as disabled. disabled= bitmap just
ignores all writes. readonly= writes are not allowed at all.
And I think, I'll try to go through way 2: "dirty" field instead of "readonly" (look at v18 discussion), as it a bit more flexible.
Not sure which I prefer...
Method 1 is attractive in that it is fairly simple, and enforces fairly loudly the inability to write to devices with RO bitmaps. It's a natural extension of your current approach.
Method 2 is attractive in that it seems a little more efficient, and is a little more clever. A dirty flag lets us avoid flushing bitmaps we never even changed (though we still need to clean up the in_use flags.)
What I wonder about #2 is what happens when a write sneaks in (due to a bug or a use case we didn't see) on a bitmap attached to a read-only node. We fail later on invalidate? It shouldn't happen in normal circumstances, but I worry that the failure mode is messier.
Well, either way I will be happy for now I think -- pick whichever option feels easiest or best for you to implement.
Thanks!
Quoted 193 lines · John Snow
Quoted 190 lines · Vladimir Sementsov-Ogievskiy
Quoted 25 lines
It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be read-only.
Signed-off-by Vladimir Sementsov-Ogievskiy <[email protected]>--- block/dirty-bitmap.c | 28 ++++++++++++++++++++++++++++ block/io.c | 8 ++++++++ blockdev.c | 6 ++++++ include/block/dirty-bitmap.h | 4 ++++ 4 files changed, 46 insertions(+)block/dirty-bitmap.c +0
-0@@ -44,6 +44,8 @@ struct BdrvDirtyBitmap {int64_t size;/* Size of the bitmap (Number of sectors) */
bool disabled; /* Bitmap is read-only */
intactive_iterators; /* How many iterators are active */
+ bool readonly; /* Bitmap is read-only and may be
changed only
+ by deserialize* functions */Quoted 8 lines
QLIST_ENTRY(BdrvDirtyBitmap) list; }; @@ -436,6 +438,7 @@ void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) { assert(bdrv_dirty_bitmap_enabled(bitmap));+ assert(!bdrv_dirty_bitmap_readonly(bitmap));
Not reasonable to add the condition for !readonly into
bdrv_dirty_bitmap_enabled?As is:
If readonly is set to true on a bitmap,
bdrv_dirty_bitmap_statusis going to return ACTIVE for such bitmaps, but DISABLED might be more appropriate to indicate the read-only nature.If you add this condition into
_enabled(), you can skip the extra assertions you've added here.Quoted 58 lines
hbitmap_set(bitmap->bitmap, cur_sector, nr_sectors); } @@ -443,12 +446,14 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) { assert(bdrv_dirty_bitmap_enabled(bitmap));block/dirty-bitmap.c +3
-0+assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_reset (bitmap->bitmap, cur_sector, nr_sectors); }void bdrv_clear_dirty_bitmap (BdrvDirtyBitmap *bitmap,HBitmap **out) {assert (bdrv_dirty_bitmap_enabled (bitmap)); +assert (!bdrv_dirty_bitmap_readonly (bitmap));if (!out) {hbitmap_reset_all (bitmap->bitmap); }else {@@ -519,6 +524,7 @@ void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, if (!bdrv_dirty_bitmap_enabled(bitmap)) {continue ; } +assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_set (bitmap->bitmap, cur_sector, nr_sectors); }}block/dirty-bitmap.c +22
-0@@ -540,3 +546,25 @@ int64_t bdrv_get_meta_dirty_count(BdrvDirtyBitmap *bitmap) {return hbitmap_count (bitmap->meta); } + +bool bdrv_dirty_bitmap_readonly (const BdrvDirtyBitmap *bitmap) +{ +return bitmap->readonly; +} + +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap) +{ + bitmap->readonly = true; +} + +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs) +{ +BdrvDirtyBitmap *bm; + QLIST_FOREACH(bm, &bs->dirty_bitmaps, list) { +if (bm->readonly) { +return true; + } + } + +return false; +}block/io.c +0
-0block/io.c static int coroutine_fn · line 1355
Quoted 7 lines
block/io.c +3
-0@@ -1349,6 +1349,10 @@ static int coroutine_fnbdrv_aligned_pwritev (BdrvChild *child, uint64_t bytes_remaining = bytes;int max_transfer; + if (bdrv_has_readonly_bitmaps(bs)) { +return -EPERM ; + } +Oh, hardcore. The original design for "disabled" was just that they would become invalid after writes; but in this case a read-only bitmap literally enforces the concept.
I can envision usages for both.
Quoted 19 lines
block/io.c +3
-0assert (is_power_of_2 (align));assert ((offset & (align -1 )) ==0 );assert ((bytes & (align -1 )) ==0 );@@ -2437,6 +2441,10 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs, int64_t offset, return -ENOMEDIUM; } + if (bdrv_has_readonly_bitmaps(bs)) { +return -EPERM ; + } + ret =bdrv_check_byte_request (bs, offset, count);if (ret <0 ) {return ret;blockdev.c +0
-0blockdev.c static void · line 2041
Quoted 9 lines
blockdev.c +3
-0@@ -2033,6 +2033,9 @@ static void block_dirty_bitmap_clear_prepare(BlkActionState *common, } else if (!bdrv_dirty_bitmap_enabled(state->bitmap)) { error_setg(errp, "Cannot clear a disabled bitmap"); return; + } else if (bdrv_dirty_bitmap_readonly(state->bitmap)) { +error_setg (errp,"Cannot clear a readonly bitmap" ); +return ; }Oh, I see -- perhaps you wanted a better error message? That makes sense to me....
...Though, you know,
bdrv_disable_dirty_bitmapaccomplishes something pretty similar here: we take the bitmap out of active RW state and put it into RO mode, it's just done under the name enabled/disabled instead of RO.As of this patch, nothing uses it yet. Is this patch necessary? Would setting a bitmap as "disabled" to mean "RO" be sufficient, or are the two flags truly semantically necessary?
Quoted 19 lines
bdrv_clear_dirty_bitmap(state->bitmap, &state->backup);blockdev.c +3
-0@@ -2813,6 +2816,9 @@ void qmp_block_dirty_bitmap_clear(const char *node, const char *name,"Bitmap '%s' is currently disabled and cannot be cleared", name); goto out; + }else if (bdrv_dirty_bitmap_readonly (bitmap)) { +error_setg (errp,"Bitmap '%s' is readonly and cannot be cleared", name); + goto out;} bdrv_clear_dirty_bitmap(bitmap, NULL);include/block/dirty-bitmap.h +0
-0include/block/dirty-bitmap.h void · line 82
Quoted 8 lines
include/block/dirty-bitmap.h +3
-0@@ -75,4 +75,8 @@ voidbdrv_dirty_bitmap_deserialize_ones (BdrvDirtyBitmap *bitmap, bool finish);void bdrv_dirty_bitmap_deserialize_finish (BdrvDirtyBitmap *bitmap); +bool bdrv_dirty_bitmap_readonly(const BdrvDirtyBitmap *bitmap); +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap); +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs); +#endif I realize I am being very bike-sheddy about this, so I might give an r-b with a light justification.
--js
Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
Quoted 8 lines · John Snow
Quoted 6 lines · Sementsov-Ogievskiy Vladimir
Hi John!
Look at our discussion about this in v18 thread.
Quoted 1 line
Shortly: readonly is not the same as disabled. disabled= bitmap just
ignores all writes. readonly= writes are not allowed at all.
Quoted 8 lines
Quoted 3 lines
And I think, I'll try to go through way 2: "dirty" field instead of "readonly" (look at v18 discussion), as it a bit more flexible.
Not sure which I prefer...
Method 1 is attractive in that it is fairly simple, and enforces fairly loudly the inability to write to devices with RO bitmaps. It's a natural extension of your current approach.
For now I decided to realize this one, I think I'll publish it today. Also, I'm going to rename s/readonly/in_use - to avoid the confuse with disabled. So let this field just be mirror of IN_USE in the image and just say "persistent storage knows, that bitmap is in use and may be dirty".
Also, optimization with 'dirty' flag may be added later.
Quoted 9 lines
Method 2 is attractive in that it seems a little more efficient, and is a little more clever. A dirty flag lets us avoid flushing bitmaps we never even changed (though we still need to clean up the
in_useflags.)What I wonder about #2 is what happens when a write sneaks in (due to a bug or a use case we didn't see) on a bitmap attached to a read-only node. We fail later on invalidate? It shouldn't happen in normal circumstances, but I worry that the failure mode is messier.
if bitmap is dirty - all ok, the problems will appear when we'll try to save it, but these problems are not fatal - bitmap should be marked 'in_use' in the image, so it will be lost (the worst case is when in_use not set and bitmap is incorrect - it may lead to data loss for user)
if it is not dirty - we will fail to write 'in_use' before actual write and the whole write will fail.
Quoted 197 lines
Well, either way I will be happy for now I think -- pick whichever option feels easiest or best for you to implement.
Thanks!
Quoted 190 lines · John Snow
Quoted 189 lines · Vladimir Sementsov-Ogievskiy
Quoted 25 lines
It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be read-only.
Signed-off-by Vladimir Sementsov-Ogievskiy <[email protected]>--- block/dirty-bitmap.c | 28 ++++++++++++++++++++++++++++ block/io.c | 8 ++++++++ blockdev.c | 6 ++++++ include/block/dirty-bitmap.h | 4 ++++ 4 files changed, 46 insertions(+)block/dirty-bitmap.c +0
-0@@ -44,6 +44,8 @@ struct BdrvDirtyBitmap {int64_t size;/* Size of the bitmap (Number of sectors) */
bool disabled; /* Bitmap is read-only */
intactive_iterators; /* How many iterators are active */
+ bool readonly; /* Bitmap is read-only and may be
changed only
+ by deserialize* functions */Quoted 8 lines
QLIST_ENTRY(BdrvDirtyBitmap) list; }; @@ -436,6 +438,7 @@ void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) { assert(bdrv_dirty_bitmap_enabled(bitmap));+ assert(!bdrv_dirty_bitmap_readonly(bitmap));
Not reasonable to add the condition for !readonly into
bdrv_dirty_bitmap_enabled?As is:
If readonly is set to true on a bitmap,
bdrv_dirty_bitmap_statusis going to return ACTIVE for such bitmaps, but DISABLED might be more appropriate to indicate the read-only nature.If you add this condition into
_enabled(), you can skip the extra assertions you've added here.Quoted 58 lines
hbitmap_set(bitmap->bitmap, cur_sector, nr_sectors); } @@ -443,12 +446,14 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) { assert(bdrv_dirty_bitmap_enabled(bitmap));block/dirty-bitmap.c +3
-0+assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_reset (bitmap->bitmap, cur_sector, nr_sectors); }void bdrv_clear_dirty_bitmap (BdrvDirtyBitmap *bitmap,HBitmap **out) {assert (bdrv_dirty_bitmap_enabled (bitmap)); +assert (!bdrv_dirty_bitmap_readonly (bitmap));if (!out) {hbitmap_reset_all (bitmap->bitmap); }else {@@ -519,6 +524,7 @@ void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, if (!bdrv_dirty_bitmap_enabled(bitmap)) {continue ; } +assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_set (bitmap->bitmap, cur_sector, nr_sectors); }}block/dirty-bitmap.c +22
-0@@ -540,3 +546,25 @@ int64_t bdrv_get_meta_dirty_count(BdrvDirtyBitmap *bitmap) {return hbitmap_count (bitmap->meta); } + +bool bdrv_dirty_bitmap_readonly (const BdrvDirtyBitmap *bitmap) +{ +return bitmap->readonly; +} + +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap) +{ + bitmap->readonly = true; +} + +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs) +{ +BdrvDirtyBitmap *bm; + QLIST_FOREACH(bm, &bs->dirty_bitmaps, list) { +if (bm->readonly) { +return true; + } + } + +return false; +}block/io.c +0
-0block/io.c static int coroutine_fn · line 1355
Quoted 7 lines
block/io.c +3
-0@@ -1349,6 +1349,10 @@ static int coroutine_fnbdrv_aligned_pwritev (BdrvChild *child, uint64_t bytes_remaining = bytes;int max_transfer; + if (bdrv_has_readonly_bitmaps(bs)) { +return -EPERM ; + } +Oh, hardcore. The original design for "disabled" was just that they would become invalid after writes; but in this case a read-only bitmap literally enforces the concept.
I can envision usages for both.
Quoted 19 lines
block/io.c +3
-0assert (is_power_of_2 (align));assert ((offset & (align -1 )) ==0 );assert ((bytes & (align -1 )) ==0 );@@ -2437,6 +2441,10 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs, int64_t offset, return -ENOMEDIUM; } + if (bdrv_has_readonly_bitmaps(bs)) { +return -EPERM ; + } + ret =bdrv_check_byte_request (bs, offset, count);if (ret <0 ) {return ret;blockdev.c +0
-0blockdev.c static void · line 2041
Quoted 9 lines
blockdev.c +3
-0@@ -2033,6 +2033,9 @@ static void block_dirty_bitmap_clear_prepare(BlkActionState *common, } else if (!bdrv_dirty_bitmap_enabled(state->bitmap)) { error_setg(errp, "Cannot clear a disabled bitmap"); return; + } else if (bdrv_dirty_bitmap_readonly(state->bitmap)) { +error_setg (errp,"Cannot clear a readonly bitmap" ); +return ; }Oh, I see -- perhaps you wanted a better error message? That makes sense to me....
...Though, you know,
bdrv_disable_dirty_bitmapaccomplishes something pretty similar here: we take the bitmap out of active RW state and put it into RO mode, it's just done under the name enabled/disabled instead of RO.As of this patch, nothing uses it yet. Is this patch necessary? Would setting a bitmap as "disabled" to mean "RO" be sufficient, or are the two flags truly semantically necessary?
Quoted 19 lines
bdrv_clear_dirty_bitmap(state->bitmap, &state->backup);blockdev.c +3
-0@@ -2813,6 +2816,9 @@ void qmp_block_dirty_bitmap_clear(const char *node, const char *name,"Bitmap '%s' is currently disabled and cannot be cleared", name); goto out; + }else if (bdrv_dirty_bitmap_readonly (bitmap)) { +error_setg (errp,"Bitmap '%s' is readonly and cannot be cleared", name); + goto out;} bdrv_clear_dirty_bitmap(bitmap, NULL);include/block/dirty-bitmap.h +0
-0include/block/dirty-bitmap.h void · line 82
Quoted 8 lines
include/block/dirty-bitmap.h +3
-0@@ -75,4 +75,8 @@ voidbdrv_dirty_bitmap_deserialize_ones (BdrvDirtyBitmap *bitmap, bool finish);void bdrv_dirty_bitmap_deserialize_finish (BdrvDirtyBitmap *bitmap); +bool bdrv_dirty_bitmap_readonly(const BdrvDirtyBitmap *bitmap); +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap); +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs); +#endif I realize I am being very bike-sheddy about this, so I might give an r-b with a light justification.
--js
Signature · 2 lines
Best regards, Vladimir
Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
Quoted 14 lines · Vladimir Sementsov-Ogievskiy
Quoted 13 lines · John Snow
Quoted 9 lines · Sementsov-Ogievskiy Vladimir
Hi John!
Look at our discussion about this in v18 thread.
Quoted 1 line
Shortly: readonly is not the same as disabled. disabled= bitmap just
ignores all writes. readonly= writes are not allowed at all.
And I think, I'll try to go through way 2: "dirty" field instead of "readonly" (look at v18 discussion), as it a bit more flexible.
Not sure which I prefer...
Quoted 7 lines
Quoted 3 lines
Method 1 is attractive in that it is fairly simple, and enforces fairly loudly the inability to write to devices with RO bitmaps. It's a natural extension of your current approach.
For now I decided to realize this one, I think I'll publish it today. Also, I'm going to rename s/readonly/in_use - to avoid the confuse with disabled. So let this field just be mirror of
IN_USEin the image and just say "persistent storage knows, that bitmap is in use and may be dirty".Also, optimization with 'dirty' flag may be added later.
And, also, I don't want to influence this "first write", on which we will set "IN_USE" in all bitmaps (for way (2). Reopening rw is less performance-demanding place than write.
Quoted 218 lines
Quoted 10 lines
Method 2 is attractive in that it seems a little more efficient, and is a little more clever. A dirty flag lets us avoid flushing bitmaps we never even changed (though we still need to clean up the
in_useflags.)What I wonder about #2 is what happens when a write sneaks in (due to a bug or a use case we didn't see) on a bitmap attached to a read-only node. We fail later on invalidate? It shouldn't happen in normal circumstances, but I worry that the failure mode is messier.
if bitmap is dirty - all ok, the problems will appear when we'll try to save it, but these problems are not fatal - bitmap should be marked '
in_use' in the image, so it will be lost (the worst case is whenin_usenot set and bitmap is incorrect - it may lead to data loss for user)if it is not dirty - we will fail to write '
in_use' before actual write and the whole write will fail.Quoted 201 lines
Well, either way I will be happy for now I think -- pick whichever option feels easiest or best for you to implement.
Thanks!
Quoted 194 lines · John Snow
Quoted 193 lines · Vladimir Sementsov-Ogievskiy
Quoted 26 lines
It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be read-only.
Signed-off-by Vladimir Sementsov-Ogievskiy <[email protected]>--- block/dirty-bitmap.c | 28 ++++++++++++++++++++++++++++ block/io.c | 8 ++++++++ blockdev.c | 6 ++++++ include/block/dirty-bitmap.h | 4 ++++ 4 files changed, 46 insertions(+)block/dirty-bitmap.c +0
-0@@ -44,6 +44,8 @@ struct BdrvDirtyBitmap {int64_t size;/* Size of the bitmap (Number of sectors) */
bool disabled; /* Bitmap is read-only */
intactive_iterators; /* How many iterators are
active */
+ bool readonly; /* Bitmap is read-only and may be
changed only
+ by deserialize* functions */Quoted 8 lines
QLIST_ENTRY(BdrvDirtyBitmap) list; }; @@ -436,6 +438,7 @@ void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) { assert(bdrv_dirty_bitmap_enabled(bitmap));+ assert(!bdrv_dirty_bitmap_readonly(bitmap));
Not reasonable to add the condition for !readonly into
bdrv_dirty_bitmap_enabled?As is:
If readonly is set to true on a bitmap,
bdrv_dirty_bitmap_statusis going to return ACTIVE for such bitmaps, but DISABLED might be more appropriate to indicate the read-only nature.If you add this condition into
_enabled(), you can skip the extra assertions you've added here.Quoted 60 lines
hbitmap_set(bitmap->bitmap, cur_sector, nr_sectors); } @@ -443,12 +446,14 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) { assert(bdrv_dirty_bitmap_enabled(bitmap)); + assert(!bdrv_dirty_bitmap_readonly(bitmap)); hbitmap_reset(bitmap->bitmap, cur_sector, nr_sectors); } void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap **out) { assert(bdrv_dirty_bitmap_enabled(bitmap));block/dirty-bitmap.c +2
-0+assert (!bdrv_dirty_bitmap_readonly (bitmap));if (!out) {hbitmap_reset_all (bitmap->bitmap); }else {@@ -519,6 +524,7 @@ void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, if (!bdrv_dirty_bitmap_enabled(bitmap)) {continue ; } +assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_set (bitmap->bitmap, cur_sector, nr_sectors); }}block/dirty-bitmap.c +22
-0@@ -540,3 +546,25 @@ int64_t bdrv_get_meta_dirty_count(BdrvDirtyBitmap *bitmap) {return hbitmap_count (bitmap->meta); } + +bool bdrv_dirty_bitmap_readonly (const BdrvDirtyBitmap *bitmap) +{ +return bitmap->readonly; +} + +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap) +{ + bitmap->readonly = true; +} + +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs) +{ +BdrvDirtyBitmap *bm; + QLIST_FOREACH(bm, &bs->dirty_bitmaps, list) { +if (bm->readonly) { +return true; + } + } + +return false; +}block/io.c +0
-0block/io.c static int coroutine_fn · line 1355
Quoted 7 lines
block/io.c +3
-0@@ -1349,6 +1349,10 @@ static int coroutine_fnbdrv_aligned_pwritev (BdrvChild *child, uint64_t bytes_remaining = bytes;int max_transfer; + if (bdrv_has_readonly_bitmaps(bs)) { +return -EPERM ; + } +Oh, hardcore. The original design for "disabled" was just that they would become invalid after writes; but in this case a read-only bitmap literally enforces the concept.
I can envision usages for both.
Quoted 19 lines
block/io.c +3
-0assert (is_power_of_2 (align));assert ((offset & (align -1 )) ==0 );assert ((bytes & (align -1 )) ==0 );@@ -2437,6 +2441,10 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs, int64_t offset, return -ENOMEDIUM; } + if (bdrv_has_readonly_bitmaps(bs)) { +return -EPERM ; + } + ret =bdrv_check_byte_request (bs, offset, count);if (ret <0 ) {return ret;blockdev.c +0
-0blockdev.c static void · line 2040
Quoted 8 lines
blockdev.c +3
-0@@ -2033,6 +2033,9 @@ static void block_dirty_bitmap_clear_prepare(BlkActionState *common, } else if (!bdrv_dirty_bitmap_enabled(state->bitmap)) { error_setg(errp, "Cannot clear a disabled bitmap"); return; + } else if (bdrv_dirty_bitmap_readonly(state->bitmap)) { +error_setg (errp,"Cannot clear a readonly bitmap" ); +return ; }Oh, I see -- perhaps you wanted a better error message? That makes sense to me....
...Though, you know,
bdrv_disable_dirty_bitmapaccomplishes something pretty similar here: we take the bitmap out of active RW state and put it into RO mode, it's just done under the name enabled/disabled instead of RO.As of this patch, nothing uses it yet. Is this patch necessary? Would setting a bitmap as "disabled" to mean "RO" be sufficient, or are the two flags truly semantically necessary?
Quoted 20 lines
blockdev.c +0
-0bdrv_clear_dirty_bitmap (state->bitmap, &state->backup);@@ -2813,6 +2816,9 @@ void qmp_block_dirty_bitmap_clear(const char *node, const char *name, "Bitmap '%s' is currently disabled andcannot be
cleared",name); goto out;blockdev.c +2
-0+ }else if (bdrv_dirty_bitmap_readonly (bitmap)) { + error_setg(errp, "Bitmap '%s' is readonly and cannot becleared", name);
blockdev.c +1
-0+ goto out; }bdrv_clear_dirty_bitmap (bitmap,NULL );include/block/dirty-bitmap.h +0
-0include/block/dirty-bitmap.h void · line 82
Quoted 9 lines
include/block/dirty-bitmap.h +3
-0@@ -75,4 +75,8 @@ voidbdrv_dirty_bitmap_deserialize_ones (BdrvDirtyBitmap *bitmap, bool finish);void bdrv_dirty_bitmap_deserialize_finish (BdrvDirtyBitmap *bitmap); +bool bdrv_dirty_bitmap_readonly(const BdrvDirtyBitmap *bitmap); +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap); +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs); +#endif I realize I am being very bike-sheddy about this, so I might give an r-b with a light justification.
--js
Signature · 2 lines
Best regards, Vladimir
Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
Quoted 13 lines · Vladimir Sementsov-Ogievskiy
Quoted 12 lines · Vladimir Sementsov-Ogievskiy
Quoted 11 lines · John Snow
Quoted 9 lines · Sementsov-Ogievskiy Vladimir
Hi John!
Look at our discussion about this in v18 thread.
Quoted 1 line
Shortly: readonly is not the same as disabled. disabled= bitmap just
ignores all writes. readonly= writes are not allowed at all.
And I think, I'll try to go through way 2: "dirty" field instead of "readonly" (look at v18 discussion), as it a bit more flexible.
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Not sure which I prefer...
Method 1 is attractive in that it is fairly simple, and enforces fairly loudly the inability to write to devices with RO bitmaps. It's a natural extension of your current approach.
For now I decided to realize this one, I think I'll publish it today. Also, I'm going to rename s/readonly/in_use - to avoid the confuse with disabled. So let this field just be mirror of
IN_USEin the image and just say "persistent storage knows, that bitmap is in use and may be dirty".
Finally it would be readonly. in_use is bad for created (not loaded) bitmaps. I'll add more descriptive comments for disabled and readonly.
Quoted 228 lines
Quoted 2 lines
Also, optimization with 'dirty' flag may be added later.
And, also, I don't want to influence this "first write", on which we will set "
IN_USE" in all bitmaps (for way (2). Reopening rw is less performance-demanding place than write.Quoted 221 lines
Quoted 10 lines
Method 2 is attractive in that it seems a little more efficient, and is a little more clever. A dirty flag lets us avoid flushing bitmaps we never even changed (though we still need to clean up the
in_useflags.)What I wonder about #2 is what happens when a write sneaks in (due to a bug or a use case we didn't see) on a bitmap attached to a read-only node. We fail later on invalidate? It shouldn't happen in normal circumstances, but I worry that the failure mode is messier.
if bitmap is dirty - all ok, the problems will appear when we'll try to save it, but these problems are not fatal - bitmap should be marked '
in_use' in the image, so it will be lost (the worst case is whenin_usenot set and bitmap is incorrect - it may lead to data loss for user)if it is not dirty - we will fail to write '
in_use' before actual write and the whole write will fail.Quoted 204 lines
Well, either way I will be happy for now I think -- pick whichever option feels easiest or best for you to implement.
Thanks!
Quoted 197 lines · John Snow
Quoted 196 lines · Vladimir Sementsov-Ogievskiy
Quoted 34 lines
It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be read-only.
Signed-off-by Vladimir Sementsov-Ogievskiy <[email protected]>--- block/dirty-bitmap.c | 28 ++++++++++++++++++++++++++++ block/io.c | 8 ++++++++ blockdev.c | 6 ++++++ include/block/dirty-bitmap.h | 4 ++++ 4 files changed, 46 insertions(+)block/dirty-bitmap.c +0
-0@@ -44,6 +44,8 @@ struct BdrvDirtyBitmap {int64_t size;/* Size of the bitmap (Number of sectors) */
bool disabled; /* Bitmap is read-only */
intactive_iterators; /* How many iterators are
active */
+ bool readonly; /* Bitmap is read-only and may be
changed only
+ by deserialize* functions */QLIST_ENTRY(BdrvDirtyBitmap) list; }; @@ -436,6 +438,7 @@ void bdrv_set_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) { assert(bdrv_dirty_bitmap_enabled(bitmap));Quoted 1 line
+ assert(!bdrv_dirty_bitmap_readonly(bitmap));
Not reasonable to add the condition for !readonly into
bdrv_dirty_bitmap_enabled?As is:
If readonly is set to true on a bitmap,
bdrv_dirty_bitmap_statusis going to return ACTIVE for such bitmaps, but DISABLED might be more appropriate to indicate the read-only nature.If you add this condition into
_enabled(), you can skip the extra assertions you've added here.Quoted 62 lines
hbitmap_set(bitmap->bitmap, cur_sector, nr_sectors); } @@ -443,12 +446,14 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap, int64_t cur_sector, int64_t nr_sectors) { assert(bdrv_dirty_bitmap_enabled(bitmap)); + assert(!bdrv_dirty_bitmap_readonly(bitmap)); hbitmap_reset(bitmap->bitmap, cur_sector, nr_sectors); } void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap **out) { assert(bdrv_dirty_bitmap_enabled(bitmap));block/dirty-bitmap.c +1
-0+assert (!bdrv_dirty_bitmap_readonly (bitmap));if (!out) {hbitmap_reset_all (bitmap->bitmap); }else {@@ -519,6 +524,7 @@ void bdrv_set_dirty(BlockDriverState *bs,
int64_tcur_sector,if (!bdrv_dirty_bitmap_enabled(bitmap)) { continue; }block/dirty-bitmap.c +23
-0+assert (!bdrv_dirty_bitmap_readonly (bitmap));hbitmap_set (bitmap->bitmap, cur_sector, nr_sectors); } }@@ -540,3 +546,25 @@ int64_t bdrv_get_meta_dirty_count(BdrvDirtyBitmap *bitmap) {return hbitmap_count (bitmap->meta); } + +bool bdrv_dirty_bitmap_readonly (const BdrvDirtyBitmap *bitmap) +{ +return bitmap->readonly; +} + +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap) +{ + bitmap->readonly = true; +} + +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs) +{ +BdrvDirtyBitmap *bm; + QLIST_FOREACH(bm, &bs->dirty_bitmaps, list) { +if (bm->readonly) { +return true; + } + } + +return false; +}block/io.c +0
-0block/io.c static int coroutine_fn · line 1355
Quoted 7 lines
block/io.c +3
-0@@ -1349,6 +1349,10 @@ static int coroutine_fnbdrv_aligned_pwritev (BdrvChild *child, uint64_t bytes_remaining = bytes;int max_transfer; + if (bdrv_has_readonly_bitmaps(bs)) { +return -EPERM ; + } +Oh, hardcore. The original design for "disabled" was just that they would become invalid after writes; but in this case a read-only bitmap literally enforces the concept.
I can envision usages for both.
Quoted 19 lines
block/io.c +3
-0assert (is_power_of_2 (align));assert ((offset & (align -1 )) ==0 );assert ((bytes & (align -1 )) ==0 );@@ -2437,6 +2441,10 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs, int64_t offset, return -ENOMEDIUM; } + if (bdrv_has_readonly_bitmaps(bs)) { +return -EPERM ; + } + ret =bdrv_check_byte_request (bs, offset, count);if (ret <0 ) {return ret;blockdev.c +0
-0blockdev.c static void · line 2040
Quoted 8 lines
blockdev.c +3
-0@@ -2033,6 +2033,9 @@ static void block_dirty_bitmap_clear_prepare(BlkActionState *common, } else if (!bdrv_dirty_bitmap_enabled(state->bitmap)) { error_setg(errp, "Cannot clear a disabled bitmap"); return; + } else if (bdrv_dirty_bitmap_readonly(state->bitmap)) { +error_setg (errp,"Cannot clear a readonly bitmap" ); +return ; }Oh, I see -- perhaps you wanted a better error message? That makes sense to me....
...Though, you know,
bdrv_disable_dirty_bitmapaccomplishes something pretty similar here: we take the bitmap out of active RW state and put it into RO mode, it's just done under the name enabled/disabled instead of RO.As of this patch, nothing uses it yet. Is this patch necessary? Would setting a bitmap as "disabled" to mean "RO" be sufficient, or are the two flags truly semantically necessary?
Quoted 20 lines
blockdev.c +0
-0bdrv_clear_dirty_bitmap (state->bitmap, &state->backup);@@ -2813,6 +2816,9 @@ void qmp_block_dirty_bitmap_clear(const char *node, const char *name, "Bitmap '%s' is currently disabled andcannot be
cleared",name); goto out;blockdev.c +2
-0+ }else if (bdrv_dirty_bitmap_readonly (bitmap)) { + error_setg(errp, "Bitmap '%s' is readonly and cannot becleared", name);
blockdev.c +1
-0+ goto out; }bdrv_clear_dirty_bitmap (bitmap,NULL );include/block/dirty-bitmap.h +0
-0include/block/dirty-bitmap.h void · line 82
Quoted 9 lines
include/block/dirty-bitmap.h +3
-0@@ -75,4 +75,8 @@ voidbdrv_dirty_bitmap_deserialize_ones (BdrvDirtyBitmap *bitmap, bool finish);void bdrv_dirty_bitmap_deserialize_finish (BdrvDirtyBitmap *bitmap); +bool bdrv_dirty_bitmap_readonly(const BdrvDirtyBitmap *bitmap); +void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap); +bool bdrv_has_readonly_bitmaps (BlockDriverState *bs); +#endif I realize I am being very bike-sheddy about this, so I might give an r-b with a light justification.
--js
Signature · 2 lines
Best regards, Vladimir
Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
Quoted 21 lines · Vladimir Sementsov-Ogievskiy
Quoted 20 lines · Vladimir Sementsov-Ogievskiy
Quoted 19 lines · Vladimir Sementsov-Ogievskiy
Quoted 17 lines · John Snow
Quoted 9 lines · Sementsov-Ogievskiy Vladimir
Hi John!
Look at our discussion about this in v18 thread.
Quoted 1 line
Shortly: readonly is not the same as disabled. disabled= bitmap just
ignores all writes. readonly= writes are not allowed at all.
And I think, I'll try to go through way 2: "dirty" field instead of "readonly" (look at v18 discussion), as it a bit more flexible.
Not sure which I prefer...
Method 1 is attractive in that it is fairly simple, and enforces fairly loudly the inability to write to devices with RO bitmaps. It's a natural
extension of your current approach.
Quoted 9 lines
Quoted 5 lines
Quoted 5 lines
For now I decided to realize this one, I think I'll publish it today. Also, I'm going to rename s/readonly/in_use - to avoid the confuse with disabled. So let this field just be mirror of
IN_USEin the image and just say "persistent storage knows, that bitmap is in use and may be dirty".Finally it would be readonly.
in_useis bad for created (not loaded) bitmaps. I'll add more descriptive comments for disabled and readonly.
Makes sense. It sounds like "readonly" is simply a stricter superset of "disabled," where "disabled" doesn't care if the bitmap gets out of sync with the data, but "readonly" attempts to preserve that semantic relationship.
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Also, optimization with 'dirty' flag may be added later.
Yes, I agree.
Quoted 4 lines
Quoted 4 lines
And, also, I don't want to influence this "first write", on which we will set "
IN_USE" in all bitmaps (for way (2). Reopening rw is less performance-demanding place than write.
"And, also," -- I think you've been reading my emails too much, you're picking up my 'isms ;)
Thanks,
--John
Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
Quoted 26 lines · John Snow
Quoted 24 lines · Vladimir Sementsov-Ogievskiy
Quoted 23 lines · Vladimir Sementsov-Ogievskiy
Quoted 22 lines · Vladimir Sementsov-Ogievskiy
Quoted 10 lines · John Snow
Quoted 9 lines · Sementsov-Ogievskiy Vladimir
Hi John!
Look at our discussion about this in v18 thread.
Quoted 1 line
Shortly: readonly is not the same as disabled. disabled= bitmap just
ignores all writes. readonly= writes are not allowed at all.
And I think, I'll try to go through way 2: "dirty" field instead of "readonly" (look at v18 discussion), as it a bit more flexible.
Quoted 6 lines
Not sure which I prefer...
Method 1 is attractive in that it is fairly simple, and enforces fairly loudly the inability to write to devices with RO bitmaps. It's a natural
extension of your current approach.For now I decided to realize this one, I think I'll publish it today. Also, I'm going to rename s/readonly/in_use - to avoid the confuse with disabled. So let this field just be mirror of
IN_USEin the image and just say "persistent storage knows, that bitmap is in use and may be dirty".
Quoted 7 lines
Quoted 3 lines
Finally it would be readonly.
in_useis bad for created (not loaded) bitmaps. I'll add more descriptive comments for disabled and readonly.Makes sense. It sounds like "readonly" is simply a stricter superset of "disabled," where "disabled" doesn't care if the bitmap gets out of sync with the data, but "readonly" attempts to preserve that semantic relationship.
should we add separate "READONLY" bitmap status for qapi? I'm sure that I don't want to call them "disabled" as it is not the same. "active" is better (as when image is RW they are active, when image is RO, they are active in RO image - not bad too I think. So, may be such addition to qapi would be redundant.
Quoted 13 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Also, optimization with 'dirty' flag may be added later.
Yes, I agree.
Quoted 4 lines
Quoted 4 lines
And, also, I don't want to influence this "first write", on which we will set "
IN_USE" in all bitmaps (for way (2). Reopening rw is less performance-demanding place than write."And, also," -- I think you've been reading my emails too much, you're picking up my 'isms ;)
Thanks,
--John
Signature · 2 lines
Best regards, Vladimir.
PATCH v19 10/25 qcow2: autoloading dirty bitmaps
In reply to Vladimir Sementsov-OgievskiyAuto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They are loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive.
Extra data in bitmaps is not supported for now.
--- block/qcow2-bitmap.c | 388 +++++++++++++++++++++++++++++++++++++++++++++++++++ block/qcow2.c | 17 ++- block/qcow2.h | 2 + 3 files changed, 405 insertions(+), 2 deletions(-)
block/qcow2-bitmap.c +388 -0
@@ -44,6 +44,8 @@/* Bitmap directory entry flags */ #define BME_RESERVED_FLAGS 0xfffffffcU +#define BME_FLAG_IN_USE (1U << 0) +#define BME_FLAG_AUTO (1U << 1)/* bits [1, 8] U [56, 63] are reserved */ #define BME_TABLE_ENTRY_RESERVED_MASK 0xff000000000001feULL
@@ -85,6 +87,23 @@ typedef enum BitmapType { BT_DIRTY_TRACKING_BITMAP = 1 } BitmapType; +static inline bool can_write (BlockDriverState *bs) +{ +return !bdrv_is_read_only (bs) && !(bdrv_get_flags (bs) &BDRV_O_INACTIVE ); +} + +static int update_header_sync (BlockDriverState *bs) +{ +int ret; + + ret =qcow2_update_header (bs); +if (ret <0 ) { +return ret; + } + +return bdrv_flush (bs); +} +static int check_table_entry (uint64_t entry,int cluster_size) {uint64_t offset;
@@ -146,6 +165,120 @@ fail:return ret; } +/* This function returns the number of disk sectors covered by a single qcow2 +* cluster of bitmap data. */ +static uint64_t sectors_covered_by_bitmap_cluster (const BDRVQcow2State *s, +const BdrvDirtyBitmap *bitmap) +{ +uint32_t sector_granularity = +bdrv_dirty_bitmap_granularity (bitmap) >>BDRV_SECTOR_BITS ; + +return (uint64_t )sector_granularity * (s->cluster_size <<3 ); +} + +/* load_bitmap_data +* @bitmap_table entries must satisfy specification constraints. +* @bitmap must be cleared */ +static int load_bitmap_data (BlockDriverState *bs, +const uint64_t *bitmap_table, +uint32_t bitmap_table_size, +BdrvDirtyBitmap *bitmap) +{ +int ret =0 ; +BDRVQcow2State *s = bs->opaque; +uint64_t sector, sbc; +uint64_t bm_size =bdrv_dirty_bitmap_size (bitmap); +uint8_t *buf =NULL ; +uint64_t i, tab_size = +size_to_clusters (s, +bdrv_dirty_bitmap_serialization_size (bitmap,0 , bm_size)); + +if (tab_size != bitmap_table_size || tab_size >BME_MAX_TABLE_SIZE ) { +return -EINVAL ; + } + + buf =g_malloc (s->cluster_size); + sbc =sectors_covered_by_bitmap_cluster (s, bitmap); +for (i =0 , sector =0 ; i < tab_size; ++i, sector += sbc) { +uint64_t count =MIN (bm_size - sector, sbc); +uint64_t entry = bitmap_table[i]; +uint64_t offset = entry &BME_TABLE_ENTRY_OFFSET_MASK ; + +assert (check_table_entry (entry, s->cluster_size) ==0 ); + +if (offset ==0 ) { +if (entry &BME_TABLE_ENTRY_FLAG_ALL_ONES ) { +bdrv_dirty_bitmap_deserialize_ones (bitmap, sector, count, + false); + }else { +/* No need to deserialize zeros because the dirty bitmap is +* already cleared */ + } + }else { + ret =bdrv_pread (bs->file, offset, buf, s->cluster_size); +if (ret <0 ) { + goto finish; + } +bdrv_dirty_bitmap_deserialize_part (bitmap, buf, sector, count, + false); + } + } + ret =0 ; + +bdrv_dirty_bitmap_deserialize_finish (bitmap); + +finish: +g_free (buf); + +return ret; +} + +static BdrvDirtyBitmap *load_bitmap (BlockDriverState *bs, +Qcow2Bitmap *bm,Error **errp) +{ +int ret; +uint64_t *bitmap_table =NULL ; +uint32_t granularity; +BdrvDirtyBitmap *bitmap =NULL ; + +if (bm->flags &BME_FLAG_IN_USE ) { +error_setg (errp,"Bitmap '%s' is in use" , bm->name); + goto fail; + } + + ret =bitmap_table_load (bs, &bm->table, &bitmap_table); +if (ret <0 ) { +error_setg_errno (errp, -ret, +"Could not read bitmap_table table from image for " +"bitmap '%s'" , bm->name); + goto fail; + } + + granularity =1U << bm->granularity_bits; + bitmap =bdrv_create_dirty_bitmap (bs, granularity, bm->name, errp); +if (bitmap ==NULL ) { + goto fail; + } + + ret =load_bitmap_data (bs, bitmap_table, bm->table.size, bitmap); +if (ret <0 ) { +error_setg_errno (errp, -ret,"Could not read bitmap '%s' from image" , + bm->name); + goto fail; + } + +g_free (bitmap_table); +return bitmap; + +fail: +g_free (bitmap_table); +if (bitmap !=NULL ) { +bdrv_release_dirty_bitmap (bs, bitmap); + } + +return NULL ; +} +/* * Bitmap List */
@@ -164,6 +297,15 @@ static inline void bitmap_dir_entry_to_cpu(Qcow2BitmapDirEntry *entry)be32_to_cpus (&entry->extra_data_size); } +static inline void bitmap_dir_entry_to_be (Qcow2BitmapDirEntry *entry) +{ +cpu_to_be64s (&entry->bitmap_table_offset); +cpu_to_be32s (&entry->bitmap_table_size); +cpu_to_be32s (&entry->flags); +cpu_to_be16s (&entry->name_size); +cpu_to_be32s (&entry->extra_data_size); +} +static inline int calc_dir_entry_size (size_t name_size,size_t extra_data_size) { return align_offset(sizeof(Qcow2BitmapDirEntry) +
@@ -224,6 +366,17 @@ static int check_dir_entry(BlockDriverState *bs, Qcow2BitmapDirEntry *entry)return fail ? -EINVAL :0 ; } +static inline void bitmap_directory_to_be (uint8_t *dir,size_t size) +{ +uint8_t *end = dir + size; +while (dir < end) { +Qcow2BitmapDirEntry *e = (Qcow2BitmapDirEntry *)dir; + dir +=dir_entry_size (e); + +bitmap_dir_entry_to_be (e); + } +} +/* * Bitmap List public functions */
@@ -258,6 +411,18 @@ static Qcow2BitmapList *bitmap_list_new(void)return bm_list; } +static uint32_t bitmap_list_count (Qcow2BitmapList *bm_list) +{ +Qcow2Bitmap *bm; +uint32_t nb_bitmaps =0 ; + + QSIMPLEQ_FOREACH(bm, bm_list, entry) { + nb_bitmaps++; + } + +return nb_bitmaps; +} +/* bitmap_list_load * Get bitmap list from qcow2 image. Actually reads bitmap directory, * checks it and convert to bitmap list.
@@ -437,3 +602,226 @@ out:return ret; } + +/* bitmap_list_store +* Store bitmap list to qcow2 image as a bitmap directory. +* Everything is checked. +*/ +static int bitmap_list_store (BlockDriverState *bs,Qcow2BitmapList *bm_list, +uint64_t *offset,uint64_t *size,bool in_place) +{ +int ret; +uint8_t *dir; +int64_t dir_offset =0 ; +uint64_t dir_size =0 ; +Qcow2Bitmap *bm; +Qcow2BitmapDirEntry *e; + + QSIMPLEQ_FOREACH(bm, bm_list, entry) { + dir_size +=calc_dir_entry_size (strlen (bm->name),0 ); + } + +if (dir_size ==0 || dir_size >QCOW2_MAX_BITMAP_DIRECTORY_SIZE ) { +return -EINVAL ; + } + +if (in_place) { +if (*size != dir_size || *offset ==0 ) { +return -EINVAL ; + } + + dir_offset = *offset; + } + + dir =g_try_malloc (dir_size); +if (dir ==NULL ) { +return -ENOMEM ; + } + + e = (Qcow2BitmapDirEntry *)dir; + QSIMPLEQ_FOREACH(bm, bm_list, entry) { + e->bitmap_table_offset = bm->table.offset; + e->bitmap_table_size = bm->table.size; + e->flags = bm->flags; + e->type =BT_DIRTY_TRACKING_BITMAP ; + e->granularity_bits = bm->granularity_bits; + e->name_size =strlen (bm->name); + e->extra_data_size =0 ; +memcpy (e +1 , bm->name, e->name_size); + +if (check_dir_entry (bs, e) <0 ) { + ret = -EINVAL ; + goto fail; + } + + e =next_dir_entry (e); + } + +bitmap_directory_to_be (dir, dir_size); + +if (!in_place) { + dir_offset =qcow2_alloc_clusters (bs, dir_size); +if (dir_offset <0 ) { + ret = dir_offset; + goto fail; + } + } + + ret =qcow2_pre_write_overlap_check (bs,0 , dir_offset, dir_size); +if (ret <0 ) { + goto fail; + } + + ret =bdrv_pwrite (bs->file, dir_offset, dir, dir_size); +if (ret <0 ) { + goto fail; + } + +g_free (dir); + +if (!in_place) { + *size = dir_size; + *offset = dir_offset; + } + +return 0 ; + +fail: +g_free (dir); + +if (!in_place && dir_offset >0 ) { +qcow2_free_clusters (bs, dir_offset, dir_size,QCOW2_DISCARD_OTHER ); + } + +return ret; +} + +/* +* Bitmap List end +*/ + +static int update_ext_header_and_dir_in_place (BlockDriverState *bs, +Qcow2BitmapList *bm_list) +{ +BDRVQcow2State *s = bs->opaque; +int ret; + +if (!(s->autoclear_features &QCOW2_AUTOCLEAR_BITMAPS ) || + bm_list ==NULL ||QSIMPLEQ_EMPTY (bm_list) || +bitmap_list_count (bm_list) != s->nb_bitmaps) + { +return -EINVAL ; + } + + s->autoclear_features &= ~(uint64_t )QCOW2_AUTOCLEAR_BITMAPS ; + ret =update_header_sync (bs); +if (ret <0 ) { +/* Two variants are possible here: +* 1. Autoclear flag is dropped, all bitmaps will be lost. +* 2. Autoclear flag is not dropped, old state is left. +*/ +return ret; + } + +/* autoclear bit is not set, so we can safely update bitmap directory */ + + ret =bitmap_list_store (bs, bm_list, &s->bitmap_directory_offset, + &s->bitmap_directory_size, true); +if (ret <0 ) { +/* autoclear bit is cleared, so all leaked clusters would be removed on +* qemu-img check */ +return ret; + } + + ret =update_header_sync (bs); +if (ret <0 ) { +/* autoclear bit is cleared, so all leaked clusters would be removed on +* qemu-img check */ +return ret; + } + + s->autoclear_features |=QCOW2_AUTOCLEAR_BITMAPS ; +return update_header_sync (bs); +/* If final update_header_sync() fails, two variants are possible: +* 1. Autoclear flag is not set, all bitmaps will be lost. +* 2. Autoclear flag is set, header and directory are successfully updated. +*/ +} + +/* for g_slist_foreach for GSList of BdrvDirtyBitmap* elements */ +static void release_dirty_bitmap_helper (gpointer bitmap, +gpointer bs) +{ +bdrv_release_dirty_bitmap (bs, bitmap); +} + +/* for g_slist_foreach for GSList of BdrvDirtyBitmap* elements */ +static void set_readonly_helper (gpointer bitmap,gpointer unused) +{ +bdrv_dirty_bitmap_set_readonly (bitmap); +} + +/* qcow2_load_autoloading_dirty_bitmaps() +* Return value is a hint for caller: true means that the Qcow2 header was +* updated. (false doesn't mean that the header should be updated by the +* caller, it just means that updating was not needed or the image cannot be +* written to). +* On failure the function returns false. +*/ +bool qcow2_load_autoloading_dirty_bitmaps (BlockDriverState *bs,Error **errp) +{ +BDRVQcow2State *s = bs->opaque; +Qcow2BitmapList *bm_list; +Qcow2Bitmap *bm; +GSList *created_dirty_bitmaps =NULL ; +bool header_updated = false; + +if (s->nb_bitmaps ==0 ) { +/* No bitmaps - nothing to do */ +return false; + } + + bm_list =bitmap_list_load (bs, s->bitmap_directory_offset, + s->bitmap_directory_size, errp); +if (bm_list ==NULL ) { +return false; + } + + QSIMPLEQ_FOREACH(bm, bm_list, entry) { +if ((bm->flags &BME_FLAG_AUTO ) && !(bm->flags &BME_FLAG_IN_USE )) { +BdrvDirtyBitmap *bitmap =load_bitmap (bs, bm, errp); +if (bitmap ==NULL ) { + goto fail; + } + bm->flags |=BME_FLAG_IN_USE ; + created_dirty_bitmaps = +g_slist_append (created_dirty_bitmaps, bitmap); + } + } + +if (created_dirty_bitmaps !=NULL ) { +if (can_write (bs)) { +/* in_use flags must be updated */ +int ret =update_ext_header_and_dir_in_place (bs, bm_list); +if (ret <0 ) { +error_setg_errno (errp, -ret,"Can't update bitmap directory" ); + goto fail; + } + header_updated = true; + }else { +g_slist_foreach (created_dirty_bitmaps, set_readonly_helper,NULL ); + } + } + +g_slist_free (created_dirty_bitmaps); +bitmap_list_free (bm_list); + +return header_updated; + +fail: +g_slist_foreach (created_dirty_bitmaps, release_dirty_bitmap_helper, bs); +g_slist_free (created_dirty_bitmaps); +bitmap_list_free (bm_list); + +return false; +}
block/qcow2.c +15 -2
@@ -1239,9 +1239,22 @@ static int qcow2_do_open(BlockDriverState *bs, QDict *options, int flags,/* Clear unknown autoclear feature bits */ update_header |= s->autoclear_features & ~QCOW2_AUTOCLEAR_MASK ; - -if (update_header && !bs->read_only && !(flags &BDRV_O_INACTIVE )) { + update_header = + update_header && !bs->read_only && !(flags &BDRV_O_INACTIVE ); +if (update_header) { s->autoclear_features &=QCOW2_AUTOCLEAR_MASK ; + } + +if (qcow2_load_autoloading_dirty_bitmaps (bs, &local_err)) { + update_header = false; + } +if (local_err !=NULL ) { +error_propagate (errp, local_err); + ret = -EINVAL ; + goto fail; + } + +if (update_header) { ret =qcow2_update_header (bs);if (ret <0 ) {error_setg_errno (errp, -ret,"Could not update qcow2 header" );
block/qcow2.h +2 -0
@@ -629,4 +629,6 @@ void qcow2_cache_put(BlockDriverState *bs, Qcow2Cache *c, void **table);int qcow2_check_bitmaps_refcounts (BlockDriverState *bs,BdrvCheckResult *res,void **refcount_table,int64_t *refcount_table_size); +bool qcow2_load_autoloading_dirty_bitmaps (BlockDriverState *bs,Error **errp); +#endif
Signature · 1 line
2.11.1
PATCH v19 11/25 block/dirty-bitmap: add autoload field to BdrvDirtyBitmap
In reply to Vladimir Sementsov-OgievskiyMirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be needed in future, to save this flag back to Qcow2 for persistent bitmaps.
--- block/dirty-bitmap.c | 15 +++++++++++++++ block/qcow2-bitmap.c | 2 ++ include/block/dirty-bitmap.h | 3 +++ 3 files changed, 20 insertions(+)
block/dirty-bitmap.c +15 -0
@@ -46,6 +46,8 @@ struct BdrvDirtyBitmap {int active_iterators;/* How many iterators are active */ bool readonly;/* Bitmap is read-only and may be changed only by deserialize* functions */ +bool autoload;/* For persistent bitmaps: bitmap must be +autoloaded on image opening */ QLIST_ENTRY (BdrvDirtyBitmap) list; };
@@ -72,6 +74,7 @@ void bdrv_dirty_bitmap_make_anon(BdrvDirtyBitmap *bitmap)assert (!bdrv_dirty_bitmap_frozen (bitmap));g_free (bitmap->name); bitmap->name =NULL ; + bitmap->autoload = false; } BdrvDirtyBitmap *bdrv_create_dirty_bitmap(BlockDriverState *bs,
@@ -240,6 +243,8 @@ BdrvDirtyBitmap *bdrv_dirty_bitmap_abdicate(BlockDriverState *bs, bitmap->name =NULL ; successor->name = name; bitmap->successor =NULL ; + successor->autoload = bitmap->autoload; + bitmap->autoload = false;bdrv_release_dirty_bitmap (bs, bitmap);return successor;
@@ -568,3 +573,13 @@ bool bdrv_has_readonly_bitmaps(BlockDriverState *bs)return false; } + +void bdrv_dirty_bitmap_set_autoload (BdrvDirtyBitmap *bitmap,bool autoload) +{ + bitmap->autoload = autoload; +} + +bool bdrv_dirty_bitmap_get_autoload (const BdrvDirtyBitmap *bitmap) +{ +return bitmap->autoload; +}
block/qcow2-bitmap.c +2 -0
@@ -793,6 +793,8 @@ bool qcow2_load_autoloading_dirty_bitmaps(BlockDriverState *bs, Error **errp)if (bitmap ==NULL ) { goto fail; } + +bdrv_dirty_bitmap_set_autoload (bitmap, true); bm->flags |=BME_FLAG_IN_USE ; created_dirty_bitmaps =g_slist_append (created_dirty_bitmaps, bitmap);
include/block/dirty-bitmap.h +3 -0
@@ -79,4 +79,7 @@ bool bdrv_dirty_bitmap_readonly(const BdrvDirtyBitmap *bitmap);void bdrv_dirty_bitmap_set_readonly (BdrvDirtyBitmap *bitmap);bool bdrv_has_readonly_bitmaps (BlockDriverState *bs); +void bdrv_dirty_bitmap_set_autoload (BdrvDirtyBitmap *bitmap,bool autoload); +bool bdrv_dirty_bitmap_get_autoload (const BdrvDirtyBitmap *bitmap); +#endif
Signature · 1 line
2.11.1
PATCH v19 12/25 block: bdrv_close: release bitmaps after drv->bdrv_close
In reply to Vladimir Sementsov-OgievskiyRelease bitmaps after 'if (bs->drv) { ... }' block. This will allow format driver to save persistent bitmaps, which will appear in following commits.
--- block.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
block.c +3 -3
@@ -2996,9 +2996,6 @@ static void bdrv_close(BlockDriverState *bs)bdrv_flush (bs);bdrv_drain (bs);/* in case flush left pending I/O */ -bdrv_release_named_dirty_bitmaps (bs); -assert (QLIST_EMPTY (&bs->dirty_bitmaps)); -if (bs->drv) {BdrvChild *child, *next;
@@ -3037,6 +3034,9 @@ static void bdrv_close(BlockDriverState *bs) bs->full_open_options =NULL ; } +bdrv_release_named_dirty_bitmaps (bs); +assert (QLIST_EMPTY (&bs->dirty_bitmaps)); + QLIST_FOREACH_SAFE(ban, &bs->aio_notifiers, list, ban_next) {g_free (ban); }
Signature · 1 line
2.11.1
PATCH v19 13/25 block: introduce persistent dirty bitmaps
In reply to Vladimir Sementsov-OgievskiyNew field BdrvDirtyBitmap.persistent means, that bitmap should be saved by format driver in .bdrv_close and .bdrv_inactivate. No format driver supports it for now.
--- block/dirty-bitmap.c | 26 ++++++++++++++++++++++++++ block/qcow2-bitmap.c | 1 + include/block/dirty-bitmap.h | 5 +++++ 3 files changed, 32 insertions(+)
block/dirty-bitmap.c +26 -0
@@ -48,6 +48,7 @@ struct BdrvDirtyBitmap {by deserialize* functions */ bool autoload;/* For persistent bitmaps: bitmap must be autoloaded on image opening */ +bool persistent;/* bitmap must be saved to owner disk image */ QLIST_ENTRY (BdrvDirtyBitmap) list; };
@@ -74,6 +75,7 @@ void bdrv_dirty_bitmap_make_anon(BdrvDirtyBitmap *bitmap)assert (!bdrv_dirty_bitmap_frozen (bitmap));g_free (bitmap->name); bitmap->name =NULL ; + bitmap->persistent = false; bitmap->autoload = false; }
@@ -243,6 +245,8 @@ BdrvDirtyBitmap *bdrv_dirty_bitmap_abdicate(BlockDriverState *bs, bitmap->name =NULL ; successor->name = name; bitmap->successor =NULL ; + successor->persistent = bitmap->persistent; + bitmap->persistent = false; successor->autoload = bitmap->autoload; bitmap->autoload = false;bdrv_release_dirty_bitmap (bs, bitmap);
@@ -583,3 +587,25 @@ bool bdrv_dirty_bitmap_get_autoload(const BdrvDirtyBitmap *bitmap) {return bitmap->autoload; } + +void bdrv_dirty_bitmap_set_persistance (BdrvDirtyBitmap *bitmap,bool persistent) +{ + bitmap->persistent = persistent; +} + +bool bdrv_dirty_bitmap_get_persistance (BdrvDirtyBitmap *bitmap) +{ +return bitmap->persistent; +} + +bool bdrv_has_changed_persistent_bitmaps (BlockDriverState *bs) +{ +BdrvDirtyBitmap *bm; + QLIST_FOREACH(bm, &bs->dirty_bitmaps, list) { +if (bm->persistent && !bm->readonly) { +return true; + } + } + +return false; +}
block/qcow2-bitmap.c +1 -0
@@ -794,6 +794,7 @@ bool qcow2_load_autoloading_dirty_bitmaps(BlockDriverState *bs, Error **errp) goto fail; } +bdrv_dirty_bitmap_set_persistance (bitmap, true);bdrv_dirty_bitmap_set_autoload (bitmap, true); bm->flags |=BME_FLAG_IN_USE ; created_dirty_bitmaps =
include/block/dirty-bitmap.h +5 -0
@@ -82,4 +82,9 @@ bool bdrv_has_readonly_bitmaps(BlockDriverState *bs);void bdrv_dirty_bitmap_set_autoload (BdrvDirtyBitmap *bitmap,bool autoload);bool bdrv_dirty_bitmap_get_autoload (const BdrvDirtyBitmap *bitmap); +void bdrv_dirty_bitmap_set_persistance (BdrvDirtyBitmap *bitmap, +bool persistent); +bool bdrv_dirty_bitmap_get_persistance (BdrvDirtyBitmap *bitmap); +bool bdrv_has_changed_persistent_bitmaps (BlockDriverState *bs); +#endif
Signature · 1 line
2.11.1
PATCH v19 14/25 block/dirty-bitmap: add bdrv_dirty_bitmap_next()
In reply to Vladimir Sementsov-Ogievskiy--- block/dirty-bitmap.c | 7 +++++++ include/block/dirty-bitmap.h | 3 +++ 2 files changed, 10 insertions(+)
block/dirty-bitmap.c +7 -0
@@ -609,3 +609,10 @@ bool bdrv_has_changed_persistent_bitmaps(BlockDriverState *bs)return false; } + +BdrvDirtyBitmap *bdrv_dirty_bitmap_next (BlockDriverState *bs, +BdrvDirtyBitmap *bitmap) +{ +return bitmap ==NULL ?QLIST_FIRST (&bs->dirty_bitmaps) : +QLIST_NEXT (bitmap, list); +}
include/block/dirty-bitmap.h +3 -0
@@ -87,4 +87,7 @@ void bdrv_dirty_bitmap_set_persistance(BdrvDirtyBitmap *bitmap,bool bdrv_dirty_bitmap_get_persistance (BdrvDirtyBitmap *bitmap);bool bdrv_has_changed_persistent_bitmaps (BlockDriverState *bs); +BdrvDirtyBitmap *bdrv_dirty_bitmap_next (BlockDriverState *bs, +BdrvDirtyBitmap *bitmap); +#endif
Signature · 1 line
2.11.1
PATCH v19 15/25 qcow2: add persistent dirty bitmaps support
In reply to Vladimir Sementsov-OgievskiyStore persistent dirty bitmaps in qcow2 image.
--- block/qcow2-bitmap.c | 475 +++++++++++++++++++++++++++++++++++++++++++++++++++ block/qcow2.c | 9 + block/qcow2.h | 1 + 3 files changed, 485 insertions(+)
block/qcow2-bitmap.c +475 -0
@@ -27,6 +27,7 @@#include "qemu/osdep.h" #include "qapi/error.h" +#include "qemu/cutils.h" #include "block/block_int.h" #include "block/qcow2.h"
@@ -42,6 +43,10 @@#define BME_MIN_GRANULARITY_BITS 9#define BME_MAX_NAME_SIZE 1023 +#if BME_MAX_TABLE_SIZE *8ULL >INT_MAX +#error In the code bitmap table physical size assumed to fit into int +#endif +/* Bitmap directory entry flags */ #define BME_RESERVED_FLAGS 0xfffffffcU#define BME_FLAG_IN_USE (1U << 0)
@@ -72,6 +77,8 @@ typedef struct Qcow2BitmapTable {uint32_t size;/* number of 64bit entries */ QSIMPLEQ_ENTRY (Qcow2BitmapTable) entry; } Qcow2BitmapTable; +typedef QSIMPLEQ_HEAD(Qcow2BitmapTableList, Qcow2BitmapTable) +Qcow2BitmapTableList ; typedef struct Qcow2Bitmap { Qcow2BitmapTable table;
@@ -79,6 +86,8 @@ typedef struct Qcow2Bitmap {uint8_t granularity_bits;char *name; +BdrvDirtyBitmap *dirty_bitmap; +QSIMPLEQ_ENTRY (Qcow2Bitmap) entry; } Qcow2Bitmap; typedef QSIMPLEQ_HEAD(Qcow2BitmapList, Qcow2Bitmap) Qcow2BitmapList;
@@ -104,6 +113,15 @@ static int update_header_sync(BlockDriverState *bs)return bdrv_flush (bs); } +static inline void bitmap_table_to_be (uint64_t *bitmap_table,size_t size) +{ +size_t i; + +for (i =0 ; i < size; ++i) { +cpu_to_be64s (&bitmap_table[i]); + } +} +static int check_table_entry (uint64_t entry,int cluster_size) {uint64_t offset;
@@ -127,6 +145,70 @@ static int check_table_entry(uint64_t entry, int cluster_size)return 0 ; } +static int check_constraints_on_bitmap (BlockDriverState *bs, +const char *name, +uint32_t granularity, +Error **errp) +{ +BDRVQcow2State *s = bs->opaque; +int granularity_bits =ctz32 (granularity); +int64_t len =bdrv_getlength (bs); + +assert (granularity >0 ); +assert ((granularity & (granularity -1 )) ==0 ); + +if (len <0 ) { +error_setg_errno (errp, -len,"Failed to get size of '%s'" , +bdrv_get_device_or_node_name (bs)); +return len; + } + +if (granularity_bits >BME_MAX_GRANULARITY_BITS ) { +error_setg (errp,"Granularity exceeds maximum (%llu bytes)" , +1ULL <<BME_MAX_GRANULARITY_BITS ); +return -EINVAL ; + } +if (granularity_bits <BME_MIN_GRANULARITY_BITS ) { +error_setg (errp,"Granularity is under minimum (%llu bytes)" , +1ULL <<BME_MIN_GRANULARITY_BITS ); +return -EINVAL ; + } + +if ((len > (uint64_t )BME_MAX_PHYS_SIZE << granularity_bits) || + (len > (uint64_t )BME_MAX_TABLE_SIZE * s->cluster_size << + granularity_bits)) + { +error_setg (errp,"Too much space will be occupied by the bitmap. " +"Use larger granularity" ); +return -EINVAL ; + } + +if (strlen (name) >BME_MAX_NAME_SIZE ) { +error_setg (errp,"Name length exceeds maximum (%u characters)" , +BME_MAX_NAME_SIZE ); +return -EINVAL ; + } + +return 0 ; +} + +static void clear_bitmap_table (BlockDriverState *bs,uint64_t *bitmap_table, +uint32_t bitmap_table_size) +{ +BDRVQcow2State *s = bs->opaque; +int i; + +for (i =0 ; i < bitmap_table_size; ++i) { +uint64_t addr = bitmap_table[i] &BME_TABLE_ENTRY_OFFSET_MASK ; +if (!addr) { +continue ; + } + +qcow2_free_clusters (bs, addr, s->cluster_size,QCOW2_DISCARD_OTHER ); + bitmap_table[i] =0 ; + } +} +static int bitmap_table_load (BlockDriverState *bs,Qcow2BitmapTable *tb,uint64_t **bitmap_table) {
@@ -165,6 +247,28 @@ fail:return ret; } +static int free_bitmap_clusters (BlockDriverState *bs,Qcow2BitmapTable *tb) +{ +int ret; +uint64_t *bitmap_table; + + ret =bitmap_table_load (bs, tb, &bitmap_table); +if (ret <0 ) { +assert (bitmap_table ==NULL ); +return ret; + } + +clear_bitmap_table (bs, bitmap_table, tb->size); +qcow2_free_clusters (bs, tb->offset, tb->size *sizeof (uint64_t ), +QCOW2_DISCARD_OTHER ); +g_free (bitmap_table); + + tb->offset =0 ; + tb->size =0 ; + +return 0 ; +} +/* This function returns the number of disk sectors covered by a single qcow2 * cluster of bitmap data. */ static uint64_t sectors_covered_by_bitmap_cluster(const BDRVQcow2State *s,
@@ -748,6 +852,69 @@ static int update_ext_header_and_dir_in_place(BlockDriverState *bs,*/ } +static int update_ext_header_and_dir (BlockDriverState *bs, +Qcow2BitmapList *bm_list) +{ +BDRVQcow2State *s = bs->opaque; +int ret; +uint64_t new_offset =0 ; +uint64_t new_size =0 ; +uint32_t new_nb_bitmaps =0 ; +uint64_t old_offset = s->bitmap_directory_offset; +uint64_t old_size = s->bitmap_directory_size; +uint32_t old_nb_bitmaps = s->nb_bitmaps; +uint64_t old_autocl = s->autoclear_features; + +if (bm_list !=NULL && !QSIMPLEQ_EMPTY (bm_list)) { + new_nb_bitmaps =bitmap_list_count (bm_list); + +if (new_nb_bitmaps >QCOW2_MAX_BITMAPS ) { +return -EINVAL ; + } + + ret =bitmap_list_store (bs, bm_list, &new_offset, &new_size, false); +if (ret <0 ) { +return ret; + } + + ret =bdrv_flush (bs->file->bs); +if (ret <0 ) { + goto fail; + } + + s->autoclear_features |=QCOW2_AUTOCLEAR_BITMAPS ; + }else { + s->autoclear_features &= ~(uint64_t )QCOW2_AUTOCLEAR_BITMAPS ; + } + + s->bitmap_directory_offset = new_offset; + s->bitmap_directory_size = new_size; + s->nb_bitmaps = new_nb_bitmaps; + + ret =update_header_sync (bs); +if (ret <0 ) { + goto fail; + } + +if (old_size >0 ) { +qcow2_free_clusters (bs, old_offset, old_size,QCOW2_DISCARD_OTHER ); + } + +return 0 ; + +fail: +if (new_offset >0 ) { +qcow2_free_clusters (bs, new_offset, new_size,QCOW2_DISCARD_OTHER ); + } + + s->bitmap_directory_offset = old_offset; + s->bitmap_directory_size = old_size; + s->nb_bitmaps = old_nb_bitmaps; + s->autoclear_features = old_autocl; + +return ret; +} +/* for g_slist_foreach for GSList of BdrvDirtyBitmap* elements */ static void release_dirty_bitmap_helper (gpointer bitmap,gpointer bs)
@@ -828,3 +995,311 @@ fail:return false; } + +/* store_bitmap_data() +* Store bitmap to image, filling bitmap table accordingly. +*/ +static uint64_t *store_bitmap_data (BlockDriverState *bs, +BdrvDirtyBitmap *bitmap, +uint32_t *bitmap_table_size,Error **errp) +{ +int ret; +BDRVQcow2State *s = bs->opaque; +int64_t sector; +uint64_t sbc; +uint64_t bm_size =bdrv_dirty_bitmap_size (bitmap); +const char *bm_name =bdrv_dirty_bitmap_name (bitmap); +uint8_t *buf =NULL ; +BdrvDirtyBitmapIter *dbi; +uint64_t *tb; +uint64_t tb_size = +size_to_clusters (s, +bdrv_dirty_bitmap_serialization_size (bitmap,0 , bm_size)); + +if (tb_size >BME_MAX_TABLE_SIZE || + tb_size * s->cluster_size >BME_MAX_PHYS_SIZE ) + { +error_setg (errp,"Bitmap '%s' is too big" , bm_name); +return NULL ; + } + + tb =g_try_new0 (uint64_t, tb_size); +if (tb ==NULL ) { +error_setg (errp,"No memory" ); +return NULL ; + } + + dbi =bdrv_dirty_iter_new (bitmap,0 ); + buf =g_malloc (s->cluster_size); + sbc =sectors_covered_by_bitmap_cluster (s, bitmap); +assert (DIV_ROUND_UP (bm_size, sbc) == tb_size); + +while ((sector =bdrv_dirty_iter_next (dbi)) !=-1 ) { +uint64_t cluster = sector / sbc; +uint64_t end, write_size; +int64_t off; + + sector = cluster * sbc; + end =MIN (bm_size, sector + sbc); + write_size = +bdrv_dirty_bitmap_serialization_size (bitmap, sector, end - sector); +assert (write_size <= s->cluster_size); + + off =qcow2_alloc_clusters (bs, s->cluster_size); +if (off <0 ) { +error_setg_errno (errp, -off, +"Failed to allocate clusters for bitmap '%s'" , + bm_name); + goto fail; + } + tb[cluster] = off; + +bdrv_dirty_bitmap_serialize_part (bitmap, buf, sector, end - sector); +if (write_size < s->cluster_size) { +memset (buf + write_size,0 , s->cluster_size - write_size); + } + + ret =qcow2_pre_write_overlap_check (bs,0 , off, s->cluster_size); +if (ret <0 ) { +error_setg_errno (errp, -ret,"Qcow2 overlap check failed" ); + goto fail; + } + + ret =bdrv_pwrite (bs->file, off, buf, s->cluster_size); +if (ret <0 ) { +error_setg_errno (errp, -ret,"Failed to write bitmap '%s' to file" , + bm_name); + goto fail; + } + +if (end >= bm_size) { +break ; + } + +bdrv_set_dirty_iter (dbi, end); + } + + *bitmap_table_size = tb_size; +g_free (buf); +bdrv_dirty_iter_free (dbi); + +return tb; + +fail: +clear_bitmap_table (bs, tb, tb_size); +g_free (buf); +bdrv_dirty_iter_free (dbi); +g_free (tb); + +return NULL ; +} + +/* store_bitmap() +* Store bm->dirty_bitmap to qcow2. +* Set bm->table_offset and bm->table_size accordingly. +*/ +static int store_bitmap (BlockDriverState *bs,Qcow2Bitmap *bm,Error **errp) +{ +int ret; +uint64_t *tb; +int64_t tb_offset; +uint32_t tb_size; +BdrvDirtyBitmap *bitmap = bm->dirty_bitmap; +const char *bm_name; + +assert (bitmap !=NULL ); + + bm_name =bdrv_dirty_bitmap_name (bitmap); + + tb =store_bitmap_data (bs, bitmap, &tb_size, errp); +if (tb ==NULL ) { +return -EINVAL ; + } + +assert (tb_size <=BME_MAX_TABLE_SIZE ); + tb_offset =qcow2_alloc_clusters (bs, tb_size *sizeof (tb[0 ])); +if (tb_offset <0 ) { +error_setg_errno (errp, -tb_offset, +"Failed to allocate clusters for bitmap '%s'" , + bm_name); + goto fail; + } + + ret =qcow2_pre_write_overlap_check (bs,0 , tb_offset, + tb_size *sizeof (tb[0 ])); +if (ret <0 ) { +error_setg_errno (errp, -ret,"Qcow2 overlap check failed" ); + goto fail; + } + +bitmap_table_to_be (tb, tb_size); + ret =bdrv_pwrite (bs->file, tb_offset, tb, tb_size *sizeof (tb[0 ])); +if (ret <0 ) { +error_setg_errno (errp, -ret,"Failed to write bitmap '%s' to file" , + bm_name); + goto fail; + } + +g_free (tb); + + bm->table.offset = tb_offset; + bm->table.size = tb_size; + +return 0 ; + +fail: +clear_bitmap_table (bs, tb, tb_size); + +if (tb_offset >0 ) { +qcow2_free_clusters (bs, tb_offset, tb_size *sizeof (tb[0 ]), +QCOW2_DISCARD_OTHER ); + } + +g_free (tb); + +return ret; +} + +static Qcow2Bitmap *find_bitmap_by_name (Qcow2BitmapList *bm_list, +const char *name) +{ +Qcow2Bitmap *bm; + + QSIMPLEQ_FOREACH(bm, bm_list, entry) { +if (strcmp (name, bm->name) ==0 ) { +return bm; + } + } + +return NULL ; +} + +void qcow2_store_persistent_dirty_bitmaps (BlockDriverState *bs,Error **errp) +{ +BdrvDirtyBitmap *bitmap; +BDRVQcow2State *s = bs->opaque; +uint32_t new_nb_bitmaps = s->nb_bitmaps; +uint64_t new_dir_size = s->bitmap_directory_size; +int ret; +Qcow2BitmapList *bm_list; +Qcow2Bitmap *bm; +Qcow2BitmapTableList drop_tables; +Qcow2BitmapTable *tb, *tb_next; + +if (!bdrv_has_changed_persistent_bitmaps (bs)) { +/* nothing to do */ +return ; + } + +if (!can_write (bs)) { +error_setg (errp,"No write access" ); +return ; + } + +QSIMPLEQ_INIT (&drop_tables); + +if (s->nb_bitmaps ==0 ) { + bm_list =bitmap_list_new (); + }else { + bm_list =bitmap_list_load (bs, s->bitmap_directory_offset, + s->bitmap_directory_size, errp); +if (bm_list ==NULL ) { +return ; + } + } + +/* check constraints and names */ +for (bitmap =bdrv_dirty_bitmap_next (bs,NULL ); bitmap !=NULL ; + bitmap =bdrv_dirty_bitmap_next (bs, bitmap)) + { +const char *name =bdrv_dirty_bitmap_name (bitmap); +uint32_t granularity =bdrv_dirty_bitmap_granularity (bitmap); +Qcow2Bitmap *bm; + +if (!bdrv_dirty_bitmap_get_persistance (bitmap) || +bdrv_dirty_bitmap_readonly (bitmap)) + { +continue ; + } + +if (check_constraints_on_bitmap (bs, name, granularity, errp) <0 ) { +error_prepend (errp,"Bitmap '%s' doesn't satisfy the constraints: " , + name); + goto fail; + } + + bm =find_bitmap_by_name (bm_list, name); +if (bm ==NULL ) { +if (++new_nb_bitmaps >QCOW2_MAX_BITMAPS ) { +error_setg (errp,"Too many persistent bitmaps" ); + goto fail; + } + + new_dir_size +=calc_dir_entry_size (strlen (name),0 ); +if (new_dir_size >QCOW2_MAX_BITMAP_DIRECTORY_SIZE ) { +error_setg (errp,"Bitmap directory is too large" ); + goto fail; + } + + bm =g_new0 (Qcow2Bitmap,1 ); + bm->name =g_strdup (name); +QSIMPLEQ_INSERT_TAIL (bm_list, bm, entry); + }else { +if (!(bm->flags &BME_FLAG_IN_USE )) { +error_setg (errp,"Bitmap '%s' already exists in the image" , + name); + goto fail; + } + tb =g_memdup (&bm->table,sizeof (bm->table)); + bm->table.offset =0 ; + bm->table.size =0 ; +QSIMPLEQ_INSERT_TAIL (&drop_tables, tb, entry); + } + bm->flags =bdrv_dirty_bitmap_get_autoload (bitmap) ?BME_FLAG_AUTO :0 ; + bm->granularity_bits =ctz32 (bdrv_dirty_bitmap_granularity (bitmap)); + bm->dirty_bitmap = bitmap; + } + +/* allocate clusters and store bitmaps */ + QSIMPLEQ_FOREACH(bm, bm_list, entry) { +if (bm->dirty_bitmap ==NULL ) { +continue ; + } + + ret =store_bitmap (bs, bm, errp); +if (ret <0 ) { + goto fail; + } + } + + ret =update_ext_header_and_dir (bs, bm_list); +if (ret <0 ) { +error_setg_errno (errp, -ret,"Failed to update bitmap extension" ); + goto fail; + } + +/* Bitmap directory was successfully updated, so, old data can be dropped. +* TODO it is better to reuse these clusters */ + QSIMPLEQ_FOREACH_SAFE(tb, &drop_tables, entry, tb_next) { +free_bitmap_clusters (bs, tb); +g_free (tb); + } + +bitmap_list_free (bm_list); +return ; + +fail: + QSIMPLEQ_FOREACH(bm, bm_list, entry) { +if (bm->dirty_bitmap ==NULL || bm->table.offset ==0 ) { +continue ; + } + +free_bitmap_clusters (bs, &bm->table); + } + + QSIMPLEQ_FOREACH_SAFE(tb, &drop_tables, entry, tb_next) { +g_free (tb); + } + +bitmap_list_free (bm_list); +}
block/qcow2.c +9 -0
@@ -1824,6 +1824,7 @@ static int qcow2_inactivate(BlockDriverState *bs) {BDRVQcow2State *s = bs->opaque;int ret, result =0 ; +Error *local_err =NULL ; ret =qcow2_cache_flush (bs, s->l2_table_cache);if (ret) {
@@ -1839,6 +1840,14 @@ static int qcow2_inactivate(BlockDriverState *bs) strerror(-ret)); } +qcow2_store_persistent_dirty_bitmaps (bs, &local_err); +if (local_err !=NULL ) { + result = -EINVAL ; +error_report_err (local_err); +error_report ("Persistent bitmaps are lost for node '%s'" , +bdrv_get_device_or_node_name (bs)); + } +if (result ==0 ) {qcow2_mark_clean (bs); }
block/qcow2.h +1 -0
@@ -630,5 +630,6 @@ int qcow2_check_bitmaps_refcounts(BlockDriverState *bs, BdrvCheckResult *res,void **refcount_table, int64_t *refcount_table_size);bool qcow2_load_autoloading_dirty_bitmaps (BlockDriverState *bs,Error **errp); +void qcow2_store_persistent_dirty_bitmaps (BlockDriverState *bs,Error **errp);#endif
Signature · 1 line
2.11.1
PATCH v19 16/25 block: add bdrv_can_store_new_dirty_bitmap
In reply to Vladimir Sementsov-OgievskiyThis will be needed to check some restrictions before making bitmap persistent in qmp-block-dirty-bitmap-add (this functionality will be added by future patch)
--- block.c | 22 ++++++++++++++++++++++ include/block/block.h | 3 +++ include/block/block_int.h | 5 +++++ 3 files changed, 30 insertions(+)
block.c +22 -0
@@ -4889,3 +4889,25 @@ void bdrv_del_child(BlockDriverState *parent_bs, BdrvChild *child, Error **errp) parent_bs->drv->bdrv_del_child (parent_bs, child, errp); } + +bool bdrv_can_store_new_dirty_bitmap (BlockDriverState *bs,const char *name, +uint32_t granularity,Error **errp) +{ +BlockDriver *drv = bs->drv; + +if (!drv) { +error_setg_errno (errp,ENOMEDIUM , +"Can't store persistent bitmaps to %s" , +bdrv_get_device_or_node_name (bs)); +return false; + } + +if (!drv->bdrv_can_store_new_dirty_bitmap) { +error_setg_errno (errp,ENOTSUP , +"Can't store persistent bitmaps to %s" , +bdrv_get_device_or_node_name (bs)); +return false; + } + +return drv->bdrv_can_store_new_dirty_bitmap (bs, name, granularity, errp); +}
include/block/block.h +3 -0
@@ -629,4 +629,7 @@ void bdrv_add_child(BlockDriverState *parent, BlockDriverState *child, Error **errp);void bdrv_del_child (BlockDriverState *parent,BdrvChild *child,Error **errp); +bool bdrv_can_store_new_dirty_bitmap (BlockDriverState *bs,const char *name, +uint32_t granularity,Error **errp); +#endif
include/block/block_int.h +5 -0
@@ -380,6 +380,11 @@ struct BlockDriver { uint64_t parent_perm, uint64_t parent_shared, uint64_t *nperm, uint64_t *nshared); +bool (*bdrv_can_store_new_dirty_bitmap)(BlockDriverState *bs, +const char *name, +uint32_t granularity, +Error **errp); +QLIST_ENTRY (BlockDriver) list; };
Signature · 1 line
2.11.1
PATCH v19 17/25 qcow2: add .bdrv_can_store_new_dirty_bitmap
In reply to Vladimir Sementsov-OgievskiyRealize .bdrv_can_store_new_dirty_bitmap interface.
--- block/qcow2-bitmap.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ block/qcow2.c | 2 ++ block/qcow2.h | 4 ++++ 3 files changed, 57 insertions(+)
block/qcow2-bitmap.c +51 -0
@@ -1303,3 +1303,54 @@ fail:bitmap_list_free (bm_list); } + +bool qcow2_can_store_new_dirty_bitmap (BlockDriverState *bs, +const char *name, +uint32_t granularity, +Error **errp) +{ +BDRVQcow2State *s = bs->opaque; +bool found; +Qcow2BitmapList *bm_list; + +if (check_constraints_on_bitmap (bs, name, granularity, errp) !=0 ) { + goto fail; + } + +if (s->nb_bitmaps ==0 ) { +return true; + } + +if (s->nb_bitmaps >=QCOW2_MAX_BITMAPS ) { +error_setg (errp, +"Maximum number of persistent bitmaps is already reached" ); + goto fail; + } + +if (s->bitmap_directory_size +calc_dir_entry_size (strlen (name),0 ) > +QCOW2_MAX_BITMAP_DIRECTORY_SIZE ) + { +error_setg (errp,"Not enough space in the bitmap directory" ); + goto fail; + } + + bm_list =bitmap_list_load (bs, s->bitmap_directory_offset, + s->bitmap_directory_size, errp); +if (bm_list ==NULL ) { + goto fail; + } + + found =find_bitmap_by_name (bm_list, name); +bitmap_list_free (bm_list); +if (found) { +error_setg (errp,"Bitmap with the same name is already stored" ); + goto fail; + } + +return true; + +fail: +error_prepend (errp,"Can't make bitmap '%s' persistent in '%s': " , + name,bdrv_get_device_or_node_name (bs)); +return false; +}
block/qcow2.c +2 -0
@@ -3605,6 +3605,8 @@ BlockDriver bdrv_qcow2 = { .bdrv_detach_aio_context = qcow2_detach_aio_context, .bdrv_attach_aio_context = qcow2_attach_aio_context, + + .bdrv_can_store_new_dirty_bitmap = qcow2_can_store_new_dirty_bitmap, };static void bdrv_qcow2_init (void )
block/qcow2.h +4 -0
@@ -631,5 +631,9 @@ int qcow2_check_bitmaps_refcounts(BlockDriverState *bs, BdrvCheckResult *res, int64_t *refcount_table_size);bool qcow2_load_autoloading_dirty_bitmaps (BlockDriverState *bs,Error **errp);void qcow2_store_persistent_dirty_bitmaps (BlockDriverState *bs,Error **errp); +bool qcow2_can_store_new_dirty_bitmap (BlockDriverState *bs, +const char *name, +uint32_t granularity, +Error **errp);#endif
Signature · 1 line
2.11.1
PATCH v19 18/25 qmp: add persistent flag to block-dirty-bitmap-add
In reply to Vladimir Sementsov-OgievskiyAdd optional 'persistent' flag to qmp command block-dirty-bitmap-add. Default is false.
--- blockdev.c | 18 +++++++++++++++++- qapi/block-core.json | 8 +++++++- 2 files changed, 24 insertions(+), 2 deletions(-)
blockdev.c +17 -1
@@ -1982,6 +1982,7 @@ static void block_dirty_bitmap_add_prepare(BlkActionState *common,/* AIO context taken and released within qmp_block_dirty_bitmap_add */ qmp_block_dirty_bitmap_add (action->node, action->name, action->has_granularity, action->granularity, + action->has_persistent, action->persistent, &local_err);if (!local_err) {
@@ -2730,10 +2731,12 @@ out:void qmp_block_dirty_bitmap_add (const char *node,const char *name,bool has_granularity,uint32_t granularity, +bool has_persistent,bool persistent,Error **errp) {AioContext *aio_context;BlockDriverState *bs; +BdrvDirtyBitmap *bitmap;if (!name || name[0 ] =='\0' ) {error_setg (errp,"Bitmap name cannot be empty" );
@@ -2759,7 +2762,20 @@ void qmp_block_dirty_bitmap_add(const char *node, const char *name, granularity =bdrv_get_default_bitmap_granularity (bs); } -bdrv_create_dirty_bitmap (bs, granularity, name, errp); +if (!has_persistent) { + persistent = false; + } + +if (persistent && + !bdrv_can_store_new_dirty_bitmap (bs, name, granularity, errp)) + { + goto out; + } + + bitmap =bdrv_create_dirty_bitmap (bs, granularity, name, errp); +if (bitmap !=NULL ) { +bdrv_dirty_bitmap_set_persistance (bitmap, persistent); + } out:aio_context_release (aio_context);
qapi/block-core.json +7 -1
@@ -1560,10 +1560,16 @@ # @granularity: the bitmap granularity, default is 64k for # block-dirty-bitmap-add # +# @persistent: the bitmap is persistent, i.e. it will be saved to the +# corresponding block device image file on its close. For now only +# Qcow2 disks support persistent bitmaps. Default is false for +# block-dirty-bitmap-add. (Since: 2.10) +# # Since: 2.4 ## { 'struct': 'BlockDirtyBitmapAdd', - 'data': { 'node': 'str', 'name': 'str', '*granularity': 'uint32' } } + 'data': { 'node': 'str', 'name': 'str', '*granularity': 'uint32', + '*persistent': 'bool' } } ## # @block-dirty-bitmap-add:
Signature · 1 line
2.11.1
PATCH v19 19/25 qmp: add autoload parameter to block-dirty-bitmap-add
In reply to Vladimir Sementsov-OgievskiyOptional. Default is false.
--- blockdev.c | 18 ++++++++++++++++-- qapi/block-core.json | 6 +++++- 2 files changed, 21 insertions(+), 3 deletions(-)
blockdev.c +16 -2
@@ -1983,6 +1983,7 @@ static void block_dirty_bitmap_add_prepare(BlkActionState *common,qmp_block_dirty_bitmap_add (action->node, action->name, action->has_granularity, action->granularity, action->has_persistent, action->persistent, + action->has_autoload, action->autoload, &local_err);if (!local_err) {
@@ -2732,6 +2733,7 @@ out:void qmp_block_dirty_bitmap_add (const char *node,const char *name,bool has_granularity,uint32_t granularity,bool has_persistent,bool persistent, +bool has_autoload,bool autoload,Error **errp) {AioContext *aio_context;
@@ -2765,6 +2767,15 @@ void qmp_block_dirty_bitmap_add(const char *node, const char *name,if (!has_persistent) { persistent = false; } +if (!has_autoload) { + autoload = false; + } + +if (has_autoload && !persistent) { +error_setg (errp,"Autoload flag must be used only for persistent " +"bitmaps" ); + goto out; + }if (persistent && !bdrv_can_store_new_dirty_bitmap (bs, name, granularity, errp))
@@ -2773,10 +2784,13 @@ void qmp_block_dirty_bitmap_add(const char *node, const char *name, } bitmap =bdrv_create_dirty_bitmap (bs, granularity, name, errp); -if (bitmap !=NULL ) { -bdrv_dirty_bitmap_set_persistance (bitmap, persistent); +if (bitmap ==NULL ) { + goto out; } +bdrv_dirty_bitmap_set_persistance (bitmap, persistent); +bdrv_dirty_bitmap_set_autoload (bitmap, autoload); + out:aio_context_release (aio_context); }
qapi/block-core.json +5 -1
@@ -1565,11 +1565,15 @@ # Qcow2 disks support persistent bitmaps. Default is false for # block-dirty-bitmap-add. (Since: 2.10) # +# @autoload: the bitmap will be automatically loaded when the image it is stored +# in is opened. This flag may only be specified for persistent +# bitmaps. Default is false for block-dirty-bitmap-add. (Since: 2.10) +# # Since: 2.4 ## { 'struct': 'BlockDirtyBitmapAdd', 'data': { 'node': 'str', 'name': 'str', '*granularity': 'uint32', - '*persistent': 'bool' } } + '*persistent': 'bool', '*autoload': 'bool' } } ## # @block-dirty-bitmap-add:
Signature · 1 line
2.11.1
PATCH v19 20/25 qmp: add x-debug-block-dirty-bitmap-sha256
In reply to Vladimir Sementsov-Ogievskiy--- block/dirty-bitmap.c | 5 +++++ blockdev.c | 29 +++++++++++++++++++++++++++++ include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8 ++++++++ qapi/block-core.json | 27 +++++++++++++++++++++++++++ tests/Makefile.include | 2 +- util/hbitmap.c | 11 +++++++++++ 7 files changed, 83 insertions(+), 1 deletion(-)
block/dirty-bitmap.c +5 -0
@@ -616,3 +616,8 @@ BdrvDirtyBitmap *bdrv_dirty_bitmap_next(BlockDriverState *bs,return bitmap ==NULL ?QLIST_FIRST (&bs->dirty_bitmaps) :QLIST_NEXT (bitmap, list); } + +char *bdrv_dirty_bitmap_sha256 (const BdrvDirtyBitmap *bitmap,Error **errp) +{ +return hbitmap_sha256 (bitmap->bitmap, errp); +}
blockdev.c +29 -0
@@ -2857,6 +2857,35 @@ void qmp_block_dirty_bitmap_clear(const char *node, const char *name,aio_context_release (aio_context); } +BlockDirtyBitmapSha256 *qmp_x_debug_block_dirty_bitmap_sha256 (const char *node, +const char *name, +Error **errp) +{ +AioContext *aio_context; +BdrvDirtyBitmap *bitmap; +BlockDriverState *bs; +BlockDirtyBitmapSha256 *ret =NULL ; +char *sha256; + + bitmap =block_dirty_bitmap_lookup (node, name, &bs, &aio_context, errp); +if (!bitmap || !bs) { +return NULL ; + } + + sha256 =bdrv_dirty_bitmap_sha256 (bitmap, errp); +if (sha256 ==NULL ) { + goto out; + } + + ret =g_new (BlockDirtyBitmapSha256,1 ); + ret->sha256 = sha256; + +out: +aio_context_release (aio_context); + +return ret; +} +void hmp_drive_del (Monitor *mon,const QDict *qdict) {const char *id =qdict_get_str (qdict,"id" );
include/block/dirty-bitmap.h +2 -0
@@ -90,4 +90,6 @@ bool bdrv_has_changed_persistent_bitmaps(BlockDriverState *bs);BdrvDirtyBitmap *bdrv_dirty_bitmap_next (BlockDriverState *bs,BdrvDirtyBitmap *bitmap); +char *bdrv_dirty_bitmap_sha256 (const BdrvDirtyBitmap *bitmap,Error **errp); +#endif
include/qemu/hbitmap.h +8 -0
@@ -253,6 +253,14 @@ void hbitmap_deserialize_ones(HBitmap *hb, uint64_t start, uint64_t count,void hbitmap_deserialize_finish (HBitmap *hb);/** +* hbitmap_sha256: +* @bitmap: HBitmap to operate on. +* +* Returns SHA256 hash of the last level. +*/ +char *hbitmap_sha256 (const HBitmap *bitmap,Error **errp); + +/** * hbitmap_free: * @hb: HBitmap to operate on. *
qapi/block-core.json +27 -0
@@ -1643,6 +1643,33 @@ 'data': 'BlockDirtyBitmap' } ## +# @BlockDirtyBitmapSha256: +# +# SHA256 hash of dirty bitmap data +# +# @sha256: ASCII representation of SHA256 bitmap hash +# +# Since: 2.10 +## + { 'struct': 'BlockDirtyBitmapSha256', + 'data': {'sha256': 'str'} } + +## +# @x-debug-block-dirty-bitmap-sha256: +# +# Get bitmap SHA256 +# +# Returns: BlockDirtyBitmapSha256 on success +# If @node is not a valid block device, DeviceNotFound +# If @name is not found or if hashing has failed, GenericError with an +# explanation +# +# Since: 2.10 +## + { 'command': 'x-debug-block-dirty-bitmap-sha256', + 'data': 'BlockDirtyBitmap', 'returns': 'BlockDirtyBitmapSha256' } + +## # @blockdev-mirror: # # Start mirroring a block device's writes to a new destination.
tests/Makefile.include +1 -1
@@ -552,7 +552,7 @@ tests/test-blockjob$(EXESUF): tests/test-blockjob.o $(test-block-obj-y) $(test-u tests/test-blockjob-txn$(EXESUF): tests/test-blockjob-txn.o $(test-block-obj-y) $(test-util-obj-y) tests/test-thread-pool$(EXESUF): tests/test-thread-pool.o $(test-block-obj-y) tests/test-iov$(EXESUF): tests/test-iov.o $(test-util-obj-y) -tests/test-hbitmap$(EXESUF): tests/test-hbitmap.o $(test-util-obj-y) +tests/test-hbitmap$(EXESUF): tests/test-hbitmap.o $(test-util-obj-y) $(test-crypto-obj-y) tests/test-x86-cpuid$(EXESUF): tests/test-x86-cpuid.o tests/test-xbzrle$(EXESUF): tests/test-xbzrle.o migration/xbzrle.o migration/page_cache.o $(test-util-obj-y) tests/test-cutils$(EXESUF): tests/test-cutils.o util/cutils.o
util/hbitmap.c +11 -0
@@ -13,6 +13,7 @@#include "qemu/hbitmap.h" #include "qemu/host-utils.h" #include "trace.h" +#include "crypto/hash.h" /* HBitmaps provides an array of bits. The bits are stored as usual in an * array of unsigned longs, but HBitmap is also optimized to provide fast
@@ -727,3 +728,13 @@ void hbitmap_free_meta(HBitmap *hb)hbitmap_free (hb->meta); hb->meta =NULL ; } + +char *hbitmap_sha256 (const HBitmap *bitmap,Error **errp) +{ +size_t size = bitmap->sizes[HBITMAP_LEVELS -1 ] *sizeof (unsigned long ); +char *data = (char *)bitmap->levels[HBITMAP_LEVELS -1 ]; +char *hash =NULL ; +qcrypto_hash_digest (QCRYPTO_HASH_ALG_SHA256 , data, size, &hash, errp); + +return hash; +}
Signature · 1 line
2.11.1
PATCH v19 21/25 iotests: test qcow2 persistent dirty bitmap
In reply to Vladimir Sementsov-Ogievskiy--- tests/qemu-iotests/165 | 105 +++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/165.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 111 insertions(+) create mode 100755 tests/qemu-iotests/165 create mode 100644 tests/qemu-iotests/165.out
tests/qemu-iotests/165 new file +105 -0
@@ -0,0 +1,105 @@ +#!/usr/bin/env python +# +# Tests for persistent dirty bitmaps. +# +# Copyright: Vladimir Sementsov-Ogievskiy 2015-2017 +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. +# + +import os +import re +import iotests +from iotests import qemu_img + +disk = os.path.join(iotests.test_dir, 'disk') +disk_size = 0x40000000 # 1G + +# regions for qemu_io: (start, count) in bytes +regions1 = ((0, 0x100000), + (0x200000, 0x100000)) + +regions2 = ((0x10000000, 0x20000), + (0x3fff0000, 0x10000)) + +class TestPersistentDirtyBitmap(iotests.QMPTestCase): + + def setUp(self): + qemu_img('create', '-f', iotests.imgfmt, disk, str(disk_size)) + + def tearDown(self): + os.remove(disk) + + def mkVm(self): + return iotests.VM().add_drive(disk) + + def mkVmRo(self): + return iotests.VM().add_drive(disk, opts='readonly=on') + + def getSha256(self): + result = self.vm.qmp('x-debug-block-dirty-bitmap-sha256', + node='drive0', name='bitmap0') + return result['return']['sha256'] + + def checkBitmap(self, sha256): + result = self.vm.qmp('x-debug-block-dirty-bitmap-sha256', + node='drive0', name='bitmap0') + self.assert_qmp(result, 'return/sha256', sha256); + + def writeRegions(self, regions): + for r in regions: + self.vm.hmp_qemu_io('drive0', + 'write %d %d' % r) + + def qmpAddBitmap(self): + self.vm.qmp('block-dirty-bitmap-add', node='drive0', + name='bitmap0', persistent=True, autoload=True) + + def test_persistent(self): + self.vm = self.mkVm() + self.vm.launch() + self.qmpAddBitmap() + + self.writeRegions(regions1) + sha256 = self.getSha256() + + self.vm.shutdown() + + self.vm = self.mkVmRo() + self.vm.launch() + self.vm.shutdown() + + #catch 'Persistent bitmaps are lost' possible error + log = self.vm.get_log() + log = re.sub(r'^\[I \d+\.\d+\] OPENED\n', '', log) + log = re.sub(r'\[I \+\d+\.\d+\] CLOSED\n?$', '', log) + if log: + print log + + self.vm = self.mkVm() + self.vm.launch() + + self.checkBitmap(sha256) + self.writeRegions(regions2) + sha256 = self.getSha256() + + self.vm.shutdown() + self.vm.launch() + + self.checkBitmap(sha256) + + self.vm.shutdown() + +if __name__ == '__main__': + iotests.main(supported_fmts=['qcow2'])
tests/qemu-iotests/165.out new file +5 -0
@@ -0,0 +1,5 @@ +. +---------------------------------------------------------------------- +Ran 1 tests + +OK
tests/qemu-iotests/group +1 -0
@@ -163,6 +163,7 @@ 159 rw auto quick 160 rw auto quick 162 auto quick +165 rw auto quick 170 rw auto quick 171 rw auto quick 172 auto
Signature · 1 line
2.11.1
PATCH v19 22/25 block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap
In reply to Vladimir Sementsov-OgievskiyInterface for removing persistent bitmap from its storage.
--- block/dirty-bitmap.c | 18 ++++++++++++++++++ include/block/block_int.h | 3 +++ include/block/dirty-bitmap.h | 3 +++ 3 files changed, 24 insertions(+)
block/dirty-bitmap.c +18 -0
@@ -329,12 +329,30 @@ void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap)/** * Release all named dirty bitmaps attached to a BDS (for use in bdrv_close()). * There must not be any frozen bitmaps attached. +* This function does not remove persistent bitmaps from the storage. */ void bdrv_release_named_dirty_bitmaps (BlockDriverState *bs) {bdrv_do_release_matching_dirty_bitmap (bs,NULL , true); } +/** +* Remove persistent dirty bitmap from the storage if it exists. +* Absence of bitmap is not an error, because we have the following scenario: +* BdrvDirtyBitmap can have .persistent = true but not yet saved and have no +* stored version. For such bitmap bdrv_remove_persistent_dirty_bitmap() should +* not fail. +* This function doesn't release corresponding BdrvDirtyBitmap. +*/ +void bdrv_remove_persistent_dirty_bitmap (BlockDriverState *bs, +const char *name, +Error **errp) +{ +if (bs->drv && bs->drv->bdrv_remove_persistent_dirty_bitmap) { + bs->drv->bdrv_remove_persistent_dirty_bitmap (bs, name, errp); + } +} +void bdrv_disable_dirty_bitmap (BdrvDirtyBitmap *bitmap) {assert (!bdrv_dirty_bitmap_frozen (bitmap));
include/block/block_int.h +3 -0
@@ -384,6 +384,9 @@ struct BlockDriver {const char *name, uint32_t granularity, Error **errp); +void (*bdrv_remove_persistent_dirty_bitmap)(BlockDriverState *bs, +const char *name, +Error **errp);QLIST_ENTRY (BlockDriver) list; };
include/block/dirty-bitmap.h +3 -0
@@ -25,6 +25,9 @@ BdrvDirtyBitmap *bdrv_find_dirty_bitmap(BlockDriverState *bs,void bdrv_dirty_bitmap_make_anon (BdrvDirtyBitmap *bitmap);void bdrv_release_dirty_bitmap (BlockDriverState *bs,BdrvDirtyBitmap *bitmap);void bdrv_release_named_dirty_bitmaps (BlockDriverState *bs); +void bdrv_remove_persistent_dirty_bitmap (BlockDriverState *bs, +const char *name, +Error **errp);void bdrv_disable_dirty_bitmap (BdrvDirtyBitmap *bitmap);void bdrv_enable_dirty_bitmap (BdrvDirtyBitmap *bitmap);BlockDirtyInfoList *bdrv_query_dirty_bitmaps (BlockDriverState *bs);
Signature · 1 line
2.11.1
PATCH v19 23/25 qcow2: add .bdrv_remove_persistent_dirty_bitmap
In reply to Vladimir Sementsov-OgievskiyRealize .bdrv_remove_persistent_dirty_bitmap interface.
--- block/qcow2-bitmap.c | 41 +++++++++++++++++++++++++++++++++++++++++ block/qcow2.c | 1 + block/qcow2.h | 3 +++ 3 files changed, 45 insertions(+)
block/qcow2-bitmap.c +41 -0
@@ -1174,6 +1174,47 @@ static Qcow2Bitmap *find_bitmap_by_name(Qcow2BitmapList *bm_list,return NULL ; } +void qcow2_remove_persistent_dirty_bitmap (BlockDriverState *bs, +const char *name, +Error **errp) +{ +int ret; +BDRVQcow2State *s = bs->opaque; +Qcow2Bitmap *bm; +Qcow2BitmapList *bm_list; + +if (s->nb_bitmaps ==0 ) { +/* Absence of the bitmap is not an error: see explanation above +* bdrv_remove_persistent_dirty_bitmap() definition. */ +return ; + } + + bm_list =bitmap_list_load (bs, s->bitmap_directory_offset, + s->bitmap_directory_size, errp); +if (bm_list ==NULL ) { +return ; + } + + bm =find_bitmap_by_name (bm_list, name); +if (bm ==NULL ) { + goto fail; + } + +QSIMPLEQ_REMOVE (bm_list, bm, Qcow2Bitmap, entry); + + ret =update_ext_header_and_dir (bs, bm_list); +if (ret <0 ) { +error_setg_errno (errp, -ret,"Failed to update bitmap extension" ); + goto fail; + } + +free_bitmap_clusters (bs, &bm->table); + +fail: +bitmap_free (bm); +bitmap_list_free (bm_list); +} +void qcow2_store_persistent_dirty_bitmaps (BlockDriverState *bs,Error **errp) {BdrvDirtyBitmap *bitmap;
block/qcow2.c +1 -0
@@ -3607,6 +3607,7 @@ BlockDriver bdrv_qcow2 = { .bdrv_attach_aio_context = qcow2_attach_aio_context, .bdrv_can_store_new_dirty_bitmap = qcow2_can_store_new_dirty_bitmap, + .bdrv_remove_persistent_dirty_bitmap = qcow2_remove_persistent_dirty_bitmap, };static void bdrv_qcow2_init (void )
block/qcow2.h +3 -0
@@ -635,5 +635,8 @@ bool qcow2_can_store_new_dirty_bitmap(BlockDriverState *bs,const char *name, uint32_t granularity, Error **errp); +void qcow2_remove_persistent_dirty_bitmap (BlockDriverState *bs, +const char *name, +Error **errp);#endif
Signature · 1 line
2.11.1
PATCH v19 24/25 qmp: block-dirty-bitmap-remove: remove persistent
In reply to Vladimir Sementsov-OgievskiyRemove persistent bitmap from the storage on block-dirty-bitmap-remove.
--- blockdev.c | 10 ++++++++++ qapi/block-core.json | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-)
blockdev.c +10 -0
@@ -2801,6 +2801,7 @@ void qmp_block_dirty_bitmap_remove(const char *node, const char *name,AioContext *aio_context;BlockDriverState *bs;BdrvDirtyBitmap *bitmap; +Error *local_err =NULL ; bitmap =block_dirty_bitmap_lookup (node, name, &bs, &aio_context, errp);if (!bitmap || !bs) {
@@ -2813,6 +2814,15 @@ void qmp_block_dirty_bitmap_remove(const char *node, const char *name, name); goto out; } + +if (bdrv_dirty_bitmap_get_persistance (bitmap)) { +bdrv_remove_persistent_dirty_bitmap (bs, name, &local_err); +if (local_err !=NULL ) { +error_propagate (errp, local_err); + goto out; + } + } +bdrv_dirty_bitmap_make_anon (bitmap);bdrv_release_dirty_bitmap (bs, bitmap);
qapi/block-core.json +2 -1
@@ -1600,7 +1600,8 @@ # @block-dirty-bitmap-remove: # # Stop write tracking and remove the dirty bitmap that was created -# with block-dirty-bitmap-add. +# with block-dirty-bitmap-add. If the bitmap is persistent, remove it from its +# storage too. # # Returns: nothing on success # If @node is not a valid block device or node, DeviceNotFound
Signature · 1 line
2.11.1
PATCH v19 25/25 block: release persistent bitmaps on inactivate
In reply to Vladimir Sementsov-OgievskiyWe should release them here to reload on invalidate cache.
--- block.c | 4 ++++ block/dirty-bitmap.c | 29 +++++++++++++++++++++++------ include/block/dirty-bitmap.h | 1 + 3 files changed, 28 insertions(+), 6 deletions(-)
block.c +4 -0
@@ -4091,6 +4091,10 @@ static int bdrv_inactivate_recurse(BlockDriverState *bs, } } +/* At this point persistent bitmaps should be already stored by the format +* driver */ +bdrv_release_persistent_dirty_bitmaps (bs); +return 0 ; }
block/dirty-bitmap.c +23 -6
@@ -296,13 +296,18 @@ void bdrv_dirty_bitmap_truncate(BlockDriverState *bs) } } -static void bdrv_do_release_matching_dirty_bitmap (BlockDriverState *bs, -BdrvDirtyBitmap *bitmap, -bool only_named) +static bool bdrv_dirty_bitmap_has_name (BdrvDirtyBitmap *bitmap) +{ +return !!bdrv_dirty_bitmap_name (bitmap); +} + +static void bdrv_do_release_matching_dirty_bitmap ( +BlockDriverState *bs,BdrvDirtyBitmap *bitmap, +bool (*cond)(BdrvDirtyBitmap *bitmap)) {BdrvDirtyBitmap *bm, *next; QLIST_FOREACH_SAFE(bm, &bs->dirty_bitmaps, list, next) { -if ((!bitmap || bm == bitmap) && (!only_named || bm->name)) { +if ((!bitmap || bm == bitmap) && (!cond ||cond (bm))) {assert (!bm->active_iterators);assert (!bdrv_dirty_bitmap_frozen (bm));assert (!bm->meta);
@@ -323,7 +328,7 @@ static void bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs,void bdrv_release_dirty_bitmap (BlockDriverState *bs,BdrvDirtyBitmap *bitmap) { -bdrv_do_release_matching_dirty_bitmap (bs, bitmap, false); +bdrv_do_release_matching_dirty_bitmap (bs, bitmap,NULL ); }/**
@@ -333,7 +338,19 @@ void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap)*/ void bdrv_release_named_dirty_bitmaps (BlockDriverState *bs) { -bdrv_do_release_matching_dirty_bitmap (bs,NULL , true); +bdrv_do_release_matching_dirty_bitmap (bs,NULL , bdrv_dirty_bitmap_has_name); +} + +/** +* Release all persistent dirty bitmaps attached to a BDS (for use in +* bdrv_inactivate_recurse()). +* There must not be any frozen bitmaps attached. +* This function does not remove persistent bitmaps from the storage. +*/ +void bdrv_release_persistent_dirty_bitmaps (BlockDriverState *bs) +{ +bdrv_do_release_matching_dirty_bitmap (bs,NULL , + bdrv_dirty_bitmap_get_persistance); }/**
include/block/dirty-bitmap.h +1 -0
@@ -25,6 +25,7 @@ BdrvDirtyBitmap *bdrv_find_dirty_bitmap(BlockDriverState *bs,void bdrv_dirty_bitmap_make_anon (BdrvDirtyBitmap *bitmap);void bdrv_release_dirty_bitmap (BlockDriverState *bs,BdrvDirtyBitmap *bitmap);void bdrv_release_named_dirty_bitmaps (BlockDriverState *bs); +void bdrv_release_persistent_dirty_bitmaps (BlockDriverState *bs);void bdrv_remove_persistent_dirty_bitmap (BlockDriverState *bs,const char *name,Error **errp);
Signature · 1 line
2.11.1
09 should be reworked as discussed in v18 thread, so wait for v20, I hope I'll make it in two days.
Quoted 435 lines · Vladimir Sementsov-Ogievskiy
Hi all!
There is a new update of qcow2-bitmap series - v19.
web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v19
git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v19)v19:
rebased on master
05: move 'sign-off' over 'reviewed-by's
08:error_report->error_setginqcow2_truncate(because of rebase) 09: return EPERM inbdrv_aligned_pwritevandbdrv_co_pdiscardif there
are readonly bitmaps. EPERM is chosen because it is already used for readonly image inbdrv_co_pdiscard.
Also handle readonly bitmap inblock_dirty_bitmap_clear_prepareandqmp_block_dirty_bitmap_clear
Max's r-b is not added
10: fix grammar in comment
add Max's r-b
12, 13, 15, 21: add Max's r-b
24: fix grammar in comment
25: fix grammar and wording in comment
also, I see contextual changes in inactiavate mechanism. Hope, they do not affect these series.v18:
rebased on master (sorry for v17)
08: contextual:
qcow2_do_openis changed instead ofqcow2_open
rename s/need_update_header/update_header/ inqcow2_do_open, to not do it in 10
save r-b's by Max and John
09: new patch
10:load_bitmap_data: do not clear bitmap parameter - it should be already cleared
(it actually created before singleload_bitmap_data()call)
if some bitmaps are loaded, but we can't write the image (it is readonly
or inactive), so we can't mark bitmaps "in use" in the image, mark
corresponding BdrvDirtyBitmap read-only.
changeerror_setgtoerror_setg_errnofor "Can't update bitmap directory"
no needs to rename s/need_update_header/update_header/ here, as it done in 08
13: functionbdrv_has_persistent_bitmapsbecomesbdrv_has_changed_persistent_bitmaps,
to handle readonly field.
14: declaration moved to the bottom of .h, save r-b's
15: firstly checkbdrv_has_changed_persistent_bitmapsand only then fail on !can_write, and thenQSIMPLEQ_INIT(&drop_tables)
skip readonly bitmaps in saving loop
18: remove '#optional', 2.9 -> 2.10, save r-b's
19: remove '#optional', 2.9 -> 2.10, save r-b's
20: 2.9 -> 2.10, save r-b's
21: add check of read-only image open, drop r-b's
24: add comment toqapi/block-core.json, that block-dirty-bitmap-add removes bitmap
from storage. r-b's by Max and John savedv17:
08: add r-b's by Max and John
09: clear unknown autoclear features from BDRVQcow2State before calling
qcow2_load_autoloading_dirty_bitmaps(), and also do not extra update header if it is updated byqcow2_load_autoloading_dirty_bitmaps().
11: new patch, splitted out from 16
12: rewrite commit message
14: changingbdrv_closemoved to separate new patch 11s/1/1ULL/ ; s/%u/%llu/ for two errors16: s/No/Not/
add Max's r-b
24: new patchv16:
mostly by Kevin's comments:
07: just moved here, as preparation for merging refcounts to 08
08: move "qcow2-bitmap: refcounts" staff to this patch, to not break qcow2-img check
drop r-b's
move necessary supporting static functions to this patch too (to not break compilation) fprintf ->error_report
other small changes with error messages and comments
code style
forqcow2-bitmap.c:
'include "exec/log.h"' was dropped
s/1/(1U << 0) forBME_FLAG_IN_USE
addBME_TABLE_ENTRY_FLAG_ALL_ONESto replace magic 1
don't check 'cluster_size<= 0' incheck_table_entry
old "[PATCH v15 08/25] block: introduce auto-loading bitmaps" was dropped
09: was "[PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps"
drop r-b's
some staff was moved to 08
update_header_sync- error onbdrv_flushfail
renamedisk_sectors_in_bitmap_clustertosectors_covered_by_bitmap_cluster
and adjust comment.
so, variable for storing this function result: s/dsc/sbc/
s/1/BME_TABLE_ENTRY_FLAG_ALL_ONES/
also, as Qcow2BitmapTable already introduced in 08,
s/table_offset/table.offset/ and s/table_size/table.size, etc..
update_ext_header_and_dir_in_place: add comments, add additional
update_header_sync, to reduce indeterminacy in case of error.
callqcow2_load_autoloading_dirty_bitmapsdirectly fromqcow2_open
no .bdrv_load_autoloading_dirty_bitmaps
11: dropbdrv_store_persistent_dirty_bitmapsat all.
drop r-b's
13: rename patch, rewrite commit msg
drop r-b's
movebdrv_release_named_dirty_bitmapsinbdrv_close()afterdrv->bdrv_close()Qcow2BitmapTable is already introduced, so no
s/table_offset/table.offset/ and s/table_size/table.size, etc.. here
old 25 withcheck_constraints_on_bitmap()improvements merged here (Eric)
like in 09, s/dsc/sbc/ and s/disk_sectors_in_bitmap_cluster/sectors_covered_by_bitmap_cluster/ no .bdrv_store_persistent_dirty_bitmaps
callqcow2_store_persistent_dirty_bitmapsdirectly fromqcow2_inactivate
15: corresponding part of 25 merged here. Add John's r-b, as 25 was also reviewed by John. 16: add John's r-bv15:
13,14: add John's r-b
15:qcow2_can_store_new_dirty_bitmap:
- check max dirty bitmaps and bitmap directory overhead
- switch toerror_prepend
rm Max's r-b
not add John's r-b
17-24: add John's r-b
25: changed because 15 changed,
not add John's r-bv14:
07: use '|=' to update
need_update_header
add John's r-b
add Max's r-b
09: remove unusedbitmap_table_to_cpu()
left Max's r-b, hope it's ok
add John's r-b
10: remove extra new line
add John's r-b
11: add John's r-b
12: add John's r-b
13: small fixes by John's review:
- remove weirdg_freeof NULL pointer from
if (tb == NULL) {
g_free(tb);
return-EINVAL;
}
- remove extra comment "/* errp is already set */"
- s/"Too large bitmap directory"/"Bitmap directory is too large"/
left Max's r-b, hope you don't mind
22: add Max's r-b
23: add Max's r-b
24: add Max's r-b
25: new patch to improve error message oncheck_constraints_on_bitmapfailv13: Just a fix for style checker.
13: line over 80
14: line over 80
22: s/if () \n{/if () {/v12:
07: do not update header inqcow2_read_extensions, instead do it in the
end ofqcow2_open, where it is updated also to clear unknown autoclear features.
Wrongbdrv_is_root_nodeused instead ofbdrv_is_read_onlyis fixed automatically.
08: add Max's r-b
09: contextual: s/raw_bsd/raw-format/
qcow2-bitmap.c: copyright s/2016/2017/
fix compilation: moveupdate_header_sync()to this patch
add Max's r-b
13:update_header_sync()is moved to 09
add Max's r-b
15: add Max's r-b
16: As qmp-commands.txt is removed from master, remove it here too.
Sentence "For now only Qcow2 disks support persistent bitmaps.
Default is false." moved toqapi/block-core.json.
Hope that is OK, Max's r-b is not dropped.
17: qmp-commands.txt deleted, r-b is not dropped too.
18: s/is failed/has failed/, add Max's r-b
19: copyright: s/2016/2017/
21: drop "res->corruptions> 0 => ret =-EINVAL", add Max's r-b
22: actually, patch is replaced with a new one, however some parts are the same.
instead of changingbdrv_release_dirty_bitmapbehaviour, create newbdrv_remove_persistent_dirty_bitmap
23: improve comment, about not-exists is not an error
24: new patchOld 24 (qcow2-bitmap: cache bitmap list in BDRVQcow2State) will be sent separately, to be applied after these series.
Also: about
bdrv_dirty_bitmap_set_persistance: I've decided not change its behaviour for now and just callbdrv_remove_persistent_dirty_bitmapfromqmp_block_dirty_bitmap_remove. Reasons:
1. Do not change reviewed part.
2. I'm not sure, that this complication of BdrvDirtyBitmap.persistent semantics is good (current semantics are just: .persistent means that bitmap should be saved on disk close). .persistent actually is not very related to "is there stored version of the bitmap in the image".
3. It may be done later.
4. It is not actually needed for now, as the only usage is dropping bitmap inbdrv_remove_persistent_dirty_bitmap. May be in future it will be needed, when we will have qmp interfaces for finer control of persistent dirty bitmaps.v11:
Fix automatic build test fail.
18: wording - "ASCII representation of SHA256 ..."
24: fix redeclaration error. (This is still RFC, may be not needed patch,
see description in v10 below).v10:
07: rm John's r-b
not add Max's r-b
fix subject s/dirty bitmaps/bitmaps
improve WARNING message
remove header ext if autoclear bit is unset, throughqcow2_updata_header()- r-b blocking change
08: movebdrv_load_autoloading_dirty_bitmapsunder asserts block (Max)
fix typo in commit message
movebdrv_load_autoloading_dirty_bitmapsafter asserts
John's r-b
09: rewritecheck_dir_entry
remove extra feature cluster_size=0 fromcheck_table_entry
which clears autoclear bit before trying to update bitmap directorybitmap_list_store- do not free old clusters if in_place=true
changes in comments, fix indents
add functions
bitmap_list_count
update_ext_header_and_dir_in_place(unset autoclear bit before trying to
modify bitmap directory)
(for usage inqcow2_load_autoloading_dirty_bitmaps)
11: add node name to error report
Max's r-b
13: add type Qcow2BitmapTable
move from bm.table_* to bm.table.*
rewritecheck_constraints_on_bitmap
flush(bs->file)instead of flush(bs) inupdate_ext_header_and_dirassert(DIV_ROUND_UP(bm_size, dsc) == tb_size);
andassert(write_size <= s->cluster_size); instore_bitmap_data
fix: s/tb_size/tb_size *sizeof(tb[0])instore_bitmap
inqcow2_store_persistent_dirty_bitmaps:
fail if !can_write
fix counting ofnew_nb_bitmapsandnew_dir_size
free old clusters _after_ successful directory update (aggregate old bitmap
tables intodrop_tables)
2 14: rename tocan_store_new_dirty_bitmap
Max's r-b
15: rename tocan_store_new_dirty_bitmap
rm extra !!
16: Max's r-b
rename tocan_store_new_dirty_bitmap
indenting
Since s/2.8/2.9
17: Max's r-bSince s/2.8/2.918: hashing can fail in comment for qapi
Since s/2.8/2.9
remove dead comment
19: indentation
Max's r-b
20: Max's r-b
21: fix error handlingreturn 0 if nb_bitmaps == 0new patches:
22-23: remove bitmap from file onbdrv_release_dirty_bitmap
24: experimental, RFC: cache bitmap list to bs, to not reload it from file.
I'm not sure that is needed now, but if you want I can merge it to earlier patches.v9:
rebase on master!
01-04,06,07: John's r-b
03: rewording in comment ("The concurrent resetting ..."), John's r-b 07: reword error messagescommit message: dirty bitmap -> bitmap09: fix uninitialized ret in
bitmap_list_store()(fix compilation warning) 18: fix compilation of tests/test-hbitmapalso, change constants names for qcow2:
DIRTY_BITMAP-> BITMAP (as it is not dirty bitmaps extension, but just bitmaps extension), QCOW -> QCOW2 (bitmaps are only for qcow2)v8:
Patches 01-06 are mostly unchanged, except for spelling and wording. 02 - add Eric's r-b
03,04 - add Max's r-b07-09 is refactored "bitmap-read" part of the feature. Main changes:
- introduce bitmap list - normal list, which represents bitmap directory. Functionbitmap_list_loadloads bitmap directory, checks everything and creates normal list.
- introduce .bdrv_load_autoloading_dirty_bitmaps : instead of loading bitmaps inqcow2_open, lets load them only inbdrv_open, to avoid reloading inbdrv_snapshot_goto
- do not delete bitmaps after read, but mark themIN_USE10 has contextual changes and rewording of comment. I've added Max's r-b, hope it's ok.
11: add
error_report("Persistent bitmaps are lost")in case of failed bitmap store12: add Max's r-b
13 is refactored "bitmap-store" part of the feature. see 07-09 description
- for now I just free old clusters and allocate new. This will be improved with a separate patch.patch about "delete bitmaps on truncate" is removed. This case will be handled later.
IN_USE, autoclear, check-constraints things are merged into other patches.14-15 are mew patches, to early check possibility of creating persistent bitmap with
specified name and granularity in specified BDS16-17: spelling, rewording, indenting, tiny code simplifying, check
can_store(by 14-15),
s/if (autoload && !persistent)/if (has_autoload&& !persistent)/, rebase (deleted qmp-commands.hx)18: alternative to md5 in query-block:
- separated qmp command -x-debug-block-dirty-bitmap-sha256
- as adviced by Daniel P. Berrange in my parallel thread:
- sha256 instead of md5
- use qcrypto_hash_* instead of GChecksum
- fix bug =) (size was wrong inhbitmap_md5)19: s/3999/3fff/, use x-debug-block-dirty-bitmap-sha256
20: new patch to rename and publish
inc_refcounts21: some fixes and refactoring mostyly by Max's comments.
Max, Eric, great tanks for your review!
I hope, I've covered most of your comments by this update.TODO:
- handle reopening imageRO->RWand incoming migration, setIN_USEfor existing loaded bitmaps in these cases.
- reuse old, already allocated data clusters for bitmaps storing
- truncate bitmaps in the image on truncatev7:
https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=refs%2Ftags%2Fqcow2-bitmap-v7
based on block-next (https://github.com/XanClic/qemu/commits/block-next)- a lot of refactoring and reordering of patches.
- dead code removed (bdrv_dirty_bitmap_load, etc.)
- do not maintain extra data for now
- do not store dirty bitmap directory in memory (as we use it seldom, we can just reread if needed)By Kevin's review:
01 - commit message changed:fix->improvement(as it was not a bug) 03 - r-b
04 - r-b
05 - add 21 patch to fix spec, also, removed all (I hope) mentions of
"Bitmap Header", switch to one unified name for it - "Bitmap Directory Entry", to avoid misunderstanding with Qcow2 header. (also, add patch 22, to fix it in spec)
v6.06 - improvefor_each_dir_entryloop, reorder patches, other small fixes v6.07 ~> v7.09 - dead code removed, I've moved to one function
.bdrv_store_persistent_bitmaps and have wrapper and callback in one patch (with also some other staff. If it not ok, I can split them)
v6.08 - about keeping bitmap directory instead of bitmap list: no I don't keep
it at all.
v6.16 - oldbdrv_bitmap-storing related functions are removed. The new one is
bdrv_store_persistent_bitmaps.v6:
https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=refs%2Ftags%2Fqcow2-bitmap-v6
based on block-next (https://github.com/XanClic/qemu/commits/block-next)There are a lot of changes, reorderings and additions in comparement with v5. One principal thing: now bitmaps are removed from image after loading instead of marking them
in_use. It is simpler and we do not need to store superfluous data. Also, we are no more interested in command line interface to dirty bitmaps. So it is dropped. If someone needs it I can add it later.Vladimir Sementsov-Ogievskiy (25):
specs/qcow2: fix bitmap granularity qemu-specific note specs/qcow2: do not use wording 'bitmap header'
hbitmap: improve dirty iter
tests: add hbitmap iter test
block: fixbdrv_dirty_bitmap_granularitysignatureblock/dirty-bitmap: adddeserialize_onesfunc
qcow2-refcount: renameinc_refcounts()and make it public
qcow2: add bitmaps extension
block/dirty-bitmap: add readonly field to BdrvDirtyBitmap
qcow2: autoloading dirty bitmapsblock/dirty-bitmap: add autoload field to BdrvDirtyBitmap
block:bdrv_close: release bitmaps afterdrv->bdrv_close
block: introduce persistent dirty bitmapsblock/dirty-bitmap: addbdrv_dirty_bitmap_next()
qcow2: add persistent dirty bitmaps support
block: addbdrv_can_store_new_dirty_bitmap
qcow2: add .bdrv_can_store_new_dirty_bitmap
qmp: add persistent flag to block-dirty-bitmap-add
qmp: add autoload parameter to block-dirty-bitmap-add
qmp: add x-debug-block-dirty-bitmap-sha256
iotests: test qcow2 persistent dirty bitmapblock/dirty-bitmap: addbdrv_remove_persistent_dirty_bitmap
qcow2: add .bdrv_remove_persistent_dirty_bitmap
qmp: block-dirty-bitmap-remove: remove persistent
block: release persistent bitmaps on inactivateblock.c | 32 +- block/Makefile.objs | 2 +- block/dirty-bitmap.c | 137 ++++- block/io.c | 8 + block/qcow2-bitmap.c | 1397 ++++++++++++++++++++++++++++++++++++++++++ block/qcow2-refcount.c | 59 +- block/qcow2.c | 149 ++++- block/qcow2.h | 41 ++ blockdev.c | 77 ++- docs/specs/qcow2.txt | 8 +- include/block/block.h | 3 + include/block/block_int.h | 8 + include/block/dirty-bitmap.h | 26 +- include/qemu/hbitmap.h | 49 +- qapi/block-core.json | 42 +- tests/Makefile.include | 2 +- tests/qemu-iotests/165 | 105 ++++ tests/qemu-iotests/165.out | 5 + tests/qemu-iotests/group | 1 + tests/test-hbitmap.c | 19 + util/hbitmap.c | 51 +- 21 files changed, 2147 insertions(+), 74 deletions(-)create mode 100644
block/qcow2-bitmap.c
create mode 100755 tests/qemu-iotests/165
create mode 100644 tests/qemu-iotests/165.out
Signature · 2 lines
Best regards, Vladimir