Skip to contentSkip to conversation

hwmon: (aspeed-pwm-tacho) Select REGMAP

PATCH In review Guenter Roeck 2 participants 3 messages May 27, 2017 – May 30, 2017 Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

PATCH 1/1 hwmon: (aspeed-pwm-tacho) Select REGMAP

The driver uses regmap and thus has to select it to avoid build errors such as the following.

drivers/hwmon/aspeed-pwm-tacho.c:337:21: error: variable
'aspeed_pwm_tacho_regmap_config' has initializer but incomplete type

Signed-off-by Guenter Roeck <[email protected]>
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/Kconfig +1 -0
index 22d5eafd6815..5ef2814345ef 100644
@@ -343,6 +343,7 @@ config SENSORS_ASB100
 
 config SENSORS_ASPEED
 	tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
+	select REGMAP
 	help
 	  This driver provides support for ASPEED AST2400/AST2500 PWM
 	  and Fan Tacho controllers.
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Guenter Roeck

The driver uses regmap and thus has to select it to avoid build errors such as the following.

drivers/hwmon/aspeed-pwm-tacho.c:337:21: error: variable
'aspeed_pwm_tacho_regmap_config' has initializer but incomplete type

While we're at it the driver should also depend on OF.

Quoted 1 line
Signed-off-by Guenter Roeck <[email protected]>
Acked-by Joel Stanley <[email protected]>

Cheers,

Joel

Quoted 19 lines
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/Kconfig +1 -1
index 22d5eafd6815..5ef2814345ef 100644
@@ -343,6 +343,7 @@ config SENSORS_ASB100
 
 config SENSORS_ASPEED
        tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
+       select REGMAP
        help
          This driver provides support for ASPEED AST2400/AST2500 PWM
          and Fan Tacho controllers.
--

2.7.4

author maintainer
#2 lore raw
Quoted 9 lines · Joel Stanley
Quoted 5 lines · Guenter Roeck

The driver uses regmap and thus has to select it to avoid build errors such as the following.

drivers/hwmon/aspeed-pwm-tacho.c:337:21: error: variable
'aspeed_pwm_tacho_regmap_config' has initializer but incomplete type

While we're at it the driver should also depend on OF.

The driver compiles without it, so that isn't strictly necessary.

Quoted 4 lines
Quoted 1 line
Signed-off-by Guenter Roeck <[email protected]>
Acked-by Joel Stanley <[email protected]>

Thanks,

Guenter

Quoted 28 lines

Cheers,

Joel

Quoted 17 lines
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/Kconfig +1 -1
index 22d5eafd6815..5ef2814345ef 100644
@@ -343,6 +343,7 @@ config SENSORS_ASB100
 
 config SENSORS_ASPEED
        tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
+       select REGMAP
        help
          This driver provides support for ASPEED AST2400/AST2500 PWM
          and Fan Tacho controllers.
--
Quoted 2 lines

2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html