firmware: dmi: Fix permissions of product_family
PATCH 1/1 firmware: dmi: Fix permissions of product_family
This is not sensitive information like serial numbers, we can allow all users to read it.
Fix odd alignment while we're here.
Signed-off-by Jean Delvare <[email protected]>
Fixes c61872c9833d ("firmware: dmi: Add DMI_PRODUCT_FAMILY identification string")
Cc Dmitry Torokhov <[email protected]>
Cc Mika Westerberg <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Linus Walleij <[email protected]>
--- drivers/firmware/dmi-id.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/firmware/dmi-id.c +2 -2
@@ -47,7 +47,7 @@ DEFINE_DMI_ATTR_WITH_SHOW(product_name,DEFINE_DMI_ATTR_WITH_SHOW (product_version,0444 ,DMI_PRODUCT_VERSION );DEFINE_DMI_ATTR_WITH_SHOW (product_serial,0400 ,DMI_PRODUCT_SERIAL );DEFINE_DMI_ATTR_WITH_SHOW (product_uuid,0400 ,DMI_PRODUCT_UUID ); -DEFINE_DMI_ATTR_WITH_SHOW (product_family,0400 ,DMI_PRODUCT_FAMILY ); +DEFINE_DMI_ATTR_WITH_SHOW (product_family,0444 ,DMI_PRODUCT_FAMILY );DEFINE_DMI_ATTR_WITH_SHOW (board_vendor,0444 ,DMI_BOARD_VENDOR );DEFINE_DMI_ATTR_WITH_SHOW (board_name,0444 ,DMI_BOARD_NAME );DEFINE_DMI_ATTR_WITH_SHOW (board_version,0444 ,DMI_BOARD_VERSION );
@@ -192,7 +192,7 @@ static void __init dmi_id_init_attr_tablADD_DMI_ATTR (product_version,DMI_PRODUCT_VERSION );ADD_DMI_ATTR (product_serial,DMI_PRODUCT_SERIAL );ADD_DMI_ATTR (product_uuid,DMI_PRODUCT_UUID ); -ADD_DMI_ATTR (product_family,DMI_PRODUCT_FAMILY ); +ADD_DMI_ATTR (product_family,DMI_PRODUCT_FAMILY );ADD_DMI_ATTR (board_vendor,DMI_BOARD_VENDOR );ADD_DMI_ATTR (board_name,DMI_BOARD_NAME );ADD_DMI_ATTR (board_version,DMI_BOARD_VERSION );
Signature · 2 lines
Jean Delvare SUSE L3 Support
Quoted 4 lines · Jean Delvare
This is not sensitive information like serial numbers, we can allow all users to read it.
Fix odd alignment while we're here.
Reviewed-by Andy Shevchenko <[email protected]>
Quoted 36 lines
Signed-off-by Jean Delvare <[email protected]>Fixes c61872c9833d ("firmware: dmi: Add DMI_PRODUCT_FAMILY identification string")Cc Dmitry Torokhov <[email protected]>Cc Mika Westerberg <[email protected]>Cc Andy Shevchenko <[email protected]>Cc Linus Walleij <[email protected]>--- drivers/firmware/dmi-id.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/firmware/dmi-id.c 2017-06-01 14:43:58.205186555 +0200 renamed from drivers/firmware/dmi-id.c 2017-06-01 13:49:59.933485745 +0200 +2
-3@@ -47,7 +47,7 @@ DEFINE_DMI_ATTR_WITH_SHOW(product_name, DEFINE_DMI_ATTR_WITH_SHOW(product_version, 0444, DMI_PRODUCT_VERSION); DEFINE_DMI_ATTR_WITH_SHOW(product_serial, 0400, DMI_PRODUCT_SERIAL); DEFINE_DMI_ATTR_WITH_SHOW(product_uuid, 0400, DMI_PRODUCT_UUID); -DEFINE_DMI_ATTR_WITH_SHOW(product_family, 0400, DMI_PRODUCT_FAMILY); +DEFINE_DMI_ATTR_WITH_SHOW(product_family, 0444, DMI_PRODUCT_FAMILY); DEFINE_DMI_ATTR_WITH_SHOW(board_vendor, 0444, DMI_BOARD_VENDOR); DEFINE_DMI_ATTR_WITH_SHOW(board_name, 0444, DMI_BOARD_NAME); DEFINE_DMI_ATTR_WITH_SHOW(board_version, 0444, DMI_BOARD_VERSION);@@ -192,7 +192,7 @@ static void __init dmi_id_init_attr_tabl ADD_DMI_ATTR(product_version, DMI_PRODUCT_VERSION); ADD_DMI_ATTR(product_serial, DMI_PRODUCT_SERIAL); ADD_DMI_ATTR(product_uuid, DMI_PRODUCT_UUID); - ADD_DMI_ATTR(product_family, DMI_PRODUCT_FAMILY); + ADD_DMI_ATTR(product_family, DMI_PRODUCT_FAMILY); ADD_DMI_ATTR(board_vendor, DMI_BOARD_VENDOR); ADD_DMI_ATTR(board_name, DMI_BOARD_NAME); ADD_DMI_ATTR(board_version, DMI_BOARD_VERSION); --Jean Delvare
SUSE L3 Support
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 9 lines · Jean Delvare
This is not sensitive information like serial numbers, we can allow all users to read it.
Fix odd alignment while we're here.
Signed-off-by Jean Delvare <[email protected]>Fixes c61872c9833d ("firmware: dmi: Add DMI_PRODUCT_FAMILY identification string")Cc Dmitry Torokhov <[email protected]>Cc Mika Westerberg <[email protected]>
Reviewed-by Mika Westerberg <[email protected]>