Skip to contentSkip to conversation

edid: Fix gcc 7.1 warning

PATCH New Jernej Skrabec 5 participants 6 messages May 23, 2017 – Jun 2, 2017

lore
Share & tools
lore

Jernej Skrabec

author
#0 lore raw

PATCH 1/1 edid: Fix gcc 7.1 warning

This commit fixes the warning produced by gcc 7.1.

Signed-off-by Jernej Skrabec <[email protected]>

---

 common/edid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/edid.c +1 -1
index 19410aa4fc..854d40c8f8 100644
@@ -295,7 +295,7 @@ static void edid_print_dtd(struct edid_monitor_descriptor *monitor,
 
 		h_total = h_active + h_blanking;
 		v_total = v_active + v_blanking;
-		if (v_total * h_total)
+		if (v_total > 0 && h_total > 0)
 			vfreq = pixclock / (v_total * h_total);
 		else
 			vfreq = 1; /* Error case */
Signature · 1 line
2.13.0
#1 lore raw

PATCH 1/1 edid: Fix gcc 7.1 warning

Quoted 3 lines · Jernej Skrabec

This commit fixes the warning produced by gcc 7.1.

Signed-off-by Jernej Skrabec <[email protected]>
Reviewed-by Tom Rini <[email protected]>

And I'm curious, where is your gcc-7.1 toolchain from, self built or something else? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170523/85c47e2a/attachment.sig>
author
#2 lore raw

PATCH 1/1 edid: Fix gcc 7.1 warning

Hi,

Dne sreda, 24. maj 2017 ob 03:00:16 CEST je Tom Rini napisal(a):

Quoted 9 lines · Jernej Skrabec
Quoted 3 lines

This commit fixes the warning produced by gcc 7.1.

Signed-off-by Jernej Skrabec <[email protected]>
Reviewed-by Tom Rini <[email protected]>

And I'm curious, where is your gcc-7.1 toolchain from, self built or something else? Thanks!

It's from Arch Linux repository.

I'm sorry to say that there seems to be something wrong with either gcc 7.1 or bootp code. With OrangePi 2 board, bootp crashes and resets the board (ethernet cable is not connected). I didn't have time to investigate it further.

Best regards,
Jernej

#3 lore raw

PATCH 1/1 edid: Fix gcc 7.1 warning

Quoted 13 lines · Jernej Å krabec

Hi,

Dne sreda, 24. maj 2017 ob 03:00:16 CEST je Tom Rini napisal(a):

Quoted 9 lines · Jernej Skrabec
Quoted 3 lines

This commit fixes the warning produced by gcc 7.1.

Signed-off-by Jernej Skrabec <[email protected]>
Reviewed-by Tom Rini <[email protected]>

And I'm curious, where is your gcc-7.1 toolchain from, self built or something else? Thanks!

Quoted 6 lines

It's from Arch Linux repository.

I'm sorry to say that there seems to be something wrong with either gcc 7.1 or bootp code. With OrangePi 2 board, bootp crashes and resets the board (ethernet cable is not connected). I didn't have time to investigate it further.

I think we might have seen something similar with Fedora and gcc-7, I'll ask some of the QA people and see if they can provide any more details.

Peter