Skip to contentSkip to conversation

drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type

PATCH In review Andrea della Porta 2 participants 2 messages Apr 28, 2017 – Jun 3, 2017 Staging

lore
Share & tools
lore

Andrea della Porta

author
#0 lore raw

PATCH 1/1 drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type

Fixed the following sparse warning:

CHECK drivers/staging/lustre/lustre/llite//file.c
drivers/staging/lustre/lustre/llite//file.c:441:24: warning: incorrect type in assignment (different base types)
drivers/staging/lustre/lustre/llite//file.c:441:24: expected
restricted fmode_t [usertype] och_flags
drivers/staging/lustre/lustre/llite//file.c:441:24: got unsigned
long long [unsigned] [usertype] it_flags drivers/staging/lustre/lustre/llite//file.c:465:65: warning:
restricted fmode_t degrades to integer drivers/staging/lustre/lustre/llite//file.c:465:22: warning: incorrect type in assignment (different base types)
drivers/staging/lustre/lustre/llite//file.c:465:22: expected
restricted fmode_t [usertype] fd_omode
drivers/staging/lustre/lustre/llite//file.c:465:22: got unsigned
long long drivers/staging/lustre/lustre/llite//file.c:526:38: warning: invalid
assignment: |=
drivers/staging/lustre/lustre/llite//file.c:526:38: left side has
type unsigned long long
drivers/staging/lustre/lustre/llite//file.c:526:38: right side has
type restricted fmode_t drivers/staging/lustre/lustre/llite//file.c:533:49: warning:
restricted fmode_t degrades to integer drivers/staging/lustre/lustre/llite//file.c:553:28: warning:
restricted fmode_t degrades to integer drivers/staging/lustre/lustre/llite//file.c:556:35: warning:
restricted fmode_t degrades to integer drivers/staging/lustre/lustre/llite//file.c:778:23: warning:
restricted fmode_t degrades to integer drivers/staging/lustre/lustre/llite//file.c:1309:62: warning:
restricted fmode_t degrades to integer drivers/staging/lustre/lustre/llite//file.c:1357:23: warning:
incorrect type in initializer (different base types)
drivers/staging/lustre/lustre/llite//file.c:1357:23: expected
unsigned long long [unsigned] [usertype] flags
drivers/staging/lustre/lustre/llite//file.c:1357:23: got restricted
fmode_t [usertype] <noident>

Signed-off-by Andrea della Porta <[email protected]>
---
 drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/include/lustre_intent.h +1 -1
index ed2b6c6..c036633 100644
@@ -38,7 +38,7 @@
 struct lookup_intent {
 	int		it_op;
 	int		it_create_mode;
-	__u64		it_flags;
+	fmode_t		it_flags;
 	int		it_disposition;
 	int		it_status;
 	__u64		it_lock_handle;
Signature · 1 line
2.4.10
maintainer
#1 lore raw
Quoted 31 lines · Andrea della Porta

Fixed the following sparse warning:

CHECK drivers/staging/lustre/lustre/llite//file.c
drivers/staging/lustre/lustre/llite//file.c:441:24: warning: incorrect type in assignment (different base types)
drivers/staging/lustre/lustre/llite//file.c:441:24: expected
restricted fmode_t [usertype] och_flags
drivers/staging/lustre/lustre/llite//file.c:441:24: got unsigned
long long [unsigned] [usertype] it_flags drivers/staging/lustre/lustre/llite//file.c:465:65: warning:
restricted fmode_t degrades to integer drivers/staging/lustre/lustre/llite//file.c:465:22: warning: incorrect type in assignment (different base types)
drivers/staging/lustre/lustre/llite//file.c:465:22: expected
restricted fmode_t [usertype] fd_omode
drivers/staging/lustre/lustre/llite//file.c:465:22: got unsigned
long long drivers/staging/lustre/lustre/llite//file.c:526:38: warning: invalid
assignment: |=
drivers/staging/lustre/lustre/llite//file.c:526:38: left side has
type unsigned long long
drivers/staging/lustre/lustre/llite//file.c:526:38: right side has
type restricted fmode_t drivers/staging/lustre/lustre/llite//file.c:533:49: warning:
restricted fmode_t degrades to integer drivers/staging/lustre/lustre/llite//file.c:553:28: warning:
restricted fmode_t degrades to integer drivers/staging/lustre/lustre/llite//file.c:556:35: warning:
restricted fmode_t degrades to integer drivers/staging/lustre/lustre/llite//file.c:778:23: warning:
restricted fmode_t degrades to integer

Quoted 8 lines

drivers/staging/lustre/lustre/llite//file.c:1309:62: warning:
restricted fmode_t degrades to integer drivers/staging/lustre/lustre/llite//file.c:1357:23: warning:
incorrect type in initializer (different base types)
drivers/staging/lustre/lustre/llite//file.c:1357:23: expected
unsigned long long [unsigned] [usertype] flags
drivers/staging/lustre/lustre/llite//file.c:1357:23: got restricted
fmode_t [usertype] <noident>

Please don't line-wrap messages like this so that we can see them easier.

Quoted 10 lines
Signed-off-by Andrea della Porta <[email protected]>
---
 drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/include/lustre_intent.h +0 -0
index ed2b6c6..c036633 100644

drivers/staging/lustre/lustre/include/lustre_intent.h line 41

Quoted 5 lines
drivers/staging/lustre/lustre/include/lustre_intent.h +1 -1
@@ -38,7 +38,7 @@
 struct lookup_intent {
 	int		it_op;
 	int		it_create_mode;
-	__u64		it_flags;
+	fmode_t		it_flags;

This adds a bunch of new build warnings when appied, are you sure you test-built your code? Always do so, I can't take this patch as-is :(

thanks,

greg k-h