Skip to contentSkip to conversation

ARM: dts: imx7d-pico: Add watchdog support

PATCH New Fabio Estevam 3 participants 5 messages May 23, 2017 – Jun 4, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: dts: imx7d-pico: Add watchdog support

imx7d-pico has the WDOG1_B pin connected to the PMIC, so add the wdog1 node and use the 'fsl,ext-reset-output' property to properly describe it.

---
 arch/arm/boot/dts/imx7d-pico.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/arm/boot/dts/imx7d-pico.dts +15 -0
index ebda3df..f874352 100644
@@ -284,6 +284,13 @@
 	status = "okay";
 };
 
+&wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog>;
+	fsl,ext-reset-output;
+	status = "okay";
+};
+
 &iomuxc {
 	pinctrl_enet1: enet1grp {
 		fsl,pins = <
@@ -385,3 +392,11 @@
 		>;
 	};
 };
+
+&iomuxc_lpsr {
+	pinctrl_wdog: wdoggrp {
+		fsl,pins = <
+			MX7D_PAD_LPSR_GPIO1_IO00__WDOD1_WDOG_B	0x74
+		>;
+	};
+};
Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/2 ARM: dts: imx7d-pico: Pass 'no-1-8-v' property to the eMMC

Currently the following eMMC error is seen:

mmc1: mmc_select_hs200 failed, error -74

On imx7d-pico the eMMC VCCQ is fixed at 3.15V, so pass the 'no-1-8-v' property to properly describe that 1.8V operation is not possible.

---
 arch/arm/boot/dts/imx7d-pico.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx7d-pico.dts +1 -0
index f874352..79b5d83 100644
@@ -279,6 +279,7 @@
 	assigned-clocks = <&clks IMX7D_USDHC3_ROOT_CLK>;
 	assigned-clock-rates = <400000000>;
 	bus-width = <8>;
+	no-1-8-v;
 	fsl,tuning-step = <2>;
 	non-removable;
 	status = "okay";
Signature · 1 line
2.7.4
reviewer
#3 lore raw

PATCH 1/2 ARM: dts: imx7d-pico: Add watchdog support

Hi Shawn,

Quoted 8 lines · Shawn Guo
Quoted 5 lines · Fabio Estevam

imx7d-pico has the WDOG1_B pin connected to the PMIC, so add the wdog1 node and use the 'fsl,ext-reset-output' property to properly describe it.

Applied both, thanks.

Maybe you forgot to push them to your tree?

#4 lore raw

PATCH 1/2 ARM: dts: imx7d-pico: Add watchdog support

Quoted 8 lines · Fabio Estevam

Hi Shawn,

Quoted 5 lines · Shawn Guo
Quoted 4 lines · Fabio Estevam

imx7d-pico has the WDOG1_B pin connected to the PMIC, so add the wdog1 node and use the 'fsl,ext-reset-output' property to properly describe it.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Applied both, thanks.

Maybe you forgot to push them to your tree?

Hmm, it's been on imx/dt for quite a few days, and for-next needs to be updated though.

Shawn