dts: gpio_atmel: adapt binding doc to reality

According to the binding documentation and the source code the omap-gpio controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*.

This patch uses the right variable type which yields the same result when compiled. Note that this might be wrong and actually IRQ_TYPE_LEVEL_LOW is intended by the dt author.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---
Hello,

can somebody with the hardware or it's documentation please check which flag is the right one?

Quoted 7 lines · Uwe Kleine-K?nig

According to the binding documentation and the source code the omap-gpio controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*.

This patch uses the right variable type which yields the same result when compiled. Note that this might be wrong and actually IRQ_TYPE_LEVEL_LOW is intended by the dt author.

Quoted 6 lines

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---
Hello,

can somebody with the hardware or it's documentation please check which flag is the right one?

I'll wait on this one until we have somebody test it.

Hi Uwe, Tony,

Quoted 12 lines · Tony Lindgren

Quoted 11 lines · Uwe Kleine-K?nig

According to the binding documentation and the source code the omap-gpio controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*.

This patch uses the right variable type which yields the same result when compiled. Note that this might be wrong and actually IRQ_TYPE_LEVEL_LOW is intended by the dt author.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---
Hello,

Quoted 4 lines

Quoted 2 lines

can somebody with the hardware or it's documentation please check which flag is the right one?

I'll wait on this one until we have somebody test it.

I'll look at it this week.

Quoted 15 lines · Yegor Yefremov

Hi Uwe, Tony,

Quoted 12 lines · Tony Lindgren

Quoted 11 lines · Uwe Kleine-K?nig

According to the binding documentation and the source code the omap-gpio controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*.

This patch uses the right variable type which yields the same result when compiled. Note that this might be wrong and actually IRQ_TYPE_LEVEL_LOW is intended by the dt author.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---
Hello,

Quoted 6 lines

Quoted 4 lines

Quoted 2 lines

can somebody with the hardware or it's documentation please check which flag is the right one?

I'll wait on this one until we have somebody test it.

I'll look at it this week.

This is what works for me (at least it doesn't produce "irq 88: nobody cared (try booting with the "irqpoll" option)").

As for tca6416 it is working with all possible settings (from IRQ_TYPE_EDGE_RISING till IRQ_TYPE_LEVEL_LOW). "cat /proc/interrupts" always shows Level type:

47: 5 44e07000.gpio 20 Level 1-0020

According to the binding documentation and the source code the atmel-gpio controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*.

This patch uses the right variable type which yields the same result when compiled. Note that this might be wrong and actually IRQ_TYPE_LEVEL_LOW is intended by the dt author.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---
Hello,

can somebody with the hardware or it's documentation please check which flag is the right one?

Best regards
Uwe

 arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi +2 -2

index b5a5a91bc2ef..b813fdfa2842 100644
@@ -75,7 +75,7 @@
 					reg = <0>;
 					clocks = <&clk20m>;
 					interrupt-parent = <&pioE>;
-					interrupts = <6 GPIO_ACTIVE_LOW>;
+					interrupts = <6 IRQ_TYPE_EDGE_RISING>;
 					spi-max-frequency = <10000000>;
 				};
 

@@ -84,7 +84,7 @@
 					reg = <1>;
 					clocks = <&clk20m>;
 					interrupt-parent = <&pioE>;
-					interrupts = <7 GPIO_ACTIVE_LOW>;
+					interrupts = <7 IRQ_TYPE_EDGE_RISING>;
 					spi-max-frequency = <10000000>;
 				};
 			};

Quoted 11 lines · Uwe Kleine-K?nig

According to the binding documentation and the source code the atmel-gpio controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*.

This patch uses the right variable type which yields the same result when compiled. Note that this might be wrong and actually IRQ_TYPE_LEVEL_LOW is intended by the dt author.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---
Hello,

Quoted 2 lines

can somebody with the hardware or it's documentation please check which flag is the right one?

It's correct, I tested the CAN, so:

Acked-by Marek Vasut <[email protected]>

Quoted 6 lines

Best regards
Uwe

 arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

According to the binding documentation and the source code the vf610-gpio controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*.

This patch uses the right variable type which yields the same result when compiled. Note that this might be wrong and actually IRQ_TYPE_LEVEL_LOW is intended by the dt author.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---
Hello,

can somebody with the hardware or it's documentation please check which flag is the right one?

Best regards
Uwe

 arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/vf-colibri-eval-v3.dtsi +1 -1

index 091b738041a0..3e0c84d79c43 100644
@@ -117,7 +117,7 @@
 		clocks = <&clk16m>;
 		spi-max-frequency = <10000000>;
 		interrupt-parent = <&gpio1>;
-		interrupts = <11 GPIO_ACTIVE_LOW>;
+		interrupts = <11 IRQ_TYPE_EDGE_RISING>;
 	};
 };
 

Signature · 1 line

2.11.0

Quoted 8 lines · Uwe Kleine-K?nig

According to the binding documentation and the source code the vf610-gpio controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*.

This patch uses the right variable type which yields the same result when compiled. Note that this might be wrong and actually IRQ_TYPE_LEVEL_LOW is intended by the dt author.

Quoted 6 lines

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---
Hello,

can somebody with the hardware or it's documentation please check which flag is the right one?

@Stefan, can you help to confirm?

Quoted 23 lines

Best regards
Uwe

 arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/vf-colibri-eval-v3.dtsi +1 -2

index 091b738041a0..3e0c84d79c43 100644
@@ -117,7 +117,7 @@
 		clocks = <&clk16m>;
 		spi-max-frequency = <10000000>;
 		interrupt-parent = <&gpio1>;
-		interrupts = <11 GPIO_ACTIVE_LOW>;
+		interrupts = <11 IRQ_TYPE_EDGE_RISING>;
 	};
 };
 
--

2.11.0

+- interrupt-controller: Marks the device node as a GPIO controller.

Quoted 1 line

+- interrupt-controller: Marks the device node as a GPIO controller.

Interrupt controller, not GPIO controller.

Review

Quoted 6 lines

+- #interrupt-cells: Should be two. The first cell is the pin number and the

(quoted diff) +5 -0

+  second cell is used to specify irq type flags:
+      1 = low-to-high edge triggered.
+      2 = high-to-low edge triggered.
+      4 = active high level-sensitive.
+      8 = active low level-sensitive.

Maybe just reference interrupts.txt?

The second cell in a gpio reference is used to pass GPIO_ACTIVE_LOW or GPIO_ACTIVE_HIGH. The gpio device can also be used as irq controller and a reference can contain the IRQ_TYPE_* values in the second cell.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---

Quoted 4 lines · Andrew Lunn

Quoted 1 line

+- interrupt-controller: Marks the device node as a GPIO controller.

Interrupt controller, not GPIO controller.

Quoted 8 lines

Review

Quoted 6 lines

+- #interrupt-cells: Should be two. The first cell is the pin number and the

(quoted diff) +5 -0

+  second cell is used to specify irq type flags:
+      1 = low-to-high edge triggered.
+      2 = high-to-low edge triggered.
+      4 = active high level-sensitive.
+      8 = active low level-sensitive.

Maybe just reference interrupts.txt?

ack for both and changed in this v2.

Thanks
Uwe

 Documentation/devicetree/bindings/gpio/gpio_atmel.txt | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)