Skip to contentSkip to conversation

Fixed comment coding style issues.

PATCH In review srishti sharma 2 participants 7 messages Jun 3, 2017 – Jun 6, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Fixed comment coding style issues.

This patchset contains a series of comment coding style issues fixes.

srishti sharma (4):
Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a
comment block.
Staging: ccree: cc_crypto_ctx.h: Fixed trailing */ issue in a comment
block
Staging: ccree: cc_crypto_ctx.h: Fixed * alignment issues in a comment
block
Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a
comment block

 drivers/staging/ccree/cc_crypto_ctx.h | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/4 Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

Added * on subsequent lines of a comment block.

---
 drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ccree/cc_crypto_ctx.h +1 -1
index ac39d34..6ee51b8 100644
@@ -219,7 +219,7 @@ struct drv_ctx_hash {
 };
 
 /* !!!! drv_ctx_hmac should have the same structure as drv_ctx_hash except
-   k0, k0_size fields */
+ * k0, k0_size fields */
 struct drv_ctx_hmac {
	enum drv_crypto_alg alg; /* DRV_CRYPTO_ALG_HMAC */
	enum drv_hash_mode mode;

--
2.7.4

maintainer
#2 lore raw

Re: [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

Quoted 6 lines · srishti sharma

Added * on subsequent lines of a comment block.

---
 drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This whole series also does not apply. Note, this driver is under active development, you are probably running into the problem that lots of people are working on it at the same time.

sorry,

greg k-h

#3 lore raw

Re: [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

Quoted 8 lines · Greg KH
Quoted 6 lines · srishti sharma

Added * on subsequent lines of a comment block.

---
 drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 7 lines

This whole series also does not apply. Note, this driver is under active development, you are probably running into the problem that lots of people are working on it at the same time.

sorry,

greg k-h

Okay , Thanks a lot !

Regards,
Srishti

#4 lore raw

PATCH 2/4 Staging: ccree: cc_crypto_ctx.h: Fixed trailing */ issue in a comment block

In reply to srishti sharma

Fixed trailing */ style issue in a block comment.

---
 drivers/staging/ccree/cc_crypto_ctx.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/ccree/cc_crypto_ctx.h +0 -0
index 6ee51b8..27a5914 100644
@@ -218,8 +218,10 @@ struct drv_ctx_hash {
			CC_DIGEST_SIZE_MAX];

};

-/* !!!! drv_ctx_hmac should have the same structure as drv_ctx_hash except
- * k0, k0_size fields */
+/*
+ * !!!! drv_ctx_hmac should have the same structure as drv_ctx_hash except
+ * k0, k0_size fields
+ */

 struct drv_ctx_hmac {
	enum drv_crypto_alg alg; /* DRV_CRYPTO_ALG_HMAC */
	enum drv_hash_mode mode;

@@ -285,4 +287,3 @@ struct drv_ctx_aead {
#define GET_CTX_FIELD_ADDR(ctx, type, member) (ctx + offsetof(type, member))

#endif /* _CC_CRYPTO_CTX_H_ */
-
--
2.7.4

#5 lore raw

PATCH 3/4 Staging: ccree: cc_crypto_ctx.h: Fixed * alignment issues in a comment block

In reply to srishti sharma

Fixed the alignment of * in a comment block.

---
 drivers/staging/ccree/cc_crypto_ctx.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/ccree/cc_crypto_ctx.h +0 -0
index 27a5914..03164624 100644
@@ -242,9 +242,9 @@ struct drv_ctx_cipher {

u32 key_size; /* numeric value in bytes */ u32 data_unit_size; /* required for XTS */ /* block_state is the AES engine block state.

-	*  It is used by the host to pass IV or counter at initialization.
-	*  It is used by SeP for intermediate block chaining state and for
-	*  returning MAC algorithms results. */
+	 * It is used by the host to pass IV or counter at initialization.
+	 * It is used by SeP for intermediate block chaining state and for
+	 * returning MAC algorithms results. */
	u8 block_state[CC_AES_BLOCK_SIZE];
	u8 key[CC_AES_KEY_SIZE_MAX];
	u8 xex_key[CC_AES_KEY_SIZE_MAX];
#6 lore raw

PATCH 4/4 Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block

In reply to srishti sharma

Added *'s on subsequent lines of a comment block to fix coding style issues.

---
 drivers/staging/ccree/cc_crypto_ctx.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/ccree/cc_crypto_ctx.h +3 -3
index 03164624..a8747d5 100644
@@ -281,9 +281,9 @@ struct drv_ctx_aead {
 
 
 /* Get the address of a @member within a given @ctx address
-   @ctx: The context address
-   @type: Type of context structure
-   @member: Associated context field */
+ * @ctx: The context address
+ * @type: Type of context structure
+ * @member: Associated context field */
 #define GET_CTX_FIELD_ADDR(ctx, type, member) (ctx + offsetof(type, member))
 
 #endif /* _CC_CRYPTO_CTX_H_ */

--
2.7.4