drm/i915: Remove unecessary PORT3 definition.
Subsystems (2)
Rodrigo Vivi
maintainerPATCH 1/1 drm/i915: Remove unecessary PORT3 definition.
Let's be picky and just use PICK directly. So we can extend this later without creating a new PORT_X por every new number of ports we have to handle.
--- drivers/gpu/drm/i915/i915_reg.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +2 -4
@@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define _MMIO_TRANS (tran, a, b) _MMIO(_TRANS(tran, a, b))#define _PORT (port, a, b) ((a) + (port)*((b)-(a)))#define _MMIO_PORT (port, a, b) _MMIO(_PORT(port, a, b)) -#define _PIPE3 (pipe, ...) _PICK(pipe, __VA_ARGS__) -#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c)) -#define _PORT3 (port, ...) _PICK(port, __VA_ARGS__) -#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c)) +#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c)) +#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))#define _PHY3 (phy, ...) _PICK(phy, __VA_ARGS__)#define _MMIO_PHY3 (phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for drm/i915: Remove unecessary PORT3 definition.
== Series Details ==
== Series Details ==
Series: drm/i915: Remove unecessary PORT3 definition.
URL : https://patchwork.freedesktop.org/series/25313/
State : warning
== Summary ==
Series 25313v1 drm/i915: Remove unecessary PORT3 definition.
https://patchwork.freedesktop.org/api/1.0/series/25313/revisions/1/mbox/
Test kms_busy:
Subgroup basic-flip-default-a:
pass -> DMESG-WARN (fi-skl-6700hq) fdo#101144 +1
Test drv_module_reload:
Subgroup basic-reload-final:
pass -> DMESG-WARN (fi-skl-6770hq)fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:442s fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:431s fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:578s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:517s fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:484s fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:482s fi-glk-2a total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:591s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:435s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:415s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:423s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:496s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:465s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:461s fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:565s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:460s fi-skl-6700hq total:278 pass:228 dwarn:1 dfail:0 fail:27 skip:22 time:401s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:463s fi-skl-6770hq total:278 pass:267 dwarn:1 dfail:0 fail:0 skip:10 time:499s fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:439s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:530s fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:401s
30d3326ecb407cad6c03ef6a6d3805c70ba9f0a9 drm-tip: 2017y-06m-05d-15h-21m-50s UTC integration manifest a5cfe1e drm/i915: Remove unecessary PORT3 definition.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4882/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 18 lines · Rodrigo Vivi
Let's be picky and just use PICK directly. So we can extend this later without creating a new
PORT_Xpor every new number of ports we have to handle.Cc Manasi Navare <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_reg.h +0
-0@@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define _MMIO_TRANS (tran, a, b) _MMIO(_TRANS(tran, a, b))#define _PORT (port, a, b) ((a) + (port)*((b)-(a)))
drivers/gpu/drm/i915/i915_reg.h static inline bool i915_mmio_reg_valid(i915_reg_t reg) · line 65
Quoted 10 lines
drivers/gpu/drm/i915/i915_reg.h +2
-4#define _MMIO_PORT (port, a, b) _MMIO(_PORT(port, a, b)) -#define _PIPE3 (pipe, ...) _PICK(pipe, __VA_ARGS__) -#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c)) -#define _PORT3 (port, ...) _PICK(port, __VA_ARGS__) -#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c)) +#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c)) +#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))#define _PHY3 (phy, ...) _PICK(phy, __VA_ARGS__)#define _MMIO_PHY3 (phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
Directly using _PICK looks good to me so we need not define more macros for different number of ports.
Looks good to me.
Regards
Manasi
Quoted 3 lines
Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Vivi, Rodrigo
maintainerQuoted 24 lines · Manasi Navare
Quoted 23 lines · Rodrigo Vivi
Let's be picky and just use PICK directly. So we can extend this later without creating a new
PORT_Xpor every new number of ports we have to handle.Cc Manasi Navare <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_reg.h +0
-4@@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define _MMIO_TRANS (tran, a, b) _MMIO(_TRANS(tran, a, b))#define _PORT (port, a, b) ((a) + (port)*((b)-(a)))#define _MMIO_PORT (port, a, b) _MMIO(_PORT(port, a, b)) -#define _PIPE3 (pipe, ...) _PICK(pipe, __VA_ARGS__) -#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c)) -#define _PORT3 (port, ...) _PICK(port, __VA_ARGS__) -#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c))
Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h static inline bool i915_mmio_reg_valid(i915_reg_t reg) · line 65
Quoted 5 lines
drivers/gpu/drm/i915/i915_reg.h +2
-0+#define _MMIO_PIPE3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c)) +#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))#define _PHY3 (phy, ...) _PICK(phy, __VA_ARGS__)#define _MMIO_PHY3 (phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))Directly using
_PICKlooks good to me so we need not define more macros for different number of ports.
Does this mean rv-b? :P
Quoted 10 lines
Looks good to me.
Regards
ManasiQuoted 3 lines
Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx