Skip to contentSkip to conversation

Fixup bug in PMIC TPS65217 register address definition

PATCH New Brock Zheng Techyauld Ltd 3 participants 3 messages Jun 6, 2017 – Jun 9, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fixup bug in PMIC TPS65217 register address definition

The addresses of the registers in TI TPS65217 are not continuous. There is a gap between ENABLE(0x16) and DEFUVLO(0x18). No 0x17 register available.

Fixup the enum values by adding a 'reserved' placeholder to correct the addresses higher than 0x17.

Series-to: Heiko Schocher <[email protected]>

---

 include/power/tps65217.h | 1 +
 1 file changed, 1 insertion(+)
include/power/tps65217.h +1 -0
index 69a49f76fe..cb07ea5ce6 100644
@@ -38,6 +38,7 @@ enum {
 	TPS65217_DEFLS1,
 	TPS65217_DEFLS2,
 	TPS65217_ENABLE,
+	TPS65217_RESERVED0, /* no 0x17 register available */
 	TPS65217_DEFUVLO,
 	TPS65217_SEQ1,
 	TPS65217_SEQ2,
Signature · 1 line
2.13.0
#1 lore raw

PATCH 1/1 Fixup bug in PMIC TPS65217 register address definition

Quoted 20 lines · On Tue, 6 Jun 2017 09:06:21 +0800 Brock Zheng Techyauld Ltd…

The addresses of the registers in TI TPS65217 are not continuous. There is a gap between ENABLE(0x16) and DEFUVLO(0x18). No 0x17 register available.

Fixup the enum values by adding a 'reserved' placeholder to
correct the addresses higher than 0x17.

Series-to: Heiko Schocher <[email protected]>

---

 include/power/tps65217.h | 1 +
 1 file changed, 1 insertion(+)
include/power/tps65217.h +0 -0
index 69a49f76fe..cb07ea5ce6 100644

include/power/tps65217.h enum { · line 44

Quoted 7 lines
include/power/tps65217.h +1 -0
@@ -38,6 +38,7 @@ enum {
 	TPS65217_DEFLS1,
 	TPS65217_DEFLS2,
 	TPS65217_ENABLE,
+	TPS65217_RESERVED0, /* no 0x17 register available */
 	TPS65217_DEFUVLO,
 	TPS65217_SEQ1,
 	TPS65217_SEQ2,

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

#2 lore raw

PATCH 1/1 Fixup bug in PMIC TPS65217 register address definition

Quoted 18 lines · Lukasz Majewski
Quoted 15 lines · On Tue, 6 Jun 2017 09:06:21 +0800 Brock Zheng Techyauld Ltd…

The addresses of the registers in TI TPS65217 are not continuous. There is a gap between ENABLE(0x16) and DEFUVLO(0x18). No 0x17 register available.

Fixup the enum values by adding a 'reserved' placeholder to
correct the addresses higher than 0x17.

Series-to: Heiko Schocher <[email protected]>

---

 include/power/tps65217.h | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

include/power/tps65217.h enum { · line 44

Quoted 12 lines
include/power/tps65217.h +1 -0
index 69a49f76fe..cb07ea5ce6 100644
@@ -38,6 +38,7 @@ enum {
 	TPS65217_DEFLS1,
 	TPS65217_DEFLS2,
 	TPS65217_ENABLE,
+	TPS65217_RESERVED0, /* no 0x17 register available */
 	TPS65217_DEFUVLO,
 	TPS65217_SEQ1,
 	TPS65217_SEQ2,

Applied to u-boot-mmc for pmic. Thanks.

Best Regards,
Jaehoon Chung

Quoted 16 lines

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot