mkfs.ubifs: Allow root entry in device table

PATCH Superseded David Engraf 2 participants 4 messages Jun 6, 2017 – Mar 7, 2018 Memory technology devices (MTD)

Share & tools

David Engraf

author

2017-06-06 13:32 UTC #0 lore raw

PATCH 1/1 mkfs.ubifs: Allow root entry in device table

When using a local root folder the permissions, user and group settings are taken from the local folder. These permissions might be incorrect if the folder has been created for the local user. Creating an UBIFS image on my local system resulted in the following output on the target:

drwx------   17 1000     1000   1264 Jan  1 00:00 .
drwx------   17 1000     1000   1264 Jan  1 00:00 ..
drwxr-xr-x    2 root     root   9104 May 30  2017 bin
drwxr-xr-x    7 root     root   2760 Jan  1 00:00 dev

...

mkfs.ubifs aborts with an error message when the device table contains a root entry. This patch allows setting the root folder permissions, user and group to overwrite local configurations.

---
 ubifs-utils/mkfs.ubifs/devtable.c   |  8 ++++----
 ubifs-utils/mkfs.ubifs/mkfs.ubifs.c | 13 +++++++++++++
 2 files changed, 17 insertions(+), 4 deletions(-)

ubifs-utils/mkfs.ubifs/devtable.c +4 -4

index 3b46abc..10faaca 100644
@@ -146,16 +146,16 @@ static int interpret_table_entry(const char *line)
 		increment, count);
 
 	len = strnlen(buf, 1024);
+	if (len == 0)
+		return err_msg("empty path");
 	if (len == 1024)
 		return err_msg("too long path");
 
-	if (!strcmp(buf, "/"))
+	if (buf[0] != '/')
 		return err_msg("device table entries require absolute paths");
-	if (buf[1] == '\0')
-		return err_msg("root directory cannot be created");
 	if (strstr(buf, "//"))
 		return err_msg("'//' cannot be used in the path");
-	if (buf[len - 1] == '/')
+	if (len > 1 && buf[len - 1] == '/')
 		return err_msg("do not put '/' at the end");
 
 	if (strstr(buf, "/./") || strstr(buf, "/../") ||

ubifs-utils/mkfs.ubifs/mkfs.ubifs.c +13 -0

index a60052d..52ed511 100644
@@ -1823,6 +1823,8 @@ static int write_data(void)
 {
 	int err;
 	mode_t mode = S_IFDIR | S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH;
+	struct path_htbl_element *ph_elt;
+	struct name_htbl_element *nh_elt;
 
 	if (root) {
 		err = stat(root, &root_st);

@@ -1835,6 +1837,17 @@ static int write_data(void)
 		root_st.st_mode = mode;
 	}
 
+	/*
+	 * Check for root entry and update permissions if it exists. This will
+	 * also remove the entry from the device table list.
+	 */
+	ph_elt = devtbl_find_path("/");
+	if (ph_elt) {
+		nh_elt = devtbl_find_name(ph_elt, "");
+		if (nh_elt && override_attributes(&root_st, ph_elt, nh_elt))
+			return -1;
+	}
+
 	head_flags = 0;
 
 	err = create_inum_attr(UBIFS_ROOT_INO, root);

Signature · 1 line

2.11.0

David Engraf

author

2017-06-06 13:46 UTC #1 lore raw

Am 06.06.2017 um 15:31 schrieb David Engraf:

Quoted 9 lines

When using a local root folder the permissions, user and group settings are taken from the local folder. These permissions might be incorrect if the folder has been created for the local user. Creating an UBIFS image on my local system resulted in the following output on the target:
drwx------   17 1000     1000   1264 Jan  1 00:00 .
drwx------   17 1000     1000   1264 Jan  1 00:00 ..
drwxr-xr-x    2 root     root   9104 May 30  2017 bin
drwxr-xr-x    7 root     root   2760 Jan  1 00:00 dev

Quoted 5 lines

...
mkfs.ubifs aborts with an error message when the device table contains a root entry. This patch allows setting the root folder permissions, user and group to overwrite local configurations.

Signed-off-by David Engraf <[email protected]>

Quoted 62 lines

---
  ubifs-utils/mkfs.ubifs/devtable.c   |  8 ++++----
  ubifs-utils/mkfs.ubifs/mkfs.ubifs.c | 13 +++++++++++++
  2 files changed, 17 insertions(+), 4 deletions(-)

ubifs-utils/mkfs.ubifs/devtable.c +4 -4

index 3b46abc..10faaca 100644
@@ -146,16 +146,16 @@ static int interpret_table_entry(const char *line)
  		increment, count);
 
  	len = strnlen(buf, 1024);
+	if (len == 0)
+		return err_msg("empty path");
  	if (len == 1024)
  		return err_msg("too long path");
 
-	if (!strcmp(buf, "/"))
+	if (buf[0] != '/')
  		return err_msg("device table entries require absolute paths");
-	if (buf[1] == '\0')
-		return err_msg("root directory cannot be created");
  	if (strstr(buf, "//"))
  		return err_msg("'//' cannot be used in the path");
-	if (buf[len - 1] == '/')
+	if (len > 1 && buf[len - 1] == '/')
  		return err_msg("do not put '/' at the end");
 
  	if (strstr(buf, "/./") || strstr(buf, "/../") ||

ubifs-utils/mkfs.ubifs/mkfs.ubifs.c +13 -0

index a60052d..52ed511 100644
@@ -1823,6 +1823,8 @@ static int write_data(void)
  {
  	int err;
  	mode_t mode = S_IFDIR | S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH;
+	struct path_htbl_element *ph_elt;
+	struct name_htbl_element *nh_elt;
 
  	if (root) {
  		err = stat(root, &root_st);

@@ -1835,6 +1837,17 @@ static int write_data(void)
  		root_st.st_mode = mode;
  	}
 
+	/*
+	 * Check for root entry and update permissions if it exists. This will
+	 * also remove the entry from the device table list.
+	 */
+	ph_elt = devtbl_find_path("/");
+	if (ph_elt) {
+		nh_elt = devtbl_find_name(ph_elt, "");
+		if (nh_elt && override_attributes(&root_st, ph_elt, nh_elt))
+			return -1;
+	}
+
  	head_flags = 0;
 
  	err = create_inum_attr(UBIFS_ROOT_INO, root);

David Engraf

author

2018-03-06 08:24 UTC #2 lore raw

PATCH RESEND 1/1 mkfs.ubifs: Allow root entry in device table

drwx------   17 1000     1000   1264 Jan  1 00:00 .
drwx------   17 1000     1000   1264 Jan  1 00:00 ..
drwxr-xr-x    2 root     root   9104 May 30  2017 bin
drwxr-xr-x    7 root     root   2760 Jan  1 00:00 dev

...

mkfs.ubifs aborts with an error message when the device table contains a root entry. This patch allows setting the root folder permissions, user and group to overwrite local configurations.

Signed-off-by David Engraf <[email protected]>

---
 ubifs-utils/mkfs.ubifs/devtable.c   |  8 ++++----
 ubifs-utils/mkfs.ubifs/mkfs.ubifs.c | 13 +++++++++++++
 2 files changed, 17 insertions(+), 4 deletions(-)

ubifs-utils/mkfs.ubifs/devtable.c +4 -4

index 3b46abc..10faaca 100644
@@ -146,16 +146,16 @@ static int interpret_table_entry(const char *line)
 		increment, count);
 
 	len = strnlen(buf, 1024);
+	if (len == 0)
+		return err_msg("empty path");
 	if (len == 1024)
 		return err_msg("too long path");
 
-	if (!strcmp(buf, "/"))
+	if (buf[0] != '/')
 		return err_msg("device table entries require absolute paths");
-	if (buf[1] == '\0')
-		return err_msg("root directory cannot be created");
 	if (strstr(buf, "//"))
 		return err_msg("'//' cannot be used in the path");
-	if (buf[len - 1] == '/')
+	if (len > 1 && buf[len - 1] == '/')
 		return err_msg("do not put '/' at the end");
 
 	if (strstr(buf, "/./") || strstr(buf, "/../") ||

ubifs-utils/mkfs.ubifs/mkfs.ubifs.c +13 -0

index c916f48..2e18fdc 100644
@@ -1825,6 +1825,8 @@ static int write_data(void)
 {
 	int err;
 	mode_t mode = S_IFDIR | S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH;
+	struct path_htbl_element *ph_elt;
+	struct name_htbl_element *nh_elt;
 
 	if (root) {
 		err = stat(root, &root_st);

@@ -1839,6 +1841,17 @@ static int write_data(void)
 		root_st.st_mode = mode;
 	}
 
+	/*
+	 * Check for root entry and update permissions if it exists. This will
+	 * also remove the entry from the device table list.
+	 */
+	ph_elt = devtbl_find_path("/");
+	if (ph_elt) {
+		nh_elt = devtbl_find_name(ph_elt, "");
+		if (nh_elt && override_attributes(&root_st, ph_elt, nh_elt))
+			return -1;
+	}
+
 	head_flags = 0;
 
 	err = create_inum_attr(UBIFS_ROOT_INO, root);

Signature · 1 line

2.14.1

David Oberhollenzer

Applied

2018-03-07 23:24 UTC #3 lore raw

Applied to mtd-utils.git

Thanks,

David