drm/i915/skl+: enable PF_ID interlace mode in SKL
Subsystems (2)
RFC PATCH 1/1 drm/i915/skl+: enable PF_ID interlace mode in SKL
In previous GEN default Interlace mode enabled is IF-ID mode, but IF-ID mode has many limitations in SKL. This mode doesn't support y-tiling, 90-270 rotation is not supported & YUV-420 planar source pixel formats are not supported with above mode.
This patch make changes to use PF-ID Interlace mode in SKL+ platforms. PF-ID mode require one scaler to be attached in pipe-scaling mode.
During WM calculation adjusted pixel rate need to be doubled. During max_supported_pixel_format calculation vertical downscale is 2.0.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90238
--- drivers/gpu/drm/i915/intel_atomic.c | 13 ++++++++++ drivers/gpu/drm/i915/intel_display.c | 47 +++++++++++++++++++++++++++++++----- drivers/gpu/drm/i915/intel_drv.h | 10 ++++++++ drivers/gpu/drm/i915/intel_panel.c | 9 +++++-- drivers/gpu/drm/i915/intel_pm.c | 17 ++++++++++++- 5 files changed, 87 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/intel_atomic.c +13 -0
@@ -248,6 +248,13 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,return -EINVAL ; } +if (num_scalers_need >1 && + scaler_state->scaler_users & (1 <<SKL_CRTC_INDEX ) && + scaler_state->scaler_users & (1 <<SKL_PF_ID_INDEX )) { +DRM_ERROR ("Can't attach scaler to CRTC in Interlace Mode\n" ); +return -EINVAL ; + } +/* walkthrough scaler_users bits and start assigning scalers */ for (i =0 ; i <sizeof (scaler_state->scaler_users) *8 ; i++) {int *scaler_id;
@@ -264,6 +271,12 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,/* panel fitter case: assign as a crtc scaler */ scaler_id = &scaler_state->scaler_id; + }else if (i ==SKL_PF_ID_INDEX ) { + name ="PF-ID INTERLACE MODE" ; + idx = intel_crtc->base.base.id; + +/* PF-ID interlaced mode case: needs a pipe scaler */ + scaler_id = &scaler_state->scaler_id; }else { name ="PLANE" ;
drivers/gpu/drm/i915/intel_display.c +41 -6
84 lines not on this page · raw message
drivers/gpu/drm/i915/intel_drv.h +10 -0
@@ -483,6 +483,7 @@ struct intel_crtc_scaler_state {* avilability. */ #define SKL_CRTC_INDEX 31 +#define SKL_PF_ID_INDEX 29unsigned scaler_users;/* scaler used by crtc for panel fitting purpose */
@@ -1206,6 +1207,15 @@ hdmi_to_dig_port(struct intel_hdmi *intel_hdmi) return container_of(intel_hdmi, struct intel_digital_port, hdmi); } +static inline bool +is_skl_interlace_mode (struct drm_i915_private *dev_priv, +const struct drm_display_mode *mode) +{ +if (INTEL_GEN (dev_priv) <9 ) +return false; +return mode->flags &DRM_MODE_FLAG_INTERLACE ; +} +/* intel_fifo_underrun.c */ bool intel_set_cpu_fifo_underrun_reporting (struct drm_i915_private *dev_priv,enum pipe pipe,bool enable);
drivers/gpu/drm/i915/intel_panel.c +7 -2
@@ -108,9 +108,14 @@ intel_pch_panel_fitting(struct intel_crtc *intel_crtc,const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;int x =0 , y =0 , width =0 , height =0 ; -/* Native modes don't need fitting */ +/* +* Native modes don't need fitting +* PF-ID Interlace mode in SKL+ require a pipe scaler +*/ if (adjusted_mode->crtc_hdisplay == pipe_config->pipe_src_w && - adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h) + adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h && + !(is_skl_interlace_mode (to_i915 (intel_crtc->base.dev), + adjusted_mode))) goto done;switch (fitting_mode) {
drivers/gpu/drm/i915/intel_pm.c +16 -1
@@ -3873,15 +3873,18 @@ static uint_fixed_16_16_t skl_pipe_downscale_amount(const struct intel_crtc_state *crtc_state) {uint_fixed_16_16_t pipe_downscale =u32_to_fixed_16_16 (1 ); +const struct drm_display_mode *mode;if (!crtc_state->base.enable)return pipe_downscale; + mode = &crtc_state->base.adjusted_mode;if (crtc_state->pch_pfit.enabled) {uint32_t src_w, src_h, dst_w, dst_h;uint32_t pfit_size = crtc_state->pch_pfit.size;uint_fixed_16_16_t fp_w_ratio, fp_h_ratio;uint_fixed_16_16_t downscale_h, downscale_w; +uint_fixed_16_16_t min_h_downscale; src_w = crtc_state->pipe_src_w; src_h = crtc_state->pipe_src_h;
@@ -3891,10 +3894,19 @@ skl_pipe_downscale_amount(const struct intel_crtc_state *crtc_state)if (!dst_w || !dst_h)return pipe_downscale; +/* +* Interlace mode require 1 scaler so no other scaler can be +* attached to pipe. PF-ID mode is equivalent to 2.0 vertical +* downscale. +*/ +if (mode->flags &DRM_MODE_FLAG_INTERLACE ) + min_h_downscale =u32_to_fixed_16_16 (2 ); +else + min_h_downscale =u32_to_fixed_16_16 (1 ); fp_w_ratio =fixed_16_16_div (src_w, dst_w); fp_h_ratio =fixed_16_16_div (src_h, dst_h); downscale_w =max_fixed_16_16 (fp_w_ratio,u32_to_fixed_16_16 (1 )); - downscale_h =max_fixed_16_16 (fp_h_ratio,u32_to_fixed_16_16 (1 )); + downscale_h =max_fixed_16_16 (fp_h_ratio, min_h_downscale); pipe_downscale =mul_fixed16 (downscale_w, downscale_h); }
@@ -4418,6 +4430,9 @@ skl_adjusted_plane_pixel_rate(const struct intel_crtc_state *cstate,* with additional adjustments for plane-specific scaling. */ adjusted_pixel_rate = cstate->pixel_rate; +if (cstate->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) + adjusted_pixel_rate *=2 ; + downscale_amount =skl_plane_downscale_amount (cstate, pstate); return mul_round_up_u32_fixed16(adjusted_pixel_rate,
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/skl+: enable PF_ID interlace mode in SKL
== Series Details ==
== Series Details ==
Series: drm/i915/skl+: enable PF_ID interlace mode in SKL
URL : https://patchwork.freedesktop.org/series/25397/
State : success
== Summary ==
Series 25397v1 drm/i915/skl+: enable PF_ID interlace mode in SKL
https://patchwork.freedesktop.org/api/1.0/series/25397/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-kbl-7560u) fdo#100125
Test kms_busy:
Subgroup basic-flip-default-a:
pass -> DMESG-WARN (fi-skl-6700hq) fdo#101144 +1fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:452s fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:434s fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:579s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:514s fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:487s fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:489s fi-glk-2a total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:589s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:430s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:411s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:421s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:490s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:464s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:467s fi-kbl-7560u total:278 pass:267 dwarn:1 dfail:0 fail:0 skip:10 time:575s fi-kbl-r total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18 time:579s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:463s fi-skl-6700hq total:278 pass:228 dwarn:1 dfail:0 fail:27 skip:22 time:400s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:465s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:495s fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:439s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:534s fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:400s
ff49922ea70ec3e60e099c466551900ce7130b00 drm-tip: 2017y-06m-07d-09h-29m-11s UTC integration manifest 798d482 drm/i915/skl+: enable PF_ID interlace mode in SKL
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4898/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines · Mahesh Kumar
In previous GEN default Interlace mode enabled is IF-ID mode, but IF-ID mode has many limitations in SKL. This mode doesn't support y-tiling, 90-270 rotation is not supported & YUV-420 planar source pixel formats are not supported with above mode.
I think we'll want something much more simple for stable. And that should probably be just -EINVAL if we try to do any of those forbidden things with an interlaced mode.
Quoted 21 lines
This patch make changes to use PF-ID Interlace mode in SKL+ platforms. PF-ID mode require one scaler to be attached in pipe-scaling mode.
During WM calculation adjusted pixel rate need to be doubled. Duringmax_supported_pixel_formatcalculation vertical downscale is 2.0.Signed-off-by Mahesh Kumar <[email protected]>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90238
--- drivers/gpu/drm/i915/intel_atomic.c | 13 ++++++++++ drivers/gpu/drm/i915/intel_display.c | 47 +++++++++++++++++++++++++++++++----- drivers/gpu/drm/i915/intel_drv.h | 10 ++++++++ drivers/gpu/drm/i915/intel_panel.c | 9 +++++-- drivers/gpu/drm/i915/intel_pm.c | 17 ++++++++++++- 5 files changed, 87 insertions(+), 9 deletions(-)drivers/gpu/drm/i915/intel_atomic.c +0
-0
drivers/gpu/drm/i915/intel_atomic.c int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv, · line 256
Quoted 9 lines
drivers/gpu/drm/i915/intel_atomic.c +6
-0@@ -248,6 +248,13 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,return -EINVAL ; } +if (num_scalers_need >1 && + scaler_state->scaler_users & (1 <<SKL_CRTC_INDEX ) && + scaler_state->scaler_users & (1 <<SKL_PF_ID_INDEX )) { +DRM_ERROR ("Can't attach scaler to CRTC in Interlace Mode\n" ); +return -EINVAL ; + }
I thought the whole point of PF-ID here was that we can then do pipe scaling (and other things). So this check looks wrong to me.
And I'm thinking we shouldn't be adding yet another scaler user for this, and instead it should just be part of the normal pfit setup.
Quoted 220 lines
drivers/gpu/drm/i915/intel_atomic.c +7
-0+/* walkthrough scaler_users bits and start assigning scalers */ for (i =0 ; i <sizeof (scaler_state->scaler_users) *8 ; i++) {int *scaler_id;@@ -264,6 +271,12 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,/* panel fitter case: assign as a crtc scaler */ scaler_id = &scaler_state->scaler_id; + }else if (i ==SKL_PF_ID_INDEX ) { + name ="PF-ID INTERLACE MODE" ; + idx = intel_crtc->base.base.id; + +/* PF-ID interlaced mode case: needs a pipe scaler */ + scaler_id = &scaler_state->scaler_id; }else { name ="PLANE" ;drivers/gpu/drm/i915/intel_display.c +41
-6@@ -4626,6 +4626,11 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,*/ need_scaling = src_w != dst_w || src_h != dst_h; +if ((crtc_state->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) + && scaler_user ==SKL_PF_ID_INDEX ) +/* PF-ID Interlace mode needs a scaler */ + need_scaling = true; +/* * if plane is being disabled or scaler is no more required or force detach * - free scaler binded to this plane/crtc @@ -4635,16 +4640,24 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,* scaler can be assigned to other user. Actual register * update to free the scaler is done in plane/panel-fit programming. * For this purpose crtc/plane_state->scaler_id isn't reset here. +* Now Interlace mode is a new user of pipe-scaler, so free the scaler-id +* only if call is for respective user. If no user for scaler free it. */ if (force_detach || !need_scaling) { -if (*scaler_id >=0 ) { +if (*scaler_id >=0 && + scaler_state->scaler_users & (1 << scaler_user)) { scaler_state->scaler_users &= ~(1 << scaler_user); scaler_state->scalers[*scaler_id].in_use =0 ;DRM_DEBUG_KMS ("scaler_user index %u.%u: " "Staged freeing scaler id %d scaler_users = 0x%x\n" , - intel_crtc->pipe, scaler_user, *scaler_id, - scaler_state->scaler_users); + intel_crtc->pipe, scaler_user, + *scaler_id, scaler_state->scaler_users); + + *scaler_id =-1 ; + } +if (*scaler_id >=0 && !scaler_state->scaler_users) { + scaler_state->scalers[*scaler_id].in_use =0 ; *scaler_id =-1 ; }return 0 ;@@ -4691,6 +4704,16 @@ int skl_update_scaler_crtc(struct intel_crtc_state *state) adjusted_mode->crtc_hdisplay, adjusted_mode->crtc_vdisplay); } +static int skl_update_scaler_crtc_pf_id_output (struct intel_crtc_state *state) +{ +const struct drm_display_mode *mode = &state->base.adjusted_mode; + +return skl_update_scaler (state, !state->base.active, +SKL_PF_ID_INDEX , &state->scaler_state.scaler_id, + state->pipe_src_w, state->pipe_src_h, + mode->crtc_hdisplay, mode->crtc_vdisplay); +} +/** * skl_update_scaler_plane - Stages update to scaler state for a given plane. * @@ -6258,6 +6281,15 @@ static int intel_crtc_compute_config(struct intel_crtc *crtc, } } +if (INTEL_GEN (dev_priv) >=9 ) { +if (skl_update_scaler_crtc_pf_id_output (pipe_config)) { +DRM_ERROR ("Unable to set scaler for PF-ID mode\n" ); +return -EINVAL ; + } +intel_pch_panel_fitting (crtc, pipe_config, +DRM_MODE_SCALE_FULLSCREEN ); + } +if (adjusted_mode->crtc_clock > clock_limit) { DRM_DEBUG_KMS("requested pixel clock (%d kHz) too high (max: %d kHz, double wide: %s)\n", adjusted_mode->crtc_clock, clock_limit,@@ -8045,9 +8077,12 @@ static void haswell_set_pipeconf(struct drm_crtc *crtc)if (IS_HASWELL (dev_priv) && intel_crtc->config->dither) val |= (PIPECONF_DITHER_EN |PIPECONF_DITHER_TYPE_SP ); -if (intel_crtc->config->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) - val |=PIPECONF_INTERLACED_ILK ; -else +if (intel_crtc->config->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) { +if (INTEL_GEN (dev_priv) >=9 ) + val |=PIPECONF_PFIT_PF_INTERLACED_ILK ; +else + val |=PIPECONF_INTERLACED_ILK ; + }else val |=PIPECONF_PROGRESSIVE ;I915_WRITE (PIPECONF (cpu_transcoder), val);drivers/gpu/drm/i915/intel_drv.h +10
-0@@ -483,6 +483,7 @@ struct intel_crtc_scaler_state {* avilability. */ #define SKL_CRTC_INDEX 31 +#define SKL_PF_ID_INDEX 29unsigned scaler_users;/* scaler used by crtc for panel fitting purpose */ @@ -1206,6 +1207,15 @@ hdmi_to_dig_port(struct intel_hdmi *intel_hdmi) return container_of(intel_hdmi, struct intel_digital_port, hdmi); } +static inline bool +is_skl_interlace_mode (struct drm_i915_private *dev_priv, +const struct drm_display_mode *mode) +{ +if (INTEL_GEN (dev_priv) <9 ) +return false; +return mode->flags &DRM_MODE_FLAG_INTERLACE ; +} +/* intel_fifo_underrun.c */ bool intel_set_cpu_fifo_underrun_reporting (struct drm_i915_private *dev_priv,enum pipe pipe,bool enable);drivers/gpu/drm/i915/intel_panel.c +7
-2@@ -108,9 +108,14 @@ intel_pch_panel_fitting(struct intel_crtc *intel_crtc,const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;int x =0 , y =0 , width =0 , height =0 ; -/* Native modes don't need fitting */ +/* +* Native modes don't need fitting +* PF-ID Interlace mode in SKL+ require a pipe scaler +*/ if (adjusted_mode->crtc_hdisplay == pipe_config->pipe_src_w && - adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h) + adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h && + !(is_skl_interlace_mode (to_i915 (intel_crtc->base.dev), + adjusted_mode))) goto done;switch (fitting_mode) {drivers/gpu/drm/i915/intel_pm.c +16
-1@@ -3873,15 +3873,18 @@ static uint_fixed_16_16_t skl_pipe_downscale_amount(const struct intel_crtc_state *crtc_state) {uint_fixed_16_16_t pipe_downscale =u32_to_fixed_16_16 (1 ); +const struct drm_display_mode *mode;if (!crtc_state->base.enable)return pipe_downscale; + mode = &crtc_state->base.adjusted_mode;if (crtc_state->pch_pfit.enabled) {uint32_t src_w, src_h, dst_w, dst_h;uint32_t pfit_size = crtc_state->pch_pfit.size;uint_fixed_16_16_t fp_w_ratio, fp_h_ratio;uint_fixed_16_16_t downscale_h, downscale_w; +uint_fixed_16_16_t min_h_downscale; src_w = crtc_state->pipe_src_w; src_h = crtc_state->pipe_src_h;@@ -3891,10 +3894,19 @@ skl_pipe_downscale_amount(const struct intel_crtc_state *crtc_state)if (!dst_w || !dst_h)return pipe_downscale; +/* +* Interlace mode require 1 scaler so no other scaler can be +* attached to pipe. PF-ID mode is equivalent to 2.0 vertical +* downscale. +*/ +if (mode->flags &DRM_MODE_FLAG_INTERLACE ) + min_h_downscale =u32_to_fixed_16_16 (2 ); +else + min_h_downscale =u32_to_fixed_16_16 (1 ); fp_w_ratio =fixed_16_16_div (src_w, dst_w); fp_h_ratio =fixed_16_16_div (src_h, dst_h); downscale_w =max_fixed_16_16 (fp_w_ratio,u32_to_fixed_16_16 (1 )); - downscale_h =max_fixed_16_16 (fp_h_ratio,u32_to_fixed_16_16 (1 )); + downscale_h =max_fixed_16_16 (fp_h_ratio, min_h_downscale); pipe_downscale =mul_fixed16 (downscale_w, downscale_h); }@@ -4418,6 +4430,9 @@ skl_adjusted_plane_pixel_rate(const struct intel_crtc_state *cstate,* with additional adjustments for plane-specific scaling. */ adjusted_pixel_rate = cstate->pixel_rate; +if (cstate->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) + adjusted_pixel_rate *=2 ; + downscale_amount =skl_plane_downscale_amount (cstate, pstate); return mul_round_up_u32_fixed16(adjusted_pixel_rate,Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Ville,
Thanks for review
Quoted 8 lines · Ville Syrjälä
Quoted 4 lines · Mahesh Kumar
In previous GEN default Interlace mode enabled is IF-ID mode, but IF-ID mode has many limitations in SKL. This mode doesn't support y-tiling, 90-270 rotation is not supported & YUV-420 planar source pixel formats are not supported with above mode.
I think we'll want something much more simple for stable. And that should probably be just
-EINVALif we try to do any of those forbidden things with an interlaced mode.
Agree.
Quoted 24 lines
Quoted 24 lines
This patch make changes to use PF-ID Interlace mode in SKL+ platforms. PF-ID mode require one scaler to be attached in pipe-scaling mode.
During WM calculation adjusted pixel rate need to be doubled. Duringmax_supported_pixel_formatcalculation vertical downscale is 2.0.Signed-off-by Mahesh Kumar <[email protected]>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90238
--- drivers/gpu/drm/i915/intel_atomic.c | 13 ++++++++++ drivers/gpu/drm/i915/intel_display.c | 47 +++++++++++++++++++++++++++++++----- drivers/gpu/drm/i915/intel_drv.h | 10 ++++++++ drivers/gpu/drm/i915/intel_panel.c | 9 +++++-- drivers/gpu/drm/i915/intel_pm.c | 17 ++++++++++++- 5 files changed, 87 insertions(+), 9 deletions(-)drivers/gpu/drm/i915/intel_atomic.c +0
-0@@ -248,6 +248,13 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,return -EINVAL ; }
Quoted 8 lines
drivers/gpu/drm/i915/intel_atomic.c int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv, · line 256
Quoted 6 lines
drivers/gpu/drm/i915/intel_atomic.c +6
-0+if (num_scalers_need >1 && + scaler_state->scaler_users & (1 <<SKL_CRTC_INDEX ) && + scaler_state->scaler_users & (1 <<SKL_PF_ID_INDEX )) { +DRM_ERROR ("Can't attach scaler to CRTC in Interlace Mode\n" ); +return -EINVAL ; + }I thought the whole point of PF-ID here was that we can then do pipe scaling (and other things). So this check looks wrong to me.
With PF-ID we can have Y-tiled buffers, & 90/270 rotation enabled, It doesn't explicitly talk about scaling.
BSpec doesn't limit us from using 2 scalers as a pipe scaler, still I sent a query to HW team regarding same.
Current S/W framework doesn't allows us to attach multiple pipe-scalers in a pipe (multiple scaler_id associated with one crtc_state). that's the reason for above check.
Quoted 3 lines
And I'm thinking we shouldn't be adding yet another scaler user for this, and instead it should just be part of the normal pfit setup.
To use existing scaler framework, we need one scaler-user to be associated with it.
If we use existing CRTC_INDEX user then there will be many corner cases to handle. To make it simple I added new scaler-user. This code uses pfit setup only to attach/enable Pipe-scaler.
Please let me know if I didn't understood your concern correctly.
Any other suggestions/queries are welcome.
-Mahesh
Quoted 213 lines
Quoted 213 lines
drivers/gpu/drm/i915/intel_atomic.c +7
-0+/* walkthrough scaler_users bits and start assigning scalers */ for (i =0 ; i <sizeof (scaler_state->scaler_users) *8 ; i++) {int *scaler_id;@@ -264,6 +271,12 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,/* panel fitter case: assign as a crtc scaler */ scaler_id = &scaler_state->scaler_id; + }else if (i ==SKL_PF_ID_INDEX ) { + name ="PF-ID INTERLACE MODE" ; + idx = intel_crtc->base.base.id; + +/* PF-ID interlaced mode case: needs a pipe scaler */ + scaler_id = &scaler_state->scaler_id; }else { name ="PLANE" ;drivers/gpu/drm/i915/intel_display.c +41
-6@@ -4626,6 +4626,11 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,*/ need_scaling = src_w != dst_w || src_h != dst_h; +if ((crtc_state->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) + && scaler_user ==SKL_PF_ID_INDEX ) +/* PF-ID Interlace mode needs a scaler */ + need_scaling = true; +/* * if plane is being disabled or scaler is no more required or force detach * - free scaler binded to this plane/crtc @@ -4635,16 +4640,24 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,* scaler can be assigned to other user. Actual register * update to free the scaler is done in plane/panel-fit programming. * For this purpose crtc/plane_state->scaler_id isn't reset here. +* Now Interlace mode is a new user of pipe-scaler, so free the scaler-id +* only if call is for respective user. If no user for scaler free it. */ if (force_detach || !need_scaling) { -if (*scaler_id >=0 ) { +if (*scaler_id >=0 && + scaler_state->scaler_users & (1 << scaler_user)) { scaler_state->scaler_users &= ~(1 << scaler_user); scaler_state->scalers[*scaler_id].in_use =0 ;DRM_DEBUG_KMS ("scaler_user index %u.%u: " "Staged freeing scaler id %d scaler_users = 0x%x\n" , - intel_crtc->pipe, scaler_user, *scaler_id, - scaler_state->scaler_users); + intel_crtc->pipe, scaler_user, + *scaler_id, scaler_state->scaler_users); + + *scaler_id =-1 ; + } +if (*scaler_id >=0 && !scaler_state->scaler_users) { + scaler_state->scalers[*scaler_id].in_use =0 ; *scaler_id =-1 ; }return 0 ;@@ -4691,6 +4704,16 @@ int skl_update_scaler_crtc(struct intel_crtc_state *state) adjusted_mode->crtc_hdisplay, adjusted_mode->crtc_vdisplay); } +static int skl_update_scaler_crtc_pf_id_output (struct intel_crtc_state *state) +{ +const struct drm_display_mode *mode = &state->base.adjusted_mode; + +return skl_update_scaler (state, !state->base.active, +SKL_PF_ID_INDEX , &state->scaler_state.scaler_id, + state->pipe_src_w, state->pipe_src_h, + mode->crtc_hdisplay, mode->crtc_vdisplay); +} +/** * skl_update_scaler_plane - Stages update to scaler state for a given plane. * @@ -6258,6 +6281,15 @@ static int intel_crtc_compute_config(struct intel_crtc *crtc, } } +if (INTEL_GEN (dev_priv) >=9 ) { +if (skl_update_scaler_crtc_pf_id_output (pipe_config)) { +DRM_ERROR ("Unable to set scaler for PF-ID mode\n" ); +return -EINVAL ; + } +intel_pch_panel_fitting (crtc, pipe_config, +DRM_MODE_SCALE_FULLSCREEN ); + } +if (adjusted_mode->crtc_clock > clock_limit) { DRM_DEBUG_KMS("requested pixel clock (%d kHz) too high (max: %d kHz, double wide: %s)\n", adjusted_mode->crtc_clock, clock_limit,@@ -8045,9 +8077,12 @@ static void haswell_set_pipeconf(struct drm_crtc *crtc)if (IS_HASWELL (dev_priv) && intel_crtc->config->dither) val |= (PIPECONF_DITHER_EN |PIPECONF_DITHER_TYPE_SP ); -if (intel_crtc->config->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) - val |=PIPECONF_INTERLACED_ILK ; -else +if (intel_crtc->config->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) { +if (INTEL_GEN (dev_priv) >=9 ) + val |=PIPECONF_PFIT_PF_INTERLACED_ILK ; +else + val |=PIPECONF_INTERLACED_ILK ; + }else val |=PIPECONF_PROGRESSIVE ;I915_WRITE (PIPECONF (cpu_transcoder), val);drivers/gpu/drm/i915/intel_drv.h +10
-0@@ -483,6 +483,7 @@ struct intel_crtc_scaler_state {* avilability. */ #define SKL_CRTC_INDEX 31 +#define SKL_PF_ID_INDEX 29unsigned scaler_users;/* scaler used by crtc for panel fitting purpose */ @@ -1206,6 +1207,15 @@ hdmi_to_dig_port(struct intel_hdmi *intel_hdmi) return container_of(intel_hdmi, struct intel_digital_port, hdmi); } +static inline bool +is_skl_interlace_mode (struct drm_i915_private *dev_priv, +const struct drm_display_mode *mode) +{ +if (INTEL_GEN (dev_priv) <9 ) +return false; +return mode->flags &DRM_MODE_FLAG_INTERLACE ; +} +/* intel_fifo_underrun.c */ bool intel_set_cpu_fifo_underrun_reporting (struct drm_i915_private *dev_priv,enum pipe pipe,bool enable);drivers/gpu/drm/i915/intel_panel.c +7
-2@@ -108,9 +108,14 @@ intel_pch_panel_fitting(struct intel_crtc *intel_crtc,const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;int x =0 , y =0 , width =0 , height =0 ; -/* Native modes don't need fitting */ +/* +* Native modes don't need fitting +* PF-ID Interlace mode in SKL+ require a pipe scaler +*/ if (adjusted_mode->crtc_hdisplay == pipe_config->pipe_src_w && - adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h) + adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h && + !(is_skl_interlace_mode (to_i915 (intel_crtc->base.dev), + adjusted_mode))) goto done;switch (fitting_mode) {drivers/gpu/drm/i915/intel_pm.c +16
-1@@ -3873,15 +3873,18 @@ static uint_fixed_16_16_t skl_pipe_downscale_amount(const struct intel_crtc_state *crtc_state) {uint_fixed_16_16_t pipe_downscale =u32_to_fixed_16_16 (1 ); +const struct drm_display_mode *mode;if (!crtc_state->base.enable)return pipe_downscale; + mode = &crtc_state->base.adjusted_mode;if (crtc_state->pch_pfit.enabled) {uint32_t src_w, src_h, dst_w, dst_h;uint32_t pfit_size = crtc_state->pch_pfit.size;uint_fixed_16_16_t fp_w_ratio, fp_h_ratio;uint_fixed_16_16_t downscale_h, downscale_w; +uint_fixed_16_16_t min_h_downscale; src_w = crtc_state->pipe_src_w; src_h = crtc_state->pipe_src_h;@@ -3891,10 +3894,19 @@ skl_pipe_downscale_amount(const struct intel_crtc_state *crtc_state)if (!dst_w || !dst_h)return pipe_downscale; +/* +* Interlace mode require 1 scaler so no other scaler can be +* attached to pipe. PF-ID mode is equivalent to 2.0 vertical +* downscale. +*/ +if (mode->flags &DRM_MODE_FLAG_INTERLACE ) + min_h_downscale =u32_to_fixed_16_16 (2 ); +else + min_h_downscale =u32_to_fixed_16_16 (1 ); fp_w_ratio =fixed_16_16_div (src_w, dst_w); fp_h_ratio =fixed_16_16_div (src_h, dst_h); downscale_w =max_fixed_16_16 (fp_w_ratio,u32_to_fixed_16_16 (1 )); - downscale_h =max_fixed_16_16 (fp_h_ratio,u32_to_fixed_16_16 (1 )); + downscale_h =max_fixed_16_16 (fp_h_ratio, min_h_downscale); pipe_downscale =mul_fixed16 (downscale_w, downscale_h); }@@ -4418,6 +4430,9 @@ skl_adjusted_plane_pixel_rate(const struct intel_crtc_state *cstate,* with additional adjustments for plane-specific scaling. */ adjusted_pixel_rate = cstate->pixel_rate; +if (cstate->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) + adjusted_pixel_rate *=2 ; + downscale_amount =skl_plane_downscale_amount (cstate, pstate);
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_pm.c +0
-0return mul_round_up_u32_fixed16(adjusted_pixel_rate,Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 47 lines · Mahesh Kumar
Hi Ville,
Thanks for review
Quoted 8 lines · Ville Syrjälä
Quoted 4 lines · Mahesh Kumar
In previous GEN default Interlace mode enabled is IF-ID mode, but IF-ID mode has many limitations in SKL. This mode doesn't support y-tiling, 90-270 rotation is not supported & YUV-420 planar source pixel formats are not supported with above mode.
I think we'll want something much more simple for stable. And that should probably be just
-EINVALif we try to do any of those forbidden things with an interlaced mode.Agree.
Quoted 24 lines
Quoted 24 lines
This patch make changes to use PF-ID Interlace mode in SKL+ platforms. PF-ID mode require one scaler to be attached in pipe-scaling mode.
During WM calculation adjusted pixel rate need to be doubled. Duringmax_supported_pixel_formatcalculation vertical downscale is 2.0.Signed-off-by Mahesh Kumar <[email protected]>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90238
--- drivers/gpu/drm/i915/intel_atomic.c | 13 ++++++++++ drivers/gpu/drm/i915/intel_display.c | 47 +++++++++++++++++++++++++++++++----- drivers/gpu/drm/i915/intel_drv.h | 10 ++++++++ drivers/gpu/drm/i915/intel_panel.c | 9 +++++-- drivers/gpu/drm/i915/intel_pm.c | 17 ++++++++++++- 5 files changed, 87 insertions(+), 9 deletions(-)drivers/gpu/drm/i915/intel_atomic.c +0
-0@@ -248,6 +248,13 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,return -EINVAL ; }Quoted 8 lines
drivers/gpu/drm/i915/intel_atomic.c int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv, · line 256
Quoted 6 lines
drivers/gpu/drm/i915/intel_atomic.c +6
-0+if (num_scalers_need >1 && + scaler_state->scaler_users & (1 <<SKL_CRTC_INDEX ) && + scaler_state->scaler_users & (1 <<SKL_PF_ID_INDEX )) { +DRM_ERROR ("Can't attach scaler to CRTC in Interlace Mode\n" ); +return -EINVAL ; + }I thought the whole point of PF-ID here was that we can then do pipe scaling (and other things). So this check looks wrong to me.
Quoted 2 lines
With PF-ID we can have Y-tiled buffers, & 90/270 rotation enabled, It doesn't explicitly talk about scaling.
PF-ID itself is scaling. Presumably you don't have to have exactly 2:1 scaling factor with PF-ID.
Quoted 2 lines
BSpec doesn't limit us from using 2 scalers as a pipe scaler, still I sent a query to HW team regarding same.
We don't want to use multiple scalers. I dubt that would even work. And before SKL the panel fitter was a dedicated piece of hw anyway so there was no way to even try to assign multiple scalers to the pipe.
Quoted 11 lines
Current S/W framework doesn't allows us to attach multiple pipe-scalers in a pipe (multiple
scaler_idassociated with onecrtc_state). that's the reason for above check.Quoted 3 lines
And I'm thinking we shouldn't be adding yet another scaler user for this, and instead it should just be part of the normal pfit setup.
To use existing scaler framework, we need one scaler-user to be associated with it.
If we use existingCRTC_INDEXuser then there will be many corner cases to handle.
I'm not 100% whether we need any adjustment in the pfit code itself. The spec doesn't seem to tell us that we need to adjust the panel fitter window in any way. That's a little inconsistent with the resulting scaling factor, but I guess the hw will automagically reduce the destination size by two when the pipe is in the PF-ID mode.
So I think it should mostly be a simple matter of calling the pfit code to set up the pos/size, and then you should just adjust ilk_pipe_pixel_rate() to double the resulting pixel rate.
That said, I'm not really sure we want to flip PF-ID on automagically. It would result in scaling when the user doesn't necessarily want it. So we might want to think about some kind if property to control this stuff.
Quoted 228 lines
To make it simple I added new scaler-user.
This code uses pfit setup only to attach/enable Pipe-scaler. Please let me know if I didn't understood your concern correctly. Any other suggestions/queries are welcome.-Mahesh
Quoted 221 lines
Quoted 221 lines
drivers/gpu/drm/i915/intel_atomic.c +7
-0+/* walkthrough scaler_users bits and start assigning scalers */ for (i =0 ; i <sizeof (scaler_state->scaler_users) *8 ; i++) {int *scaler_id;@@ -264,6 +271,12 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,/* panel fitter case: assign as a crtc scaler */ scaler_id = &scaler_state->scaler_id; + }else if (i ==SKL_PF_ID_INDEX ) { + name ="PF-ID INTERLACE MODE" ; + idx = intel_crtc->base.base.id; + +/* PF-ID interlaced mode case: needs a pipe scaler */ + scaler_id = &scaler_state->scaler_id; }else { name ="PLANE" ;drivers/gpu/drm/i915/intel_display.c +41
-6@@ -4626,6 +4626,11 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,*/ need_scaling = src_w != dst_w || src_h != dst_h; +if ((crtc_state->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) + && scaler_user ==SKL_PF_ID_INDEX ) +/* PF-ID Interlace mode needs a scaler */ + need_scaling = true; +/* * if plane is being disabled or scaler is no more required or force detach * - free scaler binded to this plane/crtc @@ -4635,16 +4640,24 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,* scaler can be assigned to other user. Actual register * update to free the scaler is done in plane/panel-fit programming. * For this purpose crtc/plane_state->scaler_id isn't reset here. +* Now Interlace mode is a new user of pipe-scaler, so free the scaler-id +* only if call is for respective user. If no user for scaler free it. */ if (force_detach || !need_scaling) { -if (*scaler_id >=0 ) { +if (*scaler_id >=0 && + scaler_state->scaler_users & (1 << scaler_user)) { scaler_state->scaler_users &= ~(1 << scaler_user); scaler_state->scalers[*scaler_id].in_use =0 ;DRM_DEBUG_KMS ("scaler_user index %u.%u: " "Staged freeing scaler id %d scaler_users = 0x%x\n" , - intel_crtc->pipe, scaler_user, *scaler_id, - scaler_state->scaler_users); + intel_crtc->pipe, scaler_user, + *scaler_id, scaler_state->scaler_users); + + *scaler_id =-1 ; + } +if (*scaler_id >=0 && !scaler_state->scaler_users) { + scaler_state->scalers[*scaler_id].in_use =0 ; *scaler_id =-1 ; }return 0 ;@@ -4691,6 +4704,16 @@ int skl_update_scaler_crtc(struct intel_crtc_state *state) adjusted_mode->crtc_hdisplay, adjusted_mode->crtc_vdisplay); } +static int skl_update_scaler_crtc_pf_id_output (struct intel_crtc_state *state) +{ +const struct drm_display_mode *mode = &state->base.adjusted_mode; + +return skl_update_scaler (state, !state->base.active, +SKL_PF_ID_INDEX , &state->scaler_state.scaler_id, + state->pipe_src_w, state->pipe_src_h, + mode->crtc_hdisplay, mode->crtc_vdisplay); +} +/** * skl_update_scaler_plane - Stages update to scaler state for a given plane. * @@ -6258,6 +6281,15 @@ static int intel_crtc_compute_config(struct intel_crtc *crtc, } } +if (INTEL_GEN (dev_priv) >=9 ) { +if (skl_update_scaler_crtc_pf_id_output (pipe_config)) { +DRM_ERROR ("Unable to set scaler for PF-ID mode\n" ); +return -EINVAL ; + } +intel_pch_panel_fitting (crtc, pipe_config, +DRM_MODE_SCALE_FULLSCREEN ); + } +if (adjusted_mode->crtc_clock > clock_limit) { DRM_DEBUG_KMS("requested pixel clock (%d kHz) too high (max: %d kHz, double wide: %s)\n", adjusted_mode->crtc_clock, clock_limit,@@ -8045,9 +8077,12 @@ static void haswell_set_pipeconf(struct drm_crtc *crtc)if (IS_HASWELL (dev_priv) && intel_crtc->config->dither) val |= (PIPECONF_DITHER_EN |PIPECONF_DITHER_TYPE_SP ); -if (intel_crtc->config->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) - val |=PIPECONF_INTERLACED_ILK ; -else +if (intel_crtc->config->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) { +if (INTEL_GEN (dev_priv) >=9 ) + val |=PIPECONF_PFIT_PF_INTERLACED_ILK ; +else + val |=PIPECONF_INTERLACED_ILK ; + }else val |=PIPECONF_PROGRESSIVE ;I915_WRITE (PIPECONF (cpu_transcoder), val);drivers/gpu/drm/i915/intel_drv.h +10
-0@@ -483,6 +483,7 @@ struct intel_crtc_scaler_state {* avilability. */ #define SKL_CRTC_INDEX 31 +#define SKL_PF_ID_INDEX 29unsigned scaler_users;/* scaler used by crtc for panel fitting purpose */ @@ -1206,6 +1207,15 @@ hdmi_to_dig_port(struct intel_hdmi *intel_hdmi) return container_of(intel_hdmi, struct intel_digital_port, hdmi); } +static inline bool +is_skl_interlace_mode (struct drm_i915_private *dev_priv, +const struct drm_display_mode *mode) +{ +if (INTEL_GEN (dev_priv) <9 ) +return false; +return mode->flags &DRM_MODE_FLAG_INTERLACE ; +} +/* intel_fifo_underrun.c */ bool intel_set_cpu_fifo_underrun_reporting (struct drm_i915_private *dev_priv,enum pipe pipe,bool enable);drivers/gpu/drm/i915/intel_panel.c +7
-2@@ -108,9 +108,14 @@ intel_pch_panel_fitting(struct intel_crtc *intel_crtc,const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;int x =0 , y =0 , width =0 , height =0 ; -/* Native modes don't need fitting */ +/* +* Native modes don't need fitting +* PF-ID Interlace mode in SKL+ require a pipe scaler +*/ if (adjusted_mode->crtc_hdisplay == pipe_config->pipe_src_w && - adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h) + adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h && + !(is_skl_interlace_mode (to_i915 (intel_crtc->base.dev), + adjusted_mode))) goto done;switch (fitting_mode) {drivers/gpu/drm/i915/intel_pm.c +16
-1@@ -3873,15 +3873,18 @@ static uint_fixed_16_16_t skl_pipe_downscale_amount(const struct intel_crtc_state *crtc_state) {uint_fixed_16_16_t pipe_downscale =u32_to_fixed_16_16 (1 ); +const struct drm_display_mode *mode;if (!crtc_state->base.enable)return pipe_downscale; + mode = &crtc_state->base.adjusted_mode;if (crtc_state->pch_pfit.enabled) {uint32_t src_w, src_h, dst_w, dst_h;uint32_t pfit_size = crtc_state->pch_pfit.size;uint_fixed_16_16_t fp_w_ratio, fp_h_ratio;uint_fixed_16_16_t downscale_h, downscale_w; +uint_fixed_16_16_t min_h_downscale; src_w = crtc_state->pipe_src_w; src_h = crtc_state->pipe_src_h;@@ -3891,10 +3894,19 @@ skl_pipe_downscale_amount(const struct intel_crtc_state *crtc_state)if (!dst_w || !dst_h)return pipe_downscale; +/* +* Interlace mode require 1 scaler so no other scaler can be +* attached to pipe. PF-ID mode is equivalent to 2.0 vertical +* downscale. +*/ +if (mode->flags &DRM_MODE_FLAG_INTERLACE ) + min_h_downscale =u32_to_fixed_16_16 (2 ); +else + min_h_downscale =u32_to_fixed_16_16 (1 ); fp_w_ratio =fixed_16_16_div (src_w, dst_w); fp_h_ratio =fixed_16_16_div (src_h, dst_h); downscale_w =max_fixed_16_16 (fp_w_ratio,u32_to_fixed_16_16 (1 )); - downscale_h =max_fixed_16_16 (fp_h_ratio,u32_to_fixed_16_16 (1 )); + downscale_h =max_fixed_16_16 (fp_h_ratio, min_h_downscale); pipe_downscale =mul_fixed16 (downscale_w, downscale_h); }@@ -4418,6 +4430,9 @@ skl_adjusted_plane_pixel_rate(const struct intel_crtc_state *cstate,* with additional adjustments for plane-specific scaling. */ adjusted_pixel_rate = cstate->pixel_rate; +if (cstate->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) + adjusted_pixel_rate *=2 ; + downscale_amount =skl_plane_downscale_amount (cstate, pstate); return mul_round_up_u32_fixed16(adjusted_pixel_rate,Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi,
Quoted 49 lines · Ville Syrjälä
Quoted 46 lines · Mahesh Kumar
Hi Ville,
Thanks for review
Quoted 8 lines · Ville Syrjälä
Quoted 4 lines · Mahesh Kumar
In previous GEN default Interlace mode enabled is IF-ID mode, but IF-ID mode has many limitations in SKL. This mode doesn't support y-tiling, 90-270 rotation is not supported & YUV-420 planar source pixel formats are not supported with above mode.
I think we'll want something much more simple for stable. And that should probably be just
-EINVALif we try to do any of those forbidden things with an interlaced mode.Agree.
Quoted 23 lines
Quoted 23 lines
This patch make changes to use PF-ID Interlace mode in SKL+ platforms. PF-ID mode require one scaler to be attached in pipe-scaling mode.
During WM calculation adjusted pixel rate need to be doubled. Duringmax_supported_pixel_formatcalculation vertical downscale is 2.0.Signed-off-by Mahesh Kumar <[email protected]>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90238
--- drivers/gpu/drm/i915/intel_atomic.c | 13 ++++++++++ drivers/gpu/drm/i915/intel_display.c | 47 +++++++++++++++++++++++++++++++----- drivers/gpu/drm/i915/intel_drv.h | 10 ++++++++ drivers/gpu/drm/i915/intel_panel.c | 9 +++++-- drivers/gpu/drm/i915/intel_pm.c | 17 ++++++++++++- 5 files changed, 87 insertions(+), 9 deletions(-)drivers/gpu/drm/i915/intel_atomic.c +0
-0@@ -248,6 +248,13 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,return -EINVAL ; }Quoted 8 lines
drivers/gpu/drm/i915/intel_atomic.c int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv, · line 256
Quoted 6 lines
drivers/gpu/drm/i915/intel_atomic.c +6
-0+if (num_scalers_need >1 && + scaler_state->scaler_users & (1 <<SKL_CRTC_INDEX ) && + scaler_state->scaler_users & (1 <<SKL_PF_ID_INDEX )) { +DRM_ERROR ("Can't attach scaler to CRTC in Interlace Mode\n" ); +return -EINVAL ; + }I thought the whole point of PF-ID here was that we can then do pipe scaling (and other things). So this check looks wrong to me.
Quoted 2 lines
With PF-ID we can have Y-tiled buffers, & 90/270 rotation enabled, It doesn't explicitly talk about scaling.
Quoted 8 lines
PF-ID itself is scaling. Presumably you don't have to have exactly 2:1 scaling factor with PF-ID.
Quoted 2 lines
BSpec doesn't limit us from using 2 scalers as a pipe scaler, still I sent a query to HW team regarding same.
We don't want to use multiple scalers. I dubt that would even work. And before SKL the panel fitter was a dedicated piece of hw anyway so there was no way to even try to assign multiple scalers to the pipe.
got it..
Quoted 9 lines
Quoted 9 lines
Current S/W framework doesn't allows us to attach multiple pipe-scalers in a pipe (multiple
scaler_idassociated with onecrtc_state). that's the reason for above check.Quoted 2 lines
And I'm thinking we shouldn't be adding yet another scaler user for this, and instead it should just be part of the normal pfit setup.
To use existing scaler framework, we need one scaler-user to be associated with it.
If we use existingCRTC_INDEXuser then there will be many corner cases to handle.
Quoted 5 lines
I'm not 100% whether we need any adjustment in the pfit code itself. The spec doesn't seem to tell us that we need to adjust the panel fitter window in any way. That's a little inconsistent with the resulting scaling factor, but I guess the hw will automagically reduce the destination size by two when the pipe is in the PF-ID mode.
yes, this is the same behavior as per my experiment, Hardware automatically taking care of everything.
(it's not reducing programmed destination size by 2).
I'm just setting source-size == destination-size & src-pos == dst-pos for scaler & hardware automagically taking care of all the conversions.
Quoted 4 lines
So I think it should mostly be a simple matter of calling the pfit code to set up the pos/size, and then you should just adjust
ilk_pipe_pixel_rate()to double the resulting pixel rate.
Agree, setting this in ilk_pipe_pixel_rate() will be right place, will incorporate this :)
Quoted 5 lines
That said, I'm not really sure we want to flip PF-ID on automagically. It would result in scaling when the user doesn't necessarily want it. So we might want to think about some kind if property to control this stuff.
yeah, PF-ID is needed only if user want Y-tiled buffer and/or 90/270 rotation.
But If we add a new property to choose mode (PF-PD / PF-ID / IF-ID) who will be the user for this connector property? We don't have any open-source user available to use this property as of now.
Please suggest if that is ok to use?
-Mahesh
Quoted 219 lines
Quoted 219 lines
To make it simple I added new scaler-user.
This code uses pfit setup only to attach/enable Pipe-scaler. Please let me know if I didn't understood your concern correctly. Any other suggestions/queries are welcome.-Mahesh
Quoted 212 lines
Quoted 212 lines
drivers/gpu/drm/i915/intel_atomic.c +7
-0+/* walkthrough scaler_users bits and start assigning scalers */ for (i =0 ; i <sizeof (scaler_state->scaler_users) *8 ; i++) {int *scaler_id;@@ -264,6 +271,12 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,/* panel fitter case: assign as a crtc scaler */ scaler_id = &scaler_state->scaler_id; + }else if (i ==SKL_PF_ID_INDEX ) { + name ="PF-ID INTERLACE MODE" ; + idx = intel_crtc->base.base.id; + +/* PF-ID interlaced mode case: needs a pipe scaler */ + scaler_id = &scaler_state->scaler_id; }else { name ="PLANE" ;drivers/gpu/drm/i915/intel_display.c +41
-6@@ -4626,6 +4626,11 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,*/ need_scaling = src_w != dst_w || src_h != dst_h; +if ((crtc_state->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) + && scaler_user ==SKL_PF_ID_INDEX ) +/* PF-ID Interlace mode needs a scaler */ + need_scaling = true; +/* * if plane is being disabled or scaler is no more required or force detach * - free scaler binded to this plane/crtc @@ -4635,16 +4640,24 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,* scaler can be assigned to other user. Actual register * update to free the scaler is done in plane/panel-fit programming. * For this purpose crtc/plane_state->scaler_id isn't reset here. +* Now Interlace mode is a new user of pipe-scaler, so free the scaler-id +* only if call is for respective user. If no user for scaler free it. */ if (force_detach || !need_scaling) { -if (*scaler_id >=0 ) { +if (*scaler_id >=0 && + scaler_state->scaler_users & (1 << scaler_user)) { scaler_state->scaler_users &= ~(1 << scaler_user); scaler_state->scalers[*scaler_id].in_use =0 ;DRM_DEBUG_KMS ("scaler_user index %u.%u: " "Staged freeing scaler id %d scaler_users = 0x%x\n" , - intel_crtc->pipe, scaler_user, *scaler_id, - scaler_state->scaler_users); + intel_crtc->pipe, scaler_user, + *scaler_id, scaler_state->scaler_users); + + *scaler_id =-1 ; + } +if (*scaler_id >=0 && !scaler_state->scaler_users) { + scaler_state->scalers[*scaler_id].in_use =0 ; *scaler_id =-1 ; }return 0 ;@@ -4691,6 +4704,16 @@ int skl_update_scaler_crtc(struct intel_crtc_state *state) adjusted_mode->crtc_hdisplay, adjusted_mode->crtc_vdisplay); } +static int skl_update_scaler_crtc_pf_id_output (struct intel_crtc_state *state) +{ +const struct drm_display_mode *mode = &state->base.adjusted_mode; + +return skl_update_scaler (state, !state->base.active, +SKL_PF_ID_INDEX , &state->scaler_state.scaler_id, + state->pipe_src_w, state->pipe_src_h, + mode->crtc_hdisplay, mode->crtc_vdisplay); +} +/** * skl_update_scaler_plane - Stages update to scaler state for a given plane. * @@ -6258,6 +6281,15 @@ static int intel_crtc_compute_config(struct intel_crtc *crtc, } } +if (INTEL_GEN (dev_priv) >=9 ) { +if (skl_update_scaler_crtc_pf_id_output (pipe_config)) { +DRM_ERROR ("Unable to set scaler for PF-ID mode\n" ); +return -EINVAL ; + } +intel_pch_panel_fitting (crtc, pipe_config, +DRM_MODE_SCALE_FULLSCREEN ); + } +if (adjusted_mode->crtc_clock > clock_limit) { DRM_DEBUG_KMS("requested pixel clock (%d kHz) too high (max: %d kHz, double wide: %s)\n", adjusted_mode->crtc_clock, clock_limit,@@ -8045,9 +8077,12 @@ static void haswell_set_pipeconf(struct drm_crtc *crtc)if (IS_HASWELL (dev_priv) && intel_crtc->config->dither) val |= (PIPECONF_DITHER_EN |PIPECONF_DITHER_TYPE_SP ); -if (intel_crtc->config->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) - val |=PIPECONF_INTERLACED_ILK ; -else +if (intel_crtc->config->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) { +if (INTEL_GEN (dev_priv) >=9 ) + val |=PIPECONF_PFIT_PF_INTERLACED_ILK ; +else + val |=PIPECONF_INTERLACED_ILK ; + }else val |=PIPECONF_PROGRESSIVE ;I915_WRITE (PIPECONF (cpu_transcoder), val);drivers/gpu/drm/i915/intel_drv.h +10
-0@@ -483,6 +483,7 @@ struct intel_crtc_scaler_state {* avilability. */ #define SKL_CRTC_INDEX 31 +#define SKL_PF_ID_INDEX 29unsigned scaler_users;/* scaler used by crtc for panel fitting purpose */ @@ -1206,6 +1207,15 @@ hdmi_to_dig_port(struct intel_hdmi *intel_hdmi) return container_of(intel_hdmi, struct intel_digital_port, hdmi); } +static inline bool +is_skl_interlace_mode (struct drm_i915_private *dev_priv, +const struct drm_display_mode *mode) +{ +if (INTEL_GEN (dev_priv) <9 ) +return false; +return mode->flags &DRM_MODE_FLAG_INTERLACE ; +} +/* intel_fifo_underrun.c */ bool intel_set_cpu_fifo_underrun_reporting (struct drm_i915_private *dev_priv,enum pipe pipe,bool enable);drivers/gpu/drm/i915/intel_panel.c +7
-2@@ -108,9 +108,14 @@ intel_pch_panel_fitting(struct intel_crtc *intel_crtc,const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;int x =0 , y =0 , width =0 , height =0 ; -/* Native modes don't need fitting */ +/* +* Native modes don't need fitting +* PF-ID Interlace mode in SKL+ require a pipe scaler +*/ if (adjusted_mode->crtc_hdisplay == pipe_config->pipe_src_w && - adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h) + adjusted_mode->crtc_vdisplay == pipe_config->pipe_src_h && + !(is_skl_interlace_mode (to_i915 (intel_crtc->base.dev), + adjusted_mode))) goto done;switch (fitting_mode) {drivers/gpu/drm/i915/intel_pm.c +16
-1@@ -3873,15 +3873,18 @@ static uint_fixed_16_16_t skl_pipe_downscale_amount(const struct intel_crtc_state *crtc_state) {uint_fixed_16_16_t pipe_downscale =u32_to_fixed_16_16 (1 ); +const struct drm_display_mode *mode;if (!crtc_state->base.enable)return pipe_downscale; + mode = &crtc_state->base.adjusted_mode;if (crtc_state->pch_pfit.enabled) {uint32_t src_w, src_h, dst_w, dst_h;uint32_t pfit_size = crtc_state->pch_pfit.size;uint_fixed_16_16_t fp_w_ratio, fp_h_ratio;uint_fixed_16_16_t downscale_h, downscale_w; +uint_fixed_16_16_t min_h_downscale; src_w = crtc_state->pipe_src_w; src_h = crtc_state->pipe_src_h;@@ -3891,10 +3894,19 @@ skl_pipe_downscale_amount(const struct intel_crtc_state *crtc_state)if (!dst_w || !dst_h)return pipe_downscale; +/* +* Interlace mode require 1 scaler so no other scaler can be +* attached to pipe. PF-ID mode is equivalent to 2.0 vertical +* downscale. +*/ +if (mode->flags &DRM_MODE_FLAG_INTERLACE ) + min_h_downscale =u32_to_fixed_16_16 (2 ); +else + min_h_downscale =u32_to_fixed_16_16 (1 ); fp_w_ratio =fixed_16_16_div (src_w, dst_w); fp_h_ratio =fixed_16_16_div (src_h, dst_h); downscale_w =max_fixed_16_16 (fp_w_ratio,u32_to_fixed_16_16 (1 )); - downscale_h =max_fixed_16_16 (fp_h_ratio,u32_to_fixed_16_16 (1 )); + downscale_h =max_fixed_16_16 (fp_h_ratio, min_h_downscale); pipe_downscale =mul_fixed16 (downscale_w, downscale_h); }@@ -4418,6 +4430,9 @@ skl_adjusted_plane_pixel_rate(const struct intel_crtc_state *cstate,* with additional adjustments for plane-specific scaling. */ adjusted_pixel_rate = cstate->pixel_rate; +if (cstate->base.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) + adjusted_pixel_rate *=2 ; + downscale_amount =skl_plane_downscale_amount (cstate, pstate);
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_pm.c +0
-0return mul_round_up_u32_fixed16(adjusted_pixel_rate,Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx