IB/qib: remove duplicate code
PATCH 1/1 IB/qib: remove duplicate code
Remove duplicate code.
Addresses-Coverity-ID: 1226951
--- drivers/infiniband/hw/qib/qib_mad.c | 2 -- 1 file changed, 2 deletions(-)
drivers/infiniband/hw/qib/qib_mad.c +0 -2
@@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,ib_dispatch_event (&event); } - ret =subn_get_portinfo (smp, ibdev, port); -/* restore re-reg bit per o14-12.2.1 */ pip->clientrereg_resv_subnetto |= clientrereg;
Signature · 1 line
2.5.0
Quoted 8 lines · Gustavo A. R. Silva
Remove duplicate code.
Addresses-Coverity-ID: 1226951
Signed-off-by Gustavo A. R. Silva <garsilva-L1vi/[email protected]>--- drivers/infiniband/hw/qib/qib_mad.c | 2 -- 1 file changed, 2 deletions(-)
Thanks,
Quoted 14 lines · Gustavo A. R. Silva
Remove duplicate code.
Addresses-Coverity-ID: 1226951
Signed-off-by Gustavo A. R. Silva <garsilva-L1vi/[email protected]>--- drivers/infiniband/hw/qib/qib_mad.c | 2 -- 1 file changed, 2 deletions(-)drivers/infiniband/hw/qib/qib_mad.c +0
-0
drivers/infiniband/hw/qib/qib_mad.c static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev, · line 879
Quoted 8 lines
drivers/infiniband/hw/qib/qib_mad.c +0
-2@@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,ib_dispatch_event (&event); } - ret =subn_get_portinfo (smp, ibdev, port); -/* restore re-reg bit per o14-12.2.1 */ pip->clientrereg_resv_subnetto |= clientrereg;
Would be nice to see a few more words in the commit message rather than having to go look for Coverity.
Regardless, patch seems fine to me code wise.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dennis,
Quoting Dennis Dalessandro <[email protected]>:
Quoted 9 lines · Gustavo A. R. Silva
Quoted 8 lines
Remove duplicate code.
Addresses-Coverity-ID: 1226951
Signed-off-by Gustavo A. R. Silva <garsilva-L1vi/[email protected]>--- drivers/infiniband/hw/qib/qib_mad.c | 2 -- 1 file changed, 2 deletions(-)
Quoted 16 lines
drivers/infiniband/hw/qib/qib_mad.c static int subn_set_portinfo(struct ib_smp · line 879
Quoted 13 lines
drivers/infiniband/hw/qib/qib_mad.c +0
-1@@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,ib_dispatch_event (&event); } - ret =subn_get_portinfo (smp, ibdev, port); -/* restore re-reg bit per o14-12.2.1 */ pip->clientrereg_resv_subnetto |= clientrereg;Would be nice to see a few more words in the commit message rather than having to go look for Coverity.
I'll take note of that.
Quoted 3 lines
Regardless, patch seems fine to me code wise.
Reviewed-by Dennis Dalessandro <[email protected]>
Thank you
--
Gustavo A. R. Silva
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 4 lines · Gustavo A. R. Silva
Remove duplicate code.
Addresses-Coverity-ID: 1226951
Signed-off-by Gustavo A. R. Silva <[email protected]>
This patch was accepted into 4.13-rc, thanks.
In addition, I no longer have the original email for another patch of yours that was also accepted into 4.13-rc. You created the patch in a thread asking about the argument position for argument usage in ib_init_ah_from_wc(). Your comment addition was accepted as well.
Signature · 3 lines
Doug Ledford <[email protected]> GPG Key ID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Quoted 7 lines · Doug Ledford
Quoted 4 lines · Gustavo A. R. Silva
Remove duplicate code.
Addresses-Coverity-ID: 1226951
Signed-off-by Gustavo A. R. Silva <garsilva-L1vi/[email protected]>This patch was accepted into 4.13-rc, thanks.
Correction, this patch is in my queue for my for-next branch, only the other patch, referenced below, made it into 4.13-rc.
Quoted 6 lines
In addition, I no longer have the original email for another patch of yours that was also accepted into 4.13-rc. You created the patch in a thread asking about the argument position for argument usage in
ib_init_ah_from_wc(). Your comment addition was accepted as well.
Signature · 3 lines
Doug Ledford <[email protected]> GPG Key ID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Hi Doug,
Quoted 4 lines · Doug Ledford
Quoted 3 lines · Doug Ledford
Quoted 2 lines · Gustavo A. R. Silva
Remove duplicate code.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Addresses-Coverity-ID: 1226951
Signed-off-by Gustavo A. R. Silva <[email protected]>This patch was accepted into 4.13-rc, thanks.
Correction, this patch is in my queue for my for-next branch, only the other patch, referenced below, made it into 4.13-rc.
That's cool.
Quoted 6 lines
Quoted 6 lines
In addition, I no longer have the original email for another patch of yours that was also accepted into 4.13-rc. You created the patch in a thread asking about the argument position for argument usage in
ib_init_ah_from_wc(). Your comment addition was accepted as well.
Yeah, I noticed that. I'm glad to help out. :)
Thank you
Signature · 1 line
Gustavo A. R. Silva