Skip to contentSkip to conversation

Make autogen.sh set the default format.subjectPrefix

PATCH In review Eric Anholt 2 participants 2 messages Jun 7, 2017 – Jun 8, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Make autogen.sh set the default format.subjectPrefix

CONTRIBUTING requests that people do this, but it's a lot easier if we just set it up by default for them.

---

I missed this step on my previous two patches, so let's just prevent that in the future. :(

 autogen.sh | 3 +++
 1 file changed, 3 insertions(+)
autogen.sh +3 -0
index ec633f3efefd..53df7525a976 100755
@@ -16,6 +16,9 @@ fi
 autoreconf -v --install || exit 1
 cd $ORIGDIR || exit $?
 
+git config --local --get format.subjectPrefix >/dev/null 2>&1 ||
+    git config --local format.subjectPrefix "PATCH i-g-t"
+
 if test -z "$NOCONFIGURE"; then
         $srcdir/configure "$@"
 fi
Signature · 6 lines
2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Acked-by on v1 1/1
#1 lore raw
Quoted 17 lines · Eric Anholt

CONTRIBUTING requests that people do this, but it's a lot easier if we just set it up by default for them.

---

I missed this step on my previous two patches, so let's just prevent that in the future. :(

 autogen.sh | 3 +++
 1 file changed, 3 insertions(+)
autogen.sh +0 -0
index ec633f3efefd..53df7525a976 100755

autogen.sh fi · line 21

Quoted 6 lines
autogen.sh +3 -0
@@ -16,6 +16,9 @@ fi
 autoreconf -v --install || exit 1
 cd $ORIGDIR || exit $?
 
+git config --local --get format.subjectPrefix >/dev/null 2>&1 ||
+    git config --local format.subjectPrefix "PATCH i-g-t"
+

If your IGT is not in git, setting the config will output an error message. Although autogen.sh is only in git, not in the dist tarball, so that shouldn't be an issue.

Can you also document that autogen.sh does the config for you in CONTRIBUTING?

Anyway,

Quoted 10 lines
autogen.sh +0 -0
 if test -z "$NOCONFIGURE"; then
         $srcdir/configure "$@"
 fi
Signature · 6 lines
2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx