Skip to contentSkip to conversation

image-vm: Avoid use of fold, tac and paste commands for DISK_SIGNATURE

PATCH In review Jonathan Liu 2 participants 4 messages Jun 8, 2017

lore
Share & tools
lore

Jonathan Liu

author
#0 lore raw

PATCH 1/1 image-vm: Avoid use of fold, tac and paste commands for DISK_SIGNATURE

These commands are not whitelisted by the HOSTTOOLS variable which silently prevents the MBR disk signature from being written to the image.

Reported-by Michael Davis <[email protected]>
Signed-off-by Jonathan Liu <[email protected]>
---
 meta/classes/image-vm.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/image-vm.bbclass +1 -1
index 35c9244e9b..98bd92000e 100644
@@ -93,7 +93,7 @@ build_boot_dd() {
 
 	parted $IMAGE print
 
-	awk "BEGIN { printf \"$(echo ${DISK_SIGNATURE} | fold -w 2 | tac | paste -sd '' | sed 's/\(..\)/\\x&/g')\" }" | \
+	awk "BEGIN { printf \"$(echo ${DISK_SIGNATURE} | sed 's/\(..\)\(..\)\(..\)\(..\)/\\x\4\\x\3\\x\2\\x\1/')\" }" | \
 		dd of=$IMAGE bs=1 seek=440 conv=notrunc
 
 	OFFSET=`expr $END2 / 512`
Signature · 1 line
2.12.2
#1 lore raw
Quoted 4 lines · Jonathan Liu

These commands are not whitelisted by the HOSTTOOLS variable which silently prevents the MBR disk signature from being written to the image.

Silently, ouch. Thanks, awk.

Ross

author
#2 lore raw

Hi Ross,

It is the shell not awk.

For example:

$ echo $(false)
$ echo $?
0

Regards,
Jonathan

Quoted 11 lines · Ross
Quoted 4 lines · Jonathan Liu

These commands are not whitelisted by the HOSTTOOLS variable which silently prevents the MBR disk signature from being written to the image.

Silently, ouch. Thanks, awk.

Ross

#3 lore raw
Quoted 6 lines · Jonathan Liu

For example:

$ echo $(false)
$ echo $?
0

I stand corrected. Thanks, sh.

Ross