Drivers: unisys: visorhba - style fix
PATCH 1/1 Drivers: unisys: visorhba - style fix
Fixed style of permissions to octal.
Found using checkpatch
--- drivers/staging/unisys/visorhba/visorhba_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/unisys/visorhba/visorhba_main.c +1 -1
@@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev) goto err_scsi_remove_host; } devdata->debugfs_info = -debugfs_create_file ("info" ,S_IRUSR |S_IRGRP , +debugfs_create_file ("info" ,0440 , devdata->debugfs_dir, devdata, &info_debugfs_fops);if (!devdata->debugfs_info) {
Signature · 1 line
2.13.0
Quoted 12 lines
-----Original Message-----
From: Derek Robson [mailto:[email protected]]
Sent: Friday, June 9, 2017 1:16 AM
To: Kershner, David A <[email protected]>; [email protected]; Binder, David Anthony <[email protected]>; Sell, Timothy C <[email protected]>; Wadgaonkar, Sameer Laxmikant <[email protected]>; Thompson, Bryan E. <[email protected]>; [email protected]
Cc: *S-Par-Maintainer <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] Drivers: unisys: visorhba - style fix
Quoted 4 lines
Fixed style of permissions to octal.
Found using checkpatchSigned-off-by Derek Robson <[email protected]>
Quoted 20 lines
--- drivers/staging/unisys/visorhba/visorhba_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/unisys/visorhba/visorhba_main.c +1
-2@@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev) goto err_scsi_remove_host; } devdata->debugfs_info = -debugfs_create_file ("info" ,S_IRUSR |S_IRGRP , +debugfs_create_file ("info" ,0440 , devdata->debugfs_dir, devdata, &info_debugfs_fops);if (!devdata->debugfs_info) { --2.13.0
Drivers is never a valid subsystem. Do a git log --oneline <file> to look at what other people are doing. The style varies by subsystem so you should always run that command.
regards,
dan carpenter