dt: sun8i: Perfect r_pio node of the A83T

From: Ziping Chen <[email protected]>

The SinA83T is an A83T core/daughter board combo from Sinlinx.

Add support for it.

Signed-off-by Ziping Chen <[email protected]>

---
 arch/arm/dts/Makefile                       |   3 +-
 arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts | 107 ++++++++++++++++++++++++++++
 board/sunxi/MAINTAINERS                     |   6 ++
 configs/Sinlinx_SinA83T_defconfig           |  21 ++++++
 4 files changed, 136 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts
 create mode 100644 configs/Sinlinx_SinA83T_defconfig

arch/arm/dts/Makefile +0 -0

index 8b8f5e9e76..c0eae9f443 100644

arch/arm/dts/Makefile +0 -0

 dtb-$(CONFIG_MACH_SUN8I_H3) += \
 	sun8i-h2-plus-orangepi-zero.dtb \
 	sun8i-h3-bananapi-m2-plus.dtb \

arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts new file +97 -0

new file mode 100644
index 0000000000..ae50e022d4
@@ -0,0 +1,107 @@
+/*
+ * Copyright 2017 Ziping Chen
+ * Ziping Chen <[email protected]>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include "sun8i-a83t.dtsi"
+#include "sunxi-common-regulators.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/pinctrl/sun4i-a10.h>
+
+/ {
+	model = "Sinlinx SinA83T";
+	compatible = "sinlinx,sina83t", "allwinner,sun8i-a83t";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		usr_led {
+			label = "sinlinx:blue:usr";
+			gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 */
+			default-state = "on";
+		};
+	};
+};
+
+#define USB_CLASS_HUB 9
+
+&ehci0 {
+	/* USB 2.0 4 port hub IC */
+	status = "okay";
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	hub {
+		compatible = "usb-hub";
+		usb,device-class = <USB_CLASS_HUB>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+	};
+};
+
+&ehci1 {
+	status = "okay";
+};
+
+&ohci0 {
+	status = "okay";
+};

Hi,

Quoted 10 lines · Ziping Chen

From: Ziping Chen <[email protected]>

The SinA83T is an A83T core/daughter board combo from Sinlinx.

Add support for it.

Signed-off-by Ziping Chen <[email protected]>

---
 arch/arm/dts/Makefile                       |   3 +-
 arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts | 107

++++++++++++++++++++++++++++

Quoted 11 lines

 board/sunxi/MAINTAINERS                     |   6 ++
 configs/Sinlinx_SinA83T_defconfig           |  21 ++++++
 4 files changed, 136 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts
 create mode 100644 configs/Sinlinx_SinA83T_defconfig

arch/arm/dts/Makefile +0 -0

index 8b8f5e9e76..c0eae9f443 100644

arch/arm/dts/Makefile dtb-$(CONFIG_MACH_SUN8I_A33) += \ · line 309

Quoted 6 lines

arch/arm/dts/Makefile +2 -1

@@ -305,7 +305,8 @@ dtb-$(CONFIG_MACH_SUN8I_A33) += \
 dtb-$(CONFIG_MACH_SUN8I_A83T) += \
      sun8i-a83t-allwinner-h8homlet-v2.dtb \
      sun8i-a83t-cubietruck-plus.dtb \
-     sun8i-a83t-sinovoip-bpi-m3.dtb
+     sun8i-a83t-sinovoip-bpi-m3.dtb \
+     sun8i-a83t-sinlinx-sina83t.dtb

DT should be ordered alphabetically, so before the BPi M3.

Review

Quoted 4 lines

arch/arm/dts/Makefile +0 -0

 dtb-$(CONFIG_MACH_SUN8I_H3) += \
      sun8i-h2-plus-orangepi-zero.dtb \
      sun8i-h3-bananapi-m2-plus.dtb \

(quoted diff) +0 -0

b/arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts

Quoted 7 lines

new file mode 100644
index 0000000000..ae50e022d4

arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts new file +2 -0

@@ -0,0 +1,107 @@
+/*
+ * Copyright 2017 Ziping Chen

arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts line 12

Quoted 10 lines

arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts new file +10 -0

+ * Ziping Chen <[email protected]>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of

the

Quoted 85 lines

arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts new file +85 -0

+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include "sun8i-a83t.dtsi"
+#include "sunxi-common-regulators.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/pinctrl/sun4i-a10.h>
+
+/ {
+     model = "Sinlinx SinA83T";
+     compatible = "sinlinx,sina83t", "allwinner,sun8i-a83t";
+
+     aliases {
+             serial0 = &uart0;
+     };
+
+     chosen {
+             stdout-path = "serial0:115200n8";
+     };
+
+     leds {
+             compatible = "gpio-leds";
+
+             usr_led {
+                     label = "sinlinx:blue:usr";
+                     gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 */
+                     default-state = "on";
+             };
+     };
+};
+
+#define USB_CLASS_HUB 9
+
+&ehci0 {
+     /* USB 2.0 4 port hub IC */
+     status = "okay";
+     #address-cells = <2>;
+     #size-cells = <2>;
+
+     hub {
+             compatible = "usb-hub";
+             usb,device-class = <USB_CLASS_HUB>;
+             #address-cells = <1>;
+             #size-cells = <0>;
+     };
+};
+
+&ehci1 {
+     status = "okay";
+};
+
+&ohci0 {
+     status = "okay";
+};

arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts line 107

Quoted 10 lines

arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts new file +10 -0

+
+&uart0 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&uart0_pins_a>;
+     status = "okay";
+};
+
+&usb_otg {
+     status = "okay";
+};

Can you contribute that DT with Linux first? We share them with Linux, and it should be accepted there first.

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Previously I did not submit the patch to linux because of the missing a83t's DT support of Linux...
And I saw Bananapi M3 haven't been supported for Linux, but for U-Boot.

Well, now I will try to fix up the a83t's DT support for Linux, and then submitted it to uboot.

BTW, I found that the U-Boot's DT is a little different from the Linux's DT. Sometime I should adjust the DT file slightly to make it compatible for each other. For exmaple, Linux now uses "sun8i-h3-h5.dtsi" and "sun8i-h3.dtsi" for a h3 device, while U-Boot only uses "sun8i-h3.dtsi".