Skip to contentSkip to conversation

ARM: OMAP: PM: stop early on systems without twl

PATCH Superseded Sebastian Reichel 2 participants 5 messages Jun 9, 2017 – Jun 14, 2017

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP: PM: stop early on systems without twl

Motorola Droid 4 has an OMAP4, but no TWL6030. It currently complains verbosely about this during boot:

twl: not initialized
twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1410000 Vs max 1316660
omap2_set_init_voltage: unable to find boot up OPP for vdd_core
omap2_set_init_voltage: unable to set vdd_core
omap2_set_init_voltage: unable to find boot up OPP for vdd_iva
omap2_set_init_voltage: unable to set vdd_iva

While proper support for CPCAP should be added at some point, let's exit early in omap2_common_pm_late_init() until that has been implemented to avoid the above errors. There is still a reminder about missing PM in dmesg:

Missing OMAP4 PM for this platform!

---
 arch/arm/mach-omap2/pm.c | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-omap2/pm.c +3 -0
index 63027e60cc20..4e4313cecc26 100644
@@ -240,6 +240,9 @@ omap_postcore_initcall(omap2_common_pm_init);
 
 int __init omap2_common_pm_late_init(void)
 {
+	if (!twl_rev())
+		return -ENODEV;
+
 	/* Init the voltage layer */
 	omap3_twl_init();
 	omap4_twl_init();
Signature · 1 line
2.11.0
maintainer
#1 lore raw
Quoted 16 lines · Sebastian Reichel

Motorola Droid 4 has an OMAP4, but no TWL6030. It currently complains verbosely about this during boot:

twl: not initialized
twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1410000 Vs max 1316660
omap2_set_init_voltage: unable to find boot up OPP for vdd_core
omap2_set_init_voltage: unable to set vdd_core
omap2_set_init_voltage: unable to find boot up OPP for vdd_iva
omap2_set_init_voltage: unable to set vdd_iva

Quoted 6 lines

While proper support for CPCAP should be added at some point, let's exit early in omap2_common_pm_late_init() until that has been implemented to avoid the above errors. There is still a reminder about missing PM in dmesg:

Missing OMAP4 PM for this platform!

Great good to see this dmesg spam go away. Applying into omap-for-v4.13/soc-v3 thanks.

Tony

maintainer
#2 lore raw
Quoted 22 lines · Tony Lindgren
Quoted 21 lines · Sebastian Reichel

Motorola Droid 4 has an OMAP4, but no TWL6030. It currently complains verbosely about this during boot:

twl: not initialized
twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1410000 Vs max 1316660
omap2_set_init_voltage: unable to find boot up OPP for vdd_core
omap2_set_init_voltage: unable to set vdd_core
omap2_set_init_voltage: unable to find boot up OPP for vdd_iva
omap2_set_init_voltage: unable to set vdd_iva

While proper support for CPCAP should be added at some point, let's exit early in omap2_common_pm_late_init() until that has been implemented to avoid the above errors. There is still a reminder about missing PM in dmesg:

Quoted 4 lines
Quoted 1 line

Missing OMAP4 PM for this platform!

Great good to see this dmesg spam go away. Applying into omap-for-v4.13/soc-v3 thanks.

After running make randconfig builds over lunch I noticed we can now get "undefined reference to `twl_rev'" so we need something more here if CONFIG_TWL4030_CORE or CONFIG_TWL6040_CORE is not selected or is a loadable module.

Maybe making the whole function depend on the following might work:

#if IS_BUILTIN(CONFIG_TWL6040_CORE) || \
	IS_BUILTIN(CONFIG_TWL4030_CORE)

...
#endif

Anyways dropping for now.

Regards,

Tony

#3 lore raw

PATCH v2 1/1 ARM: OMAP: PM: stop early on systems without twl

From: Sebastian Reichel <[email protected]>

Motorola Droid 4 has an OMAP4, but no TWL6030. It currently complains verbosely about this during boot:

twl: not initialized
twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660 twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1410000 Vs max 1316660
omap2_set_init_voltage: unable to find boot up OPP for vdd_core
omap2_set_init_voltage: unable to set vdd_core
omap2_set_init_voltage: unable to find boot up OPP for vdd_iva
omap2_set_init_voltage: unable to set vdd_iva

While proper support for CPCAP should be added at some point, let's exit early in omap2_common_pm_late_init() until that has been implemented to avoid the above errors. There is still a reminder about missing PM in dmesg:

Missing OMAP4 PM for this platform!

---
Changes since PATCHv1:
* actually add the message about missing PM support
* check if TWL is enabled at all

---
 arch/arm/mach-omap2/pm.c | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/mach-omap2/pm.c +9 -0
index 63027e60cc20..92e335decc61 100644
@@ -240,6 +240,10 @@ omap_postcore_initcall(omap2_common_pm_init);
 
 int __init omap2_common_pm_late_init(void)
 {
+#if IS_BUILTIN(CONFIG_TWL6040_CORE) || IS_BUILTIN(CONFIG_TWL4030_CORE)
+	if (!twl_rev())
+		goto no_twl;
+
 	/* Init the voltage layer */
 	omap3_twl_init();
 	omap4_twl_init();
@@ -253,4 +257,9 @@ int __init omap2_common_pm_late_init(void)
 	omap_devinit_smartreflex();
 
 	return 0;
+
+no_twl:
+#endif
+	pr_err("OMAP4 PM not supported!\n");
+	return -ENODEV;
 }
Signature · 1 line
2.11.0
maintainer
#4 lore raw
Quoted 17 lines · Sebastian Reichel

From: Sebastian Reichel <[email protected]>

arch/arm/mach-omap2/pm.c +4 -0
index 63027e60cc20..92e335decc61 100644
@@ -240,6 +240,10 @@ omap_postcore_initcall(omap2_common_pm_init);
 
 int __init omap2_common_pm_late_init(void)
 {
+#if IS_BUILTIN(CONFIG_TWL6040_CORE) || IS_BUILTIN(CONFIG_TWL4030_CORE)
+	if (!twl_rev())
+		goto no_twl;
+
 	/* Init the voltage layer */
 	omap3_twl_init();
 	omap4_twl_init();

arch/arm/mach-omap2/pm.c int __init omap2_common_pm_late_init(void) · line 264

Quoted 8 lines
arch/arm/mach-omap2/pm.c +5 -0
@@ -253,4 +257,9 @@ int __init omap2_common_pm_late_init(void)
 	omap_devinit_smartreflex();
 
 	return 0;
+
+no_twl:
+#endif
+	pr_err("OMAP4 PM not supported!\n");
+	return -ENODEV;

This should probably just say "OMAP4 SmartReflex not supported". We already have omap4 CPUs hit off mode during idle. What's missing is save and restore of registers for various domains.

SmartReflex is also doable without twl PMICs, at least ti81xx are doing SmartReflex over a group of GPIO pins without twl.

So maybe just put the twl specific parts into IS_BUILTIN so we can optionally add other PM init here if needed?

Regards,

Tony