package/qt5/qt5base: needs host gcc >= 4.8 for icu support
PATCH 3/4 package/qt5/qt5base: needs host gcc >= 4.8 for icu support
--- package/qt5/qt5base/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
package/qt5/qt5base/Config.in +4 -2
@@ -258,6 +258,7 @@ config BR2_PACKAGE_QT5BASE_DBUS config BR2_PACKAGE_QT5BASE_ICU bool "Enable ICU support" + depends on BR2_HOST_GCC_AT_LEAST_4_8 # icu depends on !BR2_BINFMT_FLAT # icu depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu select BR2_PACKAGE_ICU
@@ -265,9 +266,10 @@ config BR2_PACKAGE_QT5BASE_ICU This option enables ICU support in Qt5. This is for example needed for Qt5Webkit. -comment "icu support needs a toolchain w/ gcc >= 4.8" +comment "icu support needs a toolchain w/ gcc >= 4.8, host gcc >= 4.8" depends on !BR2_BINFMT_FLAT - depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \ + !BR2_HOST_GCC_AT_LEAST_4_8 config BR2_PACKAGE_QT5BASE_TSLIB bool "Enable Tslib support"
Signature · 1 line
2.11.0
PATCH 4/4 package/qt5/qt5webkit: needs host gcc >= 4.8 for icu support
--- package/qt5/qt5webkit/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
package/qt5/qt5webkit/Config.in +4 -2
@@ -2,6 +2,7 @@ config BR2_PACKAGE_QT5WEBKIT bool "qt5webkit" depends on !BR2_STATIC_LIBS depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE + depends on BR2_HOST_GCC_AT_LEAST_4_8 # icu depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu depends on !BR2_BINFMT_FLAT # icu # assumes a FPU is available on MIPS
@@ -27,8 +28,9 @@ config BR2_PACKAGE_QT5WEBKIT http://doc.qt.io/archives/qt-5.5/qtwebkit-index.html -comment "qt5webkit needs a toolchain w/ dynamic library, gcc >= 4.8" - depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 +comment "qt5webkit needs a toolchain w/ dynamic library, gcc >= 4.8, host gcc >= 4.8" + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \ + !BR2_HOST_GCC_AT_LEAST_4_8 depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE depends on !BR2_BINFMT_FLAT depends on !BR2_MIPS_SOFT_FLOAT
Signature · 1 line
2.11.0
PATCH 4/4 package/qt5/qt5webkit: needs host gcc >= 4.8 for icu support
Hello,
package/qt5/qt5webkit/Config.in config BR2_PACKAGE_QT5WEBKIT · line 33
Quoted 2 lines · Bernd Kuhls
package/qt5/qt5webkit/Config.in +2
-0+ depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \ + !BR2_HOST_GCC_AT_LEAST_4_8
You forgot to add a || here, so this patch causes a clear failure when running "make menuconfig". I've fixed that before pushing of course, but it would be nice if you could at least test your Config.in changes by running "make menuconfig" :)
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 4/4 package/qt5/qt5webkit: needs host gcc >= 4.8 for icu support
Am Sat, 10 Jun 2017 23:08:43 +0200 schrieb Thomas Petazzoni:
Quoted 2 lines
it would be nice if you could at least test your Config.in changes by running "make menuconfig" :)
Hi,
I did but I missed the fact that
source "package/qt5/qt5webkit/Config.in"
is guarded by
if BR2_PACKAGE_QT5
Sorry for the hassle.
Regards, Bernd
PATCH 4/4 package/qt5/qt5webkit: needs host gcc >= 4.8 for icu support
Hello,
Quoted 5 lines · Bernd Kuhls
Quoted 2 lines
it would be nice if you could at least test your Config.in changes by running "make menuconfig" :)
Hi,
Quoted 7 lines
I did but I missed the fact that
source "package/qt5/qt5webkit/Config.in"
is guarded by
if
BR2_PACKAGE_QT5
I didn't had qt5 enabled. All Config.in files are parsed when you run "make menuconfig", even if their inclusion is guarded by a if..endif.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com