IB/ipoib: Let lower driver handle get_stats64 call
PATCH 1/1 IB/ipoib: Let lower driver handle get_stats64 call
From: Erez Shitrit <erezsh-VPRAkNaXOzVWk0Htik3J/[email protected]>
The driver checks if the lower level driver supports get_stats, and if so calls it to get the updated statistics, otherwise takes from the current netdevice stats object.
--- drivers/infiniband/ulp/ipoib/ipoib_main.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/infiniband/ulp/ipoib/ipoib_main.c +12 -0
@@ -261,6 +261,17 @@ static int ipoib_change_mtu(struct net_device *dev, int new_mtu)return 0 ; } +static void ipoib_get_stats (struct net_device *dev, +struct rtnl_link_stats64 *stats) +{ +struct ipoib_dev_priv *priv =ipoib_priv (dev); + +if (priv->rn_ops->ndo_get_stats64) + priv->rn_ops->ndo_get_stats64 (dev, stats); +else +netdev_stats_to_stats64 (stats, &dev->stats); +} +/* Called with an RCU read lock taken */ static bool ipoib_is_dev_match_addr_rcu (const struct sockaddr *addr,struct net_device *dev)
@@ -1805,6 +1816,7 @@ static const struct net_device_ops ipoib_netdev_ops_pf = { .ndo_get_vf_stats = ipoib_get_vf_stats, .ndo_set_vf_guid = ipoib_set_vf_guid, .ndo_set_mac_address = ipoib_set_mac, + .ndo_get_stats64 = ipoib_get_stats, };static const struct net_device_ops ipoib_netdev_ops_vf = {
--
2.12.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20170612074521.15785-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Yuval Shaia
Reviewed-byQuoted 36 lines · Leon Romanovsky
From: Erez Shitrit <erezsh-VPRAkNaXOzVWk0Htik3J/[email protected]>
The driver checks if the lower level driver supports
get_stats, and if so calls it to get the updated statistics, otherwise takes from the current netdevice stats object.Signed-off-by Leon Romanovsky <[email protected]>--- drivers/infiniband/ulp/ipoib/ipoib_main.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/infiniband/ulp/ipoib/ipoib_main.c +11
-0@@ -261,6 +261,17 @@ static int ipoib_change_mtu(struct net_device *dev, int new_mtu)return 0 ; } +static void ipoib_get_stats (struct net_device *dev, +struct rtnl_link_stats64 *stats) +{ +struct ipoib_dev_priv *priv =ipoib_priv (dev); + +if (priv->rn_ops->ndo_get_stats64) + priv->rn_ops->ndo_get_stats64 (dev, stats); +else +netdev_stats_to_stats64 (stats, &dev->stats); +} +/* Called with an RCU read lock taken */ static bool ipoib_is_dev_match_addr_rcu (const struct sockaddr *addr,struct net_device *dev)
drivers/infiniband/ulp/ipoib/ipoib_main.c static const struct net_device_ops ipoib_netdev_ops_pf = { · line 1820
Quoted 5 lines
drivers/infiniband/ulp/ipoib/ipoib_main.c +1
-0@@ -1805,6 +1816,7 @@ static const struct net_device_ops ipoib_netdev_ops_pf = { .ndo_get_vf_stats = ipoib_get_vf_stats, .ndo_set_vf_guid = ipoib_set_vf_guid, .ndo_set_mac_address = ipoib_set_mac, + .ndo_get_stats64 = ipoib_get_stats, };
Quoted 9 lines
drivers/infiniband/ulp/ipoib/ipoib_main.c +0
-1static const struct net_device_ops ipoib_netdev_ops_vf = { --2.12.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 9 lines · Leon Romanovsky
From: Erez Shitrit <erezsh-VPRAkNaXOzVWk0Htik3J/[email protected]>
The driver checks if the lower level driver supports
get_stats, and if so calls it to get the updated statistics, otherwise takes from the current netdevice stats object.Signed-off-by Leon Romanovsky <[email protected]>
This has been accepted into 4.13-rc, thanks.
Signature · 3 lines
Doug Ledford <[email protected]> GPG Key ID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD