Skip to contentSkip to conversation

proc: snmp6: Use correct type in memset

PATCH In review Christian Perle 2 participants 2 messages Jun 12, 2017

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Christian Perle

author
#0 lore raw

PATCH 1/1 proc: snmp6: Use correct type in memset

Reading /proc/net/snmp6 yields bogus values on 32 bit kernels. Use "u64" instead of "unsigned long" in sizeof().

Fixes 4a4857b ("proc: Reduce cache miss in snmp6_seq_show")
Signed-off-by Christian Perle <[email protected]>
---
 net/ipv6/proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv6/proc.c +1 -1
index cc8e3ae..e88bcb8 100644
@@ -219,7 +219,7 @@ static void snmp6_seq_show_item64(struct seq_file *seq, void __percpu *mib,
 	u64 buff64[SNMP_MIB_MAX];
 	int i;
 
-	memset(buff64, 0, sizeof(unsigned long) * SNMP_MIB_MAX);
+	memset(buff64, 0, sizeof(u64) * SNMP_MIB_MAX);
 
 	snmp_get_cpu_field64_batch(buff64, itemlist, mib, syncpoff);
 	for (i = 0; itemlist[i].name; i++)
Signature · 1 line
2.1.4
maintainer
#1 lore raw

From: Christian Perle <[email protected]>
Date: Mon, 12 Jun 2017 10:06:57 +0200

Quoted 4 lines

Reading /proc/net/snmp6 yields bogus values on 32 bit kernels. Use "u64" instead of "unsigned long" in sizeof().

Fixes 4a4857b ("proc: Reduce cache miss in snmp6_seq_show")

Please use 12 significant digits of SHA1-ID in Fixes: tags, I fixed it up for you this time.

Quoted 1 line
Signed-off-by Christian Perle <[email protected]>

Applied and queued up for -stable, thanks.