USB: serial: option: add Telewell TW-3G HSPA+ device id

PATCH In review Johan Hovold 5 participants 11 messages Jun 12, 2017

Subsystems (3)

Stable branch USB USB serial

lore

Share & tools

lore

Johan Hovold

author maintainer

2017-06-12 09:16 UTC #0 lore raw

PATCH 1/1 USB: serial: option: add Telewell TW-3G HSPA+ device id

Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the Longcheer vendor id.

Reported-by Teemu Likonen <[email protected]>

Cc stable <[email protected]>

Signed-off-by Johan Hovold <[email protected]>

---
 drivers/usb/serial/option.c | 4 ++++
 1 file changed, 4 insertions(+)

Teemu, would you be able to test this patch?

Thanks,
Johan

drivers/usb/serial/option.c +4 -0

index 3bf61acfc26b..b48f3557b2e4 100644
@@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
 /* SpeedUp SU9800 usb 3g modem */
 #define SPEEDUP_PRODUCT_SU9800			0x9800
 
+/* Telewell */
+#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
+
 /* Haier products */
 #define HAIER_VENDOR_ID				0x201e
 #define HAIER_PRODUCT_CE81B			0x10f8

@@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
 	},
 	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
+	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
 	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },

Signature · 1 line

2.13.1

Bjørn Mork

2017-06-12 09:50 UTC #1 lore raw

Quoted 31 lines · Johan Hovold

Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the Longcheer vendor id.
Reported-by Teemu Likonen <[email protected]>
Cc stable <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/usb/serial/option.c | 4 ++++
 1 file changed, 4 insertions(+)
Teemu, would you be able to test this patch?
Thanks,
Johan
drivers/usb/serial/option.c +3 -0
index 3bf61acfc26b..b48f3557b2e4 100644
@@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
 /* SpeedUp SU9800 usb 3g modem */
 #define SPEEDUP_PRODUCT_SU9800			0x9800
 
+/* Telewell */
+#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
+
 /* Haier products */
 #define HAIER_VENDOR_ID				0x201e
 #define HAIER_PRODUCT_CE81B			0x10f8

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1886

Quoted 7 lines

drivers/usb/serial/option.c +1 -0

@@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
 	},
 	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
+	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
 	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },

I was looking at the Windows drivers on
https://www.telewell.fi/files/tw-3g_hspa_ajuri.zip
whiche have this among the serial stuff:

[QCOM]

%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9801&MI_03
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9803&MI_04
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9806&MI_05
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9808&MI_06

%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9866&MI_03
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9868&MI_04
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9869&MI_05

It's not clear what type of driver the 'cmntnet.sys' installed by this is, but I wonder if it maybe is QMI based on the 'qc' prefix?

And maybe we should add the remaining device IDs too?

Bjørn

Oliver Neukum

2017-06-12 10:11 UTC #2 lore raw

Am Montag, den 12.06.2017, 11:50 +0200 schrieb Bjørn Mork:

Quoted 2 lines

It's not clear what type of driver the 'cmntnet.sys' installed by this is, but I wonder if it maybe is QMI based on the 'qc' prefix?

QualCom

I am afraid it says nothing about the protocol.

Regards
Oliver

Johan Hovold

author maintainer

2017-06-12 10:13 UTC #3 lore raw

In reply to Bjørn Mork

[ +CC: Lars ]

Quoted 52 lines · Bjï¿½rn Mork

Quoted 31 lines · Johan Hovold
Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the Longcheer vendor id.
Reported-by Teemu Likonen <[email protected]>
Cc stable <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/usb/serial/option.c | 4 ++++
 1 file changed, 4 insertions(+)
Teemu, would you be able to test this patch?
Thanks,
Johan
drivers/usb/serial/option.c +3 -0
index 3bf61acfc26b..b48f3557b2e4 100644
@@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
 /* SpeedUp SU9800 usb 3g modem */
 #define SPEEDUP_PRODUCT_SU9800			0x9800
 
+/* Telewell */
+#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
+
 /* Haier products */
 #define HAIER_VENDOR_ID				0x201e
 #define HAIER_PRODUCT_CE81B			0x10f8
drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1886
Quoted 7 lines
drivers/usb/serial/option.c +1 -0
@@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
 	},
 	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
+	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
 	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },
I was looking at the Windows drivers on
https://www.telewell.fi/files/tw-3g_hspa_ajuri.zip
whiche have this among the serial stuff:
[QCOM]
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9801&MI_03
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9803&MI_04
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9806&MI_05
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9808&MI_06

Quoted 7 lines

%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9866&MI_03
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9868&MI_04
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9869&MI_05
It's not clear what type of driver the 'cmntnet.sys' installed by this is, but I wonder if it maybe is QMI based on the 'qc' prefix?

I think Lars just suggested that.

Quoted 1 line

And maybe we should add the remaining device IDs too?

Good idea, I'll respin.

Thanks,
Johan

Johan Hovold

author maintainer

2017-06-12 10:14 UTC #4 lore raw

In reply to Bjørn Mork

[ +CC: Lars, resend with Lars actually on CC ]

Quoted 52 lines · Bjï¿½rn Mork

Quoted 31 lines · Johan Hovold
Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the Longcheer vendor id.
Reported-by Teemu Likonen <[email protected]>
Cc stable <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/usb/serial/option.c | 4 ++++
 1 file changed, 4 insertions(+)
Teemu, would you be able to test this patch?
Thanks,
Johan
drivers/usb/serial/option.c +3 -0
index 3bf61acfc26b..b48f3557b2e4 100644
@@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
 /* SpeedUp SU9800 usb 3g modem */
 #define SPEEDUP_PRODUCT_SU9800			0x9800
 
+/* Telewell */
+#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
+
 /* Haier products */
 #define HAIER_VENDOR_ID				0x201e
 #define HAIER_PRODUCT_CE81B			0x10f8
drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1886
Quoted 7 lines
drivers/usb/serial/option.c +1 -0
@@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
 	},
 	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
+	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
 	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },
I was looking at the Windows drivers on
https://www.telewell.fi/files/tw-3g_hspa_ajuri.zip
whiche have this among the serial stuff:
[QCOM]
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9801&MI_03
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9803&MI_04
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9806&MI_05
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9808&MI_06

Quoted 7 lines

%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9866&MI_03
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9868&MI_04
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9869&MI_05
It's not clear what type of driver the 'cmntnet.sys' installed by this is, but I wonder if it maybe is QMI based on the 'qc' prefix?

I think Lars just suggested that.

Quoted 1 line

And maybe we should add the remaining device IDs too?

Good idea, I'll respin.

Thanks,
Johan

Lars Melin

2017-06-12 10:31 UTC #5 lore raw

In reply to Bjørn Mork

Quoted 61 lines · Bjørn Mork

Quoted 31 lines · Johan Hovold
Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the Longcheer vendor id.
Reported-by Teemu Likonen <[email protected]>
Cc stable <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
  drivers/usb/serial/option.c | 4 ++++
  1 file changed, 4 insertions(+)
Teemu, would you be able to test this patch?
Thanks,
Johan
drivers/usb/serial/option.c +3 -0
index 3bf61acfc26b..b48f3557b2e4 100644
@@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
  /* SpeedUp SU9800 usb 3g modem */
  #define SPEEDUP_PRODUCT_SU9800			0x9800
 
+/* Telewell */
+#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
+
  /* Haier products */
  #define HAIER_VENDOR_ID				0x201e
  #define HAIER_PRODUCT_CE81B			0x10f8
drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1886
Quoted 7 lines
drivers/usb/serial/option.c +1 -0
@@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
  	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
  	},
  	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
+	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
  	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },
I was looking at the Windows drivers on
https://www.telewell.fi/files/tw-3g_hspa_ajuri.zip
whiche have this among the serial stuff:
[QCOM]
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9801&MI_03
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9803&MI_04
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9806&MI_05
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9808&MI_06
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9866&MI_03
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9868&MI_04
%qcwwan.DeviceDesc%    = qcwwan.ndi, USB\VID_1C9E&PID_9869&MI_05
It's not clear what type of driver the 'cmntnet.sys' installed by this is, but I wonder if it maybe is QMI based on the 'qc' prefix?

Quoted 6 lines

And maybe we should add the remaining device IDs too?
Bjørn

1c9e:9803 can be added, the other ones may be reserved id's for products that never reached the market.

/Lars

Bjørn Mork

2017-06-12 10:38 UTC #6 lore raw

Quoted 2 lines · Lars Melin

1c9e:9803 can be added, the other ones may be reserved id's for products that never reached the market.

Out of curiosity: How do you know these things?

Thanks for very valuable information. Our lists of supported devices are long enough without lots of dead entries...

Bjørn

Lars Melin

2017-06-12 11:02 UTC #7 lore raw

Quoted 5 lines · Bjørn Mork

Quoted 2 lines · Lars Melin
1c9e:9803 can be added, the other ones may be reserved id's for products that never reached the market.

Quoted 8 lines

Out of curiosity: How do you know these things?
Thanks for very valuable information. Our lists of supported devices are long enough without lots of dead entries...
Bjørn

The driver is almost 6 years old and only the first two id's has surfaced on the net or in all the GPL code I have from some of the major Chinese 3G router manufacturers. 1c9e:9801 is btw included in a mfgr specific qmi_wwan driver together
with some other id's which may interest you.
Tell me if you want to get that driver and I'll mail it to you.

The driver is written by Qualcomm for Longcheer and Qualcomm is known for including device id's that either never become used or (even worser) will be used for a product with an interface layout not matching what was listed in the big Qualcomm driver .inf file

I have never seen qcwwan.ndi used for anything else than rmnet/qmiwwan and a single interface without altsetting and with 3 interfaces whereof one is of interrupt type and with interface attributes ff/ff/ff can't possibly be for any other net type protocol.

/Lars

Johan Hovold

author maintainer

2017-06-12 14:29 UTC #8 lore raw

Quoted 23 lines · Lars Melin

Quoted 9 lines · Bjï¿½rn Mork
Quoted 2 lines · Lars Melin
1c9e:9803 can be added, the other ones may be reserved id's for products that never reached the market.
Out of curiosity: How do you know these things?
Thanks for very valuable information. Our lists of supported devices are long enough without lots of dead entries...
The driver is almost 6 years old and only the first two id's has surfaced on the net or in all the GPL code I have from some of the major Chinese 3G router manufacturers.
1c9e:9801 is btw included in a mfgr specific qmi_wwan driver together with some other id's which may interest you.
Tell me if you want to get that driver and I'll mail it to you.
The driver is written by Qualcomm for Longcheer and Qualcomm is known for including device id's that either never become used or (even worser) will be used for a product with an interface layout not matching what was listed in the big Qualcomm driver .inf file

Quoted 4 lines

I have never seen qcwwan.ndi used for anything else than rmnet/qmiwwan and a single interface without altsetting and with 3 interfaces whereof one is of interrupt type and with interface attributes ff/ff/ff can't possibly be for any other net type protocol.

Thanks for the details.

So I'll only add these two ids while blacklisting interface 3 and 4 respectively.

Thanks,
Johan

Teemu Likonen

2017-06-12 10:11 UTC #9 lore raw

In reply to Johan Hovold

Quoted 11 lines · Johan Hovold [2017-06-12 11:16:12+02] wrote:

Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the Longcheer vendor id.
Reported-by Teemu Likonen <[email protected]>
Cc stable <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/usb/serial/option.c | 4 ++++
 1 file changed, 4 insertions(+)
Teemu, would you be able to test this patch?

It seems that you will do another patch but I'll confirm anyway that this works. I compiled the mainline kernel v4.12-rc5 with this patch.

Quoted 22 lines

drivers/usb/serial/option.c +4 -0

index 3bf61acfc26b..b48f3557b2e4 100644
@@ -388,6 +388,9 @@ static void option_instat_callback(struct urb *urb);
 /* SpeedUp SU9800 usb 3g modem */
 #define SPEEDUP_PRODUCT_SU9800			0x9800
 
+/* Telewell */
+#define TELEWELL_PRODUCT_TW_3G_HSPAP		0x9801
+
 /* Haier products */
 #define HAIER_VENDOR_ID				0x201e
 #define HAIER_PRODUCT_CE81B			0x10f8

@@ -1877,6 +1880,7 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = (kernel_ulong_t)&four_g_w100_blacklist
 	},
 	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
+	{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, TELEWELL_PRODUCT_TW_3G_HSPAP, 0xff) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
 	{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
 	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },

Johan Hovold

author maintainer

2017-06-12 10:16 UTC #10 lore raw

Quoted 12 lines · Teemu Likonen

Quoted 10 lines · Johan Hovold [2017-06-12 11:16:12+02] wrote:
Add device-id entry for the Telewell TW-3G HSPA+ modem, which uses the Longcheer vendor id.
Reported-by Teemu Likonen <[email protected]>
Cc stable <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/usb/serial/option.c | 4 ++++
 1 file changed, 4 insertions(+)

Quoted 4 lines

Quoted 1 line
Teemu, would you be able to test this patch?
It seems that you will do another patch but I'll confirm anyway that this works. I compiled the mainline kernel v4.12-rc5 with this patch.

Great, thanks for testing. It may be you are able to use the QMI driver for this one as well and we should at least blacklist interface 3.

Thanks,
Johan