azure-iot-sdk-c: New package
PATCH v3 1/1 azure-iot-sdk-c: New package
I use 2017-05-05 now, because newer versions will need some fixes (maybe as patches), so let's start with a cleaner version that just works. Still, the projects install target installs the wrong files, that's why commands are needed for staging_install and target_install.
v2: Rework the package with help from Arnouts comments
v3: Explain some things in the commit message
--- DEVELOPERS | 1 + package/Config.in | 1 + package/azure-iot-sdk-c/Config.in | 16 ++++++++++ package/azure-iot-sdk-c/azure-iot-sdk-c.mk | 51 ++++++++++++++++++++++++++++++ 4 files changed, 69 insertions(+) create mode 100644 package/azure-iot-sdk-c/Config.in create mode 100644 package/azure-iot-sdk-c/azure-iot-sdk-c.mk
DEVELOPERS +1 -0
@@ -76,6 +76,7 @@ N: Anders Darander <[email protected]> F: package/ktap/ N: Andr? Hentschel <[email protected]> +F: package/azure-iot-sdk-c/ F: package/openal/ F: package/p7zip/ F: package/wine/
package/Config.in +1 -0
@@ -1247,6 +1247,7 @@ menu "Networking" source "package/alljoyn-base/Config.in" source "package/alljoyn-tcl/Config.in" source "package/alljoyn-tcl-base/Config.in" + source "package/azure-iot-sdk-c/Config.in" source "package/batman-adv/Config.in" source "package/c-ares/Config.in" source "package/canfestival/Config.in"
package/azure-iot-sdk-c/Config.in new file +16 -0
@@ -0,0 +1,16 @@ +config BR2_PACKAGE_AZURE_IOT_SDK_C + bool "azure-iot-sdk-c" + depends on BR2_INSTALL_LIBSTDCPP + select BR2_PACKAGE_LIBCURL + select BR2_PACKAGE_LIBXML2 + select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_UTIL_LINUX + select BR2_PACKAGE_UTIL_LINUX_LIBUUID + help + Microsoft Azure IoT Hub device SDK for C is used + to connect devices running C code to Azure IoT Hub. + + https://docs.microsoft.com/nl-nl/azure/iot-hub/iot-hub-device-sdk-c-intro + +comment "azure-iot-sdk-c needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP
package/azure-iot-sdk-c/azure-iot-sdk-c.mk new file +51 -0
51 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v3 1/1 azure-iot-sdk-c: New package
Hello,
Quoted 1 line · Andr? Hentschel
I use 2017-05-05 now, because newer versions will need some fixes (maybe as patches), so let's start with a cleaner version that just works.
Don't use "personal" sentences in commit logs, and rewrap commit logs at 72 characters. So something like:
"""
Despite newer versions being available, this patch creates a package for version 2017-05-05, because newer version have issues that need to be addressed.
"""
Quoted 2 lines
Still, the projects install target installs the wrong files, that's why commands are needed for
staging_installandtarget_install.
Isn't it better to patch the package build system to fix those issues?
Quoted 3 lines
v2: Rework the package with help from Arnouts comments
v3: Explain some things in the commit message
The commit log should go...
Quoted 2 lines
Signed-off-by Andr? Hentschel <[email protected]>---
... here.
I typically do that by putting "---" below my SoB line, and writing the commit log (git commit --amend).
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v3 1/1 azure-iot-sdk-c: New package
Am 12.06.2017 um 22:45 schrieb Thomas Petazzoni:
Quoted 1 line
Hello,
Hi, thanks for the review
Quoted 6 lines · Andr? Hentschel
Quoted 1 line
I use 2017-05-05 now, because newer versions will need some fixes (maybe as patches), so let's start with a cleaner version that just works.
Don't use "personal" sentences in commit logs, and rewrap commit logs at 72 characters. So something like:
Quoted 7 lines
"""
Despite newer versions being available, this patch creates a package for version 2017-05-05, because newer version have issues that need to be addressed.
"""
thx, done
Quoted 4 lines
Quoted 2 lines
Still, the projects install target installs the wrong files, that's why commands are needed for
staging_installandtarget_install.Isn't it better to patch the package build system to fix those issues?
That would be quite a lot for the first introduction of the package. I'll get in contact with the project to improve the situation in future versions
Quoted 6 lines
Quoted 3 lines
v2: Rework the package with help from Arnouts comments
v3: Explain some things in the commit messageThe commit log should go...
Quoted 7 lines
Quoted 2 lines
Signed-off-by Andr? Hentschel <[email protected]>---
... here.
I typically do that by putting "---" below my SoB line, and writing the commit log (git commit --amend).
thx, done
PATCH v3 1/1 azure-iot-sdk-c: New package
In reply to André HentschelHi Andre,
On 12-06-17 21:51, Andr? Hentschel wrote:
[snip]
package/azure-iot-sdk-c/azure-iot-sdk-c.mk line 19
Quoted 3 lines
package/azure-iot-sdk-c/azure-iot-sdk-c.mk new file +3
-0+# The project only supports building one kind of library. +# Further the install target installs the wrong files, so we do it here: +ifeq ($(BR2_STATIC_LIBS),y)
I was going to say: these also have to be installed in the SHARED_STATIC case.
But apparently CMake doesn't build a static library in the SHARED_STATIC case. Bummer...
Quoted 13 lines
package/azure-iot-sdk-c/azure-iot-sdk-c.mk new file +13
-0+AZURE_IOT_SDK_C_LIBS += uamqp/libuamqp.a c-utility/libaziotsharedutil.a \ + iothub_client/libiothub_client.a iothub_client/libiothub_client_mqtt_ws_transport.a \ + iothub_client/libiothub_client_amqp_ws_transport.a \ + iothub_client/libiothub_client_http_transport.a \ + iothub_client/libiothub_client_amqp_transport.a \ + iothub_client/libiothub_client_mqtt_transport.a \ + iothub_service_client/libiothub_service_client.a serializer/libserializer.a umqtt/libumqtt.a +else +AZURE_IOT_SDK_C_LIBS += uamqp/libuamqp.so c-utility/libaziotsharedutil.so \ + iothub_client/libiothub_client.so iothub_client/libiothub_client_mqtt_ws_transport.so \ + iothub_client/libiothub_client_amqp_ws_transport.so \ + iothub_client/libiothub_client_http_transport.so \ + iothub_client/libiothub_client_amqp_transport.so \
package/azure-iot-sdk-c/azure-iot-sdk-c.mk line 42
Quoted 10 lines
package/azure-iot-sdk-c/azure-iot-sdk-c.mk new file +10
-0+ iothub_client/libiothub_client_mqtt_transport.so \ + iothub_service_client/libiothub_service_client.so serializer/libserializer.so umqtt/libumqtt.so +endif + +define AZURE_IOT_SDK_C_INSTALL_STAGING_CMDS + $(foreach l,$(AZURE_IOT_SDK_C_LIBS), \ + $(INSTALL) -D -m 0755 $(@D)/$(l) $(STAGING_DIR)/usr/lib/ + ) + cp -a $(@D)/c-utility/inc/* $(STAGING_DIR)/usr/include/ + cp -a $(@D)/iothub_client/inc/* $(STAGING_DIR)/usr/include/
This is not the location where the CMakeLists.txt installs the headers. Isn't
that going to give problems when there are packages that use this library?
Regards,
Arnout
Quoted 10 lines
package/azure-iot-sdk-c/azure-iot-sdk-c.mk new file +9
-0+endef + +define AZURE_IOT_SDK_C_INSTALL_TARGET_CMDS + $(foreach l,$(AZURE_IOT_SDK_C_LIBS), \ + $(INSTALL) -D -m 0755 $(@D)/$(l) $(TARGET_DIR)/usr/lib/ + ) +endef + +$(eval $(cmake-package))
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH v3 1/1 azure-iot-sdk-c: New package
Am 13.06.2017 um 00:19 schrieb Arnout Vandecappelle:
Quoted 30 lines
Hi Andre,
On 12-06-17 21:51, Andr? Hentschel wrote:
[snip]package/azure-iot-sdk-c/azure-iot-sdk-c.mk line 19
Quoted 3 lines
package/azure-iot-sdk-c/azure-iot-sdk-c.mk new file +3
-0+# The project only supports building one kind of library. +# Further the install target installs the wrong files, so we do it here: +ifeq ($(BR2_STATIC_LIBS),y)I was going to say: these also have to be installed in the
SHARED_STATICcase.
But apparently CMake doesn't build a static library in theSHARED_STATICcase. Bummer...Quoted 18 lines
package/azure-iot-sdk-c/azure-iot-sdk-c.mk new file +18
-0+AZURE_IOT_SDK_C_LIBS += uamqp/libuamqp.a c-utility/libaziotsharedutil.a \ + iothub_client/libiothub_client.a iothub_client/libiothub_client_mqtt_ws_transport.a \ + iothub_client/libiothub_client_amqp_ws_transport.a \ + iothub_client/libiothub_client_http_transport.a \ + iothub_client/libiothub_client_amqp_transport.a \ + iothub_client/libiothub_client_mqtt_transport.a \ + iothub_service_client/libiothub_service_client.a serializer/libserializer.a umqtt/libumqtt.a +else +AZURE_IOT_SDK_C_LIBS += uamqp/libuamqp.so c-utility/libaziotsharedutil.so \ + iothub_client/libiothub_client.so iothub_client/libiothub_client_mqtt_ws_transport.so \ + iothub_client/libiothub_client_amqp_ws_transport.so \ + iothub_client/libiothub_client_http_transport.so \ + iothub_client/libiothub_client_amqp_transport.so \ + iothub_client/libiothub_client_mqtt_transport.so \ + iothub_service_client/libiothub_service_client.so serializer/libserializer.so umqtt/libumqtt.so +endif + +define AZURE_IOT_SDK_C_INSTALL_STAGING_CMDS
Quoted 9 lines
package/azure-iot-sdk-c/azure-iot-sdk-c.mk line 42
Quoted 5 lines
package/azure-iot-sdk-c/azure-iot-sdk-c.mk new file +5
-0+ $(foreach l,$(AZURE_IOT_SDK_C_LIBS), \ + $(INSTALL) -D -m 0755 $(@D)/$(l) $(STAGING_DIR)/usr/lib/ + ) + cp -a $(@D)/c-utility/inc/* $(STAGING_DIR)/usr/include/ + cp -a $(@D)/iothub_client/inc/* $(STAGING_DIR)/usr/include/This is not the location where the CMakeLists.txt installs the headers. Isn't
that going to give problems when there are packages that use this library?
AFAICT the CMakeLists.txt installs the totally wrong headers, what exactly do you mean here?