ARM: provide a valid exception stack address for startup code
PATCH 1/1 ARM: provide a valid exception stack address for startup code
Create exception stack in IRAM if available to facilitate debugging of pre-relocation code by catching exceptions rather than stopping dead.
--- arch/arm/lib/vectors.S | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
arch/arm/lib/vectors.S +4 -1
@@ -117,7 +117,6 @@ data_abort: not_used: irq: fiq: - 1: bl 1b /* hang and never return */
@@ -126,7 +125,11 @@ fiq: /* IRQ stack memory (calculated at run-time) + 8 bytes */ .globl IRQ_STACK_START_IN IRQ_STACK_START_IN: +#ifdef IRAM_BASE_ADDR + .word IRAM_BASE_ADDR + 0x20 +#else .word 0x0badc0de +#endif @ @ IRQ stack frame.
Signature · 1 line
2.1.4
Quoted 4 lines · Lothar Waßmann
Create exception stack in IRAM if available to facilitate debugging of pre-relocation code by catching exceptions rather than stopping dead.
Signed-off-by Lothar Waßmann <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170612/b34c6a0c/attachment.sig>
PATCH 1/1 ARM: provide a valid exception stack address for startup code
In reply to Lothar WaßmannQuoted 7 lines · Lothar Waßmann
Create exception stack in IRAM if available to facilitate debugging of pre-relocation code by catching exceptions rather than stopping dead.
Signed-off-by Lothar Waßmann <[email protected]>--- arch/arm/lib/vectors.S | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
But please see below.
arch/arm/lib/vectors.S data_abort: · line 120
Quoted 10 lines
arch/arm/lib/vectors.S +0
-1@@ -117,7 +117,6 @@ data_abort: not_used: irq: fiq: -
What is this?
Quoted 18 lines
arch/arm/lib/vectors.S +4
-11: bl 1b /* hang and never return */@@ -126,7 +125,11 @@ fiq: /* IRQ stack memory (calculated at run-time) + 8 bytes */ .globl IRQ_STACK_START_IN IRQ_STACK_START_IN: +#ifdef IRAM_BASE_ADDR + .word IRAM_BASE_ADDR + 0x20 +#else .word 0x0badc0de +#endif @ @ IRQ stack frame. --2.1.4
PATCH 1/1 ARM: provide a valid exception stack address for startup code
Hi,
Quoted 14 lines · On Mon, 12 Jun 2017 17:50:45 -0600 Simon Glass wrote:
Quoted 7 lines · Lothar Waßmann
Create exception stack in IRAM if available to facilitate debugging of pre-relocation code by catching exceptions rather than stopping dead.
Signed-off-by Lothar Waßmann <[email protected]>--- arch/arm/lib/vectors.S | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)Reviewed-by Simon Glass <[email protected]>But please see below.
Quoted 1 line
Quoted 12 lines
arch/arm/lib/vectors.S data_abort: · line 120
Quoted 9 lines
arch/arm/lib/vectors.S +0
-1@@ -117,7 +117,6 @@ data_abort: not_used: irq: fiq: -What is this?
Ooops. An unintentionally deleted empty line.
Should I resend the patch, or can you fix it up when applying?
Lothar Waßmann
PATCH 1/1 ARM: provide a valid exception stack address for startup code
+Tom
Quoted 29 lines · Lothar Waßmann
Hi,
Quoted 14 lines · On Mon, 12 Jun 2017 17:50:45 -0600 Simon Glass wrote:
Quoted 7 lines · Lothar Waßmann
Create exception stack in IRAM if available to facilitate debugging of pre-relocation code by catching exceptions rather than stopping dead.
Signed-off-by Lothar Waßmann <[email protected]>--- arch/arm/lib/vectors.S | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)Reviewed-by Simon Glass <[email protected]>But please see below.
Quoted 1 line
Quoted 12 lines
arch/arm/lib/vectors.S data_abort: · line 120
Quoted 9 lines
arch/arm/lib/vectors.S +0
-1@@ -117,7 +117,6 @@ data_abort: not_used: irq: fiq: -What is this?
Quoted 2 lines
Ooops. An unintentionally deleted empty line.
Should I resend the patch, or can you fix it up when applying?
Probably the latter, but it's up to the custodian.