staging: lustre: llite: Replace the symbolic file permission mode with the numeric one

PATCH New Roman Storozhenko 1 participant 1 message Jun 13, 2017 Staging

Share & tools

Roman Storozhenko

author

2017-06-13 10:04 UTC #0 lore raw

PATCH v4 1/1 staging: lustre: llite: Replace the symbolic file permission mode with the numeric one

Replaces S_IRWXUGO with 0777. The reason is that symbolic permissions considered harmful:
https://lwn.net/Articles/696229/

Signed-off-by Roman Storozhenko <[email protected]>

---
Changes in V4:
- replaces mistyped '0007' in the description with '0777'
- places this description below the '---' line

 drivers/staging/lustre/lustre/llite/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/lustre/lustre/llite/dir.c +1 -1

index 13b3592..de5b4bf 100644
@@ -1141,7 +1141,7 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 		}
 
 #if OBD_OCD_VERSION(2, 9, 50, 0) > LUSTRE_VERSION_CODE
-		mode = data->ioc_type != 0 ? data->ioc_type : S_IRWXUGO;
+		mode = data->ioc_type != 0 ? data->ioc_type : 0777;
 #else
 		mode = data->ioc_type;
 #endif

Signature · 1 line

2.7.4