Fixed16.16 wrapper cleanup & wm optimization
Subsystems (2)
cover Fixed16.16 wrapper cleanup & wm optimization
This series Include patches for:
clean fixed16.16 naming & make them consistent reuse intel_compute_linetime_wm in hsw optimize wm calculation code enable/Implement trans wm calculation
Changes Since V1:
- Split fixed16 cleanup code in more logical patches (Maarten)
- make intel_compute_linetime_wm function static (Maarten)
Mahesh Kumar (9):
drm/i915: take-out common clamping code of fixed16 wrappers drm/i915: Always perform internal fixed16 division in 64 bits drm/i915: cleanup fixed-point wrappers naming
drm/i915: Addition wrapper for fixed16.16 operation drm/i915/hsw: use intel_compute_linetime_wm function for linetime wm drm/i915/skl+: WM calculation don't require height drm/i915/skl+: unify cpp value in WM calculation drm/i915/skl+: Optimize WM calculation
drm/i915/gen10: Calculate and enable transition WM
drivers/gpu/drm/i915/i915_drv.h | 83 ++++++---- drivers/gpu/drm/i915/intel_pm.c | 325 ++++++++++++++++++++++++---------------- 2 files changed, 246 insertions(+), 162 deletions(-)
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/9 drm/i915: take-out common clamping code of fixed16 wrappers
This patch creates a new function for clamping u64 to fixed16. And make use of this function in other fixed16 wrappers.
--- drivers/gpu/drm/i915/i915_drv.h | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +12 -16
@@ -160,6 +160,14 @@ static inline uint_fixed_16_16_t max_fixed_16_16(uint_fixed_16_16_t max1,return max; } +static inline uint_fixed_16_16_t clamp_u64_to_fixed16 (uint64_t val) +{ +uint_fixed_16_16_t fp; +WARN_ON (val >>32 ); + fp.val =clamp_t (uint32_t, val,0 , ~0 ); +return fp; +} +static inline uint32_t div_round_up_fixed16 (uint_fixed_16_16_t val,uint_fixed_16_16_t d) {
@@ -170,26 +178,21 @@ static inline uint32_t mul_round_up_u32_fixed16(uint32_t val, uint_fixed_16_16_t mul) {uint64_t intermediate_val; -uint32_t result; intermediate_val = (uint64_t ) val * mul.val; intermediate_val =DIV_ROUND_UP_ULL (intermediate_val,1 <<16 );WARN_ON (intermediate_val >>32 ); - result =clamp_t (uint32_t, intermediate_val,0 , ~0 ); -return result; +return clamp_t (uint32_t, intermediate_val,0 , ~0 ); }static inline uint_fixed_16_16_t mul_fixed16 (uint_fixed_16_16_t val,uint_fixed_16_16_t mul) {uint64_t intermediate_val; -uint_fixed_16_16_t fp; intermediate_val = (uint64_t ) val.val * mul.val; intermediate_val = intermediate_val >>16 ; -WARN_ON (intermediate_val >>32 ); - fp.val =clamp_t (uint32_t, intermediate_val,0 , ~0 ); -return fp; +return clamp_u64_to_fixed16 (intermediate_val); }static inline uint_fixed_16_16_t fixed_16_16_div (uint32_t val,uint32_t d)
@@ -203,15 +206,11 @@ static inline uint_fixed_16_16_t fixed_16_16_div(uint32_t val, uint32_t d)static inline uint_fixed_16_16_t fixed_16_16_div_u64 (uint32_t val,uint32_t d) { -uint_fixed_16_16_t res;uint64_t interm_val; interm_val = (uint64_t )val <<16 ; interm_val =DIV_ROUND_UP_ULL (interm_val, d); -WARN_ON (interm_val >>32 ); - res.val = (uint32_t ) interm_val; - -return res; +return clamp_u64_to_fixed16 (interm_val); } static inline uint32_t div_round_up_u32_fixed16(uint32_t val,
@@ -229,12 +228,9 @@ static inline uint_fixed_16_16_t mul_u32_fixed_16_16(uint32_t val, uint_fixed_16_16_t mul) {uint64_t intermediate_val; -uint_fixed_16_16_t fp; intermediate_val = (uint64_t ) val * mul.val; -WARN_ON (intermediate_val >>32 ); - fp.val = (uint32_t ) intermediate_val; -return fp; +return clamp_u64_to_fixed16 (intermediate_val); }static inline const char *yesno (bool v)
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/9 drm/i915: Always perform internal fixed16 division in 64 bits
In reply to Mahesh KumarThis patch combines fixed_16_16_div & fixed_16_16_div_u64 wrappers. And new fixed_16_16_div wrapper always performs division operation in u64 internally, to avoid any data loss which was happening in earlier version of wrapper.
earlier wrapper was converting u32 to fixed16 in 32 bit so we were loosing 16-MSB data.
--- drivers/gpu/drm/i915/i915_drv.h | 9 --------- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 2 files changed, 2 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +0 -9
@@ -197,15 +197,6 @@ static inline uint_fixed_16_16_t mul_fixed16(uint_fixed_16_16_t val,static inline uint_fixed_16_16_t fixed_16_16_div (uint32_t val,uint32_t d) { -uint_fixed_16_16_t fp, res; - - fp =u32_to_fixed_16_16 (val); - res.val =DIV_ROUND_UP (fp.val, d); -return res; -} - -static inline uint_fixed_16_16_t fixed_16_16_div_u64 (uint32_t val,uint32_t d) -{uint64_t interm_val; interm_val = (uint64_t )val <<16 ;
drivers/gpu/drm/i915/intel_pm.c +2 -2
@@ -4359,7 +4359,7 @@ static uint_fixed_16_16_t skl_wm_method1(uint32_t pixel_rate, uint8_t cpp,return FP_16_16_MAX ; wm_intermediate_val = latency * pixel_rate * cpp; - ret =fixed_16_16_div_u64 (wm_intermediate_val,1000 *512 ); + ret =fixed_16_16_div (wm_intermediate_val,1000 *512 );return ret; }
@@ -4397,7 +4397,7 @@ intel_get_linetime_us(struct intel_crtc_state *cstate)return u32_to_fixed_16_16 (0 ); crtc_htotal = cstate->base.adjusted_mode.crtc_htotal; - linetime_us =fixed_16_16_div_u64 (crtc_htotal *1000 , pixel_rate); + linetime_us =fixed_16_16_div (crtc_htotal *1000 , pixel_rate);return linetime_us; }
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/9 drm/i915: cleanup fixed-point wrappers naming
In reply to Mahesh KumarThis patch make naming of fixed-point wrappers consistent operation_<any_post_operation>_<1st operand>_<2nd operand> also shorten the name for fixed_16_16 to fixed16
s/u32_to_fixed_16_16/u32_to_fixed16 s/fixed_16_16_to_u32/fixed16_to_u32 s/fixed_16_16_to_u32_round_up/fixed16_to_u32_round_up s/min_fixed_16_16/min_fixed16 s/max_fixed_16_16/max_fixed16 s/mul_u32_fixed_16_16/mul_u32_fixed16 s/fixed_16_16_div/div_fixed16
Changes Since V1:
- Split the patch in more logical patches (Maarten)
--- drivers/gpu/drm/i915/i915_drv.h | 14 +++++----- drivers/gpu/drm/i915/intel_pm.c | 59 ++++++++++++++++++++--------------------- 2 files changed, 36 insertions(+), 37 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +7 -7
@@ -122,7 +122,7 @@ static inline bool is_fixed16_zero(uint_fixed_16_16_t val)return false; } -static inline uint_fixed_16_16_t u32_to_fixed_16_16 (uint32_t val) +static inline uint_fixed_16_16_t u32_to_fixed16 (uint32_t val) {uint_fixed_16_16_t fp;
@@ -132,17 +132,17 @@ static inline uint_fixed_16_16_t u32_to_fixed_16_16(uint32_t val)return fp; } -static inline uint32_t fixed_16_16_to_u32_round_up (uint_fixed_16_16_t fp) +static inline uint32_t fixed16_to_u32_round_up (uint_fixed_16_16_t fp) {return DIV_ROUND_UP (fp.val,1 <<16 ); } -static inline uint32_t fixed_16_16_to_u32 (uint_fixed_16_16_t fp) +static inline uint32_t fixed16_to_u32 (uint_fixed_16_16_t fp) {return fp.val >>16 ; } -static inline uint_fixed_16_16_t min_fixed_16_16 (uint_fixed_16_16_t min1, +static inline uint_fixed_16_16_t min_fixed16 (uint_fixed_16_16_t min1,uint_fixed_16_16_t min2) {uint_fixed_16_16_t min;
@@ -151,7 +151,7 @@ static inline uint_fixed_16_16_t min_fixed_16_16(uint_fixed_16_16_t min1,return min; } -static inline uint_fixed_16_16_t max_fixed_16_16 (uint_fixed_16_16_t max1, +static inline uint_fixed_16_16_t max_fixed16 (uint_fixed_16_16_t max1,uint_fixed_16_16_t max2) {uint_fixed_16_16_t max;
@@ -195,7 +195,7 @@ static inline uint_fixed_16_16_t mul_fixed16(uint_fixed_16_16_t val,return clamp_u64_to_fixed16 (intermediate_val); } -static inline uint_fixed_16_16_t fixed_16_16_div (uint32_t val,uint32_t d) +static inline uint_fixed_16_16_t div_fixed16 (uint32_t val,uint32_t d) {uint64_t interm_val;
@@ -215,7 +215,7 @@ static inline uint32_t div_round_up_u32_fixed16(uint32_t val,return clamp_t (uint32_t, interm_val,0 , ~0 ); } -static inline uint_fixed_16_16_t mul_u32_fixed_16_16 (uint32_t val, +static inline uint_fixed_16_16_t mul_u32_fixed16 (uint32_t val,uint_fixed_16_16_t mul) {uint64_t intermediate_val;
drivers/gpu/drm/i915/intel_pm.c +29 -30
167 lines not on this page · raw message
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/9 drm/i915: Addition wrapper for fixed16.16 operation
In reply to Mahesh KumarThis patch introduce addition wrapper for fixed point 16.16 operations. Which will be used by later patches to avoid direct member variables access of fixed_16_16_t structure.
add_fixed16 : takes 2 fixed_16_16_t variable & returns fixed_16_16_t add_fixed16_u32 : takes fixed_16_16_t & u32 variable & returns fixed_16_16_t
--- drivers/gpu/drm/i915/i915_drv.h | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
drivers/gpu/drm/i915/i915_drv.h +19 -0
@@ -224,6 +224,25 @@ static inline uint_fixed_16_16_t mul_u32_fixed16(uint32_t val,return clamp_u64_to_fixed16 (intermediate_val); } +static inline uint_fixed_16_16_t add_fixed16 (uint_fixed_16_16_t add1, +uint_fixed_16_16_t add2) +{ +uint64_t interm_sum; + + interm_sum = (uint64_t ) add1.val + add2.val; +return clamp_u64_to_fixed16 (interm_sum); +} + +static inline uint_fixed_16_16_t add_fixed16_u32 (uint_fixed_16_16_t add1, +uint32_t add2) +{ +uint64_t interm_sum; +uint_fixed_16_16_t interm_add2 =u32_to_fixed16 (add2); + + interm_sum = (uint64_t ) add1.val + interm_add2.val; +return clamp_u64_to_fixed16 (interm_sum); +} +static inline const char *yesno (bool v) {return v ?"yes" :"no" ;
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/9 drm/i915/hsw: use intel_compute_linetime_wm function for linetime wm
In reply to Mahesh Kumarlinetime wm is time taken to fill a single display line with given clock rate, multiplied by 8.
This patch reuses the common code of hsw_compute_linetime_wm & skl_compute_linetime_wm.
Changes since V1:
- don't expose intel_compute_linetime_wm out of intel_pm.c (Maarten)
--- drivers/gpu/drm/i915/intel_pm.c | 66 ++++++++++++++++++++++------------------- 1 file changed, 36 insertions(+), 30 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +36 -30
@@ -2727,6 +2727,40 @@ static void ilk_compute_wm_level(const struct drm_i915_private *dev_priv, result->enable = true; } +static uint_fixed_16_16_t +intel_get_linetime_us (const struct intel_crtc_state *cstate) +{ +uint32_t pixel_rate; +uint32_t crtc_htotal; +uint_fixed_16_16_t linetime_us; + +if (!cstate->base.active) +return u32_to_fixed16 (0 ); + + pixel_rate = cstate->pixel_rate; + +if (WARN_ON (pixel_rate ==0 )) +return u32_to_fixed16 (0 ); + + crtc_htotal = cstate->base.adjusted_mode.crtc_htotal; + linetime_us =div_fixed16 (crtc_htotal *1000 , pixel_rate); + +return linetime_us; +} + +static uint32_t +intel_compute_linetime_wm (const struct intel_crtc_state *cstate) +{ +uint_fixed_16_16_t linetime_us; + + linetime_us =intel_get_linetime_us (cstate); + +if (is_fixed16_zero (linetime_us)) +return 0 ; + +return fixed16_to_u32_round_up (mul_u32_fixed16 (8 , linetime_us)); +} +static uint32_t hsw_compute_linetime_wm (const struct intel_crtc_state *cstate) {
@@ -2746,8 +2780,7 @@ hsw_compute_linetime_wm(const struct intel_crtc_state *cstate)/* The WM are computed with base on how long it takes to fill a single * row at the given clock rate, multiplied by 8. * */ - linetime =DIV_ROUND_CLOSEST (adjusted_mode->crtc_htotal *1000 *8 , - adjusted_mode->crtc_clock); + linetime =intel_compute_linetime_wm (cstate); ips_linetime =DIV_ROUND_CLOSEST (adjusted_mode->crtc_htotal *1000 *8 , intel_state->cdclk.logical.cdclk);
@@ -4381,27 +4414,6 @@ static uint_fixed_16_16_t skl_wm_method2(uint32_t pixel_rate,return ret; } -static uint_fixed_16_16_t -intel_get_linetime_us (struct intel_crtc_state *cstate) -{ -uint32_t pixel_rate; -uint32_t crtc_htotal; -uint_fixed_16_16_t linetime_us; - -if (!cstate->base.active) -return u32_to_fixed16 (0 ); - - pixel_rate = cstate->pixel_rate; - -if (WARN_ON (pixel_rate ==0 )) -return u32_to_fixed16 (0 ); - - crtc_htotal = cstate->base.adjusted_mode.crtc_htotal; - linetime_us =div_fixed16 (crtc_htotal *1000 , pixel_rate); - -return linetime_us; -} -static uint32_t skl_adjusted_plane_pixel_rate (const struct intel_crtc_state *cstate,const struct intel_plane_state *pstate)
@@ -4609,15 +4621,9 @@ skl_compute_linetime_wm(struct intel_crtc_state *cstate) {struct drm_atomic_state *state = cstate->base.state;struct drm_i915_private *dev_priv =to_i915 (state->dev); -uint_fixed_16_16_t linetime_us;uint32_t linetime_wm; - linetime_us =intel_get_linetime_us (cstate); - -if (is_fixed16_zero (linetime_us)) -return 0 ; - - linetime_wm =fixed16_to_u32_round_up (mul_u32_fixed16 (8 , linetime_us)); + linetime_wm =intel_compute_linetime_wm (cstate);/* Display WA #1135: bxt. */ if (IS_BROXTON (dev_priv) && dev_priv->ipc_enabled)
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/9 drm/i915/skl+: WM calculation don't require height
In reply to Mahesh Kumarheight of plane was require to swap width/height in case of 90/270 rotation. Now src structure contains already swapped values, So we don't have to calculate height of the plane.
--- drivers/gpu/drm/i915/intel_pm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +1 -3
@@ -4454,7 +4454,7 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,uint32_t plane_bytes_per_line;uint32_t res_blocks, res_lines;uint8_t cpp; -uint32_t width =0 , height =0 ; +uint32_t width =0 ;uint32_t plane_pixel_rate;uint_fixed_16_16_t y_tile_minimum;uint32_t y_min_scanlines;
@@ -4481,7 +4481,6 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,if (plane->id ==PLANE_CURSOR ) { width = intel_pstate->base.crtc_w; - height = intel_pstate->base.crtc_h; }else {/* * Src coordinates are already rotated by 270 degrees for
@@ -4489,7 +4488,6 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,* GTT mapping), hence no need to account for rotation here. */ width =drm_rect_width (&intel_pstate->base.src) >>16 ; - height =drm_rect_height (&intel_pstate->base.src) >>16 ; } cpp = fb->format->cpp[0 ];
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/9 drm/i915/skl+: unify cpp value in WM calculation
In reply to Mahesh Kumaruse same cpp value in different phase of plane WM caluclation.
--- drivers/gpu/drm/i915/intel_pm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +2 -4
@@ -4490,13 +4490,11 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, width =drm_rect_width (&intel_pstate->base.src) >>16 ; } - cpp = fb->format->cpp[0 ]; + cpp = (fb->format->format ==DRM_FORMAT_NV12 ) ? fb->format->cpp[1 ] : + fb->format->cpp[0 ]; plane_pixel_rate =skl_adjusted_plane_pixel_rate (cstate, intel_pstate);if (drm_rotation_90_or_270 (pstate->rotation)) { -int cpp = (fb->format->format ==DRM_FORMAT_NV12 ) ? - fb->format->cpp[1 ] : - fb->format->cpp[0 ];switch (cpp) {case 1 :
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 8/9 drm/i915/skl+: Optimize WM calculation
In reply to Mahesh KumarPlane configuration parameters doesn't change for each WM-level calculation. Currently we compute same parameters 8 times for each wm-level.
This patch optimizes it by calculating these parameters in beginning & reuse during each level-wm calculation.
--- drivers/gpu/drm/i915/i915_drv.h | 13 ++++ drivers/gpu/drm/i915/intel_pm.c | 169 ++++++++++++++++++++++------------------ 2 files changed, 107 insertions(+), 75 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +13 -0
@@ -1776,6 +1776,19 @@ struct skl_wm_level {uint8_t plane_res_l; }; +/* Stores plane specific WM parameters */ +struct skl_wm_params { +bool x_tiled, y_tiled; +uint32_t width; +uint8_t cpp; +uint32_t plane_pixel_rate; +uint32_t y_min_scanlines; +uint32_t plane_bytes_per_line; +uint_fixed_16_16_t plane_blocks_per_line; +uint_fixed_16_16_t y_tile_minimum; +uint32_t linetime_us; +}; +/* * This struct helps tracking the state needed for runtime PM, which puts the * device in PCI D3 state. Notice that when this happens, nothing on the
drivers/gpu/drm/i915/intel_pm.c +94 -75
249 lines not on this page · raw message
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 9/9 drm/i915/gen10: Calculate and enable transition WM
In reply to Mahesh KumarGEN > 9 require transition WM to be programmed if IPC is enabled. This patch calculates & enable transition WM for supported platforms. If transition WM is enabled, Plane read requests are sent at high priority until filling above the transition watermark, then the requests are sent at lower priority until dropping below the level-0 WM. The lower priority requests allow other memory clients to have better memory access.
transition minimum is the minimum amount needed for trans_wm to work to ensure the demote does not happen before enough data has been read to meet the level 0 watermark requirements.
transition amount is configurable value. Higher values will tend to cause longer periods of high priority reads followed by longer periods of lower priority reads. Tuning to lower values will tend to cause shorter periods of high and lower priority reads.
Keeping transition amount to 0 in this patch.
--- drivers/gpu/drm/i915/intel_pm.c | 51 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 48 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +48 -3
@@ -4197,6 +4197,15 @@ skl_enable_plane_wm_levels(const struct drm_i915_private *dev_priv, level_wm->plane_en = true; } } + +/* +* Unsupported GEN will have plane_res_b = 0 & transition WM for +* them will get disabled here. +*/ +if (wm->trans_wm.plane_res_b && wm->trans_wm.plane_res_b < plane_ddb) + wm->trans_wm.plane_en = true; +else + wm->trans_wm.plane_en = false; } static int
@@ -4640,13 +4649,48 @@ skl_compute_linetime_wm(struct intel_crtc_state *cstate) }static void skl_compute_transition_wm (struct intel_crtc_state *cstate, +struct skl_wm_params *wp, +struct skl_wm_level *wm_l0,struct skl_wm_level *trans_wm/* out */ ) { +struct drm_device *dev = cstate->base.crtc->dev; +const struct drm_i915_private *dev_priv =to_i915 (dev); +uint16_t trans_min, trans_y_tile_min; +uint16_t trans_amount =0 ;/* This is configurable amount */ +uint16_t trans_offset_b, res_blocks; +if (!cstate->base.active)return ; -/* Until we know more, just disable transition WMs */ - trans_wm->plane_en = false; +/* Transition WM are not recommended by HW team for GEN9 */ +if (INTEL_GEN (dev_priv) <=9 ) +return ; + +/* Transition WM don't have any impact if ipc is disabled */ +if (!dev_priv->ipc_enabled) +return ; + +if (INTEL_GEN (dev_priv) >=10 ) + trans_min =4 ; + + trans_offset_b = trans_min + trans_amount; + trans_y_tile_min = (uint16_t )mul_round_up_u32_fixed16 (2 , + wp->y_tile_minimum); + +if (wp->y_tiled) { + res_blocks =max (wm_l0->plane_res_b, trans_y_tile_min) + + trans_offset_b; + }else { + res_blocks = wm_l0->plane_res_b + trans_offset_b; + } + + res_blocks +=1 ; + +/* WA BUG:1938466 add one block for non y-tile planes */ +if (!wp->y_tiled &&IS_CNL_REVID (dev_priv,CNL_REVID_A0 ,CNL_REVID_A0 )) + res_blocks +=1 ; + + trans_wm->plane_res_b = res_blocks; } static int skl_build_pipe_wm(struct intel_crtc_state *cstate,
@@ -4685,7 +4729,8 @@ static int skl_build_pipe_wm(struct intel_crtc_state *cstate, &wm_params, wm);if (ret)return ret; -skl_compute_transition_wm (cstate, &wm->trans_wm); +skl_compute_transition_wm (cstate, &wm_params, &wm->wm[0 ], + &wm->trans_wm); } pipe_wm->linetime =skl_compute_linetime_wm (cstate);
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Fixed16.16 wrapper cleanup & wm optimization (rev2)
In reply to Mahesh Kumar== Series Details ==
== Series Details ==
Series: Fixed16.16 wrapper cleanup & wm optimization (rev2)
URL : https://patchwork.freedesktop.org/series/25692/
State : success
== Summary ==
Series 25692v2 Fixed16.16 wrapper cleanup & wm optimization
https://patchwork.freedesktop.org/api/1.0/series/25692/revisions/2/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
dmesg-warn -> PASS (fi-kbl-7560u) fdo#100125 +1
Test kms_busy:
Subgroup basic-flip-default-b:
dmesg-warn -> FAIL (fi-skl-6700hq) fdo#101144
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-skl-6700hq) fdo#100461fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fdo#100461 https://bugs.freedesktop.org/show_bug.cgi?id=100461
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:447s fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:430s fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:590s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:518s fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:488s fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:480s fi-glk-2a total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:595s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:439s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:415s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:420s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:491s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:469s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:472s fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:566s fi-kbl-r total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18 time:577s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:461s fi-skl-6700hq total:278 pass:227 dwarn:2 dfail:0 fail:27 skip:22 time:403s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:462s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:474s fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:439s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:536s fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:404s
63f3be17429f13293c42de2c6e8ed6f0fc425145 drm-tip: 2017y-06m-13d-08h-33m-44s UTC integration manifest 0ceb4d4 drm/i915/gen10: Calculate and enable transition WM
b8a767f drm/i915/skl+: Optimize WM calculation95a47716 drm/i915/skl+: unify cpp value in WM calculation
7e1daf1 drm/i915/skl+: WM calculation don't require height
6c078ac drm/i915/hsw: use intel_compute_linetime_wm function for linetime wm
07465c9 drm/i915: Addition wrapper for fixed16.16 operation
741891d drm/i915: cleanup fixed-point wrappers naming
71b1d26 drm/i915: Always perform internal fixed16 division in 64 bits
8d7c80b drm/i915: take-out common clamping code of fixed16 wrappers
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4940/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx