Skip to contentSkip to conversation

nvme: submit nvme_admin_activate_fw to admin queue

PATCH New David Milburn 3 participants 3 messages Jun 13, 2017 – Jun 15, 2017 NVMe

lore
Share & tools
lore

David Milburn

author
#0 lore raw

PATCH 1/1 nvme: submit nvme_admin_activate_fw to admin queue

The nvme_admin_activate_fw command should be submitted to the admin queue; otherwise, mode 0x0F (ACTIVATE_DEFERRED_MICROCODE) and mode 0x05 (DOWNLOAD_SAVE_ACTIVATE) will fail.

Fixes b90c48d0c11ef("nvme: split nvme_trans_send_fw_cmd")
Reported-by Joseph Szczypek <joseph.szczypek at hpe.com>
Tested-by Micah Parrish <micah.parrish at hpe.com>
Signed-off-by David Milburn <dmilburn at redhat.com>
---
 drivers/nvme/host/scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/scsi.c +1 -1
index 1f7671e..f4395e6 100644
@@ -1231,7 +1231,7 @@ static int nvme_trans_send_activate_fw_cmd(struct nvme_ns *ns, struct sg_io_hdr
 	c.common.opcode = nvme_admin_activate_fw;
 	c.common.cdw10[0] = cpu_to_le32(buffer_id | NVME_FWACT_REPL_ACTV);
 
-	nvme_sc = nvme_submit_sync_cmd(ns->queue, &c, NULL, 0);
+	nvme_sc = nvme_submit_sync_cmd(ns->ctrl->admin_q, &c, NULL, 0);
 	return nvme_trans_status_code(hdr, nvme_sc);
 }
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw

PATCH 1/1 nvme: submit nvme_admin_activate_fw to admin queue

Quoted 8 lines · David Milburn

The nvme_admin_activate_fw command should be submitted to the admin queue; otherwise, mode 0x0F (ACTIVATE_DEFERRED_MICROCODE) and mode 0x05 (DOWNLOAD_SAVE_ACTIVATE) will fail.

Fixes b90c48d0c11ef("nvme: split nvme_trans_send_fw_cmd")
Reported-by Joseph Szczypek <joseph.szczypek at hpe.com>
Tested-by Micah Parrish <micah.parrish at hpe.com>
Signed-off-by David Milburn <dmilburn at redhat.com>

If this command has been broken all the time we should just remove it.

maintainer
#2 lore raw

PATCH 1/1 nvme: submit nvme_admin_activate_fw to admin queue

Quoted 11 lines · Christoph Hellwig
Quoted 8 lines · David Milburn

The nvme_admin_activate_fw command should be submitted to the admin queue; otherwise, mode 0x0F (ACTIVATE_DEFERRED_MICROCODE) and mode 0x05 (DOWNLOAD_SAVE_ACTIVATE) will fail.

Fixes b90c48d0c11ef("nvme: split nvme_trans_send_fw_cmd")
Reported-by Joseph Szczypek <joseph.szczypek at hpe.com>
Tested-by Micah Parrish <micah.parrish at hpe.com>
Signed-off-by David Milburn <dmilburn at redhat.com>

If this command has been broken all the time we should just remove it.

Agreed.