Skip to contentSkip to conversation

thunderbolt: Fix reset response_type

PATCH Superseded Dan Carpenter 3 participants 3 messages Jun 14, 2017

Subsystems (2)
Kernel janitors Thunderbolt driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 thunderbolt: Fix reset response_type

There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET) instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the same as TB_CFG_PKG_NOTIFY_ACK.

Fixes d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
Signed-off-by Dan Carpenter <[email protected]>
drivers/thunderbolt/ctl.c +1 -1
index 69c0232a22f8..fb40dd0588b9 100644
@@ -804,7 +804,7 @@ struct tb_cfg_result tb_cfg_reset(struct tb_ctl *ctl, u64 route,
 	req->request_type = TB_CFG_PKG_RESET;
 	req->response = &reply;
 	req->response_size = sizeof(reply);
-	req->response_type = sizeof(TB_CFG_PKG_RESET);
+	req->response_type = TB_CFG_PKG_RESET;
 
 	res = tb_cfg_request_sync(ctl, req, timeout_msec);
maintainer
#2 lore raw
Quoted 11 lines · Mika Westerberg
Quoted 6 lines · Dan Carpenter

There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET) instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the same as TB_CFG_PKG_NOTIFY_ACK.

Fixes d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
Signed-off-by Dan Carpenter <[email protected]>

Good catch!

Acked-by Mika Westerberg <[email protected]>
Signed-off-by Andreas Noever <[email protected]>