block: missing break in process_queued_bios()
Subsystems (3)
PATCH 1/1 block: missing break in process_queued_bios()
This used to be a fall through case, but we shifted code around and I think we want a break here now.
drivers/md/dm-mpath.c +1 -0
@@ -625,6 +625,7 @@ static void process_queued_bios(struct work_struct *work)case DM_MAPIO_KILL : bio->bi_status =BLK_STS_IOERR ;bio_endio (bio); +break ;case DM_MAPIO_REQUEUE : bio->bi_status =BLK_STS_DM_REQUEUE ;bio_endio (bio);
Quoted 5 lines · Dan Carpenter
This used to be a fall through case, but we shifted code around and I think we want a break here now.
Fixes 4e4cbee93d56 ("block: switch bios to blk_status_t")Signed-off-by Dan Carpenter <[email protected]>
Thanks Dan, this looks coreect:
Quoted 11 lines · Dan Carpenter
This used to be a fall through case, but we shifted code around and I think we want a break here now.
Fixes 4e4cbee93d56 ("block: switch bios to blk_status_t")Signed-off-by Dan Carpenter <[email protected]>drivers/md/dm-mpath.c +0
-0
drivers/md/dm-mpath.c static void process_queued_bios(struct work_struct *work) · line 631
Quoted 7 lines
drivers/md/dm-mpath.c +1
-0@@ -625,6 +625,7 @@ static void process_queued_bios(struct work_struct *work)case DM_MAPIO_KILL : bio->bi_status =BLK_STS_IOERR ;bio_endio (bio); +break ;case DM_MAPIO_REQUEUE : bio->bi_status =BLK_STS_DM_REQUEUE ;bio_endio (bio);
Annoyed with myself for missing this during my review...
The subject should be:
"dm mpath: add missing break in process_queued_bios()"
Also, this should go through Jens and I'll rebase my linux-dm branches accordingly. Jens, please pick this up.
Thanks!
Quoted 24 lines · Mike Snitzer
Quoted 11 lines · Dan Carpenter
This used to be a fall through case, but we shifted code around and I think we want a break here now.
Fixes 4e4cbee93d56 ("block: switch bios to blk_status_t")Signed-off-by Dan Carpenter <[email protected]>drivers/md/dm-mpath.c +0
-0drivers/md/dm-mpath.c static void process_queued_bios(struct work_struct *work) · line 631
Quoted 7 lines
drivers/md/dm-mpath.c +1
-0@@ -625,6 +625,7 @@ static void process_queued_bios(struct work_struct *work)case DM_MAPIO_KILL : bio->bi_status =BLK_STS_IOERR ;bio_endio (bio); +break ;case DM_MAPIO_REQUEUE : bio->bi_status =BLK_STS_DM_REQUEUE ;bio_endio (bio);Annoyed with myself for missing this during my review...
Quoted 7 lines
The subject should be:
"dm mpath: add missing break inprocess_queued_bios()"Also, this should go through Jens and I'll rebase my linux-dm branches accordingly. Jens, please pick this up.
Acked-by Mike Snitzer <[email protected]>
Thanks, I've added it to the 4.13 branch.
Signature · 1 line
Jens Axboe