Skip to contentSkip to conversation

rrdtool: allow configuration to disable nls

PATCH In review Randy MacLeod 1 participant 2 messages Jun 14, 2017 – Jun 15, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rrdtool: allow configuration to disable nls

When building rrdtool for a 'tiny' distro, that does not have native language support (NLS) in glibc, configure fails with the error:
autoreconf: failed to run autopoint: No such file or directory
Autopoint is part of gettext but without NLS support we populate the sysroot with gettext-minimal-native rather then the full set of gettext executables. This version does not install autopoint, nor should it.

Tell autoreconf to skip the check for the autopoint script regardless of NLS support and use the USE_NLS varible to conditionally enable NLS support.

---
 meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +2 -1
index db2df28a0..3ccefb995 100644
@@ -22,7 +22,7 @@ BBCLASSEXTEND = "native"
 SYSTEMD_PACKAGES = "rrdcached"
 SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service"
 
-EXTRA_AUTORECONF = "-I m4"
+EXTRA_AUTORECONF = "-I m4 --exclude=autopoint"
 
 PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
 
@@ -49,6 +49,7 @@ EXTRA_OECONF = " \
     --disable-lua \
     --disable-tcl \
     --disable-rpath \
+    --enable-nls=${USE_NLS} \
 "
 
 export STAGING_LIBDIR
Signature · 1 line
2.11.0
#1 lore raw

Rats, ignore this one as well.

I've just read Jose's tip on getting patchworks to identify my patch so I'll resend as suggested.

../Randy

Quoted 39 lines · Randy MacLeod

When building rrdtool for a 'tiny' distro, that does not have native language support (NLS) in glibc, configure fails with the error:
autoreconf: failed to run autopoint: No such file or directory
Autopoint is part of gettext but without NLS support we populate the sysroot with gettext-minimal-native rather then the full set of gettext executables. This version does not install autopoint, nor should it.

Tell autoreconf to skip the check for the autopoint script regardless of NLS support and use the USE_NLS varible to conditionally enable NLS support.

---
  meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +2 -1
index db2df28a0..3ccefb995 100644
@@ -22,7 +22,7 @@ BBCLASSEXTEND = "native"
  SYSTEMD_PACKAGES = "rrdcached"
  SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service"
 
-EXTRA_AUTORECONF = "-I m4"
+EXTRA_AUTORECONF = "-I m4 --exclude=autopoint"
 
  PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
 
@@ -49,6 +49,7 @@ EXTRA_OECONF = " \
      --disable-lua \
      --disable-tcl \
      --disable-rpath \
+    --enable-nls=${USE_NLS} \
  "
 
  export STAGING_LIBDIR
Signature · 2 lines
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5