pinctrl: samsung: Use unsigned int for number of controller IO mem resources
Subsystems (4)
Krzysztof Kozlowski
maintainerPATCH 1/2 pinctrl: samsung: Use unsigned int for number of controller IO mem resources
Number of IO memory resources cannot be negative obviously and the driver depends silently on this (by iterating from 0 to nr_ext_resources+1). Make this requirement explicit.
--- drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +- drivers/pinctrl/samsung/pinctrl-samsung.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/samsung/pinctrl-samsung.c +1 -1
@@ -960,7 +960,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,struct samsung_pin_bank *bank;struct resource *res;void __iomem *virt_base[SAMSUNG_PINCTRL_NUM_RESOURCES ]; -int i; +unsigned int i; id =of_alias_get_id (node,"pinctrl" );if (id <0 ) {
drivers/pinctrl/samsung/pinctrl-samsung.h +1 -1
@@ -231,7 +231,7 @@ struct samsung_retention_data {struct samsung_pin_ctrl {const struct samsung_pin_bank_data *pin_banks;u32 nr_banks; -int nr_ext_resources; +unsigned int nr_ext_resources;const struct samsung_retention_data *retention_data;int (*eint_gpio_init)(struct samsung_pinctrl_drv_data *);
Signature · 1 line
2.9.3
Krzysztof Kozlowski
maintainerPATCH 2/2 pinctrl: samsung: Consistently use unsigned instead of u32 for nr_banks
Unlike for other countable members, the driver used u32 for number of banks (nr_banks). There is no specific need for using fixed-width integer in this particular place. Make it consistent.
--- drivers/pinctrl/samsung/pinctrl-samsung.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/samsung/pinctrl-samsung.h +2 -2
@@ -230,7 +230,7 @@ struct samsung_retention_data {*/ struct samsung_pin_ctrl {const struct samsung_pin_bank_data *pin_banks; -u32 nr_banks; +unsigned int nr_banks;unsigned int nr_ext_resources;const struct samsung_retention_data *retention_data;
@@ -275,7 +275,7 @@ struct samsung_pinctrl_drv_data {unsigned int nr_functions;struct samsung_pin_bank *pin_banks; -u32 nr_banks; +unsigned int nr_banks;unsigned int pin_base;unsigned int nr_pins;
Signature · 1 line
2.9.3
Re: [PATCH 2/2] pinctrl: samsung: Consistently use unsigned instead of u32 for nr_banks
Quoted 5 lines · Krzysztof Kozlowski
Unlike for other countable members, the driver used u32 for number of banks (
nr_banks). There is no specific need for using fixed-width integer in this particular place. Make it consistent.Signed-off-by Krzysztof Kozlowski<[email protected]>
Signature · 2 lines
Regards, Sylwester
Quoted 5 lines · Krzysztof Kozlowski
Number of IO memory resources cannot be negative obviously and the driver depends silently on this (by iterating from 0 to nr_ext_resources+1). Make this requirement explicit.
Signed-off-by Krzysztof Kozlowski<[email protected]>
Signature · 2 lines
Regards, Sylwester