i2c: tc358743: remove useless variable assignment in tc358743_isr
Subsystems (2)
PATCH 1/1 i2c: tc358743: remove useless variable assignment in tc358743_isr
Remove useless variable assignment in function tc358743_isr().
The value stored in variable _intstatus_ at line 1299 is overwritten at line 1302, just before it can be used.
Addresses-Coverity-ID: 1397678
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/media/i2c/tc358743.c | 1 - 1 file changed, 1 deletion(-)
drivers/media/i2c/tc358743.c +0 -1
@@ -1296,7 +1296,6 @@ static int tc358743_isr(struct v4l2_subdev *sd, u32 status, bool *handled)tc358743_csi_err_int_handler (sd, handled);i2c_wr16 (sd,INTSTATUS ,MASK_CSI_INT ); - intstatus &= ~MASK_CSI_INT ; } intstatus =i2c_rd16 (sd,INTSTATUS );
Signature · 1 line
2.5.0
Thanks!
You could remove
intstatus &= ~MASK_HDMI_INT;
in line 1289 as well.
Regards,
Mats Randgaard
On 15/06/2017, 18:49, "Gustavo A. R. Silva" <[email protected]> wrote:
Remove useless variable assignment in function tc358743_isr().
The value stored in variable _intstatus_ at line 1299 is
overwritten at line 1302, just before it can be used.
Addresses-Coverity-ID: 1397678
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/media/i2c/tc358743.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 3251cba..e8b23f3 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1296,7 +1296,6 @@ static int tc358743_isr(struct v4l2_subdev *sd, u32 status, bool *handled)
tc358743_csi_err_int_handler(sd, handled);
i2c_wr16(sd, INTSTATUS, MASK_CSI_INT);
- intstatus &= ~MASK_CSI_INT;
}
intstatus = i2c_rd16(sd, INTSTATUS);
--
2.5.0