rrdtool: allow configuration to disable nls

PATCH Superseded Randy MacLeod 3 participants 6 messages May 18, 2017 – Jun 15, 2017

Share & tools

Randy MacLeod

author

2017-05-18 02:13 UTC #0 lore raw

PATCH v2 1/1 rrdtool: allow configuration to disable nls

When building rrdtool for a 'tiny' distro, that does not have native language support (NLS) in glibc, configure fails with the error:
autoreconf: failed to run autopoint: No such file or directory
Autopoint is part of gettext but without NLS support we populate the sysroot with gettext-minimal-native rather then the full set of gettext executables. This version does not install autopoint, nor should it.

Tell autoreconf to skip the check for the autopoint script regardless of NLS support and use the USE_NLS varible to conditionally enable NLS support.

Signed-off-by Randy MacLeod <[email protected]>

---
 meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +2 -1

index db2df28a0..3ccefb995 100644
@@ -22,7 +22,7 @@ BBCLASSEXTEND = "native"
 SYSTEMD_PACKAGES = "rrdcached"
 SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service"
 
-EXTRA_AUTORECONF = "-I m4"
+EXTRA_AUTORECONF = "-I m4 --exclude=autopoint"
 
 PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"

@@ -49,6 +49,7 @@ EXTRA_OECONF = " \
     --disable-lua \
     --disable-tcl \
     --disable-rpath \
+    --enable-nls=${USE_NLS} \
 "
 
 export STAGING_LIBDIR

Signature · 1 line

2.11.0

Randy MacLeod

author

2017-05-29 01:12 UTC #1 lore raw

Martin,

You've merged v1:
[oe] [meta-oe][PATCH] rrdtool: add gettext-native dependency
Could you drop that for this fix since it's a somewhat better approach.

../Randy

Quoted 39 lines · Randy MacLeod

When building rrdtool for a 'tiny' distro, that does not have native language support (NLS) in glibc, configure fails with the error:
autoreconf: failed to run autopoint: No such file or directory
Autopoint is part of gettext but without NLS support we populate the sysroot with gettext-minimal-native rather then the full set of gettext executables. This version does not install autopoint, nor should it.
Tell autoreconf to skip the check for the autopoint script regardless of NLS support and use the USE_NLS varible to conditionally enable NLS support.
Signed-off-by Randy MacLeod <[email protected]>
---
  meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +2 -1
index db2df28a0..3ccefb995 100644
@@ -22,7 +22,7 @@ BBCLASSEXTEND = "native"
  SYSTEMD_PACKAGES = "rrdcached"
  SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service"
 
-EXTRA_AUTORECONF = "-I m4"
+EXTRA_AUTORECONF = "-I m4 --exclude=autopoint"
 
  PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
 
@@ -49,6 +49,7 @@ EXTRA_OECONF = " \
      --disable-lua \
      --disable-tcl \
      --disable-rpath \
+    --enable-nls=${USE_NLS} \
  "
 
  export STAGING_LIBDIR

Signature · 2 lines

# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5

Randy MacLeod

author

2017-05-29 01:14 UTC #2 lore raw

Quoted 5 lines · Randy MacLeod

Martin,
You've merged v1:
[oe] [meta-oe][PATCH] rrdtool: add gettext-native dependency

err I mean, you've merged v1 to master-next to be clear. ../Randy

Quoted 43 lines

Could you drop that for this fix since it's a somewhat better approach.
../Randy
Quoted 36 lines · Randy MacLeod
When building rrdtool for a 'tiny' distro, that does not have native language support (NLS) in glibc, configure fails with the error:
autoreconf: failed to run autopoint: No such file or directory
Autopoint is part of gettext but without NLS support we populate the sysroot with gettext-minimal-native rather then the full set of gettext executables. This version does not install autopoint, nor should it.
Tell autoreconf to skip the check for the autopoint script regardless of NLS support and use the USE_NLS varible to conditionally enable NLS support.
Signed-off-by Randy MacLeod <[email protected]>
---
  meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +1 -1
index db2df28a0..3ccefb995 100644
@@ -22,7 +22,7 @@ BBCLASSEXTEND = "native"
  SYSTEMD_PACKAGES = "rrdcached"
  SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service"
-EXTRA_AUTORECONF = "-I m4"
+EXTRA_AUTORECONF = "-I m4 --exclude=autopoint"
  PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', 
'systemd', d)}"
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +1 -0
@@ -49,6 +49,7 @@ EXTRA_OECONF = " \
      --disable-lua \
      --disable-tcl \
      --disable-rpath \
+    --enable-nls=${USE_NLS} \
  "
  export STAGING_LIBDIR
 

Signature · 2 lines

# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5

Martin Jansa

2017-06-05 11:14 UTC #3 lore raw

This v2 didn't make it to patchwork and it was too late when I've noticed it and found this e-mail.

So I've merged v1 to master and immediately reverted it.

Resend v2 again, this time patchwork might do its job.

Quoted 65 lines · Randy MacLeod

Quoted 6 lines · Randy MacLeod
Martin,
You've merged v1:
[oe] [meta-oe][PATCH] rrdtool: add gettext-native dependency
err I mean, you've merged v1 to master-next to be clear. ../Randy
Could you drop that for this fix since it's a somewhat better approach.
Quoted 35 lines
../Randy
Quoted 30 lines · Randy MacLeod
When building rrdtool for a 'tiny' distro, that does not have native language support (NLS) in glibc, configure fails with the error:
autoreconf: failed to run autopoint: No such file or directory
Autopoint is part of gettext but without NLS support we populate the sysroot with gettext-minimal-native rather then the full set of gettext executables. This version does not install autopoint, nor should it.
Tell autoreconf to skip the check for the autopoint script regardless of NLS support and use the USE_NLS varible to conditionally enable NLS support.
Signed-off-by Randy MacLeod <[email protected]>
---
  meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +1 -1
index db2df28a0..3ccefb995 100644
@@ -22,7 +22,7 @@ BBCLASSEXTEND = "native"
  SYSTEMD_PACKAGES = "rrdcached"
  SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service"
-EXTRA_AUTORECONF = "-I m4"
+EXTRA_AUTORECONF = "-I m4 --exclude=autopoint"
  PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES',
'systemd', d)}"
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +0 -0
@@ -49,6 +49,7 @@ EXTRA_OECONF = " \
Quoted 10 lines
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb EXTRA_OECONF = " \
Quoted 8 lines
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +1 -0
      --disable-lua \
      --disable-tcl \
      --disable-rpath \
+    --enable-nls=${USE_NLS} \
  "
  export STAGING_LIBDIR
 
--
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5

Jose Lamego

2017-06-05 14:02 UTC #4 lore raw

Quoted 6 lines · Martin Jansa

This v2 didn't make it to patchwork and it was too late when I've noticed it and found this e-mail.
So I've merged v1 to master and immediately reverted it.
Resend v2 again, this time patchwork might do its job.

Randy, to ensure patchwork to identify your patch as such, please use the appropriate prefix (you may use --subject-prefix="meta-oe][PATCH v2" when creating your patch) as described in

http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded

optionally, you can also include

[email protected]

which adds your first patch's message id as reference in patch v2, ensuring patchwork to display it as revision 2 of the series. This is only required in cases where the patch name changes between revisions to keep thread continuity.

Regards

Quoted 69 lines

Quoted 65 lines · Randy MacLeod
Quoted 6 lines · Randy MacLeod
Martin,
You've merged v1:
[oe] [meta-oe][PATCH] rrdtool: add gettext-native dependency
err I mean, you've merged v1 to master-next to be clear. ../Randy
Could you drop that for this fix since it's a somewhat better approach.
Quoted 35 lines
../Randy
Quoted 30 lines · Randy MacLeod
When building rrdtool for a 'tiny' distro, that does not have native language support (NLS) in glibc, configure fails with the error:
autoreconf: failed to run autopoint: No such file or directory
Autopoint is part of gettext but without NLS support we populate the sysroot with gettext-minimal-native rather then the full set of gettext executables. This version does not install autopoint, nor should it.
Tell autoreconf to skip the check for the autopoint script regardless of NLS support and use the USE_NLS varible to conditionally enable NLS support.
Signed-off-by Randy MacLeod <[email protected]>
---
  meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +1 -1
index db2df28a0..3ccefb995 100644
@@ -22,7 +22,7 @@ BBCLASSEXTEND = "native"
  SYSTEMD_PACKAGES = "rrdcached"
  SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service"
-EXTRA_AUTORECONF = "-I m4"
+EXTRA_AUTORECONF = "-I m4 --exclude=autopoint"
  PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES',
'systemd', d)}"
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +0 -0
@@ -49,6 +49,7 @@ EXTRA_OECONF = " \
Quoted 10 lines
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb EXTRA_OECONF = " \
Quoted 8 lines
meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +1 -0
      --disable-lua \
      --disable-tcl \
      --disable-rpath \
+    --enable-nls=${USE_NLS} \
  "
  export STAGING_LIBDIR
 
--
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5

Signature · 1 line

Jose Lamego | OTC Embedded Platforms & Tools | GDC

Randy MacLeod

author

2017-06-15 23:55 UTC #5 lore raw

PATCH v2 1/1 rrdtool: allow configuration to disable nls

In reply to Randy MacLeod

Tell autoreconf to skip the check for the autopoint script regardless of NLS support and use the USE_NLS varible to conditionally enable NLS support.

Signed-off-by Randy MacLeod <[email protected]>

---
 meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +2 -1

index db2df28a0..3ccefb995 100644
@@ -22,7 +22,7 @@ BBCLASSEXTEND = "native"
 SYSTEMD_PACKAGES = "rrdcached"
 SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service"
 
-EXTRA_AUTORECONF = "-I m4"
+EXTRA_AUTORECONF = "-I m4 --exclude=autopoint"
 
 PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"

@@ -49,6 +49,7 @@ EXTRA_OECONF = " \
     --disable-lua \
     --disable-tcl \
     --disable-rpath \
+    --enable-nls=${USE_NLS} \
 "
 
 export STAGING_LIBDIR

Signature · 1 line

2.11.0