Skip to contentSkip to conversation

Add a DSA test key/cert pair to sample-keys

PATCH In review Steffan Karger 2 participants 2 messages Jun 18, 2017

lore
Share & tools
lore

Steffan Karger

author
#0 lore raw

PATCH 1/1 Add a DSA test key/cert pair to sample-keys

Makes it easier to test changes to DSA-related code.

Signed-off-by Steffan Karger <[email protected]...>
---
 sample/sample-keys/gen-sample-keys.sh | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
sample/sample-keys/gen-sample-keys.sh +16 -0
index 301cff28..920513a1 100755
@@ -61,6 +61,22 @@ openssl ca -batch -config openssl.cnf \
 openssl ca -config openssl.cnf -revoke sample-ca/client-revoked.crt
 openssl ca -config openssl.cnf -gencrl -out sample-ca/ca.crl
 
+# Create DSA server and client cert (signed by 'regular' RSA CA)
+openssl dsaparam -out sample-ca/dsaparams.pem 2048
+
+openssl req -new -newkey dsa:sample-ca/dsaparams.pem -nodes -config openssl.cnf \
+    -extensions server \
+    -keyout sample-ca/server-dsa.key -out sample-ca/server-dsa.csr \
+    -subj "/C=KG/ST=NA/O=OpenVPN-TEST/CN=Test-Server-DSA/[email protected]..."
+openssl ca -batch -config openssl.cnf -extensions server \
+    -out sample-ca/server-dsa.crt -in sample-ca/server-dsa.csr
+
+openssl req -new -newkey dsa:sample-ca/dsaparams.pem -nodes -config openssl.cnf \
+    -keyout sample-ca/client-dsa.key -out sample-ca/client-dsa.csr \
+    -subj "/C=KG/ST=NA/O=OpenVPN-TEST/CN=Test-Client-DSA/[email protected]..."
+openssl ca -batch -config openssl.cnf \
+    -out sample-ca/client-dsa.crt -in sample-ca/client-dsa.csr
+
 # Create EC server and client cert (signed by 'regular' RSA CA)
 openssl ecparam -out sample-ca/secp256k1.pem -name secp256k1
Signature · 1 line
2.11.0
#1 lore raw

ACK. No code changes to openvpn itself, and it's good to have all supported cert/key types around for testing.

Tested on FreeBSD, and it generates something that looks like DSA :-)

Generating DSA parameters, 2048 bit long prime
...
Generating a 2048 bit DSA private key writing new private key to 'sample-ca/server-dsa.key'
...
Generating a 2048 bit DSA private key writing new private key to 'sample-ca/client-dsa.key'

Your patch has been applied to the master and release/2.4 branch.

commit 3d215d4c9d107fa153082e2bba8a3a9c8865be5d (master) commit d937bb7eccc77ceb668cf64a8b2109329ed2aecd (release/2.4)

Author: Steffan Karger
Date:   Sun Jun 18 12:57:40 2017 +0200
     Add a DSA test key/cert pair to sample-keys

     Signed-off-by: Steffan Karger <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/search?l=mid&[email protected]...
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering