Skip to contentSkip to conversation

drm/amdgpu: Fix warnings about potentially unitialized vars

PATCH In review Harry Wentland 2 participants 2 messages Jun 19, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Fix warnings about potentially unitialized vars

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +6 -3
index c4f1a305c68c..c133f20ca7a7 100644
@@ -1023,11 +1023,14 @@ static int amdgpu_vm_update_level(struct amdgpu_device *adev,
 				  unsigned level)
 {
 	struct amdgpu_bo *shadow;
-	struct amdgpu_ring *ring;
-	uint64_t pd_addr, shadow_addr;
+	struct amdgpu_ring *ring = 0;
+	uint64_t pd_addr;
+	uint64_t shadow_addr = 0;
 	uint32_t incr = amdgpu_vm_bo_size(adev, level + 1);
 	uint64_t last_pde = ~0, last_pt = ~0, last_shadow = ~0;
-	unsigned count = 0, pt_idx, ndw;
+	unsigned count = 0;
+	unsigned pt_idx;
+	unsigned ndw = 0;
 	struct amdgpu_job *job;
 	struct amdgpu_pte_update_params params;
 	struct dma_fence *fence = NULL;
Signature · 6 lines
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20170619195004.2109-1-harry.wentland-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Both I and Harish sent out fixes for this. Harish, any plans to commit your fixes?

Alex

Quoted 30 lines · Harry Wentland
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +6 -4
index c4f1a305c68c..c133f20ca7a7 100644
@@ -1023,11 +1023,14 @@ static int amdgpu_vm_update_level(struct amdgpu_device *adev,
                                  unsigned level)
 {
        struct amdgpu_bo *shadow;
-       struct amdgpu_ring *ring;
-       uint64_t pd_addr, shadow_addr;
+       struct amdgpu_ring *ring = 0;
+       uint64_t pd_addr;
+       uint64_t shadow_addr = 0;
        uint32_t incr = amdgpu_vm_bo_size(adev, level + 1);
        uint64_t last_pde = ~0, last_pt = ~0, last_shadow = ~0;
-       unsigned count = 0, pt_idx, ndw;
+       unsigned count = 0;
+       unsigned pt_idx;
+       unsigned ndw = 0;
        struct amdgpu_job *job;
        struct amdgpu_pte_update_params params;
        struct dma_fence *fence = NULL;
--

2.11.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx