linuxconsoletools: new package

Linuxconsoletools contains the inputattach utility to attach legacy serial devices to the Linux kernel input layer and joystick utilities to calibrate and test joysticks and joypads.

The buildroot package adds options to build only certain tools.

website: http://sf.net/projects/linuxconsole/

Signed-off-by Koen Martens <[email protected]>

Hello,

Quoted 11 lines · Koen Martens

Linuxconsoletools contains the inputattach utility to attach legacy serial devices to the Linux kernel input layer and joystick utilities to calibrate and test joysticks and joypads.

The buildroot package adds options to build only certain tools.

website: http://sf.net/projects/linuxconsole/

Signed-off-by Koen Martens <[email protected]>

Thanks, I've applied, after doing a few minor tweaks. See below.

package/linuxconsoletools/Config.in line 3

Quoted 9 lines

package/linuxconsoletools/Config.in new file +3 -0

new file mode 100644
index 0000000..08a4af3
@@ -0,0 +1,34 @@
+config BR2_PACKAGE_LINUXCONSOLETOOLS
+	bool "linuxconsoletools"
+	default n

There was still a useless "default n" here, so I've dropped.

package/linuxconsoletools/Config.in line 9

Quoted 6 lines

package/linuxconsoletools/Config.in new file +6 -0

+	help
+	  Linuxconsoletools contains the inputattach utility
+	  to attach legacy serial devices to the Linux kernel
+	  input layer and joystick utilities to calibrate and
+	  test joysticks and joypads.
+	  

There was a trailing tab character on this line, which I dropped.

package/linuxconsoletools/Config.in line 13

Quoted 4 lines

package/linuxconsoletools/Config.in new file +4 -0

+	  http://sf.net/projects/linuxconsole/
+ifeq ($(BR2_PACKAGE_LINUXCONSOLETOOLS_FORCEFEEDBACK),y)
+LINUXCONSOLETOOLS_MAKE_OPTS += ENABLE_FORCEFEEDBACK=1
+LINUXCONSOLETOOLS_MAKE_OPTS += SDL_CONFIG=$(STAGING_DIR)/usr/bin/sdl-config

I've put these in a single assignment:

(quoted diff) +3 -0

+LINUXCONSOLETOOLS_MAKE_OPTS += \
+       ENABLE_FORCEFEEDBACK=1 \
+       SDL_CONFIG=$(STAGING_DIR)/usr/bin/sdl-config

package/linuxconsoletools/Config.in line 18

Quoted 7 lines

package/linuxconsoletools/Config.in new file +5 -0

+LINUXCONSOLETOOLS_DEPENDENCIES += sdl
+endif
+
+LINUXCONSOLETOOLS_MAKE_OPTS += CC=$(TARGET_CC)
+LINUXCONSOLETOOLS_MAKE_OPTS += CFLAGS="$(TARGET_CFLAGS)"

Both of those lines are not needed: CC and CFLAGS are already part of $(TARGET_CONFIGURE_OPTS), which you pass in the build and install commands.

Committed with those minor issues fixed. Thanks a lot for this contribution!

Best regards,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thanks, also for the small corrections. I must've missed a few things. This was my first attempt at contributing, from which I've learned quite a lot. So hopefully, I'll be able to contribute some more things in the near future and get it right the first time. It'll mostly be in the category 'old and ancient', given the kind of ancient hardware I'm currently working on :)

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 5 lines · Koen Martens

Linuxconsoletools contains the inputattach utility to attach legacy serial devices to the Linux kernel input layer and joystick utilities to calibrate and test joysticks and joypads.

Quoted 6 lines

The buildroot package adds options to build only certain tools.

website: http://sf.net/projects/linuxconsole/

Signed-off-by Koen Martens <[email protected]>

Thanks, I've applied, after doing a few minor tweaks. See below.

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

"Thomas" == Thomas Petazzoni

Quoted 7 lines · <[email protected]> writes:

Hello,

Quoted 5 lines · Koen Martens

Linuxconsoletools contains the inputattach utility to attach legacy serial devices to the Linux kernel input layer and joystick utilities to calibrate and test joysticks and joypads.

Quoted 8 lines

Quoted 6 lines

The buildroot package adds options to build only certain tools.

website: http://sf.net/projects/linuxconsole/

Signed-off-by Koen Martens <[email protected]>

Thanks, I've applied, after doing a few minor tweaks. See below.

Sorry for the slow response, I only noticed the patch now.

We already have (an old version of) this code in the input-tools package, so the binaries here will conflict with those.

What is the way forward? Drop the old package and add Config.in.legacy handling for the old symbols?

Quoted 7 lines

Hello,

Quoted 5 lines · Koen Martens

Linuxconsoletools contains the inputattach utility to attach legacy serial devices to the Linux kernel input layer and joystick utilities to calibrate and test joysticks and joypads.

Quoted 8 lines

Quoted 6 lines

The buildroot package adds options to build only certain tools.

website: http://sf.net/projects/linuxconsole/

Signed-off-by Koen Martens <[email protected]>

Thanks, I've applied, after doing a few minor tweaks. See below.

Sorry for the slow response, I only noticed the patch now.

We already have (an old version of) this code in the input-tools package, so the binaries here will conflict with those.

What is the way forward? Drop the old package and add Config.in.legacy handling for the old symbols?

Quoted 4 lines

Quoted 1 line

Quoted 1 line

Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

What is the way forward? Drop the old package and add Config.in.legacy handling for the old symbols?

Thanks for pointing out, I didn't notice there was an overlap with our input-tools package. Our input-tools package references
http://linuxconsole.sourceforge.net/ as the upstream URL, which no longer exists, and fetches a Debian package from 2010 called joystick. All of this is a pretty confusing:

Buildroot package name != upstream URL project != Debian package name

Since linuxconsoletools provides the three utilities provided by input-tools, has a name matching the upstream project, and uses a more recent version, I would suggest to drop input-tools indeed, and add a Config.in.legacy option that automatically enables linuxconsoletools.

Quoted 9 lines

Quoted 2 lines

What is the way forward? Drop the old package and add Config.in.legacy handling for the old symbols?

Thanks for pointing out, I didn't notice there was an overlap with our input-tools package. Our input-tools package references
http://linuxconsole.sourceforge.net/ as the upstream URL, which no longer exists, and fetches a Debian package from 2010 called joystick. All of this is a pretty confusing:

Quoted 6 lines

Buildroot package name != upstream URL project != Debian package name

Since linuxconsoletools provides the three utilities provided by input-tools, has a name matching the upstream project, and uses a more recent version, I would suggest to drop input-tools indeed, and add a Config.in.legacy option that automatically enables linuxconsoletools.

Yes, I agree - The input-tools package is very old and hasn't been updated in close to 10 years.

Will you send a patch to add the legacy handling or should I?

Quoted 5 lines · Peter Korsgaard

Quoted 4 lines

Since linuxconsoletools provides the three utilities provided by input-tools, has a name matching the upstream project, and uses a more recent version, I would suggest to drop input-tools indeed, and add a Config.in.legacy option that automatically enables linuxconsoletools.

Quoted 4 lines

Yes, I agree - The input-tools package is very old and hasn't been updated in close to 10 years.

Will you send a patch to add the legacy handling or should I?

I wasn't planning on sending such a patch, so feel free to do it :)

Quoted 6 lines · Thomas Petazzoni

Quoted 5 lines · Peter Korsgaard

Quoted 4 lines

Since linuxconsoletools provides the three utilities provided by input-tools, has a name matching the upstream project, and uses a more recent version, I would suggest to drop input-tools indeed, and add a Config.in.legacy option that automatically enables linuxconsoletools.

Quoted 6 lines

Quoted 4 lines

Yes, I agree - The input-tools package is very old and hasn't been updated in close to 10 years.

Will you send a patch to add the legacy handling or should I?

I wasn't planning on sending such a patch, so feel free to do it :)

If no-one beats me to it, i can create it tomorrow.